fix: correct execution order of transferred CJS init calls#8877
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 24, 2026
Merged
fix: correct execution order of transferred CJS init calls#8877graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
IWANABETHATGUY
changed the title
IWANABETHATGUY
commented
Mar 23, 2026
IWANABETHATGUY
force-pushed
the
03-23-fix_8863
branch
from
4a33ed0 to
d84a621
Compare
hyf0
approved these changes
Mar 24, 2026
Member
Author
Merge activity
|
## Summary - When `ensure_lazy_module_initialization_order` transfers CJS init calls to a non-wrapped module, the `PrependRenderedImport` mutations were applied using `prepend()` (`push_front`), which reversed the order of multiple init calls. - Changed to `append_intro()` (`push_back`) to maintain correct insertion order. Closes #8863 ## Test plan - Added regression test in `crates/rolldown/tests/rolldown/issues/8863/` reproducing the scenario: ESM entry importing two CJS modules + a no-op module with `treeshake: false` - Snapshot verifies `require_resource()` executes before `require_designer()` - All 1648 existing integration tests pass
graphite-app
bot
force-pushed
the
03-23-fix_8863
branch
from
d84a621 to
2f15224
Compare
This was referenced Mar 25, 2026
Closed
Merged
shulaoda
added a commit
that referenced
this pull request
Mar 25, 2026
## [1.0.0-rc.12] - 2026-03-25 ### 🚀 Features - chunk-optimizer: skip circular dependency check when strict execution order is enabled (#8886) by @hyf0 ### 🐛 Bug Fixes - emit build warnings during watch mode rebuilds (#8897) by @IWANABETHATGUY - lazy-barrel: load import-then-export specifiers when barrel has local exports (#8895) by @shulaoda - correct execution order of transferred CJS init calls (#8877) by @IWANABETHATGUY - mcs: `entriesAware` should calculate sizes without duplication (#8887) by @hyf0 - non-deterministic chunk generation (#8882) by @sapphi-red - `is_top_level` incorrectly treats strict-mode scopes as top-level (#8878) by @Dunqing ### 🚜 Refactor - treeshake: migrate SideEffectDetector to Oxc's MayHaveSideEffects trait (#8624) by @Dunqing ### 🧪 Testing - make dev server tests deterministic by replacing fixed sleeps with event-driven polling (#8561) by @Boshen ### ⚙️ Miscellaneous Tasks - deps: update dependency vite-plus to v0.1.14 (#8902) by @camc314 - deps: update dependency oxfmt to ^0.42.0 (#8891) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v6.1.1 (#8890) by @renovate[bot] - remove Rolldown MF plan (#8883) by @shulaoda - deps: update rollup submodule for tests to v4.60.0 (#8881) by @sapphi-red - deps: update test262 submodule for tests (#8880) by @sapphi-red - deps: upgrade oxc crates to 0.122.0 (#8879) by @shulaoda Co-authored-by: shulaoda <[email protected]>
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure_lazy_module_initialization_ordertransfers CJS init calls to a non-wrapped module, thePrependRenderedImportmutations were applied usingprepend()(push_front), which reversed the order of multiple init calls.append_intro()(push_back) to maintain correct insertion order.Closes #8863
Test plan
crates/rolldown/tests/rolldown/issues/8863/reproducing the scenario: ESM entry importing two CJS modules + a no-op module withtreeshake: falserequire_resource()executes beforerequire_designer()