Skip to content

chore(node): migrate oxlint and oxfmt to Vite+ #8813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 8 commits into from
Mar 20, 2026
Merged

chore(node): migrate oxlint and oxfmt to Vite+ #8813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
036ae93
chore(node): migrate oxlint and oxfmt to Vite+
Boshen Mar 20, 2026
a6f5d4d
chore(ci): migrate remaining workflows from pnpm to vp
Boshen Mar 20, 2026
59c5898
chore(ci): remove redundant playwright install step
Boshen Mar 20, 2026
f94697a
Revert "chore(ci): remove redundant playwright install step"
Boshen Mar 20, 2026
63b03fc
chore: remove playwright-chromium from root package.json
Boshen Mar 20, 2026
43f0f9c
Revert "chore: remove playwright-chromium from root package.json"
Boshen Mar 20, 2026
31e2ac1
chore: add playwright-chromium to knip ignore and remove redundant CI…
Boshen Mar 20, 2026
075b974
chore(ci): add back playwright install step
Boshen Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/autofix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
steps:
- uses: taiki-e/checkout-action@83ed61bfbe2b8abbb3c66e8b65b1335484c70009 # v1.4.1

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16
with:
Expand All @@ -36,7 +38,7 @@
run: cargo check --workspace --all-features --all-targets
if: ${{ steps.shear.outputs.shear == 'true' }}

- run: pnpm run fmt
- run: vp fmt

- run: cargo fmt --all

Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/benchmark-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@
- name: List Files
run: find -maxdepth 2 -ls

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Setup Rust
uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16
Expand All @@ -61,7 +63,7 @@
run: just build-rolldown-release

- name: Run benchmarks
run: pnpm --filter bench run bench-ci
run: vp run --filter bench bench-ci

- name: Show/Update benchmark result
uses: benchmark-action/github-action-benchmark@a7bc2366eda11037936ea57d811a43b3418d3073 # v1.21.0
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/benchmark-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
steps:
- uses: taiki-e/checkout-action@83ed61bfbe2b8abbb3c66e8b65b1335484c70009 # v1.4.1

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Setup Rust
uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16
Expand Down Expand Up @@ -68,7 +70,9 @@
steps:
- uses: taiki-e/checkout-action@83ed61bfbe2b8abbb3c66e8b65b1335484c70009 # v1.4.1

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Setup Rust
uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16
Expand Down
30 changes: 19 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@
steps:
- uses: taiki-e/checkout-action@83ed61bfbe2b8abbb3c66e8b65b1335484c70009 # v1.4.1

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Download Native Rolldown Build
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
Expand All @@ -157,13 +159,13 @@
path: ./packages

- name: Build `@rolldown/test-dev-server`
run: pnpm --filter '@rolldown/test-dev-server' build
run: vp run --filter '@rolldown/test-dev-server' build

- name: Type Check
run: pnpm type-check
run: vp run type-check

- name: Node Type Test
run: pnpm run --filter rolldown-tests test:types
run: vp run --filter rolldown-tests test:types

node-dev-server-test-windows:
needs: [changes, build-rolldown-windows]
Expand Down Expand Up @@ -239,10 +241,12 @@
steps:
- uses: taiki-e/checkout-action@83ed61bfbe2b8abbb3c66e8b65b1335484c70009 # v1.4.1

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Test `@rolldown/pluginutils`
run: pnpm --filter '@rolldown/pluginutils' test
run: vp run --filter '@rolldown/pluginutils' test

node-validation:
name: Node Validation
Expand All @@ -259,7 +263,9 @@
cache-key: native-build
save-cache: false

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Add WASI target
run: rustup target add wasm32-wasip1-threads
Expand All @@ -280,13 +286,13 @@
run: just build-pluginutils

- name: Lint Code
run: pnpm lint-code
run: vp lint

- name: Lint publint
run: pnpm lint-publint
run: vp run lint-publint

- name: Lint exports & dependencies
run: pnpm lint-knip
run: vp run lint-knip

- name: Validate workspace package
run: node scripts/misc/published-package-check.mjs
Expand All @@ -304,7 +310,9 @@
save-cache: ${{ github.ref_name == 'main' }}
components: rustfmt

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Lint Filename
run: cargo ls-lint
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/copilot-setup-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,6 @@
tools: just,cargo-insta,typos-cli,[email protected]
components: clippy rust-docs rustfmt

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true
4 changes: 3 additions & 1 deletion .github/workflows/metric.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@
token: ${{ secrets.METRIC_SECRET_KEY }}
persist-credentials: true # required by `git push` below

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Install dependencies and push metric
run: |
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/prepare-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
with:
tool: just

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Get and bump version
run: |
Expand All @@ -43,7 +45,7 @@
- run: just bump-packages ${VERSION}

- name: Regenerate binding.js after version bump
run: pnpm --filter rolldown build-binding
run: vp run --filter rolldown build-binding

- name: Generate changelog via git cliff
id: changelog
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/publish-to-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@
steps:
- uses: taiki-e/checkout-action@83ed61bfbe2b8abbb3c66e8b65b1335484c70009 # v1.4.1

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Git Reset Hard
run: git reset --hard # fix pnpm install add new line for package.json
Expand All @@ -65,10 +67,10 @@
path: packages/rolldown/artifacts

- name: Create rolldown/npm dirs
run: pnpm --filter rolldown exec napi create-npm-dirs
run: vp exec --filter rolldown napi create-npm-dirs

- name: Move Binding Artifacts
run: pnpm --filter rolldown artifacts
run: vp run --filter rolldown artifacts

- name: List Rolldown Bindings
run: ls -R ./packages/rolldown/npm
Expand Down Expand Up @@ -105,12 +107,12 @@

- name: Publish(Dry Run)
run: |
pnpm publish -r --tag latest --dry-run --no-git-checks
vp publish -r --tag latest --dry-run --no-git-checks
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore a supported publish command in the npm release job

Vite+ does not expose a top-level publish subcommand; its package-manager passthrough is vp pm. As written, the new vp publish -r ... call will fail as soon as publish-to-npm.yml reaches the dry-run step, and the identical command in the real publish step means every npm release is now blocked.

Useful? React with 👍 / 👎.


- name: Publish
run: |
npm install -g npm
pnpm publish -r --tag latest --no-git-checks
vp publish -r --tag latest --no-git-checks

release:
needs: [check, publish]
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/publish-to-pkg.pr.new.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@
steps:
- uses: taiki-e/checkout-action@83ed61bfbe2b8abbb3c66e8b65b1335484c70009 # v1.4.1

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Git Reset Hard
run: git reset --hard # fix pnpm install add new line for package.json
Expand All @@ -79,10 +81,10 @@
path: packages/rolldown/artifacts

- name: Create rolldown/npm dirs
run: pnpm --filter rolldown exec napi create-npm-dirs
run: vp exec --filter rolldown napi create-npm-dirs

- name: Move Binding Artifacts
run: pnpm --filter rolldown artifacts
run: vp run --filter rolldown artifacts

- name: List Rolldown Bindings
run: ls -R ./packages/rolldown/npm
Expand Down Expand Up @@ -126,7 +128,7 @@
- name: Canary/Nightly Versioning
run: |
node --import @oxc-node/core/register ./scripts/misc/bump-version.js ${ROLLDOWN_VERSION}
pnpm --filter rolldown prepublishOnly --skip-optional-publish
vp run --filter rolldown prepublishOnly --skip-optional-publish
env:
ROLLDOWN_VERSION: ${{ steps.rolldown-version.outputs.content }}

Expand All @@ -136,4 +138,4 @@
find ./packages/ -type d -maxdepth 1 -exec cp THIRD-PARTY-LICENSE {} \;

- name: Release
run: pnpx pkg-pr-new publish --compact --pnpm './packages/rolldown/npm/*' './packages/rolldown' './packages/browser' './packages/debug' './packages/pluginutils'
run: vp exec pkg-pr-new publish --compact --pnpm './packages/rolldown/npm/*' './packages/rolldown' './packages/browser' './packages/debug' './packages/pluginutils'
4 changes: 3 additions & 1 deletion .github/workflows/reusable-cargo-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@
save-cache: ${{ github.ref_name == 'main' }}
target-dir: ${{ runner.os == 'Windows' && format('{0}/target', env.DEV_DRIVE) || '' }}

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Run Test
run: just test-rust
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/reusable-native-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@
save-cache: ${{ github.ref_name == 'main' }}
target-dir: ${{ runner.os == 'Windows' && format('{0}/target', env.DEV_DRIVE) || '' }}

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
cache: true

- name: Build Native Rolldown
run: just build-rolldown
Expand Down
17 changes: 7 additions & 10 deletions .github/workflows/reusable-node-dev-server-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@
steps:
- uses: taiki-e/checkout-action@83ed61bfbe2b8abbb3c66e8b65b1335484c70009 # v1.4.1

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
node-version: ${{ inputs.node-version }}
cache: true

- name: Download Native Rolldown Build
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
Expand All @@ -33,16 +36,10 @@
path: ./packages

- name: Build `@rolldown/test-dev-server`
run: pnpm --filter '@rolldown/test-dev-server' build
run: vp run --filter '@rolldown/test-dev-server' build

- name: Install Playwright
run: pnpm playwright install chromium

- name: Setup Node${{ inputs.node-version }} For Testing
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: ${{ inputs.node-version }}
package-manager-cache: false
run: vp exec playwright install chromium

- name: Dev Server Test
run: pnpm run --filter '@rolldown/test-dev-server-tests' test
run: vp run --filter '@rolldown/test-dev-server-tests' test
19 changes: 8 additions & 11 deletions .github/workflows/reusable-node-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@
env-mapping: |
PNPM_HOME,{{ DEV_DRIVE }}/.pnpm

- uses: oxc-project/setup-node@b8d296d30eafd1ae2968fab67aead472a1dbf6d4 # v1.0.7
- uses: voidzero-dev/setup-vp@af9f92ccd3e5694c919913c47be133a1847ea58e # v1.0.0

Check warning

Code scanning / zizmor

detects commit SHAs that don't match their version comment tags Warning

detects commit SHAs that don't match their version comment tags
with:
node-version: ${{ inputs.node-version }}
cache: true

- name: Download Native Rolldown Build
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
Expand All @@ -44,22 +47,16 @@
path: ./packages

- name: Build `@rolldown/test-dev-server`
run: pnpm --filter '@rolldown/test-dev-server' build

- name: Setup Node${{ inputs.node-version }} For Testing
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: ${{ inputs.node-version }}
package-manager-cache: false
run: vp run --filter '@rolldown/test-dev-server' build

- name: Node Test
run: |
pnpm run --filter rolldown-tests test:main && pnpm run --filter rolldown-tests test:watcher && pnpm run --filter rolldown-tests test:stability
vp run --filter rolldown-tests test:main && vp run --filter rolldown-tests test:watcher && vp run --filter rolldown-tests test:stability

- name: Rollup Test
run: pnpm run --filter rollup-tests test
run: vp run --filter rollup-tests test
env:
SKIP_PASS_DIFF: ${{ inputs.node-version != 24 && '1' || '' }}

- name: Build Examples
run: pnpm --filter '@example/**' build
run: vp run --filter '@example/**' build
Loading
Loading