Rename BindingMagicString export to RolldownMagicString#8641
Merged
IWANABETHATGUY merged 4 commits intomainfrom Mar 12, 2026
Merged
Rename BindingMagicString export to RolldownMagicString#8641IWANABETHATGUY merged 4 commits intomainfrom
BindingMagicString export to RolldownMagicString#8641IWANABETHATGUY merged 4 commits intomainfrom
Conversation
Copilot
AI
changed the title
[WIP] Address feedback on JSDoc naming for RolldownMagicString
Rename Mar 11, 2026
BindingMagicString export to RolldownMagicString
hyf0
reviewed
Mar 11, 2026
Member
|
I leave it to you to decide if to use this PR @IWANABETHATGUY |
graphite-app
bot
force-pushed
the
03-11-chore_add_experimental_js_doc_on_binding-magic-string_
branch
from
9b656b2 to
7e1ef16
Compare
Base automatically changed from
03-11-chore_add_experimental_js_doc_on_binding-magic-string_
to
main
March 11, 2026 12:16
Member
|
The reason why I use |
Member
|
@copilot resolve the conflict |
Contributor
Author
✅ Deploy Preview for rolldown-rs canceled.
|
Member
|
@copilot continue resolve the conflict |
Contributor
Author
Copilot stopped work on behalf of
IWANABETHATGUY due to an error
March 12, 2026 04:29
IWANABETHATGUY
force-pushed
the
copilot/sub-pr-8639
branch
from
d6c430c to
5e8e204
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the public MagicString export used by rolldown’s plugin APIs from BindingMagicString to RolldownMagicString, and updates internal plugin hook plumbing/types accordingly so plugins can continue to return/use MagicString with native sourcemap support.
Changes:
- Rename the MagicString wrapper export in
binding-magic-string.tstoRolldownMagicString(type + constructor + exported const). - Update plugin API type surfaces (transform/renderChunk contexts and hook result types) to reference
RolldownMagicString. - Update bindingify hook adapters to construct/check
RolldownMagicStringfor lazy MagicString usage and direct return handling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rolldown/src/binding-magic-string.ts | Renames wrapper interface/constructor/export to RolldownMagicString. |
| packages/rolldown/src/index.ts | Re-exports RolldownMagicString from the package entrypoint. |
| packages/rolldown/src/plugin/index.ts | Updates public plugin hook/result typings to use RolldownMagicString. |
| packages/rolldown/src/plugin/transform-plugin-context.ts | Updates sendMagicString typing to accept RolldownMagicString. |
| packages/rolldown/src/plugin/bindingify-build-hooks.ts | Updates transform hook adapter to create/detect RolldownMagicString. |
| packages/rolldown/src/plugin/bindingify-output-hooks.ts | Updates renderChunk adapter to lazy-create/detect RolldownMagicString. |
IWANABETHATGUY
approved these changes
Mar 12, 2026
Member
|
Weird, why can't it be auto-merged after I approved it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BindingMagicStringtoRolldownMagicStringinbinding-magic-string.ts(interface, constructor type, and exported const)index.ts: import/exportRolldownMagicStringdirectlyRolldownMagicStringmain(bring unrelated files up to date)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.