Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make @rolldown/test-dev-server’s dev-server test suite deterministic and faster by replacing fixed sleeps with polling utilities driven by an internal dev-server status endpoint.
Changes:
- Added a dev-server status endpoint (
GET /_dev/status) exposing build/activity counters for tests. - Replaced fixed
setTimeoutsleeps in dev-server tests with polling helpers (waitForNextBuild,waitForBuildStable,waitForModuleRegistration). - Removed the CI timeout multiplier helper (
sensibleTimeoutInMs) and eliminated unused watch config plumbing in tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/test-dev-server/src/dev-server.ts | Adds build/module-registration counters and /_dev/status endpoint used by tests for synchronization. |
| packages/test-dev-server/tests/test-utils.ts | Introduces polling helpers that query /_dev/status and updates editFile to use them. |
| packages/test-dev-server/tests/vitest-setup-playwright.ts | Replaces retry sleep with a “wait for rebuild” helper before reloading the page. |
| packages/test-dev-server/tests/fixtures.test.ts | Switches fixture synchronization to build/module-registration polling instead of fixed sleeps. |
| packages/test-dev-server/tests/src/utils.ts | Removes sensibleTimeoutInMs sleep multiplier helper. |
| packages/test-dev-server/tests/src/config.ts | Removes unused CI watch option wiring from test config. |
Boshen
force-pushed
the
fix/deterministic-dev-server-tests
branch
from
2d07fe8 to
bf814f4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
sapphi-red
reviewed
Mar 12, 2026
sapphi-red
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review. Take the survey.
Boshen
force-pushed
the
fix/deterministic-dev-server-tests
branch
from
16026a4 to
03f335c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
You can also share your feedback on Copilot code review. Take the survey.
Boshen
force-pushed
the
fix/deterministic-dev-server-tests
branch
from
03f335c to
2cfc568
Compare
…th event-driven polling Add a `/_dev/status` endpoint exposing `buildSeq` and `registeredClients` counters. Tests now poll this endpoint instead of using hardcoded sleeps, eliminating flakiness from timing-dependent synchronization. Closes #8556 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Without this wait, consecutive HMR steps could be coalesced by the watcher debounce, causing the invalidation fixture to intermittently fail when ok-1 was never written. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Boshen
force-pushed
the
fix/deterministic-dev-server-tests
branch
from
2cfc568 to
1ed73fb
Compare
When HMR produces a FullReload update, the engine also triggers a rebuild which fires onOutput. Previously both callbacks incremented buildSeq, double-counting a single build cycle. Now onHmrUpdates skips the increment when FullReload is present, letting onOutput handle it. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Merged
shulaoda
added a commit
that referenced
this pull request
Mar 25, 2026
## [1.0.0-rc.12] - 2026-03-25 ### 🚀 Features - chunk-optimizer: skip circular dependency check when strict execution order is enabled (#8886) by @hyf0 ### 🐛 Bug Fixes - emit build warnings during watch mode rebuilds (#8897) by @IWANABETHATGUY - lazy-barrel: load import-then-export specifiers when barrel has local exports (#8895) by @shulaoda - correct execution order of transferred CJS init calls (#8877) by @IWANABETHATGUY - mcs: `entriesAware` should calculate sizes without duplication (#8887) by @hyf0 - non-deterministic chunk generation (#8882) by @sapphi-red - `is_top_level` incorrectly treats strict-mode scopes as top-level (#8878) by @Dunqing ### 🚜 Refactor - treeshake: migrate SideEffectDetector to Oxc's MayHaveSideEffects trait (#8624) by @Dunqing ### 🧪 Testing - make dev server tests deterministic by replacing fixed sleeps with event-driven polling (#8561) by @Boshen ### ⚙️ Miscellaneous Tasks - deps: update dependency vite-plus to v0.1.14 (#8902) by @camc314 - deps: update dependency oxfmt to ^0.42.0 (#8891) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v6.1.1 (#8890) by @renovate[bot] - remove Rolldown MF plan (#8883) by @shulaoda - deps: update rollup submodule for tests to v4.60.0 (#8881) by @sapphi-red - deps: update test262 submodule for tests (#8880) by @sapphi-red - deps: upgrade oxc crates to 0.122.0 (#8879) by @shulaoda Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/_dev/statusendpoint to the dev server exposingbuildSeq,moduleRegistrationSeq, and bundle state counterssetTimeoutsleeps in test synchronization with event-driven polling utilities (waitForNextBuild,waitForBuildStable,waitForModuleRegistration)sensibleTimeoutInMshelper and unusedCONFIG.watchreferencesbuildSeqdouble-increment on full-reload HMR builds (skip increment inonHmrUpdateswhen FullReload is present, sinceonOutputwill handle it)Eliminates all hardcoded sleeps (710ms-6000ms, x3 on CI) that caused flakiness and wasted CI minutes.
Local test results (macOS, 3 runs each)
CI job time comparison (avg of 3 runs each)
Closes #8556