Skip to content

fix: avoid incorrect CJS mutation bailout for computed member keys #8462

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-25-fix_too_aggresive_cjs_mutation_bailout
Feb 26, 2026
Merged

fix: avoid incorrect CJS mutation bailout for computed member keys #8462
graphite-app[bot] merged 1 commit intomainfrom
02-25-fix_too_aggresive_cjs_mutation_bailout

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Feb 25, 2026

No description provided.

@IWANABETHATGUY Graphite App
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Feb 25, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 25, 2026 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit eb77bc3
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/699fde8196265a0008a70fd1

@IWANABETHATGUY IWANABETHATGUY changed the title fix: too aggresive cjs mutation bailout fix: avoid incorrect CJS mutation bailout for computed member keys Feb 25, 2026
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-25-fix_too_aggresive_cjs_mutation_bailout branch from 1e69282 to 2697f4a Compare February 25, 2026 14:41
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Feb 25, 2026
Merged
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review February 25, 2026 15:39
@IWANABETHATGUY IWANABETHATGUY requested review from Copilot, hyf0 and shulaoda and removed request for Copilot February 25, 2026 15:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 25, 2026 •
edited
Loading

Benchmarks Rust

  • target: main(74af8e6)
  • pr: 02-25-fix_too_aggresive_cjs_mutation_bailout(eb77bc3)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     79.8±2.24ms        ? ?/sec    1.00     80.0±3.57ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     85.1±2.49ms        ? ?/sec    1.00     85.1±2.50ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    106.9±3.64ms        ? ?/sec    1.03    109.6±2.86ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    117.7±2.06ms        ? ?/sec    1.00    117.9±2.56ms        ? ?/sec
bundle/bundle@threejs                                        1.00     38.3±0.67ms        ? ?/sec    1.02     39.1±2.31ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.8±1.13ms        ? ?/sec    1.02     43.6±1.39ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    400.2±6.47ms        ? ?/sec    1.00    397.7±6.19ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    458.7±8.50ms        ? ?/sec    1.00    451.8±5.09ms        ? ?/sec
scan/scan@rome_ts                                            1.00     82.0±1.95ms        ? ?/sec    1.05     86.2±2.75ms        ? ?/sec
scan/scan@threejs                                            1.00     28.2±0.46ms        ? ?/sec    1.04     29.4±1.75ms        ? ?/sec
scan/scan@threejs10x                                         1.00    279.7±4.32ms        ? ?/sec    1.02    285.5±3.26ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Feb 25, 2026
Merged
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Feb 26, 2026 •
edited
Loading

Merge activity

Copilot AI review requested due to automatic review settings February 26, 2026 05:47
@graphite-app graphite-app bot force-pushed the 02-25-fix_too_aggresive_cjs_mutation_bailout branch from 2697f4a to eb77bc3 Compare February 26, 2026 05:47
@IWANABETHATGUY IWANABETHATGUY review requested due to automatic review settings February 26, 2026 05:47
@graphite-app graphite-app bot merged commit eb77bc3 into main Feb 26, 2026
35 checks passed
@graphite-app graphite-app bot deleted the 02-25-fix_too_aggresive_cjs_mutation_bailout branch February 26, 2026 05:58
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Feb 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

@shulaoda shulaoda Awaiting requested review from shulaoda

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0