test(data-url): verify plugins can resolve imports from data URL modules#8443
Closed
test(data-url): verify plugins can resolve imports from data URL modules#8443
Conversation
…ong string overhead
…ata URL modules Co-authored-by: hyf0 <[email protected]>
Copilot
AI
changed the title
[WIP] Update user error handling for data URL modules
test(data-url): verify plugins can resolve imports from data URL modules
Feb 24, 2026
d18a000 to
e8c3e87
Compare
e8c3e87 to
4776b5c
Compare
Base automatically changed from
02-22-feat_rust_data-url_use_hash_as_id_for_data_url_modules_to_prevent_long_string_overhead
to
main
February 24, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check that blocks filesystem resolution of imports from data URL modules lives in the private
resolve_id()fallback, which only runs after all pluginresolveIdhooks. Plugins already get a chance to resolve such imports; if none does, rolldown throwsUNRESOLVED_IMPORT.Changes
plugin_can_resolve_import_from_data_url_module: explicitly verifies a plugin can successfully intercept and resolve an import originating from a data URL moduleComplements the existing
loader_data_url_text_java_script_cannot_importfixture that covers the error path when no plugin resolves the import.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.