perf: bump to `sugar_path@2` for SIMD-based search and on-demand memory allocation by hyf0 · Pull Request #8432 · rolldown/rolldown

hyf0 · 2026-02-23T15:02:16Z

Summary

Bump sugar_path from 1.2.1 to 2^

What changed in sugar_path 2.0

The 2.0 release is focused on reducing allocations in hot paths. The key optimizations:

normalize() returns Cow<'_, Path> instead of PathBuf — a needs_normalization() fast-path check (using memchr) detects already-clean paths and returns Cow::Borrowed with zero allocation (#32)
absolutize() / absolutize_with() return Cow<'_, Path> — same idea: already-absolute clean paths are returned borrowed (#34)
memchr-accelerated fast path for relative() — replaces the component-iterator approach with SIMD-accelerated / scanning, avoids the absolutize() → current_dir() syscall when both paths are already absolute, and uses SmallVec<[&str; 8]> to stay on the stack (#27)
Reduced allocations across the board — reuse buffers, SmallVec for component lists, avoid collect() into Vec (#26)

Breaking change

normalize(), absolutize(), and absolutize_with() now return Cow<'_, Path> instead of PathBuf. Call sites that need an owned PathBuf require .into_owned(), and chained operations like .join().normalize().to_slash_lossy() need to be split so the intermediate Cow lives long enough.

Test plan

CI passes (same API surface, just Cow unwrapping at call sites)

hyf0 · 2026-02-23T15:02:31Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-02-23T15:02:38Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`7c62b0e`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/699c806eea6ac4000739035e

Copilot

Pull request overview

This pull request upgrades the sugar_path crate from version 1.2.1 to 2.0.0, which introduces a breaking API change where the .normalize() method now returns Cow<'_, Path> instead of PathBuf. This is a performance optimization that allows the method to return a borrowed reference when normalization doesn't change the path.

Changes:

Bumped sugar_path dependency from 1.2.1 to 2.0.0 in Cargo.toml
Updated all call sites to handle the new Cow<Path> return type by splitting chained operations and adding .into_owned() where owned PathBuf instances are required
Cargo.lock updated with transitive dependency updates (windows-sys 0.59.0 → 0.61.2, new memchr dependency for sugar_path)

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Cargo.toml	Version bump of sugar_path from 1.2.1 to 2.0.0
Cargo.lock	Dependency tree updates including sugar_path version, windows-sys, and new memchr dependency
crates/rolldown_resolver/src/resolver.rs	Split chained `.join().normalize()` into separate statements for compatibility
crates/rolldown_plugin_vite_resolve/src/vite_resolve_plugin.rs	Split chained operation and added intermediate variable
crates/rolldown_plugin_vite_build_import_analysis/src/ast_visit.rs	Split chained operation to handle Cow return type
crates/rolldown_plugin_vite_asset_import_meta_url/src/lib.rs	Split operations in two locations, one with simplified inline chaining
crates/rolldown_plugin_utils/src/check_public_file.rs	Added `.into_owned()` to convert Cow to owned PathBuf
crates/rolldown_common/src/inner_bundler_options/types/tsconfig.rs	Added `.into_owned()` for owned PathBuf storage
crates/rolldown_binding/src/options/plugin/config/binding_vite_transform_plugin_config.rs	Added `.into_owned()` for owned PathBuf storage
crates/rolldown_binding/src/options/plugin/config/binding_vite_reporter_plugin_config.rs	Added `.into_owned()` for owned PathBuf storage
crates/rolldown/src/stages/generate_stage/mod.rs	Added `.into_owned()` in two locations for absolutize_with results
crates/rolldown/examples/watch_new.rs	Added `.into_owned()` for Option storage
crates/rolldown/examples/watch.rs	Added `.into_owned()` for Option storage
crates/rolldown/examples/lazy.rs	Added `.into_owned()` for Option storage
crates/rolldown/examples/dev.rs	Added `.into_owned()` for Option storage
crates/rolldown/examples/basic.rs	Added `.into_owned()` for Option storage

codspeed-hq · 2026-02-23T15:11:14Z

Merging this PR will improve performance by 9.59%

⚡ 8 improved benchmarks

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`bundle@rome_ts`	475.6 ms	451.4 ms	+5.36%
⚡	`bundle@threejs-sourcemap`	219.2 ms	212.1 ms	+3.36%
⚡	`scan@rome_ts`	386.4 ms	364.1 ms	+6.12%
⚡	`bundle@multi-duplicated-top-level-symbol`	262.3 ms	243.8 ms	+7.61%
⚡	`bundle@multi-duplicated-top-level-symbol-sourcemap`	294.9 ms	269.1 ms	+9.59%
⚡	`bundle@threejs`	186.3 ms	179.6 ms	+3.72%
⚡	`scan@threejs`	146.9 ms	140.5 ms	+4.56%
⚡	`bundle@rome_ts-sourcemap`	546.3 ms	514.8 ms	+6.11%

_{Comparing 02-23-perf_bump_sugar_path_to_2.0.0 (b712bda) with main (2c571c8)}

github-actions · 2026-02-23T15:41:22Z

Benchmarks Rust

target: main(2c571c8)
pr: 02-23-perf_bump_sugar_path_to_2.0.0(b712bda)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     68.0±3.60ms        ? ?/sec    1.07     73.0±3.70ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     71.6±3.15ms        ? ?/sec    1.11     79.5±2.52ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00     97.5±2.89ms        ? ?/sec    1.06    103.2±3.81ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    107.7±2.69ms        ? ?/sec    1.07    115.8±2.29ms        ? ?/sec
bundle/bundle@threejs                                        1.00     34.4±1.21ms        ? ?/sec    1.08     37.1±2.30ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     39.1±0.96ms        ? ?/sec    1.07     41.7±0.73ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    359.8±4.88ms        ? ?/sec    1.06    379.7±8.77ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    415.0±6.41ms        ? ?/sec    1.04    433.2±6.78ms        ? ?/sec
scan/scan@rome_ts                                            1.00     77.5±2.61ms        ? ?/sec    1.05     81.6±3.21ms        ? ?/sec
scan/scan@threejs                                            1.00     27.5±1.76ms        ? ?/sec    1.03     28.2±1.82ms        ? ?/sec
scan/scan@threejs10x                                         1.00    271.8±4.59ms        ? ?/sec    1.03    280.3±4.01ms        ? ?/sec

hyf0 · 2026-02-23T16:29:12Z

Merge activity

Feb 23, 4:29 PM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 23, 4:29 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Feb 23, 4:36 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test-macos / Node Test').
Feb 24, 2:09 AM UTC: Brooooooklyn added this pull request to the Graphite merge queue.
Feb 24, 2:09 AM UTC: Merged by the Graphite merge queue.

## Summary Bump `sugar_path` from 1.2.1 to 2^ ### What changed in sugar_path 2.0 The 2.0 release is focused on reducing allocations in hot paths. The key optimizations: - **`normalize()` returns `Cow<'_, Path>` instead of `PathBuf`** — a `needs_normalization()` fast-path check (using `memchr`) detects already-clean paths and returns `Cow::Borrowed` with zero allocation ([#32](hyf0/sugar_path#32)) - **`absolutize()` / `absolutize_with()` return `Cow<'_, Path>`** — same idea: already-absolute clean paths are returned borrowed ([#34](hyf0/sugar_path#34)) - **`memchr`-accelerated fast path for `relative()`** — replaces the component-iterator approach with SIMD-accelerated `/` scanning, avoids the `absolutize()` → `current_dir()` syscall when both paths are already absolute, and uses `SmallVec<[&str; 8]>` to stay on the stack ([#27](hyf0/sugar_path#27)) - **Reduced allocations across the board** — reuse buffers, `SmallVec` for component lists, avoid `collect()` into `Vec` ([#26](hyf0/sugar_path#26)) ### Breaking change `normalize()`, `absolutize()`, and `absolutize_with()` now return `Cow<'_, Path>` instead of `PathBuf`. Call sites that need an owned `PathBuf` require `.into_owned()`, and chained operations like `.join().normalize().to_slash_lossy()` need to be split so the intermediate `Cow` lives long enough. ## Test plan - [x] CI passes (same API surface, just `Cow` unwrapping at call sites)

@hyf0

## [1.0.0-rc.6] - 2026-02-26 ### 💥 BREAKING CHANGES - css: remove `css_entry_filenames` , `css_chunk_filenames` and related code (#8402) by @hyf0 - css: drop builtin CSS bundling to explore alternative solutions (#8399) by @hyf0 ### 🚀 Features - rust/data-url: use hash as id for data url modules to prevent long string overhead (#8420) by @hyf0 - validate bundle stays within output dir (#8441) by @sapphi-red - rust: support `PluginOrder::PinPost` (#8417) by @hyf0 - support `ModuleType:Copy` (#8407) by @hyf0 - expose `ESTree` types from `rolldown/utils` (#8400) by @sapphi-red ### 🐛 Bug Fixes - incorrect sourcemap when postBanner/postFooter is used with shebang (#8459) by @Copilot - resolver: disable node_path option to align ESM resolver behavior (#8472) by @sapphi-red - parse `.js` within `"type": "commonjs"` as ESM for now (#8470) by @sapphi-red - case-insensitive filename conflict detection for chunk deduplication (#8458) by @Copilot - prevent inlining CJS exports that are mutated by importers (#8456) by @IWANABETHATGUY - parse `.cjs` / `.cts` / `.js` within `"type": "commonjs"` as CommonJS (#8455) by @sapphi-red - plugin/copy-module: correct hooks' priority (#8423) by @hyf0 - plugin/chunk-import-map: ensure `render_chunk_meta` run after users plugin (#8422) by @hyf0 - rust: correct hooks order of `DataUriPlugin` (#8418) by @hyf0 - `jsx.preserve` should also considering tsconfig json preserve (#8324) by @IWANABETHATGUY - `deferred_scan_data.rs "Should have resolved id: NotFound"` error (#8379) by @sapphi-red - cli: require value for `--dir`/`-d` and `--file`/`-o` (#8378) by @Copilot - dev: avoid mutex deadlock caused by inconsistent lock order (#8370) by @sapphi-red ### 🚜 Refactor - watch: rename TaskStart/TaskEnd to BundleStart/BundleEnd (#8463) by @hyf0 - rust: rename `rolldown_plugin_data_uri` to `rolldown_plugin_data_url` (#8421) by @hyf0 - bindingify-build-hook: extract helper for PluginContextImpl (#8438) by @ShroXd - give source loading a proper name (#8436) by @IWANABETHATGUY - ban holding DashMap refs across awaits (#8362) by @sapphi-red ### 📚 Documentation - add glob pattern usage example to input option (#8469) by @IWANABETHATGUY - remove `https://rolldown.rs` from links in reference docs (#8454) by @sapphi-red - mention execution order issue in `output.codeSplitting` docs (#8452) by @sapphi-red - clarify `output.comments` behavior a bit (#8451) by @sapphi-red - replace npmjs package links with npmx.dev (#8439) by @Boshen - reference: add `Exported from` for values / types exported from subpath exports (#8394) by @sapphi-red - add JSDocs for APIs exposed from subpath exports (#8393) by @sapphi-red - reference: generate reference pages for APIs exposed from subpath exports (#8392) by @sapphi-red - avoid pipe character in codeSplitting example to fix broken rendering (#8391) by @IWANABETHATGUY ### ⚡ Performance - avoid redundant PathBuf allocations in resolve paths (#8435) by @Brooooooklyn - bump to `sugar_path@2` (#8432) by @hyf0 - use flag-based convergence detection in include_statements (#8412) by @Brooooooklyn ### 🧪 Testing - execute `_test.mjs` even if `executeOutput` is false (#8398) by @sapphi-red - add retry to tree-shake/module-side-effects-proxy4 as it is flaky (#8397) by @sapphi-red - avoid `expect.assertions()` as it is not concurrent test friendly (#8383) by @sapphi-red - disable `mockReset` option (#8382) by @sapphi-red - fix flaky failure caused by concurrent resolveId calls (#8381) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rollup to v4.59.0 [security] (#8471) by @renovate[bot] - ai/design: add design doc about watch mode (#8453) by @hyf0 - deps: update oxc resolver to v11.19.0 (#8461) by @renovate[bot] - ai: introduce progressive spec-driven development pattern (#8446) by @hyf0 - deprecate output.legalComments (#8450) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.15.0 (#8448) by @renovate[bot] - ai: make CLAUDE.md a symlink of AGENTS.md (#8445) by @hyf0 - deps: update rollup submodule for tests to v4.59.0 (#8433) by @sapphi-red - deps: update test262 submodule for tests (#8434) by @sapphi-red - deps: update oxc to v0.115.0 (#8430) by @renovate[bot] - deps: update oxc apps (#8429) by @renovate[bot] - deps: update npm packages (#8426) by @renovate[bot] - deps: update rust crate owo-colors to v4.3.0 (#8428) by @renovate[bot] - deps: update github-actions (#8424) by @renovate[bot] - deps: update rust crates (#8425) by @renovate[bot] - deps: update oxc resolver to v11.18.0 (#8406) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.14.2 (#8405) by @renovate[bot] - ban `expect.assertions` in all fixture tests (#8395) by @sapphi-red - deps: update oxc apps (#8389) by @renovate[bot] - ban `expect.assertions` in fixture tests (#8387) by @sapphi-red - enable lint for `_config.ts` files (#8386) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.14.1 (#8385) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned hyf0 Feb 23, 2026

hyf0 marked this pull request as ready for review February 23, 2026 15:02

Copilot AI review requested due to automatic review settings February 23, 2026 15:02

Copilot started reviewing on behalf of hyf0 February 23, 2026 15:02 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

Brooooooklyn mentioned this pull request Feb 23, 2026

perf: replace sugar_path::relative with memchr-accelerated relative_to_slash #8419

Closed

hyf0 force-pushed the 02-23-perf_bump_sugar_path_to_2.0.0 branch from 0a20da3 to b2179f3 Compare February 23, 2026 15:12

hyf0 changed the title ~~perf: bump sugar_path to 2.0.0~~ perf: bump to sugar_path@2 Feb 23, 2026

Brooooooklyn approved these changes Feb 23, 2026

View reviewed changes

hyf0 added the graphite: merge-when-ready label Feb 23, 2026

graphite-app bot force-pushed the 02-23-perf_bump_sugar_path_to_2.0.0 branch from b712bda to 7c62b0e Compare February 23, 2026 16:29

hyf0 changed the title ~~perf: bump to sugar_path@2~~ perf: bump to sugar_path@2 for SIMD-based search and on-demand memory allocation Feb 23, 2026

graphite-app bot removed the graphite: merge-when-ready label Feb 23, 2026

graphite-app bot merged commit 7c62b0e into main Feb 24, 2026
58 of 59 checks passed

graphite-app bot deleted the 02-23-perf_bump_sugar_path_to_2.0.0 branch February 24, 2026 02:09

This was referenced Feb 25, 2026

release: v1.0.0-rc.6 #8449

Closed

release: v1.0.0-rc.6 #8473

Closed

release: v1.0.0-rc.6 #8474

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: bump to `sugar_path@2` for SIMD-based search and on-demand memory allocation#8432

perf: bump to `sugar_path@2` for SIMD-based search and on-demand memory allocation#8432
graphite-app[bot] merged 1 commit intomainfrom
02-23-perf_bump_sugar_path_to_2.0.0

hyf0 commented Feb 23, 2026 •

edited

Loading

Uh oh!

hyf0 commented Feb 23, 2026

Uh oh!

netlify bot commented Feb 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Feb 23, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

hyf0 commented Feb 23, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hyf0 commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed in sugar_path 2.0

Breaking change

Test plan

Uh oh!

hyf0 commented Feb 23, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codspeed-hq bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 9.59%

Performance Changes

Uh oh!

github-actions bot commented Feb 23, 2026

Benchmarks Rust

Uh oh!

hyf0 commented Feb 23, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hyf0 commented Feb 23, 2026 •

edited

Loading

netlify bot commented Feb 23, 2026 •

edited

Loading

codspeed-hq bot commented Feb 23, 2026 •

edited

Loading

hyf0 commented Feb 23, 2026 •

edited by graphite-app bot

Loading