Skip to content

Comments

refactor: introduce RawMangleOptions and RawCompressOptions#8366

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-18-refactor_introduce_rawmangleoptions_and_rawcompressoptions_
Feb 18, 2026
Merged

refactor: introduce RawMangleOptions and RawCompressOptions#8366
graphite-app[bot] merged 1 commit intomainfrom
02-18-refactor_introduce_rawmangleoptions_and_rawcompressoptions_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 18, 2026

A refactor for #8367. This PR does not change the behavior.

Copy link
Member Author

sapphi-red commented Feb 18, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Feb 18, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 26b5d8f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69954b083ec46d0008bb9353

@sapphi-red sapphi-red marked this pull request as ready for review February 18, 2026 04:34
Copilot AI review requested due to automatic review settings February 18, 2026 04:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors minify option handling to introduce intermediate RawMangleOptions and RawCompressOptions, supporting follow-up work from #8367 while aiming to preserve existing behavior.

Changes:

  • Export RawMangleOptions / RawCompressOptions from rolldown_common::bundler_options.
  • Replace RawMinifyOptionsDetailed.options with explicit mangle/compress raw option fields and normalize them into oxc options.
  • Update the binding-side normalization to construct the new raw minify shape.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
crates/rolldown_common/src/lib.rs Re-exports the new raw minify option types through bundler_options.
crates/rolldown_common/src/inner_bundler_options/types/minify_options.rs Introduces RawMangleOptions / RawCompressOptions and updates RawMinifyOptionsDetailed + normalization path.
crates/rolldown_binding/src/utils/normalize_binding_options.rs Updates NAPI option normalization to produce the new raw minify option structure.

@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(7593381)
  • pr: 02-18-refactor_introduce_rawmangleoptions_and_rawcompressoptions_(9df5f36)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     70.2±1.91ms        ? ?/sec    1.05     74.0±2.16ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     77.5±2.64ms        ? ?/sec    1.07     82.9±2.23ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    101.5±3.33ms        ? ?/sec    1.01    102.4±2.10ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    112.5±1.91ms        ? ?/sec    1.03    115.6±2.28ms        ? ?/sec
bundle/bundle@threejs                                        1.00     36.0±1.38ms        ? ?/sec    1.03     37.0±2.25ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.6±0.67ms        ? ?/sec    1.02     41.4±0.73ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    365.7±5.27ms        ? ?/sec    1.05    384.2±8.05ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    420.0±4.95ms        ? ?/sec    1.05    442.3±7.48ms        ? ?/sec
scan/scan@rome_ts                                            1.00     80.4±1.59ms        ? ?/sec    1.02     81.7±1.54ms        ? ?/sec
scan/scan@threejs                                            1.00     28.2±1.68ms        ? ?/sec    1.02     28.9±1.71ms        ? ?/sec
scan/scan@threejs10x                                         1.00    275.7±4.80ms        ? ?/sec    1.02    279.9±4.22ms        ? ?/sec

@sapphi-red sapphi-red force-pushed the 02-18-refactor_introduce_rawmangleoptions_and_rawcompressoptions_ branch from 9df5f36 to f01443c Compare February 18, 2026 05:04
Copy link
Member Author

sapphi-red commented Feb 18, 2026

Merge activity

  • Feb 18, 5:04 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 18, 5:15 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Feb 18, 5:23 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test-macos / Node Test').
  • Feb 18, 5:35 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 18, 5:39 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Feb 18, 5:39 AM UTC: Merged by the Graphite merge queue.

A refactor for #8367. This PR does not change the behavior.
@graphite-app graphite-app bot force-pushed the 02-18-refactor_introduce_rawmangleoptions_and_rawcompressoptions_ branch from f01443c to 26b5d8f Compare February 18, 2026 05:15
@graphite-app graphite-app bot merged commit 26b5d8f into main Feb 18, 2026
63 of 64 checks passed
@graphite-app graphite-app bot deleted the 02-18-refactor_introduce_rawmangleoptions_and_rawcompressoptions_ branch February 18, 2026 05:39
graphite-app bot pushed a commit that referenced this pull request Feb 18, 2026
…nify: true` (#8367)

`output.minify: true` and `output.minify: { compress: true, mangle: true, codegen: true }` should have the same behavior. But it wasn't.

This PR fixes that by using the same normalization in both paths. To achieve that, I introduced a new temporary struct in #8366. The alternative is to keep whether the value was default or not in a separate field (`default_target` field was doing that for `compress.target`), but I think this PR's way is more easier to understand.
This was referenced Feb 18, 2026
shulaoda pushed a commit that referenced this pull request Feb 18, 2026
## [1.0.0-rc.5] - 2026-02-18

💡 Smarter `entriesAware` Manual Code Splitting                                                                 
                                             
New `entriesAware` and `entriesAwareMergeThreshold` options for `manualCodeSplitting.groups[]` enable              
entry-reachability-based chunk splitting with automatic small chunk merging.                                       
                                                                                                                   
- `entriesAware: true` splits matched modules by entry reachability — modules reached by the same set of entries are grouped together, providing the most precise loading behavior with less over-fetching
- Chunks now get more readable names reflecting their entry associations (e.g. `vendor-entry-a-entry-b.js`) instead of opaque hashes
- `entriesAwareMergeThreshold` sets a byte-size threshold to merge tiny subgroups into the closest sibling with the fewest extra entries, reducing micro-chunk fragmentation while preserving precision
- Recommended to use together with `maxSize`: merge tiny chunks first to reduce request overhead, then cap large chunks to control payload size

```js
manualCodeSplitting: {
  groups: [{
    name: 'vendor',
    test: /node_modules/,
    entriesAware: true,
    entriesAwareMergeThreshold: 28000, // bytes
  }]
}
```

### 🚀 Features

- add `Visitor` to `rolldown/utils` (#8373) by @sapphi-red
- module-info: add `inputFormat` property to `ModuleInfo` (#8329) by @shulaoda
- default `treeshake.invalid_import_side_effects` to `false` (#8357) by @sapphi-red
- rolldown_utils: add `IndexBitSet` (#8343) by @sapphi-red
- rolldown_utils: add more methods and trait impls to BitSet (#8342) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add support for `await import().then((m) => m.prop)` (#8328) by @sapphi-red
- rolldown_plugin_vite_reporter: support custom logger for build infos (#7652) by @shulaoda
- rust/mcs: support `entriesAwareMergeThreshold` (#8312) by @hyf0
- mcs: `maxSize` will split the oversized chunk with taking file relevance into account (#8277) by @hyf0
- rolldown_plugin_vite_import_glob: support template literal in glob import patterns (#8298) by @shulaoda
- rolldown_plugin_chunk_import_map: output importmap without spaces (#8297) by @sapphi-red
- add INEFFECTIVE_DYNAMIC_IMPORT warning in core (#8284) by @shulaoda
- mcs: generate more readable name for `entriesAware` chunks (#8275) by @hyf0
- mcs: support `entriesAware` (#8274) by @hyf0

### 🐛 Bug Fixes

- improve circular dependency detection in chunk optimizer (#8371) by @IWANABETHATGUY
- align `minify.compress: true` and `minify.mangle: true` with `minify: true` (#8367) by @sapphi-red
- rolldown_plugin_esm_external_require: apply conversion to UMD and IIFE outputs (#8359) by @sapphi-red
- cjs: bailout treeshaking on cjs modules that have multiple re-exports (#8348) by @hyf0
- handle member expression and this expression in JSX element name rewriting (#8323) by @IWANABETHATGUY
- pad `encode_hash_with_base` output to fixed length to prevent slice panics (#8320) by @shulaoda
- `xxhash_with_base` skips hashing when input is exactly 16 bytes (#8319) by @shulaoda
- complete `ImportKind::try_from` with missing variants and correct `url-import` to `url-token` (#8310) by @shulaoda
- mark Node.js builtin modules as side-effect-free when resolved via `external` config (#8304) by @IWANABETHATGUY
- mcs: `maxSize` should split chunks correctly based on sizes (#8289) by @hyf0

### 🚜 Refactor

- introduce `RawMangleOptions` and `RawCompressOptions` (#8366) by @sapphi-red
- mcs: refactor `apply_manual_code_splitting` into `ManualSplitter` (#8346) by @hyf0
- rolldown_plugin_vite_reporter: simplify hook registration and remove redundant state (#8322) by @shulaoda
- use set to store user defined entry modules (#8315) by @IWANABETHATGUY
- rust/mcs: collect groups into map at first for having clean and performant operations (#8313) by @hyf0
- mcs: introduce newtype `ModuleGroupOrigin` and `ModuleGroupId` (#8311) by @hyf0
- remove unnecessary `FinalizerMutableState` struct (#8303) by @shulaoda
- move module finalization into `finalize_modules` (#8302) by @shulaoda
- extract `apply_transfer_parts_mutation` into its own module (#8301) by @shulaoda
- move ESM format check into `determine_export_mode` (#8294) by @shulaoda
- remove `warnings` field from `GenerateContext` (#8293) by @shulaoda
- extract util function remove clippy supression (#8290) by @IWANABETHATGUY
- move `is_in_node_modules` to `PathExt` trait in `rolldown_std_utils` (#8286) by @shulaoda
- rolldown_plugin_vite_reporter: remove unnecessary ineffective dynamic import detection logic (#8285) by @shulaoda
- dev: inject hmr runtime to `\0rolldown/runtime.js` (#8234) by @hyf0
- improve naming in chunk_optimizer (#8287) by @IWANABETHATGUY
- simplify PostChunkOptimizationOperation from bitflags to enum (#8283) by @IWANABETHATGUY
- optimize BitSet.index_of_one to return iterator instead of Vec (#8282) by @IWANABETHATGUY

### 📚 Documentation

- change default value in `format` JSDoc from `'esm'` to `'es'` (#8372) by @shulaoda
- in-depth: remove `invalidImportSideEffects` option mention from lazy barrel optimization doc (#8355) by @sapphi-red
- mcs: clarify `minSize` constraints (#8279) by @ShroXd

### ⚡ Performance

- use IndexVec for chunk TLA detection (#8341) by @sapphi-red
- only invoke single resolve call for the same specifier and import kind (#8332) by @sapphi-red
- rolldown_plugin_vite_reporter: skip gzip computation when `report_compressed_size` is disabled (#8321) by @shulaoda

### 🧪 Testing

- use `vi.waitFor` and `expect.poll` instead of custom `waitUtil` function (#8369) by @sapphi-red
- rolldown_plugin_esm_external_require_plugin: add tests (#8358) by @sapphi-red
- add watch file tests (#8330) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add test for dynamic import treeshaking (#8327) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- prepare-release: skip workflow on forked repositories (#8368) by @shulaoda
- format more files (#8360) by @sapphi-red
- deps: update oxc to v0.114.0 (#8347) by @camc314
- deps: update test262 submodule for tests (#8354) by @sapphi-red
- deps: update crate-ci/typos action to v1.43.5 (#8350) by @renovate[bot]
- deps: update oxc apps (#8351) by @renovate[bot]
- rolldown_plugin_vite_reporter: remove unnecessary README.md (#8334) by @shulaoda
- deps: update npm packages (#8338) by @renovate[bot]
- deps: update rust crates (#8339) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.13.0 (#8337) by @renovate[bot]
- deps: update github-actions (#8336) by @renovate[bot]
- deps: update napi to v3.8.3 (#8331) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.2 (#8325) by @renovate[bot]
- remove unnecessary transform.decorator (#8314) by @IWANABETHATGUY
- deps: update dependency rust to v1.93.1 (#8305) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.1 (#8300) by @renovate[bot]
- deps: update oxc apps (#8296) by @renovate[bot]
- docs: don't skip for build runs without cache (#8281) by @sapphi-red
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants