Skip to content

Comments

refactor: ban holding DashMap refs across awaits#8362

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-17-refactor_ban_holding_dashmap_refs_across_awaits
Feb 19, 2026
Merged

refactor: ban holding DashMap refs across awaits#8362
graphite-app[bot] merged 1 commit intomainfrom
02-17-refactor_ban_holding_dashmap_refs_across_awaits

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 17, 2026 •
edited
Loading

close #7311
refs #7289

TODO: try this PR in more places.

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Feb 17, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Feb 17, 2026 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 206fda7
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69946426064a9900084b11f6

@sapphi-red sapphi-red force-pushed the 02-17-refactor_ban_holding_dashmap_refs_across_awaits branch from b5df068 to 206fda7 Compare February 17, 2026 12:50
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 17, 2026 •
edited
Loading

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@8362

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@8362

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@8362

rolldown

npm i https://pkg.pr.new/rolldown@8362

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@8362

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@8362

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@8362

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@8362

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@8362

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@8362

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@8362

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@8362

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@8362

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@8362

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@8362

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@8362

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@8362

commit: c1dbe5d

@sapphi-red sapphi-red changed the base branch from main to graphite-base/8362 February 18, 2026 10:59
@sapphi-red sapphi-red force-pushed the 02-17-refactor_ban_holding_dashmap_refs_across_awaits branch from 206fda7 to c1dbe5d Compare February 18, 2026 10:59
@sapphi-red sapphi-red changed the base branch from graphite-base/8362 to 02-18-fix_dev_avoid_mutex_deadlock_caused_by_inconsistent_lock_order February 18, 2026 11:00
@sapphi-red sapphi-red mentioned this pull request Feb 18, 2026
Merged
@sapphi-red sapphi-red marked this pull request as ready for review February 18, 2026 11:43
@sapphi-red sapphi-red requested a review from hyf0 February 18, 2026 11:43
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026

Benchmarks Rust

  • target: 02-18-fix_dev_avoid_mutex_deadlock_caused_by_inconsistent_lock_order(23afd7b)
  • pr: 02-17-refactor_ban_holding_dashmap_refs_across_awaits(c1dbe5d)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     66.0±1.48ms        ? ?/sec    1.03     68.0±3.25ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     73.3±2.13ms        ? ?/sec    1.02     74.5±1.67ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00     96.4±2.48ms        ? ?/sec    1.01     97.7±2.00ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    109.1±1.80ms        ? ?/sec    1.00    108.0±1.55ms        ? ?/sec
bundle/bundle@threejs                                        1.00     36.0±2.21ms        ? ?/sec    1.00     36.1±1.99ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.2±0.60ms        ? ?/sec    1.02     41.1±1.31ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    353.2±6.07ms        ? ?/sec    1.01    358.3±6.81ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    421.8±4.94ms        ? ?/sec    1.00    421.7±7.26ms        ? ?/sec
scan/scan@rome_ts                                            1.00     76.0±1.20ms        ? ?/sec    1.01     77.0±3.23ms        ? ?/sec
scan/scan@threejs                                            1.00     27.0±1.69ms        ? ?/sec    1.00     26.9±0.54ms        ? ?/sec
scan/scan@threejs10x                                         1.00    266.3±2.51ms        ? ?/sec    1.00    267.5±4.70ms        ? ?/sec

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Feb 19, 2026 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 19, 2:13 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 19, 2:13 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Feb 19, 2:27 AM UTC: Merged by the Graphite merge queue.

@sapphi-red
refactor: ban holding DashMap refs across awaits (#8362)
edaac76 
close #7311
refs #7289

~~TODO: try this PR in more places.~~
@graphite-app graphite-app bot force-pushed the 02-18-fix_dev_avoid_mutex_deadlock_caused_by_inconsistent_lock_order branch from 23afd7b to fc69283 Compare February 19, 2026 02:14
@graphite-app graphite-app bot force-pushed the 02-17-refactor_ban_holding_dashmap_refs_across_awaits branch from c1dbe5d to edaac76 Compare February 19, 2026 02:14
Base automatically changed from 02-18-fix_dev_avoid_mutex_deadlock_caused_by_inconsistent_lock_order to main February 19, 2026 02:25
@graphite-app graphite-app bot merged commit edaac76 into main Feb 19, 2026
31 checks passed
@graphite-app graphite-app bot deleted the 02-17-refactor_ban_holding_dashmap_refs_across_awaits branch February 19, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

@sapphi-red sapphi-red

Labels

trigger: preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

audit: Review sync NAPI bindings for deadlock safety

2 participants

@sapphi-red @hyf0