Skip to content

Comments

fix: handle member expression and this expression in JSX element name rewriting#8323

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-13-fix_8318
Feb 14, 2026
Merged

fix: handle member expression and this expression in JSX element name rewriting#8323
graphite-app[bot] merged 1 commit intomainfrom
02-13-fix_8318

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Feb 13, 2026

closed #8318

Copy link
Member Author

IWANABETHATGUY commented Feb 13, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Feb 13, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit efd34f0
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/698fd5d4db85fa00088a974e

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 8318 fix: handle member expression and this expression in JSX element name rewriting Feb 13, 2026
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review February 13, 2026 15:41
Copy link
Member Author

IWANABETHATGUY commented Feb 13, 2026

Merge activity

  • Feb 13, 3:41 PM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 14, 1:52 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
  • Feb 14, 2:07 AM UTC: Merged by the Graphite merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes scope-hoisting JSX element-name rewriting so that when an identifier reference is rewritten into a member expression (and potentially a this expression), the AST is updated to the correct JSXElementName variant instead of hitting an unreachable!().

Changes:

  • Extend ScopeHoistingFinalizer::visit_jsx_element_name to handle rewritten StaticMemberExpression and ThisExpression results for JSXElementName::IdentifierReference.
  • Add a new integration fixture for issue #8318 that preserves JSX and exercises multi-entry CJS output.
  • Update filename-hash snapshot expectations to include the new fixture outputs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/rolldown/src/module_finalizers/impl_visit_mut.rs Updates JSX element-name rewriting to support member-expression / this-expression rewrites.
crates/rolldown/tests/rolldown/issues/8318/_config.json Adds a new integration test config (multi-entry, CJS, JSX preserve).
crates/rolldown/tests/rolldown/issues/8318/main.jsx New fixture entry that imports and uses a component in JSX.
crates/rolldown/tests/rolldown/issues/8318/component.jsx New fixture component used to trigger the JSX element-name rewrite behavior.
crates/rolldown/tests/rolldown/issues/8318/artifacts.snap Snapshot asserting the produced artifacts (notably <require_component.Greeting />).
crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap Updates hash-in-filename snapshot to include outputs for the new fixture.

@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     70.6±1.81ms        ? ?/sec    1.02     72.2±1.80ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     76.6±1.75ms        ? ?/sec    1.03     79.1±2.22ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    102.5±2.93ms        ? ?/sec    1.01    103.1±2.04ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    112.7±1.71ms        ? ?/sec    1.01    114.2±1.73ms        ? ?/sec
bundle/bundle@threejs                                        1.00     36.5±2.01ms        ? ?/sec    1.00     36.6±2.24ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.8±0.69ms        ? ?/sec    1.01     41.0±0.87ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    366.1±3.40ms        ? ?/sec    1.02    371.9±4.98ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    422.4±4.38ms        ? ?/sec    1.02    430.1±6.38ms        ? ?/sec
scan/scan@rome_ts                                            1.03     83.0±2.12ms        ? ?/sec    1.00     80.3±1.58ms        ? ?/sec
scan/scan@threejs                                            1.00     28.5±1.66ms        ? ?/sec    1.00     28.4±1.74ms        ? ?/sec
scan/scan@threejs10x                                         1.01    280.0±3.23ms        ? ?/sec    1.00    277.7±4.40ms        ? ?/sec

graphite-app bot pushed a commit that referenced this pull request Feb 14, 2026
@graphite-app graphite-app bot merged commit efd34f0 into main Feb 14, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 02-13-fix_8318 branch February 14, 2026 02:07
shulaoda pushed a commit that referenced this pull request Feb 18, 2026
## [1.0.0-rc.5] - 2026-02-18

💡 Smarter `entriesAware` Manual Code Splitting                                                                 
                                             
New `entriesAware` and `entriesAwareMergeThreshold` options for `manualCodeSplitting.groups[]` enable              
entry-reachability-based chunk splitting with automatic small chunk merging.                                       
                                                                                                                   
- `entriesAware: true` splits matched modules by entry reachability — modules reached by the same set of entries are grouped together, providing the most precise loading behavior with less over-fetching
- Chunks now get more readable names reflecting their entry associations (e.g. `vendor-entry-a-entry-b.js`) instead of opaque hashes
- `entriesAwareMergeThreshold` sets a byte-size threshold to merge tiny subgroups into the closest sibling with the fewest extra entries, reducing micro-chunk fragmentation while preserving precision
- Recommended to use together with `maxSize`: merge tiny chunks first to reduce request overhead, then cap large chunks to control payload size

```js
manualCodeSplitting: {
  groups: [{
    name: 'vendor',
    test: /node_modules/,
    entriesAware: true,
    entriesAwareMergeThreshold: 28000, // bytes
  }]
}
```

### 🚀 Features

- add `Visitor` to `rolldown/utils` (#8373) by @sapphi-red
- module-info: add `inputFormat` property to `ModuleInfo` (#8329) by @shulaoda
- default `treeshake.invalid_import_side_effects` to `false` (#8357) by @sapphi-red
- rolldown_utils: add `IndexBitSet` (#8343) by @sapphi-red
- rolldown_utils: add more methods and trait impls to BitSet (#8342) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add support for `await import().then((m) => m.prop)` (#8328) by @sapphi-red
- rolldown_plugin_vite_reporter: support custom logger for build infos (#7652) by @shulaoda
- rust/mcs: support `entriesAwareMergeThreshold` (#8312) by @hyf0
- mcs: `maxSize` will split the oversized chunk with taking file relevance into account (#8277) by @hyf0
- rolldown_plugin_vite_import_glob: support template literal in glob import patterns (#8298) by @shulaoda
- rolldown_plugin_chunk_import_map: output importmap without spaces (#8297) by @sapphi-red
- add INEFFECTIVE_DYNAMIC_IMPORT warning in core (#8284) by @shulaoda
- mcs: generate more readable name for `entriesAware` chunks (#8275) by @hyf0
- mcs: support `entriesAware` (#8274) by @hyf0

### 🐛 Bug Fixes

- improve circular dependency detection in chunk optimizer (#8371) by @IWANABETHATGUY
- align `minify.compress: true` and `minify.mangle: true` with `minify: true` (#8367) by @sapphi-red
- rolldown_plugin_esm_external_require: apply conversion to UMD and IIFE outputs (#8359) by @sapphi-red
- cjs: bailout treeshaking on cjs modules that have multiple re-exports (#8348) by @hyf0
- handle member expression and this expression in JSX element name rewriting (#8323) by @IWANABETHATGUY
- pad `encode_hash_with_base` output to fixed length to prevent slice panics (#8320) by @shulaoda
- `xxhash_with_base` skips hashing when input is exactly 16 bytes (#8319) by @shulaoda
- complete `ImportKind::try_from` with missing variants and correct `url-import` to `url-token` (#8310) by @shulaoda
- mark Node.js builtin modules as side-effect-free when resolved via `external` config (#8304) by @IWANABETHATGUY
- mcs: `maxSize` should split chunks correctly based on sizes (#8289) by @hyf0

### 🚜 Refactor

- introduce `RawMangleOptions` and `RawCompressOptions` (#8366) by @sapphi-red
- mcs: refactor `apply_manual_code_splitting` into `ManualSplitter` (#8346) by @hyf0
- rolldown_plugin_vite_reporter: simplify hook registration and remove redundant state (#8322) by @shulaoda
- use set to store user defined entry modules (#8315) by @IWANABETHATGUY
- rust/mcs: collect groups into map at first for having clean and performant operations (#8313) by @hyf0
- mcs: introduce newtype `ModuleGroupOrigin` and `ModuleGroupId` (#8311) by @hyf0
- remove unnecessary `FinalizerMutableState` struct (#8303) by @shulaoda
- move module finalization into `finalize_modules` (#8302) by @shulaoda
- extract `apply_transfer_parts_mutation` into its own module (#8301) by @shulaoda
- move ESM format check into `determine_export_mode` (#8294) by @shulaoda
- remove `warnings` field from `GenerateContext` (#8293) by @shulaoda
- extract util function remove clippy supression (#8290) by @IWANABETHATGUY
- move `is_in_node_modules` to `PathExt` trait in `rolldown_std_utils` (#8286) by @shulaoda
- rolldown_plugin_vite_reporter: remove unnecessary ineffective dynamic import detection logic (#8285) by @shulaoda
- dev: inject hmr runtime to `\0rolldown/runtime.js` (#8234) by @hyf0
- improve naming in chunk_optimizer (#8287) by @IWANABETHATGUY
- simplify PostChunkOptimizationOperation from bitflags to enum (#8283) by @IWANABETHATGUY
- optimize BitSet.index_of_one to return iterator instead of Vec (#8282) by @IWANABETHATGUY

### 📚 Documentation

- change default value in `format` JSDoc from `'esm'` to `'es'` (#8372) by @shulaoda
- in-depth: remove `invalidImportSideEffects` option mention from lazy barrel optimization doc (#8355) by @sapphi-red
- mcs: clarify `minSize` constraints (#8279) by @ShroXd

### ⚡ Performance

- use IndexVec for chunk TLA detection (#8341) by @sapphi-red
- only invoke single resolve call for the same specifier and import kind (#8332) by @sapphi-red
- rolldown_plugin_vite_reporter: skip gzip computation when `report_compressed_size` is disabled (#8321) by @shulaoda

### 🧪 Testing

- use `vi.waitFor` and `expect.poll` instead of custom `waitUtil` function (#8369) by @sapphi-red
- rolldown_plugin_esm_external_require_plugin: add tests (#8358) by @sapphi-red
- add watch file tests (#8330) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add test for dynamic import treeshaking (#8327) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- prepare-release: skip workflow on forked repositories (#8368) by @shulaoda
- format more files (#8360) by @sapphi-red
- deps: update oxc to v0.114.0 (#8347) by @camc314
- deps: update test262 submodule for tests (#8354) by @sapphi-red
- deps: update crate-ci/typos action to v1.43.5 (#8350) by @renovate[bot]
- deps: update oxc apps (#8351) by @renovate[bot]
- rolldown_plugin_vite_reporter: remove unnecessary README.md (#8334) by @shulaoda
- deps: update npm packages (#8338) by @renovate[bot]
- deps: update rust crates (#8339) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.13.0 (#8337) by @renovate[bot]
- deps: update github-actions (#8336) by @renovate[bot]
- deps: update napi to v3.8.3 (#8331) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.2 (#8325) by @renovate[bot]
- remove unnecessary transform.decorator (#8314) by @IWANABETHATGUY
- deps: update dependency rust to v1.93.1 (#8305) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.1 (#8300) by @renovate[bot]
- deps: update oxc apps (#8296) by @renovate[bot]
- docs: don't skip for build runs without cache (#8281) by @sapphi-red
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Panic]: entered unreachable code: Should always rewrite to Identifier for JsxElementName::IdentifierReference

2 participants