Skip to content

Comments

refactor(rust/mcs): collect groups into map at first for having clean and performant operations#8313

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-13-refactor_rust_mcs_collect_groups_into_map_at_first_for_having_clean_and_performant_operations
Feb 13, 2026
Merged

refactor(rust/mcs): collect groups into map at first for having clean and performant operations#8313
graphite-app[bot] merged 1 commit intomainfrom
02-13-refactor_rust_mcs_collect_groups_into_map_at_first_for_having_clean_and_performant_operations

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Feb 13, 2026

No description provided.

Copy link
Member Author

hyf0 commented Feb 13, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review February 13, 2026 04:49
Copilot AI review requested due to automatic review settings February 13, 2026 04:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the manual code splitting implementation to use FxHashMap<u32, ModuleGroup> instead of IndexVec<ModuleGroupIdx, ModuleGroup>. The refactoring improves code clarity and maintainability by simplifying the merge operation and using a more appropriate data structure for a collection where elements are frequently removed.

Changes:

  • Replaced IndexVec with FxHashMap for module group storage, using manual u32 key management
  • Simplified merge_module_groups function by replacing complex split_at_mut logic with straightforward HashMap operations
  • Refactored version tracking to use a lazy HashMap instead of pre-allocated IndexVec

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Benchmarks Rust

  • target: 02-13-feat_rust_mcs_support_entriesawaremergethreahold_(ef9d902)
  • pr: 02-13-refactor_rust_mcs_collect_groups_into_map_at_first_for_having_clean_and_performant_operations(508be39)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     70.3±2.56ms        ? ?/sec    1.00     68.9±1.29ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     76.4±1.74ms        ? ?/sec    1.00     75.3±1.46ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    101.0±1.82ms        ? ?/sec    1.00    100.7±1.67ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    112.0±1.46ms        ? ?/sec    1.00    112.0±1.52ms        ? ?/sec
bundle/bundle@threejs                                        1.02     36.8±1.70ms        ? ?/sec    1.00     36.1±2.02ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.5±0.61ms        ? ?/sec    1.00     40.6±0.63ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    363.2±3.00ms        ? ?/sec    1.00    363.9±6.08ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    421.4±4.00ms        ? ?/sec    1.00    421.2±4.96ms        ? ?/sec
scan/scan@rome_ts                                            1.00     81.0±1.89ms        ? ?/sec    1.00     81.2±2.54ms        ? ?/sec
scan/scan@threejs                                            1.00     27.7±0.38ms        ? ?/sec    1.03     28.4±1.59ms        ? ?/sec
scan/scan@threejs10x                                         1.00    275.2±2.83ms        ? ?/sec    1.01    277.9±3.54ms        ? ?/sec

@hyf0 hyf0 force-pushed the 02-13-feat_rust_mcs_support_entriesawaremergethreahold_ branch from 0dd6e74 to da81b99 Compare February 13, 2026 05:07
@hyf0 hyf0 force-pushed the 02-13-refactor_rust_mcs_collect_groups_into_map_at_first_for_having_clean_and_performant_operations branch from abc722c to 735739e Compare February 13, 2026 05:07
@hyf0 hyf0 force-pushed the 02-13-feat_rust_mcs_support_entriesawaremergethreahold_ branch from da81b99 to 4352598 Compare February 13, 2026 05:33
@hyf0 hyf0 force-pushed the 02-13-refactor_rust_mcs_collect_groups_into_map_at_first_for_having_clean_and_performant_operations branch 2 times, most recently from 64ffc96 to 3a4b1a2 Compare February 13, 2026 06:00
@hyf0 hyf0 force-pushed the 02-13-feat_rust_mcs_support_entriesawaremergethreahold_ branch from 4352598 to 1da7ac7 Compare February 13, 2026 06:00
@hyf0 hyf0 force-pushed the 02-13-refactor_rust_mcs_collect_groups_into_map_at_first_for_having_clean_and_performant_operations branch from 3a4b1a2 to 5370619 Compare February 13, 2026 06:33
@hyf0 hyf0 force-pushed the 02-13-feat_rust_mcs_support_entriesawaremergethreahold_ branch from 1da7ac7 to f56d7cf Compare February 13, 2026 06:33
@graphite-app graphite-app bot force-pushed the 02-13-feat_rust_mcs_support_entriesawaremergethreahold_ branch 2 times, most recently from 02e2f94 to ef9d902 Compare February 13, 2026 06:48
@graphite-app graphite-app bot force-pushed the 02-13-refactor_rust_mcs_collect_groups_into_map_at_first_for_having_clean_and_performant_operations branch from 5370619 to 508be39 Compare February 13, 2026 06:48
Copy link
Member Author

hyf0 commented Feb 13, 2026

Merge activity

  • Feb 13, 7:35 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 13, 7:35 AM UTC: hyf0 added this pull request to the Graphite merge queue.
  • Feb 13, 7:47 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test-macos / Node Test').
  • Feb 13, 7:59 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 13, 8:04 AM UTC: hyf0 added this pull request to the Graphite merge queue.
  • Feb 13, 8:04 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 02-13-feat_rust_mcs_support_entriesawaremergethreahold_ branch from ef9d902 to a998e81 Compare February 13, 2026 07:36
@graphite-app graphite-app bot force-pushed the 02-13-refactor_rust_mcs_collect_groups_into_map_at_first_for_having_clean_and_performant_operations branch from 508be39 to 26fc459 Compare February 13, 2026 07:36
Base automatically changed from 02-13-feat_rust_mcs_support_entriesawaremergethreahold_ to main February 13, 2026 07:46
@graphite-app graphite-app bot merged commit 26fc459 into main Feb 13, 2026
60 of 61 checks passed
@graphite-app graphite-app bot deleted the 02-13-refactor_rust_mcs_collect_groups_into_map_at_first_for_having_clean_and_performant_operations branch February 13, 2026 08:04
shulaoda pushed a commit that referenced this pull request Feb 18, 2026
## [1.0.0-rc.5] - 2026-02-18

💡 Smarter `entriesAware` Manual Code Splitting                                                                 
                                             
New `entriesAware` and `entriesAwareMergeThreshold` options for `manualCodeSplitting.groups[]` enable              
entry-reachability-based chunk splitting with automatic small chunk merging.                                       
                                                                                                                   
- `entriesAware: true` splits matched modules by entry reachability — modules reached by the same set of entries are grouped together, providing the most precise loading behavior with less over-fetching
- Chunks now get more readable names reflecting their entry associations (e.g. `vendor-entry-a-entry-b.js`) instead of opaque hashes
- `entriesAwareMergeThreshold` sets a byte-size threshold to merge tiny subgroups into the closest sibling with the fewest extra entries, reducing micro-chunk fragmentation while preserving precision
- Recommended to use together with `maxSize`: merge tiny chunks first to reduce request overhead, then cap large chunks to control payload size

```js
manualCodeSplitting: {
  groups: [{
    name: 'vendor',
    test: /node_modules/,
    entriesAware: true,
    entriesAwareMergeThreshold: 28000, // bytes
  }]
}
```

### 🚀 Features

- add `Visitor` to `rolldown/utils` (#8373) by @sapphi-red
- module-info: add `inputFormat` property to `ModuleInfo` (#8329) by @shulaoda
- default `treeshake.invalid_import_side_effects` to `false` (#8357) by @sapphi-red
- rolldown_utils: add `IndexBitSet` (#8343) by @sapphi-red
- rolldown_utils: add more methods and trait impls to BitSet (#8342) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add support for `await import().then((m) => m.prop)` (#8328) by @sapphi-red
- rolldown_plugin_vite_reporter: support custom logger for build infos (#7652) by @shulaoda
- rust/mcs: support `entriesAwareMergeThreshold` (#8312) by @hyf0
- mcs: `maxSize` will split the oversized chunk with taking file relevance into account (#8277) by @hyf0
- rolldown_plugin_vite_import_glob: support template literal in glob import patterns (#8298) by @shulaoda
- rolldown_plugin_chunk_import_map: output importmap without spaces (#8297) by @sapphi-red
- add INEFFECTIVE_DYNAMIC_IMPORT warning in core (#8284) by @shulaoda
- mcs: generate more readable name for `entriesAware` chunks (#8275) by @hyf0
- mcs: support `entriesAware` (#8274) by @hyf0

### 🐛 Bug Fixes

- improve circular dependency detection in chunk optimizer (#8371) by @IWANABETHATGUY
- align `minify.compress: true` and `minify.mangle: true` with `minify: true` (#8367) by @sapphi-red
- rolldown_plugin_esm_external_require: apply conversion to UMD and IIFE outputs (#8359) by @sapphi-red
- cjs: bailout treeshaking on cjs modules that have multiple re-exports (#8348) by @hyf0
- handle member expression and this expression in JSX element name rewriting (#8323) by @IWANABETHATGUY
- pad `encode_hash_with_base` output to fixed length to prevent slice panics (#8320) by @shulaoda
- `xxhash_with_base` skips hashing when input is exactly 16 bytes (#8319) by @shulaoda
- complete `ImportKind::try_from` with missing variants and correct `url-import` to `url-token` (#8310) by @shulaoda
- mark Node.js builtin modules as side-effect-free when resolved via `external` config (#8304) by @IWANABETHATGUY
- mcs: `maxSize` should split chunks correctly based on sizes (#8289) by @hyf0

### 🚜 Refactor

- introduce `RawMangleOptions` and `RawCompressOptions` (#8366) by @sapphi-red
- mcs: refactor `apply_manual_code_splitting` into `ManualSplitter` (#8346) by @hyf0
- rolldown_plugin_vite_reporter: simplify hook registration and remove redundant state (#8322) by @shulaoda
- use set to store user defined entry modules (#8315) by @IWANABETHATGUY
- rust/mcs: collect groups into map at first for having clean and performant operations (#8313) by @hyf0
- mcs: introduce newtype `ModuleGroupOrigin` and `ModuleGroupId` (#8311) by @hyf0
- remove unnecessary `FinalizerMutableState` struct (#8303) by @shulaoda
- move module finalization into `finalize_modules` (#8302) by @shulaoda
- extract `apply_transfer_parts_mutation` into its own module (#8301) by @shulaoda
- move ESM format check into `determine_export_mode` (#8294) by @shulaoda
- remove `warnings` field from `GenerateContext` (#8293) by @shulaoda
- extract util function remove clippy supression (#8290) by @IWANABETHATGUY
- move `is_in_node_modules` to `PathExt` trait in `rolldown_std_utils` (#8286) by @shulaoda
- rolldown_plugin_vite_reporter: remove unnecessary ineffective dynamic import detection logic (#8285) by @shulaoda
- dev: inject hmr runtime to `\0rolldown/runtime.js` (#8234) by @hyf0
- improve naming in chunk_optimizer (#8287) by @IWANABETHATGUY
- simplify PostChunkOptimizationOperation from bitflags to enum (#8283) by @IWANABETHATGUY
- optimize BitSet.index_of_one to return iterator instead of Vec (#8282) by @IWANABETHATGUY

### 📚 Documentation

- change default value in `format` JSDoc from `'esm'` to `'es'` (#8372) by @shulaoda
- in-depth: remove `invalidImportSideEffects` option mention from lazy barrel optimization doc (#8355) by @sapphi-red
- mcs: clarify `minSize` constraints (#8279) by @ShroXd

### ⚡ Performance

- use IndexVec for chunk TLA detection (#8341) by @sapphi-red
- only invoke single resolve call for the same specifier and import kind (#8332) by @sapphi-red
- rolldown_plugin_vite_reporter: skip gzip computation when `report_compressed_size` is disabled (#8321) by @shulaoda

### 🧪 Testing

- use `vi.waitFor` and `expect.poll` instead of custom `waitUtil` function (#8369) by @sapphi-red
- rolldown_plugin_esm_external_require_plugin: add tests (#8358) by @sapphi-red
- add watch file tests (#8330) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add test for dynamic import treeshaking (#8327) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- prepare-release: skip workflow on forked repositories (#8368) by @shulaoda
- format more files (#8360) by @sapphi-red
- deps: update oxc to v0.114.0 (#8347) by @camc314
- deps: update test262 submodule for tests (#8354) by @sapphi-red
- deps: update crate-ci/typos action to v1.43.5 (#8350) by @renovate[bot]
- deps: update oxc apps (#8351) by @renovate[bot]
- rolldown_plugin_vite_reporter: remove unnecessary README.md (#8334) by @shulaoda
- deps: update npm packages (#8338) by @renovate[bot]
- deps: update rust crates (#8339) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.13.0 (#8337) by @renovate[bot]
- deps: update github-actions (#8336) by @renovate[bot]
- deps: update napi to v3.8.3 (#8331) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.2 (#8325) by @renovate[bot]
- remove unnecessary transform.decorator (#8314) by @IWANABETHATGUY
- deps: update dependency rust to v1.93.1 (#8305) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.1 (#8300) by @renovate[bot]
- deps: update oxc apps (#8296) by @renovate[bot]
- docs: don't skip for build runs without cache (#8281) by @sapphi-red
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants