Skip to content

Comments

feat: rename error name to RolldownError from RollupError#8262

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-10-feat_rename_error_name_to_rolldownerror_from_rolluperror_
Feb 10, 2026
Merged

feat: rename error name to RolldownError from RollupError#8262
graphite-app[bot] merged 1 commit intomainfrom
02-10-feat_rename_error_name_to_rolldownerror_from_rolluperror_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 10, 2026

To make it less confusing.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 67a1f58
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/698aa700b502020008fbe776

@sapphi-red sapphi-red marked this pull request as ready for review February 10, 2026 03:07
Copilot AI review requested due to automatic review settings February 10, 2026 03:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the runtime error.name used for Rolldown-thrown (wrapped) logs from RollupError to RolldownError to reduce confusion and align error branding across the project.

Changes:

  • Update Rolldown’s log-to-Error wrapper to set error.name = "RolldownError".
  • Adjust Rollup-compat test expectation for the thrown error name.
  • Update a fixture expectation for formatted plugin error output to show RolldownError:.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/rollup-tests/test/misc/misc.js Updates assertion to expect error.name as RolldownError.
packages/rolldown/tests/fixtures/misc/error/plugin-context/_config.ts Updates expected formatted error message prefix to RolldownError:.
packages/rolldown/src/log/logs.ts Changes the wrapped error name from RollupError to RolldownError.

Copy link
Member Author

sapphi-red commented Feb 10, 2026

Merge activity

  • Feb 10, 3:32 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 3:32 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Feb 10, 3:44 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 02-10-feat_rename_error_name_to_rolldownerror_from_rolluperror_ branch from 87224d6 to 67a1f58 Compare February 10, 2026 03:33
@graphite-app graphite-app bot merged commit 67a1f58 into main Feb 10, 2026
32 checks passed
@graphite-app graphite-app bot deleted the 02-10-feat_rename_error_name_to_rolldownerror_from_rolluperror_ branch February 10, 2026 03:44
This was referenced Feb 11, 2026
shulaoda added a commit that referenced this pull request Feb 11, 2026
## [1.0.0-rc.4] - 2026-02-11

💡 Granular `comments` Option
- New `output.comments` option provides fine-grained control over comment preservation
- The `output.legalComments` option is now deprecated and use `comments.legal` instead

### 🚀 Features

- rename error name to `RolldownError` from `RollupError` (#8262) by @sapphi-red
- add hidden `resolve_tsconfig` function for Vite (#8257) by @sapphi-red
- rust: introduce `rolldown_watcher` (#8161) by @hyf0
- unify `comments` and `legalComments` into a single granular `comments` option (#8229) by @IWANABETHATGUY
- add builtin plugin for visualizing chunk graph (#8162) by @IWANABETHATGUY
- show import declaration location in AssignToImport errors (#8222) by @Copilot
- show import declaration span in CannotCallNamespace error (#8223) by @Copilot
- emit error when plugin accidentally removes runtime module symbols (#8203) by @IWANABETHATGUY
- support tsconfig loading & inputMap for `transform` (#8180) by @sapphi-red
- rolldown_plugin_vite_reporter: update warning message to link to Rolldown docs (#8205) by @sapphi-red

### 🐛 Bug Fixes

- avoid panic on untranspiled JSX syntax by reporting a diagnostic error (#8226) by @IWANABETHATGUY
- rolldown_plugin_vite_import_glob: relax absolute path check and improve invalid glob warning (#8219) by @shulaoda
- merge chunks after detect circular reference (#8154) by @IWANABETHATGUY
- rust: detect runtime module side effects based on its content (#8209) by @hyf0

### 🚜 Refactor

- rename `other` to `jsdoc` in comments options (#8256) by @IWANABETHATGUY
- rename chunk-visualize plugin with bundle-analyzer plugin (#8255) by @IWANABETHATGUY
- remove EXPORT_UNDEFINED_VARIABLE error (#8228) by @Copilot
- consolidate missing runtime symbol errors into a single diagnostic (#8220) by @IWANABETHATGUY
- stabilize `parse` and `parseSync` (#8215) by @sapphi-red
- return errors instead of panicking on builtin plugin conversion failure (#8217) by @shulaoda
- expose `parse` / `minify` / `transform` from `rolldown/utils` (#8214) by @sapphi-red
- prepare defer chunk merging (#8153) by @IWANABETHATGUY

### 📚 Documentation

- remove `<script>` escape behavior difference note from `platform` option (#8253) by @sapphi-red
- TypeScript & JSX support by plugins (#8183) by @sapphi-red

### 🧪 Testing

- ensure runtime module is preserved even if it's not used but has side effects (#8213) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: update oxc to v0.113.0 (#8267) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.0 (#8272) by @renovate[bot]
- deps: update oxc apps (#8269) by @renovate[bot]
- deps: update test262 submodule for tests (#8261) by @sapphi-red
- deps: update crate-ci/typos action to v1.43.4 (#8260) by @renovate[bot]
- deps: update dependency esbuild to v0.27.3 (#8250) by @renovate[bot]
- deps: update rust crates (#8244) by @renovate[bot]
- deps: update dependency semver to v7.7.4 (#8247) by @renovate[bot]
- deps: update github-actions (#8243) by @renovate[bot]
- deps: update npm packages (#8245) by @renovate[bot]
- deps: update oxc resolver to v11.17.1 (#8240) by @renovate[bot]
- deps: update rust crate oxc_sourcemap to v6.0.2 (#8241) by @renovate[bot]
- rust: handle ignored `RUSTSEC-2025-0141` cargo check error (#8235) by @hyf0
- deps: update dependency oxlint-tsgolint to v0.11.5 (#8233) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to ^0.22.0 (#8232) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.3 (#8225) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.9 (#8224) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.2 (#8212) by @renovate[bot]
- remove rolldown_plugin_vite_wasm_helper (#8207) by @shulaoda
- build docs for production (#8206) by @sapphi-red

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants