Skip to content

Comments

test: ensure runtime module is preserved even if it's not used but has side effects#8213

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-06-test_ensure_runtime_module_is_preserved_even_if_it_s_not_used_but_has_side_effects
Feb 6, 2026
Merged

test: ensure runtime module is preserved even if it's not used but has side effects#8213
graphite-app[bot] merged 1 commit intomainfrom
02-06-test_ensure_runtime_module_is_preserved_even_if_it_s_not_used_but_has_side_effects

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Feb 6, 2026

No description provided.

@hyf0 hyf0 marked this pull request as ready for review February 6, 2026 04:07
Copilot AI review requested due to automatic review settings February 6, 2026 04:08
Copy link
Member Author

hyf0 commented Feb 6, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Benchmarks Rust

  • target: 02-06-refactor_rust_detect_runtime_module_side_effects_based_on_its_content(9c1ddd7)
  • pr: 02-06-test_ensure_runtime_module_is_preserved_even_if_it_s_not_used_but_has_side_effects(73e8b19)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     66.7±1.95ms        ? ?/sec    1.03     68.3±2.45ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     70.7±1.06ms        ? ?/sec    1.05     74.0±2.20ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00     98.3±3.50ms        ? ?/sec    1.00     98.5±1.43ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    109.2±2.65ms        ? ?/sec    1.01    110.3±1.34ms        ? ?/sec
bundle/bundle@threejs                                        1.01     34.8±1.95ms        ? ?/sec    1.00     34.5±0.47ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     39.2±0.52ms        ? ?/sec    1.01     39.4±0.48ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    356.0±4.29ms        ? ?/sec    1.02    361.5±3.52ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    411.0±3.30ms        ? ?/sec    1.02    419.5±4.04ms        ? ?/sec
scan/scan@rome_ts                                            1.00     78.7±1.44ms        ? ?/sec    1.01     79.7±2.27ms        ? ?/sec
scan/scan@threejs                                            1.01     27.7±1.66ms        ? ?/sec    1.00     27.5±0.51ms        ? ?/sec
scan/scan@threejs10x                                         1.00    280.5±3.50ms        ? ?/sec    1.01    283.6±4.36ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 6, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 02-06-refactor_rust_detect_runtime_module_side_effects_based_on_its_content branch from b4a426f to 9c1ddd7 Compare February 6, 2026 06:04
@graphite-app graphite-app bot force-pushed the 02-06-test_ensure_runtime_module_is_preserved_even_if_it_s_not_used_but_has_side_effects branch from efa5098 to 73e8b19 Compare February 6, 2026 06:04
Base automatically changed from 02-06-refactor_rust_detect_runtime_module_side_effects_based_on_its_content to main February 6, 2026 06:14
@graphite-app graphite-app bot merged commit 73e8b19 into main Feb 6, 2026
32 checks passed
@graphite-app graphite-app bot deleted the 02-06-test_ensure_runtime_module_is_preserved_even_if_it_s_not_used_but_has_side_effects branch February 6, 2026 06:14
This was referenced Feb 11, 2026
shulaoda added a commit that referenced this pull request Feb 11, 2026
## [1.0.0-rc.4] - 2026-02-11

💡 Granular `comments` Option
- New `output.comments` option provides fine-grained control over comment preservation
- The `output.legalComments` option is now deprecated and use `comments.legal` instead

### 🚀 Features

- rename error name to `RolldownError` from `RollupError` (#8262) by @sapphi-red
- add hidden `resolve_tsconfig` function for Vite (#8257) by @sapphi-red
- rust: introduce `rolldown_watcher` (#8161) by @hyf0
- unify `comments` and `legalComments` into a single granular `comments` option (#8229) by @IWANABETHATGUY
- add builtin plugin for visualizing chunk graph (#8162) by @IWANABETHATGUY
- show import declaration location in AssignToImport errors (#8222) by @Copilot
- show import declaration span in CannotCallNamespace error (#8223) by @Copilot
- emit error when plugin accidentally removes runtime module symbols (#8203) by @IWANABETHATGUY
- support tsconfig loading & inputMap for `transform` (#8180) by @sapphi-red
- rolldown_plugin_vite_reporter: update warning message to link to Rolldown docs (#8205) by @sapphi-red

### 🐛 Bug Fixes

- avoid panic on untranspiled JSX syntax by reporting a diagnostic error (#8226) by @IWANABETHATGUY
- rolldown_plugin_vite_import_glob: relax absolute path check and improve invalid glob warning (#8219) by @shulaoda
- merge chunks after detect circular reference (#8154) by @IWANABETHATGUY
- rust: detect runtime module side effects based on its content (#8209) by @hyf0

### 🚜 Refactor

- rename `other` to `jsdoc` in comments options (#8256) by @IWANABETHATGUY
- rename chunk-visualize plugin with bundle-analyzer plugin (#8255) by @IWANABETHATGUY
- remove EXPORT_UNDEFINED_VARIABLE error (#8228) by @Copilot
- consolidate missing runtime symbol errors into a single diagnostic (#8220) by @IWANABETHATGUY
- stabilize `parse` and `parseSync` (#8215) by @sapphi-red
- return errors instead of panicking on builtin plugin conversion failure (#8217) by @shulaoda
- expose `parse` / `minify` / `transform` from `rolldown/utils` (#8214) by @sapphi-red
- prepare defer chunk merging (#8153) by @IWANABETHATGUY

### 📚 Documentation

- remove `<script>` escape behavior difference note from `platform` option (#8253) by @sapphi-red
- TypeScript & JSX support by plugins (#8183) by @sapphi-red

### 🧪 Testing

- ensure runtime module is preserved even if it's not used but has side effects (#8213) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: update oxc to v0.113.0 (#8267) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.0 (#8272) by @renovate[bot]
- deps: update oxc apps (#8269) by @renovate[bot]
- deps: update test262 submodule for tests (#8261) by @sapphi-red
- deps: update crate-ci/typos action to v1.43.4 (#8260) by @renovate[bot]
- deps: update dependency esbuild to v0.27.3 (#8250) by @renovate[bot]
- deps: update rust crates (#8244) by @renovate[bot]
- deps: update dependency semver to v7.7.4 (#8247) by @renovate[bot]
- deps: update github-actions (#8243) by @renovate[bot]
- deps: update npm packages (#8245) by @renovate[bot]
- deps: update oxc resolver to v11.17.1 (#8240) by @renovate[bot]
- deps: update rust crate oxc_sourcemap to v6.0.2 (#8241) by @renovate[bot]
- rust: handle ignored `RUSTSEC-2025-0141` cargo check error (#8235) by @hyf0
- deps: update dependency oxlint-tsgolint to v0.11.5 (#8233) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to ^0.22.0 (#8232) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.3 (#8225) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.9 (#8224) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.2 (#8212) by @renovate[bot]
- remove rolldown_plugin_vite_wasm_helper (#8207) by @shulaoda
- build docs for production (#8206) by @sapphi-red

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants