fix(rust): detect runtime module side effects based on its content by hyf0 · Pull Request #8209 · rolldown/rolldown

hyf0 · 2026-02-05T18:39:41Z

No description provided.

hyf0 · 2026-02-05T18:40:02Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-02-05T18:41:51Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`9c1ddd7`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6985846971986d0008d6acb9
😎 Deploy Preview	https://deploy-preview-8209--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-02-06T04:23:40Z

Benchmarks Rust

target: main(3c8ecb4)
pr: 02-06-refactor_rust_detect_runtime_module_side_effects_based_on_its_content(9c1ddd7)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     68.0±1.82ms        ? ?/sec    1.00     66.5±1.55ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     74.3±1.76ms        ? ?/sec    1.00     72.4±2.13ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01     99.5±1.54ms        ? ?/sec    1.00     98.5±1.72ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    111.7±3.21ms        ? ?/sec    1.00    109.8±1.55ms        ? ?/sec
bundle/bundle@threejs                                        1.00     35.1±1.18ms        ? ?/sec    1.01     35.6±1.92ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     39.8±0.75ms        ? ?/sec    1.00     39.5±0.53ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    365.5±4.25ms        ? ?/sec    1.00    361.3±4.89ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    421.2±5.41ms        ? ?/sec    1.00    417.7±3.58ms        ? ?/sec
scan/scan@rome_ts                                            1.00     80.2±2.17ms        ? ?/sec    1.01     81.2±1.71ms        ? ?/sec
scan/scan@threejs                                            1.01     28.0±1.77ms        ? ?/sec    1.00     27.7±0.44ms        ? ?/sec
scan/scan@threejs10x                                         1.00    284.4±3.94ms        ? ?/sec    1.00    284.0±4.21ms        ? ?/sec

crates/rolldown/src/ast_scanner/side_effect_detector/mod.rs

graphite-app · 2026-02-06T06:04:02Z

Merge activity

Feb 6, 6:04 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Feb 6, 6:14 AM UTC: Merged by the Graphite merge queue.

…8209)

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sapphi-red

## [1.0.0-rc.4] - 2026-02-11 💡 Granular `comments` Option - New `output.comments` option provides fine-grained control over comment preservation - The `output.legalComments` option is now deprecated and use `comments.legal` instead ### 🚀 Features - rename error name to `RolldownError` from `RollupError` (#8262) by @sapphi-red - add hidden `resolve_tsconfig` function for Vite (#8257) by @sapphi-red - rust: introduce `rolldown_watcher` (#8161) by @hyf0 - unify `comments` and `legalComments` into a single granular `comments` option (#8229) by @IWANABETHATGUY - add builtin plugin for visualizing chunk graph (#8162) by @IWANABETHATGUY - show import declaration location in AssignToImport errors (#8222) by @Copilot - show import declaration span in CannotCallNamespace error (#8223) by @Copilot - emit error when plugin accidentally removes runtime module symbols (#8203) by @IWANABETHATGUY - support tsconfig loading & inputMap for `transform` (#8180) by @sapphi-red - rolldown_plugin_vite_reporter: update warning message to link to Rolldown docs (#8205) by @sapphi-red ### 🐛 Bug Fixes - avoid panic on untranspiled JSX syntax by reporting a diagnostic error (#8226) by @IWANABETHATGUY - rolldown_plugin_vite_import_glob: relax absolute path check and improve invalid glob warning (#8219) by @shulaoda - merge chunks after detect circular reference (#8154) by @IWANABETHATGUY - rust: detect runtime module side effects based on its content (#8209) by @hyf0 ### 🚜 Refactor - rename `other` to `jsdoc` in comments options (#8256) by @IWANABETHATGUY - rename chunk-visualize plugin with bundle-analyzer plugin (#8255) by @IWANABETHATGUY - remove EXPORT_UNDEFINED_VARIABLE error (#8228) by @Copilot - consolidate missing runtime symbol errors into a single diagnostic (#8220) by @IWANABETHATGUY - stabilize `parse` and `parseSync` (#8215) by @sapphi-red - return errors instead of panicking on builtin plugin conversion failure (#8217) by @shulaoda - expose `parse` / `minify` / `transform` from `rolldown/utils` (#8214) by @sapphi-red - prepare defer chunk merging (#8153) by @IWANABETHATGUY ### 📚 Documentation - remove `<script>` escape behavior difference note from `platform` option (#8253) by @sapphi-red - TypeScript & JSX support by plugins (#8183) by @sapphi-red ### 🧪 Testing - ensure runtime module is preserved even if it's not used but has side effects (#8213) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: update oxc to v0.113.0 (#8267) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.12.0 (#8272) by @renovate[bot] - deps: update oxc apps (#8269) by @renovate[bot] - deps: update test262 submodule for tests (#8261) by @sapphi-red - deps: update crate-ci/typos action to v1.43.4 (#8260) by @renovate[bot] - deps: update dependency esbuild to v0.27.3 (#8250) by @renovate[bot] - deps: update rust crates (#8244) by @renovate[bot] - deps: update dependency semver to v7.7.4 (#8247) by @renovate[bot] - deps: update github-actions (#8243) by @renovate[bot] - deps: update npm packages (#8245) by @renovate[bot] - deps: update oxc resolver to v11.17.1 (#8240) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v6.0.2 (#8241) by @renovate[bot] - rust: handle ignored `RUSTSEC-2025-0141` cargo check error (#8235) by @hyf0 - deps: update dependency oxlint-tsgolint to v0.11.5 (#8233) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.22.0 (#8232) by @renovate[bot] - deps: update crate-ci/typos action to v1.43.3 (#8225) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.21.9 (#8224) by @renovate[bot] - deps: update crate-ci/typos action to v1.43.2 (#8212) by @renovate[bot] - remove rolldown_plugin_vite_wasm_helper (#8207) by @shulaoda - build docs for production (#8206) by @sapphi-red Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned hyf0 Feb 5, 2026

hyf0 mentioned this pull request Feb 6, 2026

test: ensure runtime module is preserved even if it's not used but has side effects #8213

Merged

hyf0 marked this pull request as ready for review February 6, 2026 04:08

hyf0 requested review from IWANABETHATGUY and Copilot and removed request for Copilot February 6, 2026 04:08

Copilot started reviewing on behalf of hyf0 February 6, 2026 04:08 View session

hyf0 assigned IWANABETHATGUY and unassigned hyf0 and IWANABETHATGUY Feb 6, 2026

IWANABETHATGUY reviewed Feb 6, 2026

View reviewed changes

crates/rolldown/src/ast_scanner/side_effect_detector/mod.rs Show resolved Hide resolved

IWANABETHATGUY approved these changes Feb 6, 2026

View reviewed changes

hyf0 changed the title ~~refactor(rust): detect runtime module side effects based on its content~~ fix(rust): detect runtime module side effects based on its content Feb 6, 2026

fix(rust): detect runtime module side effects based on its content (#…

9c1ddd7

…8209)

Copilot AI review requested due to automatic review settings February 6, 2026 06:04

graphite-app bot force-pushed the 02-06-refactor_rust_detect_runtime_module_side_effects_based_on_its_content branch from b4a426f to 9c1ddd7 Compare February 6, 2026 06:04

Copilot AI reviewed Feb 6, 2026

View reviewed changes

graphite-app bot merged commit 9c1ddd7 into main Feb 6, 2026
35 checks passed

graphite-app bot deleted the 02-06-refactor_rust_detect_runtime_module_side_effects_based_on_its_content branch February 6, 2026 06:14

This was referenced Feb 11, 2026

release: v1.0.0-rc.4 #8271

Closed

release: v1.0.0-rc.4 #8278

Merged

IWANABETHATGUY mentioned this pull request Feb 12, 2026

[rc.4 regression] node:module is added as side-effect to dist #8299

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix(rust): detect runtime module side effects based on its content#8209

fix(rust): detect runtime module side effects based on its content#8209
graphite-app[bot] merged 1 commit intomainfrom
02-06-refactor_rust_detect_runtime_module_side_effects_based_on_its_content

hyf0 commented Feb 5, 2026

Uh oh!

hyf0 commented Feb 5, 2026 •

edited

Loading

Uh oh!

netlify bot commented Feb 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

graphite-app bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

hyf0 commented Feb 5, 2026

Uh oh!

hyf0 commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

graphite-app bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hyf0 commented Feb 5, 2026 •

edited

Loading

netlify bot commented Feb 5, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

graphite-app bot commented Feb 6, 2026 •

edited

Loading