refactor: prepare defer chunk merging by IWANABETHATGUY · Pull Request #8153 · rolldown/rolldown

IWANABETHATGUY · 2026-02-01T12:53:03Z

Perform circular checking before chunk merging. We store the Tempchunk and its modules to calculate the chunk dependency.

IWANABETHATGUY · 2026-02-01T12:53:19Z

fix: merge chunks after detect circular reference #8154
refactor: prepare defer chunk merging #8153 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-02-01T12:54:10Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`78962f4`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69838df3aafc77000832e2e8
😎 Deploy Preview	https://deploy-preview-8153--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Refactors the chunk-optimization pipeline to replace PendingCommonChunkInfo with a new TempChunkGraph, as a preparation step for deferred chunk merging.

Changes:

Removes PendingCommonChunk* types from code_splitting.rs and routes shared-module tracking through TempChunkGraph.
Introduces TempChunkGraph / TempChunk in chunk_optimizer.rs and updates optimization logic to consume the new structure.
Adjusts common-chunk creation/merge helpers to accept borrowed module lists (&[ModuleIdx]) and borrowed BitSets.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
crates/rolldown/src/stages/generate_stage/code_splitting.rs	Builds and populates `TempChunkGraph` during split-chunk assignment, and passes it into the optimizer.
crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs	Adds `TempChunkGraph` and rewires common-chunk insertion/creation to use it instead of `PendingCommonChunkInfo`.

crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs

github-actions · 2026-02-04T11:26:03Z

Benchmarks Rust

target: main(62d58be)
pr: 02-01-refactor_prepare_defer_chunk_merging(78962f4)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     71.3±2.30ms        ? ?/sec    1.02     72.8±2.42ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     78.6±2.29ms        ? ?/sec    1.01     79.2±2.87ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    102.4±3.61ms        ? ?/sec    1.00    101.0±1.79ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    113.5±2.37ms        ? ?/sec    1.00    113.4±2.09ms        ? ?/sec
bundle/bundle@threejs                                        1.00     37.0±2.07ms        ? ?/sec    1.01     37.3±2.46ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     41.2±0.77ms        ? ?/sec    1.01     41.7±0.99ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    372.4±7.05ms        ? ?/sec    1.00    371.1±6.44ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    429.0±5.59ms        ? ?/sec    1.01    435.4±6.03ms        ? ?/sec
scan/scan@rome_ts                                            1.00     80.9±1.75ms        ? ?/sec    1.01     81.3±1.85ms        ? ?/sec
scan/scan@threejs                                            1.00     28.8±1.89ms        ? ?/sec    1.01     29.0±2.01ms        ? ?/sec
scan/scan@threejs10x                                         1.01    291.8±5.05ms        ? ?/sec    1.00    287.9±4.37ms        ? ?/sec

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs

graphite-app · 2026-02-04T18:19:57Z

Merge activity

Feb 4, 6:19 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Feb 4, 6:30 PM UTC: Merged by the Graphite merge queue.

Perform circular checking before chunk merging. We store the Tempchunk and its modules to calculate the chunk dependency.

@sapphi-red

## [1.0.0-rc.4] - 2026-02-11 💡 Granular `comments` Option - New `output.comments` option provides fine-grained control over comment preservation - The `output.legalComments` option is now deprecated and use `comments.legal` instead ### 🚀 Features - rename error name to `RolldownError` from `RollupError` (#8262) by @sapphi-red - add hidden `resolve_tsconfig` function for Vite (#8257) by @sapphi-red - rust: introduce `rolldown_watcher` (#8161) by @hyf0 - unify `comments` and `legalComments` into a single granular `comments` option (#8229) by @IWANABETHATGUY - add builtin plugin for visualizing chunk graph (#8162) by @IWANABETHATGUY - show import declaration location in AssignToImport errors (#8222) by @Copilot - show import declaration span in CannotCallNamespace error (#8223) by @Copilot - emit error when plugin accidentally removes runtime module symbols (#8203) by @IWANABETHATGUY - support tsconfig loading & inputMap for `transform` (#8180) by @sapphi-red - rolldown_plugin_vite_reporter: update warning message to link to Rolldown docs (#8205) by @sapphi-red ### 🐛 Bug Fixes - avoid panic on untranspiled JSX syntax by reporting a diagnostic error (#8226) by @IWANABETHATGUY - rolldown_plugin_vite_import_glob: relax absolute path check and improve invalid glob warning (#8219) by @shulaoda - merge chunks after detect circular reference (#8154) by @IWANABETHATGUY - rust: detect runtime module side effects based on its content (#8209) by @hyf0 ### 🚜 Refactor - rename `other` to `jsdoc` in comments options (#8256) by @IWANABETHATGUY - rename chunk-visualize plugin with bundle-analyzer plugin (#8255) by @IWANABETHATGUY - remove EXPORT_UNDEFINED_VARIABLE error (#8228) by @Copilot - consolidate missing runtime symbol errors into a single diagnostic (#8220) by @IWANABETHATGUY - stabilize `parse` and `parseSync` (#8215) by @sapphi-red - return errors instead of panicking on builtin plugin conversion failure (#8217) by @shulaoda - expose `parse` / `minify` / `transform` from `rolldown/utils` (#8214) by @sapphi-red - prepare defer chunk merging (#8153) by @IWANABETHATGUY ### 📚 Documentation - remove `<script>` escape behavior difference note from `platform` option (#8253) by @sapphi-red - TypeScript & JSX support by plugins (#8183) by @sapphi-red ### 🧪 Testing - ensure runtime module is preserved even if it's not used but has side effects (#8213) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: update oxc to v0.113.0 (#8267) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.12.0 (#8272) by @renovate[bot] - deps: update oxc apps (#8269) by @renovate[bot] - deps: update test262 submodule for tests (#8261) by @sapphi-red - deps: update crate-ci/typos action to v1.43.4 (#8260) by @renovate[bot] - deps: update dependency esbuild to v0.27.3 (#8250) by @renovate[bot] - deps: update rust crates (#8244) by @renovate[bot] - deps: update dependency semver to v7.7.4 (#8247) by @renovate[bot] - deps: update github-actions (#8243) by @renovate[bot] - deps: update npm packages (#8245) by @renovate[bot] - deps: update oxc resolver to v11.17.1 (#8240) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v6.0.2 (#8241) by @renovate[bot] - rust: handle ignored `RUSTSEC-2025-0141` cargo check error (#8235) by @hyf0 - deps: update dependency oxlint-tsgolint to v0.11.5 (#8233) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.22.0 (#8232) by @renovate[bot] - deps: update crate-ci/typos action to v1.43.3 (#8225) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.21.9 (#8224) by @renovate[bot] - deps: update crate-ci/typos action to v1.43.2 (#8212) by @renovate[bot] - remove rolldown_plugin_vite_wasm_helper (#8207) by @shulaoda - build docs for production (#8206) by @sapphi-red Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Feb 1, 2026

IWANABETHATGUY mentioned this pull request Feb 1, 2026

fix: merge chunks after detect circular reference #8154

Merged

IWANABETHATGUY force-pushed the 02-01-refactor_prepare_defer_chunk_merging branch 3 times, most recently from a1f3d60 to 66ebb55 Compare February 4, 2026 11:10

IWANABETHATGUY marked this pull request as ready for review February 4, 2026 11:10

Copilot AI review requested due to automatic review settings February 4, 2026 11:10

Copilot started reviewing on behalf of IWANABETHATGUY February 4, 2026 11:11 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs Show resolved Hide resolved

crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs Show resolved Hide resolved

IWANABETHATGUY requested review from hyf0 and shulaoda February 4, 2026 11:23

IWANABETHATGUY force-pushed the 02-01-refactor_prepare_defer_chunk_merging branch from 66ebb55 to 70b5065 Compare February 4, 2026 13:25

Copilot AI review requested due to automatic review settings February 4, 2026 13:26

Copilot AI reviewed Feb 4, 2026

View reviewed changes

IWANABETHATGUY force-pushed the 02-01-refactor_prepare_defer_chunk_merging branch from a7b1001 to 70b5065 Compare February 4, 2026 13:39

Copilot AI review requested due to automatic review settings February 4, 2026 13:40

Copilot AI reviewed Feb 4, 2026

View reviewed changes

hyf0 reviewed Feb 4, 2026

View reviewed changes

crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs Show resolved Hide resolved

hyf0 approved these changes Feb 4, 2026

View reviewed changes

refactor: prepare defer chunk merging (#8153)

78962f4

Perform circular checking before chunk merging. We store the Tempchunk and its modules to calculate the chunk dependency.

graphite-app bot force-pushed the 02-01-refactor_prepare_defer_chunk_merging branch from 817c4bb to 78962f4 Compare February 4, 2026 18:20

graphite-app bot merged commit 78962f4 into main Feb 4, 2026
35 checks passed

graphite-app bot deleted the 02-01-refactor_prepare_defer_chunk_merging branch February 4, 2026 18:30

This was referenced Feb 11, 2026

release: v1.0.0-rc.4 #8271

Closed

release: v1.0.0-rc.4 #8278

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: prepare defer chunk merging#8153

refactor: prepare defer chunk merging#8153
graphite-app[bot] merged 1 commit intomainfrom
02-01-refactor_prepare_defer_chunk_merging

IWANABETHATGUY commented Feb 1, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Feb 1, 2026 •

edited

Loading

Uh oh!

netlify bot commented Feb 1, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

graphite-app bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Feb 1, 2026 •

edited

Loading

IWANABETHATGUY commented Feb 1, 2026 •

edited

Loading

netlify bot commented Feb 1, 2026 •

edited

Loading

github-actions bot commented Feb 4, 2026 •

edited

Loading

graphite-app bot commented Feb 4, 2026 •

edited

Loading