Skip to content

Comments

fix(rust/dev): only close after the ongoing task finished#8147

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-01-fix_rust_dev_only_close_after_the_ongoing_task_finished
Feb 2, 2026
Merged

fix(rust/dev): only close after the ongoing task finished#8147
graphite-app[bot] merged 1 commit intomainfrom
02-01-fix_rust_dev_only_close_after_the_ongoing_task_finished

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jan 31, 2026

Copy link
Member Author

hyf0 commented Jan 31, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jan 31, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 94c0c0a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/698025ede71e44000813e117

@hyf0 hyf0 marked this pull request as ready for review January 31, 2026 21:27
Copilot AI review requested due to automatic review settings January 31, 2026 21:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a race condition where the bundle coordinator's message loop exits before an ongoing bundling task completes, causing the task to panic when attempting to send a BundleCompleted message to the closed coordinator channel.

Changes:

  • Added graceful shutdown logic to wait for any running bundling task before the coordinator exits

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

Benchmarks Rust

  • target: main(5ec1306)
  • pr: 02-01-fix_rust_dev_only_close_after_the_ongoing_task_finished(703d371)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.7±1.96ms        ? ?/sec    1.00     67.7±1.63ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     75.9±3.08ms        ? ?/sec    1.00     75.2±2.22ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    103.1±3.44ms        ? ?/sec    1.00    101.0±1.91ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    112.7±2.06ms        ? ?/sec    1.00    113.0±2.42ms        ? ?/sec
bundle/bundle@threejs                                        1.04     37.4±2.29ms        ? ?/sec    1.00     35.8±0.90ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     42.0±1.39ms        ? ?/sec    1.00     41.2±0.72ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    363.5±4.21ms        ? ?/sec    1.02    369.4±7.06ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    422.6±5.76ms        ? ?/sec    1.00    423.5±4.80ms        ? ?/sec
scan/scan@rome_ts                                            1.00     79.4±1.56ms        ? ?/sec    1.01     80.1±1.81ms        ? ?/sec
scan/scan@threejs                                            1.00     28.0±1.66ms        ? ?/sec    1.00     27.9±1.65ms        ? ?/sec
scan/scan@threejs10x                                         1.00    281.6±5.08ms        ? ?/sec    1.01    284.2±4.08ms        ? ?/sec

@hyf0 hyf0 changed the base branch from main to graphite-base/8147 February 1, 2026 05:32
@hyf0 hyf0 force-pushed the 02-01-fix_rust_dev_only_close_after_the_ongoing_task_finished branch from 2616f23 to f346b5d Compare February 1, 2026 05:32
@hyf0 hyf0 changed the base branch from graphite-base/8147 to 02-01-test_rust_fix_flakiness_of_rust_tests February 1, 2026 05:32
@hyf0 hyf0 requested a review from sapphi-red February 1, 2026 05:33
@hyf0 hyf0 force-pushed the 02-01-test_rust_fix_flakiness_of_rust_tests branch from 9a279da to 31f3822 Compare February 1, 2026 07:38
@graphite-app graphite-app bot changed the base branch from 02-01-test_rust_fix_flakiness_of_rust_tests to graphite-base/8147 February 1, 2026 07:48
@graphite-app graphite-app bot force-pushed the graphite-base/8147 branch from 9a279da to 5ec1306 Compare February 1, 2026 08:00
@graphite-app graphite-app bot force-pushed the 02-01-fix_rust_dev_only_close_after_the_ongoing_task_finished branch from f346b5d to 9b540d0 Compare February 1, 2026 08:00
@graphite-app graphite-app bot changed the base branch from graphite-base/8147 to main February 1, 2026 08:00
@graphite-app graphite-app bot force-pushed the 02-01-fix_rust_dev_only_close_after_the_ongoing_task_finished branch from 9b540d0 to 703d371 Compare February 1, 2026 08:01
Copy link
Member Author

hyf0 commented Feb 2, 2026

Merge activity

Copilot AI review requested due to automatic review settings February 2, 2026 04:19
@graphite-app graphite-app bot force-pushed the 02-01-fix_rust_dev_only_close_after_the_ongoing_task_finished branch from 703d371 to 94c0c0a Compare February 2, 2026 04:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 94c0c0a into main Feb 2, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 02-01-fix_rust_dev_only_close_after_the_ongoing_task_finished branch February 2, 2026 04:30
@github-actions github-actions bot mentioned this pull request Feb 4, 2026
@github-actions github-actions bot mentioned this pull request Feb 4, 2026
shulaoda added a commit that referenced this pull request Feb 4, 2026
## [1.0.0-rc.3] - 2026-02-04

⚡ Remove Unnecessary Default Export Assignment

- Eliminates redundant variable assignments when exporting default values
- Reduces output bundle size and improves code clarity
```js
// index.js
var x = 42;
export default x;

// Before
var x = 42;
var entry_default = x;
export { entry_default as default };

// After
var x = 42;
export { x as default };
```

🐛 Avoid Unnecessary Facade Chunks

- Keep user-defined entry modules in their own chunks
- Reduces HTTP round trips and improves startup performance

```js
// main.js (entry module)
import { a } from './lib.js'
console.log(a)

// lib.js
export * from './counter.js'

// counter.js (entry module)
export const a = 100

// Before
dist/
├── main.js           → import { a } from './counter-chunk.js'; console.log(a)
├── counter.js        → export { a } from './counter-chunk.js' // ❌ facade chunk
└── counter-chunk.js  → export const a = 100

// After
dist/
├── main.js    → import { a } from './counter.js'; console.log(a)
└── counter.js → export const a = 100
```

### 🚀 Features

- expose `RUNTIME_MODULE_ID` constant for plugin authors (#8199) by @shulaoda
- warn unsupported combination of `preserveValueImports` and `importsNotUsedAsValues` in tsconfig.json (#8169) by @sapphi-red
- sophisticated watch tracking for load dependencies (#8092) by @sapphi-red
- add `inputMap` option to `minify` / `minifySync` functions (#8138) by @sapphi-red
- consolidate same tsconfig errors (#8119) by @sapphi-red
- include tsconfig file path in error messages (#8107) by @Copilot
- lazy-barrel: support incremental build mode (#8114) by @shulaoda

### 🐛 Bug Fixes

- rust: preserve dependencies added by `this.addWatchFile` (#8198) by @hyf0
- spawn `RuntimeModuleTask` after `build_start` to avoid race condition (#8182) by @shulaoda
- rust/dev: only close after the ongoing task finished (#8147) by @hyf0
- ensure `\0rolldown/runtime.js` will go through transform hook and add test (#8093) by @hyf0
- `[name]` in `assetFileNames` does not include the directory part (#8098) by @IWANABETHATGUY
- handle external module properties in namespace imports (#8124) by @IWANABETHATGUY
- keep user-defined entry modules in their own chunks (#8047) by @IWANABETHATGUY
- avoid `Unknown resolve error` error message (#8111) by @sapphi-red

### 💼 Other

- remove warnings  for building rolldown with `not(feature = "experimental")` (#8110) by @coolreader18

### 🚜 Refactor

- move `VERSION` to `constants` directory (#8200) by @shulaoda
- simplify import symbol check using `SymbolFlags` (#8193) by @shulaoda
- extract tsconfig option and transform options merging logic (#8168) by @sapphi-red
- filter empty module_groups before sorting (#8149) by @ShroXd
- lazy-barrel: use single `remove` instead of `contains_key` + `remove` (#8123) by @shulaoda
- lazy-barrel: avoid redundant call and inline `get_barrel_normal_module` (#8122) by @shulaoda
- use logger instead of console.log for warnings (#8117) by @IWANABETHATGUY
- module-loader: remove intermediate ModuleTaskOwnerRef type (#8113) by @shulaoda
- rename ReExportExternalModule to ReExportDynamicExports (#8104) by @IWANABETHATGUY

### 📚 Documentation

- add dynamic OG image generation (#8192) by @sapphi-red
- add dynamic OG image generation (#8191) by @sapphi-red
- add dynamic OG image generation (#8179) by @Copilot
- apis: add links to option descriptions in JSDoc comments (#8167) by @sapphi-red
- apis: clarify parameters of `resolveDynamicImport` hook (#8137) by @sapphi-red
- lazy-barrel: clarify default export behavior (#8128) by @shulaoda

### ⚡ Performance

- remove unnecessary assignment for default export (#8127) by @shulaoda

### 🧪 Testing

- dev: `this.addWatchFile` dependency should be preserved after reload (#8165) by @sapphi-red
- mark flaky `transform_runtime_module` test as ignored (#8178) by @Copilot
- rolldown_sourcemap: add test for coarse segments (#8166) by @sapphi-red
- dev: correctly assert file change (#8164) by @sapphi-red
- rust: `transform_runtime_module` test shouldn't panic inside (#8151) by @hyf0
- rust: fix flakiness of rust tests (#8150) by @hyf0
- mark `output.dynamicImportInCjs` tests as passed (#8125) by @shulaoda
- lazy-barrel: add test cases for default export (#8129) by @shulaoda
- rolldown_plugin_vite_manifest: use relative path for outPath (#8101) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.43.1 (#8188) by @renovate[bot]
- deps: update rust crate ts-rs to v12 (#8160) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.0 (#8175) by @renovate[bot]
- deps: update rust crates (#8157) by @renovate[bot]
- deps: update oxc to v0.112.0 (#8171) by @renovate[bot]
- deps: update rollup submodule for tests to v4.57.1 (#8176) by @sapphi-red
- deps: update test262 submodule for tests (#8177) by @sapphi-red
- deps: update dependency oxlint to v1.43.0 (#8173) by @renovate[bot]
- deps: update dependency oxfmt to ^0.28.0 (#8170) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.8 (#8163) by @renovate[bot]
- deps: update dependency vue-router to v5 (#8159) by @renovate[bot]
- deps: update github-actions (#8158) by @renovate[bot]
- deps: update npm packages (#8156) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.4 (#8140) by @renovate[bot]
- fix clippy replacement typo (#8136) by @IWANABETHATGUY
- disallow `HashMap::new` and `HashSet::new` by clippy (#8135) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.21.7 (#8126) by @renovate[bot]
- deps: update oxc resolver to v11.17.0 (#8121) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.3 (#8109) by @renovate[bot]

### ❤️ New Contributors

* @coolreader18 made their first contribution in [#8110](#8110)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants