Skip to content

Comments

feat: add inputMap option to minify / minifySync functions#8138

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-30-feat_add_inputmap_option_to_minify___minifysync_functions
Jan 30, 2026
Merged

feat: add inputMap option to minify / minifySync functions#8138
graphite-app[bot] merged 1 commit intomainfrom
01-30-feat_add_inputmap_option_to_minify___minifysync_functions

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 30, 2026

Add inputMap option to minify / minifySync functions so that it is easier to migrate from transformWithEsbuild function.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jan 30, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 64776af
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/697c9ada2eefd4000878423f

@sapphi-red sapphi-red marked this pull request as ready for review January 30, 2026 11:35
Copilot AI review requested due to automatic review settings January 30, 2026 11:35
@sapphi-red sapphi-red requested a review from shulaoda January 30, 2026 11:36
Copy link
Member Author

sapphi-red commented Jan 30, 2026

Merge activity

  • Jan 30, 11:36 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 30, 11:48 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Jan 30, 12:03 PM UTC: Merged by the Graphite merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an inputMap option to the minify and minifySync functions in rolldown's experimental API, making it easier to chain source transformations when migrating from Vite's transformWithEsbuild function. The feature enables users to pass an input sourcemap that will be properly collapsed with the minification output sourcemap, preserving the full transformation chain.

Changes:

  • Added inputMap option to minify functions that accepts a sourcemap from a previous transformation step
  • Implemented sourcemap collapsing through a new Rust binding function collapseSourcemaps
  • Refactored sourcemap type conversions in Rust to support the new functionality

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/rolldown/src/utils/minify.ts New wrapper implementation that adds inputMap option and handles sourcemap collapsing
packages/rolldown/tests/utils/minify.test.ts Comprehensive test coverage for the new inputMap functionality
packages/rolldown/src/experimental-index.ts Updated exports to use the new minify wrappers instead of direct binding exports
crates/rolldown_binding/src/utils/collapse_sourcemaps.rs New Rust utility function to collapse sourcemap chains
crates/rolldown_binding/src/types/binding_sourcemap.rs Refactored From trait implementations for better code organization
packages/rolldown/src/binding.d.cts Added type definition for collapseSourcemaps function
packages/rolldown/src/binding.cjs Exported collapseSourcemaps from native binding
packages/rolldown/src/rolldown-binding.wasi.cjs Exported collapseSourcemaps for WASI builds
packages/rolldown/src/rolldown-binding.wasi-browser.js Exported collapseSourcemaps for browser WASI builds
crates/rolldown_binding/src/utils/mod.rs Added collapse_sourcemaps module declaration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(08900d3)
  • pr: 01-30-feat_add_inputmap_option_to_minify___minifysync_functions(b9c70ca)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     71.2±2.40ms        ? ?/sec    1.00     71.4±2.27ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     75.7±1.75ms        ? ?/sec    1.04     78.9±2.88ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    103.9±2.27ms        ? ?/sec    1.00    103.8±3.02ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    115.9±2.11ms        ? ?/sec    1.00    115.2±1.84ms        ? ?/sec
bundle/bundle@threejs                                        1.05     38.1±2.58ms        ? ?/sec    1.00     36.3±0.91ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     41.4±1.60ms        ? ?/sec    1.00     40.7±0.74ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    371.6±4.37ms        ? ?/sec    1.01    374.3±5.33ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    423.5±4.60ms        ? ?/sec    1.01    426.4±4.20ms        ? ?/sec
scan/scan@rome_ts                                            1.00     80.0±1.81ms        ? ?/sec    1.00     80.0±1.50ms        ? ?/sec
scan/scan@threejs                                            1.01     27.9±1.65ms        ? ?/sec    1.00     27.5±0.40ms        ? ?/sec
scan/scan@threejs10x                                         1.00    283.5±5.41ms        ? ?/sec    1.01    286.3±6.75ms        ? ?/sec

@graphite-app graphite-app bot force-pushed the 01-30-feat_add_inputmap_option_to_minify___minifysync_functions branch from b9c70ca to 64776af Compare January 30, 2026 11:49
@graphite-app graphite-app bot merged commit 64776af into main Jan 30, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 01-30-feat_add_inputmap_option_to_minify___minifysync_functions branch January 30, 2026 12:03
This was referenced Feb 4, 2026
shulaoda added a commit that referenced this pull request Feb 4, 2026
## [1.0.0-rc.3] - 2026-02-04

⚡ Remove Unnecessary Default Export Assignment

- Eliminates redundant variable assignments when exporting default values
- Reduces output bundle size and improves code clarity
```js
// index.js
var x = 42;
export default x;

// Before
var x = 42;
var entry_default = x;
export { entry_default as default };

// After
var x = 42;
export { x as default };
```

🐛 Avoid Unnecessary Facade Chunks

- Keep user-defined entry modules in their own chunks
- Reduces HTTP round trips and improves startup performance

```js
// main.js (entry module)
import { a } from './lib.js'
console.log(a)

// lib.js
export * from './counter.js'

// counter.js (entry module)
export const a = 100

// Before
dist/
├── main.js           → import { a } from './counter-chunk.js'; console.log(a)
├── counter.js        → export { a } from './counter-chunk.js' // ❌ facade chunk
└── counter-chunk.js  → export const a = 100

// After
dist/
├── main.js    → import { a } from './counter.js'; console.log(a)
└── counter.js → export const a = 100
```

### 🚀 Features

- expose `RUNTIME_MODULE_ID` constant for plugin authors (#8199) by @shulaoda
- warn unsupported combination of `preserveValueImports` and `importsNotUsedAsValues` in tsconfig.json (#8169) by @sapphi-red
- sophisticated watch tracking for load dependencies (#8092) by @sapphi-red
- add `inputMap` option to `minify` / `minifySync` functions (#8138) by @sapphi-red
- consolidate same tsconfig errors (#8119) by @sapphi-red
- include tsconfig file path in error messages (#8107) by @Copilot
- lazy-barrel: support incremental build mode (#8114) by @shulaoda

### 🐛 Bug Fixes

- rust: preserve dependencies added by `this.addWatchFile` (#8198) by @hyf0
- spawn `RuntimeModuleTask` after `build_start` to avoid race condition (#8182) by @shulaoda
- rust/dev: only close after the ongoing task finished (#8147) by @hyf0
- ensure `\0rolldown/runtime.js` will go through transform hook and add test (#8093) by @hyf0
- `[name]` in `assetFileNames` does not include the directory part (#8098) by @IWANABETHATGUY
- handle external module properties in namespace imports (#8124) by @IWANABETHATGUY
- keep user-defined entry modules in their own chunks (#8047) by @IWANABETHATGUY
- avoid `Unknown resolve error` error message (#8111) by @sapphi-red

### 💼 Other

- remove warnings  for building rolldown with `not(feature = "experimental")` (#8110) by @coolreader18

### 🚜 Refactor

- move `VERSION` to `constants` directory (#8200) by @shulaoda
- simplify import symbol check using `SymbolFlags` (#8193) by @shulaoda
- extract tsconfig option and transform options merging logic (#8168) by @sapphi-red
- filter empty module_groups before sorting (#8149) by @ShroXd
- lazy-barrel: use single `remove` instead of `contains_key` + `remove` (#8123) by @shulaoda
- lazy-barrel: avoid redundant call and inline `get_barrel_normal_module` (#8122) by @shulaoda
- use logger instead of console.log for warnings (#8117) by @IWANABETHATGUY
- module-loader: remove intermediate ModuleTaskOwnerRef type (#8113) by @shulaoda
- rename ReExportExternalModule to ReExportDynamicExports (#8104) by @IWANABETHATGUY

### 📚 Documentation

- add dynamic OG image generation (#8192) by @sapphi-red
- add dynamic OG image generation (#8191) by @sapphi-red
- add dynamic OG image generation (#8179) by @Copilot
- apis: add links to option descriptions in JSDoc comments (#8167) by @sapphi-red
- apis: clarify parameters of `resolveDynamicImport` hook (#8137) by @sapphi-red
- lazy-barrel: clarify default export behavior (#8128) by @shulaoda

### ⚡ Performance

- remove unnecessary assignment for default export (#8127) by @shulaoda

### 🧪 Testing

- dev: `this.addWatchFile` dependency should be preserved after reload (#8165) by @sapphi-red
- mark flaky `transform_runtime_module` test as ignored (#8178) by @Copilot
- rolldown_sourcemap: add test for coarse segments (#8166) by @sapphi-red
- dev: correctly assert file change (#8164) by @sapphi-red
- rust: `transform_runtime_module` test shouldn't panic inside (#8151) by @hyf0
- rust: fix flakiness of rust tests (#8150) by @hyf0
- mark `output.dynamicImportInCjs` tests as passed (#8125) by @shulaoda
- lazy-barrel: add test cases for default export (#8129) by @shulaoda
- rolldown_plugin_vite_manifest: use relative path for outPath (#8101) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.43.1 (#8188) by @renovate[bot]
- deps: update rust crate ts-rs to v12 (#8160) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.0 (#8175) by @renovate[bot]
- deps: update rust crates (#8157) by @renovate[bot]
- deps: update oxc to v0.112.0 (#8171) by @renovate[bot]
- deps: update rollup submodule for tests to v4.57.1 (#8176) by @sapphi-red
- deps: update test262 submodule for tests (#8177) by @sapphi-red
- deps: update dependency oxlint to v1.43.0 (#8173) by @renovate[bot]
- deps: update dependency oxfmt to ^0.28.0 (#8170) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.8 (#8163) by @renovate[bot]
- deps: update dependency vue-router to v5 (#8159) by @renovate[bot]
- deps: update github-actions (#8158) by @renovate[bot]
- deps: update npm packages (#8156) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.4 (#8140) by @renovate[bot]
- fix clippy replacement typo (#8136) by @IWANABETHATGUY
- disallow `HashMap::new` and `HashSet::new` by clippy (#8135) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.21.7 (#8126) by @renovate[bot]
- deps: update oxc resolver to v11.17.0 (#8121) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.3 (#8109) by @renovate[bot]

### ❤️ New Contributors

* @coolreader18 made their first contribution in [#8110](#8110)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants