Skip to content

Comments

test(lazy-barrel): add test cases for default export#8129

Merged
shulaoda merged 1 commit intomainfrom
01-30-test_lazy-barrel_add_test_cases_for_default_export
Jan 30, 2026
Merged

test(lazy-barrel): add test cases for default export#8129
shulaoda merged 1 commit intomainfrom
01-30-test_lazy-barrel_add_test_cases_for_default_export

Conversation

@shulaoda
Copy link
Member

No description provided.

@shulaoda shulaoda requested a review from sapphi-red January 29, 2026 19:24
@shulaoda shulaoda marked this pull request as ready for review January 29, 2026 19:24
Copy link
Member Author

shulaoda commented Jan 29, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the base branch from 01-30-docs_lazy-barrel_clarify_default_export_behavior to graphite-base/8129 January 29, 2026 19:27
@shulaoda shulaoda force-pushed the 01-30-test_lazy-barrel_add_test_cases_for_default_export branch from 4eb48c1 to 4a2f356 Compare January 29, 2026 19:40
@shulaoda shulaoda changed the base branch from graphite-base/8129 to 01-30-docs_lazy-barrel_clarify_default_export_behavior January 29, 2026 19:40
@shulaoda shulaoda force-pushed the 01-30-test_lazy-barrel_add_test_cases_for_default_export branch from 4a2f356 to 38d7d4a Compare January 29, 2026 19:45
Base automatically changed from 01-30-docs_lazy-barrel_clarify_default_export_behavior to main January 30, 2026 03:04
Copilot AI review requested due to automatic review settings January 30, 2026 03:05
@shulaoda shulaoda force-pushed the 01-30-test_lazy-barrel_add_test_cases_for_default_export branch from 38d7d4a to 8548599 Compare January 30, 2026 03:05
@shulaoda shulaoda merged commit cda51b2 into main Jan 30, 2026
14 of 15 checks passed
@shulaoda shulaoda deleted the 01-30-test_lazy-barrel_add_test_cases_for_default_export branch January 30, 2026 03:05
@netlify
Copy link

netlify bot commented Jan 30, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8548599
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/697c1fe0e7a49500089f5d0b

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive test coverage for default export handling in lazy-barrel tree-shaking scenarios. It distinguishes between two important patterns: own default exports (export default value) and re-exported default values (export { value as default }), which have different tree-shaking implications.

Changes:

  • Added test case for own default export behavior (case-own-export-default)
  • Added test case for re-exported default value behavior (case-reexport-default)
  • Added barrel/other.js to support the re-export test scenario
  • Modified barrel/index.js to add a default export for the own export test scenario

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
case-reexport-default/main.js Entry point that imports default export from barrel/other.js to test re-export behavior
case-reexport-default/_config.ts Test configuration verifying that re-exported default only loads minimal files (4 total)
case-own-export-default/main.js Entry point that imports default export from barrel to test own export behavior
case-own-export-default/_config.ts Test configuration verifying that own default export loads all barrel imports (10 total)
barrel/other.js New barrel file that re-exports gg as default using export { gg as default } pattern
barrel/index.js Modified to add export default gg to test own default export pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

import './f.js';
import { gg } from './g.js';

console.log('./index.js', gg);
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The console.log message should reference './other.js' to correctly identify this file, not './index.js'. This is inconsistent with the actual file name and could be misleading during debugging.

Suggested change
console.log('./index.js', gg);
console.log('./other.js', gg);

Copilot uses AI. Check for mistakes.
This was referenced Feb 4, 2026
shulaoda added a commit that referenced this pull request Feb 4, 2026
## [1.0.0-rc.3] - 2026-02-04

⚡ Remove Unnecessary Default Export Assignment

- Eliminates redundant variable assignments when exporting default values
- Reduces output bundle size and improves code clarity
```js
// index.js
var x = 42;
export default x;

// Before
var x = 42;
var entry_default = x;
export { entry_default as default };

// After
var x = 42;
export { x as default };
```

🐛 Avoid Unnecessary Facade Chunks

- Keep user-defined entry modules in their own chunks
- Reduces HTTP round trips and improves startup performance

```js
// main.js (entry module)
import { a } from './lib.js'
console.log(a)

// lib.js
export * from './counter.js'

// counter.js (entry module)
export const a = 100

// Before
dist/
├── main.js           → import { a } from './counter-chunk.js'; console.log(a)
├── counter.js        → export { a } from './counter-chunk.js' // ❌ facade chunk
└── counter-chunk.js  → export const a = 100

// After
dist/
├── main.js    → import { a } from './counter.js'; console.log(a)
└── counter.js → export const a = 100
```

### 🚀 Features

- expose `RUNTIME_MODULE_ID` constant for plugin authors (#8199) by @shulaoda
- warn unsupported combination of `preserveValueImports` and `importsNotUsedAsValues` in tsconfig.json (#8169) by @sapphi-red
- sophisticated watch tracking for load dependencies (#8092) by @sapphi-red
- add `inputMap` option to `minify` / `minifySync` functions (#8138) by @sapphi-red
- consolidate same tsconfig errors (#8119) by @sapphi-red
- include tsconfig file path in error messages (#8107) by @Copilot
- lazy-barrel: support incremental build mode (#8114) by @shulaoda

### 🐛 Bug Fixes

- rust: preserve dependencies added by `this.addWatchFile` (#8198) by @hyf0
- spawn `RuntimeModuleTask` after `build_start` to avoid race condition (#8182) by @shulaoda
- rust/dev: only close after the ongoing task finished (#8147) by @hyf0
- ensure `\0rolldown/runtime.js` will go through transform hook and add test (#8093) by @hyf0
- `[name]` in `assetFileNames` does not include the directory part (#8098) by @IWANABETHATGUY
- handle external module properties in namespace imports (#8124) by @IWANABETHATGUY
- keep user-defined entry modules in their own chunks (#8047) by @IWANABETHATGUY
- avoid `Unknown resolve error` error message (#8111) by @sapphi-red

### 💼 Other

- remove warnings  for building rolldown with `not(feature = "experimental")` (#8110) by @coolreader18

### 🚜 Refactor

- move `VERSION` to `constants` directory (#8200) by @shulaoda
- simplify import symbol check using `SymbolFlags` (#8193) by @shulaoda
- extract tsconfig option and transform options merging logic (#8168) by @sapphi-red
- filter empty module_groups before sorting (#8149) by @ShroXd
- lazy-barrel: use single `remove` instead of `contains_key` + `remove` (#8123) by @shulaoda
- lazy-barrel: avoid redundant call and inline `get_barrel_normal_module` (#8122) by @shulaoda
- use logger instead of console.log for warnings (#8117) by @IWANABETHATGUY
- module-loader: remove intermediate ModuleTaskOwnerRef type (#8113) by @shulaoda
- rename ReExportExternalModule to ReExportDynamicExports (#8104) by @IWANABETHATGUY

### 📚 Documentation

- add dynamic OG image generation (#8192) by @sapphi-red
- add dynamic OG image generation (#8191) by @sapphi-red
- add dynamic OG image generation (#8179) by @Copilot
- apis: add links to option descriptions in JSDoc comments (#8167) by @sapphi-red
- apis: clarify parameters of `resolveDynamicImport` hook (#8137) by @sapphi-red
- lazy-barrel: clarify default export behavior (#8128) by @shulaoda

### ⚡ Performance

- remove unnecessary assignment for default export (#8127) by @shulaoda

### 🧪 Testing

- dev: `this.addWatchFile` dependency should be preserved after reload (#8165) by @sapphi-red
- mark flaky `transform_runtime_module` test as ignored (#8178) by @Copilot
- rolldown_sourcemap: add test for coarse segments (#8166) by @sapphi-red
- dev: correctly assert file change (#8164) by @sapphi-red
- rust: `transform_runtime_module` test shouldn't panic inside (#8151) by @hyf0
- rust: fix flakiness of rust tests (#8150) by @hyf0
- mark `output.dynamicImportInCjs` tests as passed (#8125) by @shulaoda
- lazy-barrel: add test cases for default export (#8129) by @shulaoda
- rolldown_plugin_vite_manifest: use relative path for outPath (#8101) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.43.1 (#8188) by @renovate[bot]
- deps: update rust crate ts-rs to v12 (#8160) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.0 (#8175) by @renovate[bot]
- deps: update rust crates (#8157) by @renovate[bot]
- deps: update oxc to v0.112.0 (#8171) by @renovate[bot]
- deps: update rollup submodule for tests to v4.57.1 (#8176) by @sapphi-red
- deps: update test262 submodule for tests (#8177) by @sapphi-red
- deps: update dependency oxlint to v1.43.0 (#8173) by @renovate[bot]
- deps: update dependency oxfmt to ^0.28.0 (#8170) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.8 (#8163) by @renovate[bot]
- deps: update dependency vue-router to v5 (#8159) by @renovate[bot]
- deps: update github-actions (#8158) by @renovate[bot]
- deps: update npm packages (#8156) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.4 (#8140) by @renovate[bot]
- fix clippy replacement typo (#8136) by @IWANABETHATGUY
- disallow `HashMap::new` and `HashSet::new` by clippy (#8135) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.21.7 (#8126) by @renovate[bot]
- deps: update oxc resolver to v11.17.0 (#8121) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.3 (#8109) by @renovate[bot]

### ❤️ New Contributors

* @coolreader18 made their first contribution in [#8110](#8110)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants