Skip to content

Comments

feat: consolidate same tsconfig errors#8119

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-29-feat_consolidate_same_tsconfig_errors
Jan 30, 2026
Merged

feat: consolidate same tsconfig errors#8119
graphite-app[bot] merged 1 commit intomainfrom
01-29-feat_consolidate_same_tsconfig_errors

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 29, 2026

Consolidate same tsconfig errors into one error so that the output is cleaner.
I'm not sure if there's a better way to achieve this.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jan 29, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 1576816
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/697c30493ee12d00091e0a96

@sapphi-red sapphi-red marked this pull request as ready for review January 29, 2026 12:17
Copilot AI review requested due to automatic review settings January 29, 2026 12:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates duplicate TSConfig errors into single error messages to produce cleaner output. When multiple files encounter the same TSConfig error (same reason), they are now grouped together and displayed as a single error with all affected file paths listed.

Changes:

  • Changed TsConfigError from storing a single file_path to storing multiple file_paths in a Vec
  • Added consolidate_diagnostics function to merge diagnostics with matching error types and reasons
  • Added AsAny trait and downcast_ref method to enable type inspection of diagnostics

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
crates/rolldown_error/src/lib.rs Exports the new consolidate_diagnostics function
crates/rolldown_error/src/build_diagnostic/mod.rs Implements consolidate_diagnostics function and adds downcast_ref method for diagnostic type inspection
crates/rolldown_error/src/build_diagnostic/events/tsconfig_error.rs Changes file_path field to file_paths Vec and updates message formatting to list all affected files
crates/rolldown_error/src/build_diagnostic/events/mod.rs Adds AsAny trait to enable downcasting of BuildEvent trait objects
crates/rolldown_error/src/build_diagnostic/constructors.rs Updates constructor to initialize file_paths as a Vec with single element
crates/rolldown/tests/rolldown/errors/tsconfig_error/consolidate_same_errors/* Adds test case demonstrating consolidation of duplicate TSConfig errors
crates/rolldown/src/module_loader/module_loader.rs Calls consolidate_diagnostics before returning errors from module loading

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sapphi-red sapphi-red marked this pull request as draft January 29, 2026 12:25
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2026

Benchmarks Rust

  • target: main(489558c)
  • pr: 01-29-feat_consolidate_same_tsconfig_errors(716d283)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     68.2±1.70ms        ? ?/sec    1.00     66.9±2.22ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     76.8±2.57ms        ? ?/sec    1.00     75.6±2.34ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    102.1±2.05ms        ? ?/sec    1.00     99.9±1.60ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    112.1±1.95ms        ? ?/sec    1.00    111.3±3.07ms        ? ?/sec
bundle/bundle@threejs                                        1.06     37.1±2.17ms        ? ?/sec    1.00     35.1±2.07ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.05     41.7±0.68ms        ? ?/sec    1.00     39.7±0.60ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    369.9±5.67ms        ? ?/sec    1.00    367.2±4.43ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    428.4±5.78ms        ? ?/sec    1.00    419.2±4.79ms        ? ?/sec
scan/scan@rome_ts                                            1.00     82.1±2.33ms        ? ?/sec    1.00     82.4±1.78ms        ? ?/sec
scan/scan@threejs                                            1.03     28.8±1.59ms        ? ?/sec    1.00     28.1±1.72ms        ? ?/sec
scan/scan@threejs10x                                         1.00    288.6±4.12ms        ? ?/sec    1.01    290.1±4.24ms        ? ?/sec

@sapphi-red sapphi-red force-pushed the 01-29-feat_consolidate_same_tsconfig_errors branch from f008956 to 716d283 Compare January 29, 2026 12:44
@sapphi-red sapphi-red marked this pull request as ready for review January 29, 2026 13:12
Copilot AI review requested due to automatic review settings January 29, 2026 13:12
@sapphi-red sapphi-red requested a review from hyf0 January 29, 2026 13:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sapphi-red sapphi-red force-pushed the 01-29-feat_consolidate_same_tsconfig_errors branch from 716d283 to ecc4475 Compare January 30, 2026 04:02
Copilot AI review requested due to automatic review settings January 30, 2026 04:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Member Author

sapphi-red commented Jan 30, 2026

Merge activity

  • Jan 30, 4:12 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 30, 4:14 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Jan 30, 4:28 AM UTC: Merged by the Graphite merge queue.

Consolidate same tsconfig errors into one error so that the output is cleaner.
I'm not sure if there's a better way to achieve this.
@graphite-app graphite-app bot force-pushed the 01-29-feat_consolidate_same_tsconfig_errors branch from 0a98e3d to 1576816 Compare January 30, 2026 04:15
@graphite-app graphite-app bot merged commit 1576816 into main Jan 30, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 01-29-feat_consolidate_same_tsconfig_errors branch January 30, 2026 04:28
This was referenced Feb 4, 2026
shulaoda added a commit that referenced this pull request Feb 4, 2026
## [1.0.0-rc.3] - 2026-02-04

⚡ Remove Unnecessary Default Export Assignment

- Eliminates redundant variable assignments when exporting default values
- Reduces output bundle size and improves code clarity
```js
// index.js
var x = 42;
export default x;

// Before
var x = 42;
var entry_default = x;
export { entry_default as default };

// After
var x = 42;
export { x as default };
```

🐛 Avoid Unnecessary Facade Chunks

- Keep user-defined entry modules in their own chunks
- Reduces HTTP round trips and improves startup performance

```js
// main.js (entry module)
import { a } from './lib.js'
console.log(a)

// lib.js
export * from './counter.js'

// counter.js (entry module)
export const a = 100

// Before
dist/
├── main.js           → import { a } from './counter-chunk.js'; console.log(a)
├── counter.js        → export { a } from './counter-chunk.js' // ❌ facade chunk
└── counter-chunk.js  → export const a = 100

// After
dist/
├── main.js    → import { a } from './counter.js'; console.log(a)
└── counter.js → export const a = 100
```

### 🚀 Features

- expose `RUNTIME_MODULE_ID` constant for plugin authors (#8199) by @shulaoda
- warn unsupported combination of `preserveValueImports` and `importsNotUsedAsValues` in tsconfig.json (#8169) by @sapphi-red
- sophisticated watch tracking for load dependencies (#8092) by @sapphi-red
- add `inputMap` option to `minify` / `minifySync` functions (#8138) by @sapphi-red
- consolidate same tsconfig errors (#8119) by @sapphi-red
- include tsconfig file path in error messages (#8107) by @Copilot
- lazy-barrel: support incremental build mode (#8114) by @shulaoda

### 🐛 Bug Fixes

- rust: preserve dependencies added by `this.addWatchFile` (#8198) by @hyf0
- spawn `RuntimeModuleTask` after `build_start` to avoid race condition (#8182) by @shulaoda
- rust/dev: only close after the ongoing task finished (#8147) by @hyf0
- ensure `\0rolldown/runtime.js` will go through transform hook and add test (#8093) by @hyf0
- `[name]` in `assetFileNames` does not include the directory part (#8098) by @IWANABETHATGUY
- handle external module properties in namespace imports (#8124) by @IWANABETHATGUY
- keep user-defined entry modules in their own chunks (#8047) by @IWANABETHATGUY
- avoid `Unknown resolve error` error message (#8111) by @sapphi-red

### 💼 Other

- remove warnings  for building rolldown with `not(feature = "experimental")` (#8110) by @coolreader18

### 🚜 Refactor

- move `VERSION` to `constants` directory (#8200) by @shulaoda
- simplify import symbol check using `SymbolFlags` (#8193) by @shulaoda
- extract tsconfig option and transform options merging logic (#8168) by @sapphi-red
- filter empty module_groups before sorting (#8149) by @ShroXd
- lazy-barrel: use single `remove` instead of `contains_key` + `remove` (#8123) by @shulaoda
- lazy-barrel: avoid redundant call and inline `get_barrel_normal_module` (#8122) by @shulaoda
- use logger instead of console.log for warnings (#8117) by @IWANABETHATGUY
- module-loader: remove intermediate ModuleTaskOwnerRef type (#8113) by @shulaoda
- rename ReExportExternalModule to ReExportDynamicExports (#8104) by @IWANABETHATGUY

### 📚 Documentation

- add dynamic OG image generation (#8192) by @sapphi-red
- add dynamic OG image generation (#8191) by @sapphi-red
- add dynamic OG image generation (#8179) by @Copilot
- apis: add links to option descriptions in JSDoc comments (#8167) by @sapphi-red
- apis: clarify parameters of `resolveDynamicImport` hook (#8137) by @sapphi-red
- lazy-barrel: clarify default export behavior (#8128) by @shulaoda

### ⚡ Performance

- remove unnecessary assignment for default export (#8127) by @shulaoda

### 🧪 Testing

- dev: `this.addWatchFile` dependency should be preserved after reload (#8165) by @sapphi-red
- mark flaky `transform_runtime_module` test as ignored (#8178) by @Copilot
- rolldown_sourcemap: add test for coarse segments (#8166) by @sapphi-red
- dev: correctly assert file change (#8164) by @sapphi-red
- rust: `transform_runtime_module` test shouldn't panic inside (#8151) by @hyf0
- rust: fix flakiness of rust tests (#8150) by @hyf0
- mark `output.dynamicImportInCjs` tests as passed (#8125) by @shulaoda
- lazy-barrel: add test cases for default export (#8129) by @shulaoda
- rolldown_plugin_vite_manifest: use relative path for outPath (#8101) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.43.1 (#8188) by @renovate[bot]
- deps: update rust crate ts-rs to v12 (#8160) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.0 (#8175) by @renovate[bot]
- deps: update rust crates (#8157) by @renovate[bot]
- deps: update oxc to v0.112.0 (#8171) by @renovate[bot]
- deps: update rollup submodule for tests to v4.57.1 (#8176) by @sapphi-red
- deps: update test262 submodule for tests (#8177) by @sapphi-red
- deps: update dependency oxlint to v1.43.0 (#8173) by @renovate[bot]
- deps: update dependency oxfmt to ^0.28.0 (#8170) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.8 (#8163) by @renovate[bot]
- deps: update dependency vue-router to v5 (#8159) by @renovate[bot]
- deps: update github-actions (#8158) by @renovate[bot]
- deps: update npm packages (#8156) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.4 (#8140) by @renovate[bot]
- fix clippy replacement typo (#8136) by @IWANABETHATGUY
- disallow `HashMap::new` and `HashSet::new` by clippy (#8135) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.21.7 (#8126) by @renovate[bot]
- deps: update oxc resolver to v11.17.0 (#8121) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.3 (#8109) by @renovate[bot]

### ❤️ New Contributors

* @coolreader18 made their first contribution in [#8110](#8110)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants