Skip to content

Comments

refactor(module-loader): remove intermediate ModuleTaskOwnerRef type#8113

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-29-refactor_module-loader_remove_intermediate_moduletaskownerref_type
Jan 29, 2026
Merged

refactor(module-loader): remove intermediate ModuleTaskOwnerRef type#8113
graphite-app[bot] merged 1 commit intomainfrom
01-29-refactor_module-loader_remove_intermediate_moduletaskownerref_type

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jan 29, 2026

Since we previously removed the conversion from ArcStr to CompactStr, cloning here (i.e. cloning the ArcStr) is cheap. This also resolves the mutable vs. immutable borrow conflict in the follow-up PR.

Copy link
Member Author

shulaoda commented Jan 29, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jan 29, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 871849e
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/697b0ac7a5fae30008677e62

@shulaoda shulaoda marked this pull request as ready for review January 29, 2026 06:47
Copilot AI review requested due to automatic review settings January 29, 2026 06:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the module loader by removing the intermediate ModuleTaskOwnerRef type, simplifying the codebase by directly using ModuleTaskOwner with a constructor instead of going through a lifetime-parameterized reference type and conversion.

Changes:

  • Removed ModuleTaskOwnerRef<'a> struct and its associated methods
  • Added a new() constructor directly to ModuleTaskOwner that accepts a &NormalModule reference
  • Updated all call sites to use ModuleTaskOwner::new() instead of ModuleTaskOwnerRef::new() followed by .into()
  • Reorganized imports in unloadable_dependency.rs to follow standard Rust conventions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/rolldown/src/module_loader/module_task.rs Removed intermediate ModuleTaskOwnerRef type and simplified to use ModuleTaskOwner::new() constructor directly
crates/rolldown/src/module_loader/module_loader.rs Updated all usage sites to call ModuleTaskOwner::new() and removed conversion via .into()
crates/rolldown_error/src/build_diagnostic/events/unloadable_dependency.rs Reorganized imports to follow standard grouping conventions (external, crate, super)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(1da27e3)
  • pr: 01-29-refactor_module-loader_remove_intermediate_moduletaskownerref_type(b8d91ab)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     75.1±2.07ms        ? ?/sec    1.00     73.1±2.54ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     81.1±2.06ms        ? ?/sec    1.00     79.0±2.33ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    107.4±2.28ms        ? ?/sec    1.00    104.4±2.31ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    117.9±2.18ms        ? ?/sec    1.00    115.8±2.62ms        ? ?/sec
bundle/bundle@threejs                                        1.03     38.2±1.25ms        ? ?/sec    1.00     36.9±0.57ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     43.4±1.95ms        ? ?/sec    1.00     41.8±0.65ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    379.9±5.19ms        ? ?/sec    1.00    374.9±5.56ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    438.8±6.79ms        ? ?/sec    1.00    431.9±4.66ms        ? ?/sec
scan/scan@rome_ts                                            1.00     82.1±1.85ms        ? ?/sec    1.01     83.1±1.73ms        ? ?/sec
scan/scan@threejs                                            1.01     28.8±1.66ms        ? ?/sec    1.00     28.6±0.56ms        ? ?/sec
scan/scan@threejs10x                                         1.02    293.8±4.80ms        ? ?/sec    1.00    289.5±3.43ms        ? ?/sec

Copy link
Member Author

shulaoda commented Jan 29, 2026

Merge activity

  • Jan 29, 7:22 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 29, 7:22 AM UTC: shulaoda added this pull request to the Graphite merge queue.
  • Jan 29, 7:32 AM UTC: Merged by the Graphite merge queue.

…8113)

Since we previously removed the conversion from `ArcStr` to `CompactStr`, cloning here (i.e. cloning the `ArcStr`) is cheap. This also resolves the mutable vs. immutable borrow conflict in the follow-up PR.
@graphite-app graphite-app bot force-pushed the 01-29-refactor_module-loader_remove_intermediate_moduletaskownerref_type branch from b8d91ab to 871849e Compare January 29, 2026 07:22
@graphite-app graphite-app bot merged commit 871849e into main Jan 29, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 01-29-refactor_module-loader_remove_intermediate_moduletaskownerref_type branch January 29, 2026 07:32
This was referenced Feb 4, 2026
shulaoda added a commit that referenced this pull request Feb 4, 2026
## [1.0.0-rc.3] - 2026-02-04

⚡ Remove Unnecessary Default Export Assignment

- Eliminates redundant variable assignments when exporting default values
- Reduces output bundle size and improves code clarity
```js
// index.js
var x = 42;
export default x;

// Before
var x = 42;
var entry_default = x;
export { entry_default as default };

// After
var x = 42;
export { x as default };
```

🐛 Avoid Unnecessary Facade Chunks

- Keep user-defined entry modules in their own chunks
- Reduces HTTP round trips and improves startup performance

```js
// main.js (entry module)
import { a } from './lib.js'
console.log(a)

// lib.js
export * from './counter.js'

// counter.js (entry module)
export const a = 100

// Before
dist/
├── main.js           → import { a } from './counter-chunk.js'; console.log(a)
├── counter.js        → export { a } from './counter-chunk.js' // ❌ facade chunk
└── counter-chunk.js  → export const a = 100

// After
dist/
├── main.js    → import { a } from './counter.js'; console.log(a)
└── counter.js → export const a = 100
```

### 🚀 Features

- expose `RUNTIME_MODULE_ID` constant for plugin authors (#8199) by @shulaoda
- warn unsupported combination of `preserveValueImports` and `importsNotUsedAsValues` in tsconfig.json (#8169) by @sapphi-red
- sophisticated watch tracking for load dependencies (#8092) by @sapphi-red
- add `inputMap` option to `minify` / `minifySync` functions (#8138) by @sapphi-red
- consolidate same tsconfig errors (#8119) by @sapphi-red
- include tsconfig file path in error messages (#8107) by @Copilot
- lazy-barrel: support incremental build mode (#8114) by @shulaoda

### 🐛 Bug Fixes

- rust: preserve dependencies added by `this.addWatchFile` (#8198) by @hyf0
- spawn `RuntimeModuleTask` after `build_start` to avoid race condition (#8182) by @shulaoda
- rust/dev: only close after the ongoing task finished (#8147) by @hyf0
- ensure `\0rolldown/runtime.js` will go through transform hook and add test (#8093) by @hyf0
- `[name]` in `assetFileNames` does not include the directory part (#8098) by @IWANABETHATGUY
- handle external module properties in namespace imports (#8124) by @IWANABETHATGUY
- keep user-defined entry modules in their own chunks (#8047) by @IWANABETHATGUY
- avoid `Unknown resolve error` error message (#8111) by @sapphi-red

### 💼 Other

- remove warnings  for building rolldown with `not(feature = "experimental")` (#8110) by @coolreader18

### 🚜 Refactor

- move `VERSION` to `constants` directory (#8200) by @shulaoda
- simplify import symbol check using `SymbolFlags` (#8193) by @shulaoda
- extract tsconfig option and transform options merging logic (#8168) by @sapphi-red
- filter empty module_groups before sorting (#8149) by @ShroXd
- lazy-barrel: use single `remove` instead of `contains_key` + `remove` (#8123) by @shulaoda
- lazy-barrel: avoid redundant call and inline `get_barrel_normal_module` (#8122) by @shulaoda
- use logger instead of console.log for warnings (#8117) by @IWANABETHATGUY
- module-loader: remove intermediate ModuleTaskOwnerRef type (#8113) by @shulaoda
- rename ReExportExternalModule to ReExportDynamicExports (#8104) by @IWANABETHATGUY

### 📚 Documentation

- add dynamic OG image generation (#8192) by @sapphi-red
- add dynamic OG image generation (#8191) by @sapphi-red
- add dynamic OG image generation (#8179) by @Copilot
- apis: add links to option descriptions in JSDoc comments (#8167) by @sapphi-red
- apis: clarify parameters of `resolveDynamicImport` hook (#8137) by @sapphi-red
- lazy-barrel: clarify default export behavior (#8128) by @shulaoda

### ⚡ Performance

- remove unnecessary assignment for default export (#8127) by @shulaoda

### 🧪 Testing

- dev: `this.addWatchFile` dependency should be preserved after reload (#8165) by @sapphi-red
- mark flaky `transform_runtime_module` test as ignored (#8178) by @Copilot
- rolldown_sourcemap: add test for coarse segments (#8166) by @sapphi-red
- dev: correctly assert file change (#8164) by @sapphi-red
- rust: `transform_runtime_module` test shouldn't panic inside (#8151) by @hyf0
- rust: fix flakiness of rust tests (#8150) by @hyf0
- mark `output.dynamicImportInCjs` tests as passed (#8125) by @shulaoda
- lazy-barrel: add test cases for default export (#8129) by @shulaoda
- rolldown_plugin_vite_manifest: use relative path for outPath (#8101) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.43.1 (#8188) by @renovate[bot]
- deps: update rust crate ts-rs to v12 (#8160) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.0 (#8175) by @renovate[bot]
- deps: update rust crates (#8157) by @renovate[bot]
- deps: update oxc to v0.112.0 (#8171) by @renovate[bot]
- deps: update rollup submodule for tests to v4.57.1 (#8176) by @sapphi-red
- deps: update test262 submodule for tests (#8177) by @sapphi-red
- deps: update dependency oxlint to v1.43.0 (#8173) by @renovate[bot]
- deps: update dependency oxfmt to ^0.28.0 (#8170) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.8 (#8163) by @renovate[bot]
- deps: update dependency vue-router to v5 (#8159) by @renovate[bot]
- deps: update github-actions (#8158) by @renovate[bot]
- deps: update npm packages (#8156) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.4 (#8140) by @renovate[bot]
- fix clippy replacement typo (#8136) by @IWANABETHATGUY
- disallow `HashMap::new` and `HashSet::new` by clippy (#8135) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.21.7 (#8126) by @renovate[bot]
- deps: update oxc resolver to v11.17.0 (#8121) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.3 (#8109) by @renovate[bot]

### ❤️ New Contributors

* @coolreader18 made their first contribution in [#8110](#8110)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants