Skip to content

Comments

feat: include tsconfig file path in error messages#8107

Merged
graphite-app[bot] merged 1 commit intomainfrom
copilot/improve-readme-content
Jan 29, 2026
Merged

feat: include tsconfig file path in error messages#8107
graphite-app[bot] merged 1 commit intomainfrom
copilot/improve-readme-content

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

This PR moves the JSON path extraction logic to resolve_error_to_message as requested by @sapphi-red. The function now requires a DiagnosticOptions parameter for path stabilization.

Summary

Changes

  1. resolve_error_to_message now takes a required &DiagnosticOptions parameter
  2. ResolveError::Json includes the file path in the error message
  3. All call sites create and pass DiagnosticOptions with cwd for path stabilization
  4. Updated snapshots for package.json syntax error tests

Before

[TSCONFIG_ERROR] Error: Failed to load tsconfig for 'main.ts': JSON parse error

After

[TSCONFIG_ERROR] Error: Failed to load tsconfig for 'main.ts': JSON parse error in 'tsconfig.json'
Original prompt

Read #8105 (comment) and try it


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@netlify
Copy link

netlify bot commented Jan 28, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 489558c
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/697b21e25d0a2b0008c9aad4

Copilot AI changed the title [WIP] Update README for better clarity and engagement feat: include tsconfig file path in error messages Jan 28, 2026
Copilot AI requested a review from hyf0 January 28, 2026 15:10
@hyf0 hyf0 marked this pull request as ready for review January 28, 2026 16:14
@hyf0 hyf0 requested review from Copilot and sapphi-red January 28, 2026 16:14
Copy link
Member

hyf0 commented Jan 28, 2026

Merge activity

  • Jan 28, 4:15 PM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 29, 5:15 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 29, 5:16 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jan 29, 9:00 AM UTC: hyf0 added this pull request to the Graphite merge queue.
  • Jan 29, 9:11 AM UTC: Merged by the Graphite merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses review feedback from #8105 by enhancing error messages for TypeScript configuration file loading failures. The change extracts the tsconfig file path from ResolveError::Json errors to provide more contextual information to developers when debugging configuration issues.

Changes:

  • Added a new generate_message helper method to the TsConfigError struct that extracts and includes the tsconfig file path from JSON parse errors
  • Updated error message format to include the specific file path where the JSON parse error occurred
  • Updated test snapshot to reflect the improved error message format

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/rolldown_error/src/build_diagnostic/events/tsconfig_error.rs Implements generate_message method with pattern matching to extract path from ResolveError::Json variant and stabilize it for consistent error messages
crates/rolldown/tests/rolldown/errors/tsconfig_error/artifacts.snap Updates test snapshot to verify the new error message format includes the tsconfig file path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     72.4±3.39ms        ? ?/sec    1.03     74.8±2.24ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     79.1±4.63ms        ? ?/sec    1.04     82.4±3.43ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    104.6±3.61ms        ? ?/sec    1.04    109.1±2.86ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    114.0±3.54ms        ? ?/sec    1.06    120.8±2.31ms        ? ?/sec
bundle/bundle@threejs                                        1.01     37.5±0.79ms        ? ?/sec    1.00     37.3±0.97ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     41.8±1.30ms        ? ?/sec    1.05     43.8±0.91ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    384.1±9.35ms        ? ?/sec    1.02    391.0±7.77ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    438.1±8.15ms        ? ?/sec    1.03    450.2±9.01ms        ? ?/sec
scan/scan@rome_ts                                            1.00     84.1±1.99ms        ? ?/sec    1.01     85.1±2.28ms        ? ?/sec
scan/scan@threejs                                            1.01     29.0±1.74ms        ? ?/sec    1.00     28.8±1.68ms        ? ?/sec
scan/scan@threejs10x                                         1.00    296.8±5.71ms        ? ?/sec    1.00    296.1±6.09ms        ? ?/sec

@hyf0
Copy link
Member

hyf0 commented Jan 29, 2026

#8111

@hyf0 hyf0 closed this Jan 29, 2026
@sapphi-red
Copy link
Member

#8111 doesn't include this change

This PR moves the JSON path extraction logic to `resolve_error_to_message` as requested by @sapphi-red. The function now requires a `DiagnosticOptions` parameter for path stabilization.

## Summary

### Changes
1. `resolve_error_to_message` now takes a required `&DiagnosticOptions` parameter
2. `ResolveError::Json` includes the file path in the error message
3. All call sites create and pass `DiagnosticOptions` with `cwd` for path stabilization
4. Updated snapshots for package.json syntax error tests

### Before
```
[TSCONFIG_ERROR] Error: Failed to load tsconfig for 'main.ts': JSON parse error
```

### After
```
[TSCONFIG_ERROR] Error: Failed to load tsconfig for 'main.ts': JSON parse error in 'tsconfig.json'
```

<!-- START COPILOT CODING AGENT SUFFIX -->

<!-- START COPILOT ORIGINAL PROMPT -->

<details>

<summary>Original prompt</summary>

> Read #8105 (comment) and try it

</details>

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for you](https://github.com/rolldown/rolldown/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.
@graphite-app graphite-app bot force-pushed the copilot/improve-readme-content branch from fe5df4a to 489558c Compare January 29, 2026 09:01
@graphite-app graphite-app bot merged commit 489558c into main Jan 29, 2026
34 checks passed
@graphite-app graphite-app bot deleted the copilot/improve-readme-content branch January 29, 2026 09:11
This was referenced Feb 4, 2026
shulaoda added a commit that referenced this pull request Feb 4, 2026
## [1.0.0-rc.3] - 2026-02-04

⚡ Remove Unnecessary Default Export Assignment

- Eliminates redundant variable assignments when exporting default values
- Reduces output bundle size and improves code clarity
```js
// index.js
var x = 42;
export default x;

// Before
var x = 42;
var entry_default = x;
export { entry_default as default };

// After
var x = 42;
export { x as default };
```

🐛 Avoid Unnecessary Facade Chunks

- Keep user-defined entry modules in their own chunks
- Reduces HTTP round trips and improves startup performance

```js
// main.js (entry module)
import { a } from './lib.js'
console.log(a)

// lib.js
export * from './counter.js'

// counter.js (entry module)
export const a = 100

// Before
dist/
├── main.js           → import { a } from './counter-chunk.js'; console.log(a)
├── counter.js        → export { a } from './counter-chunk.js' // ❌ facade chunk
└── counter-chunk.js  → export const a = 100

// After
dist/
├── main.js    → import { a } from './counter.js'; console.log(a)
└── counter.js → export const a = 100
```

### 🚀 Features

- expose `RUNTIME_MODULE_ID` constant for plugin authors (#8199) by @shulaoda
- warn unsupported combination of `preserveValueImports` and `importsNotUsedAsValues` in tsconfig.json (#8169) by @sapphi-red
- sophisticated watch tracking for load dependencies (#8092) by @sapphi-red
- add `inputMap` option to `minify` / `minifySync` functions (#8138) by @sapphi-red
- consolidate same tsconfig errors (#8119) by @sapphi-red
- include tsconfig file path in error messages (#8107) by @Copilot
- lazy-barrel: support incremental build mode (#8114) by @shulaoda

### 🐛 Bug Fixes

- rust: preserve dependencies added by `this.addWatchFile` (#8198) by @hyf0
- spawn `RuntimeModuleTask` after `build_start` to avoid race condition (#8182) by @shulaoda
- rust/dev: only close after the ongoing task finished (#8147) by @hyf0
- ensure `\0rolldown/runtime.js` will go through transform hook and add test (#8093) by @hyf0
- `[name]` in `assetFileNames` does not include the directory part (#8098) by @IWANABETHATGUY
- handle external module properties in namespace imports (#8124) by @IWANABETHATGUY
- keep user-defined entry modules in their own chunks (#8047) by @IWANABETHATGUY
- avoid `Unknown resolve error` error message (#8111) by @sapphi-red

### 💼 Other

- remove warnings  for building rolldown with `not(feature = "experimental")` (#8110) by @coolreader18

### 🚜 Refactor

- move `VERSION` to `constants` directory (#8200) by @shulaoda
- simplify import symbol check using `SymbolFlags` (#8193) by @shulaoda
- extract tsconfig option and transform options merging logic (#8168) by @sapphi-red
- filter empty module_groups before sorting (#8149) by @ShroXd
- lazy-barrel: use single `remove` instead of `contains_key` + `remove` (#8123) by @shulaoda
- lazy-barrel: avoid redundant call and inline `get_barrel_normal_module` (#8122) by @shulaoda
- use logger instead of console.log for warnings (#8117) by @IWANABETHATGUY
- module-loader: remove intermediate ModuleTaskOwnerRef type (#8113) by @shulaoda
- rename ReExportExternalModule to ReExportDynamicExports (#8104) by @IWANABETHATGUY

### 📚 Documentation

- add dynamic OG image generation (#8192) by @sapphi-red
- add dynamic OG image generation (#8191) by @sapphi-red
- add dynamic OG image generation (#8179) by @Copilot
- apis: add links to option descriptions in JSDoc comments (#8167) by @sapphi-red
- apis: clarify parameters of `resolveDynamicImport` hook (#8137) by @sapphi-red
- lazy-barrel: clarify default export behavior (#8128) by @shulaoda

### ⚡ Performance

- remove unnecessary assignment for default export (#8127) by @shulaoda

### 🧪 Testing

- dev: `this.addWatchFile` dependency should be preserved after reload (#8165) by @sapphi-red
- mark flaky `transform_runtime_module` test as ignored (#8178) by @Copilot
- rolldown_sourcemap: add test for coarse segments (#8166) by @sapphi-red
- dev: correctly assert file change (#8164) by @sapphi-red
- rust: `transform_runtime_module` test shouldn't panic inside (#8151) by @hyf0
- rust: fix flakiness of rust tests (#8150) by @hyf0
- mark `output.dynamicImportInCjs` tests as passed (#8125) by @shulaoda
- lazy-barrel: add test cases for default export (#8129) by @shulaoda
- rolldown_plugin_vite_manifest: use relative path for outPath (#8101) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.43.1 (#8188) by @renovate[bot]
- deps: update rust crate ts-rs to v12 (#8160) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.0 (#8175) by @renovate[bot]
- deps: update rust crates (#8157) by @renovate[bot]
- deps: update oxc to v0.112.0 (#8171) by @renovate[bot]
- deps: update rollup submodule for tests to v4.57.1 (#8176) by @sapphi-red
- deps: update test262 submodule for tests (#8177) by @sapphi-red
- deps: update dependency oxlint to v1.43.0 (#8173) by @renovate[bot]
- deps: update dependency oxfmt to ^0.28.0 (#8170) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.8 (#8163) by @renovate[bot]
- deps: update dependency vue-router to v5 (#8159) by @renovate[bot]
- deps: update github-actions (#8158) by @renovate[bot]
- deps: update npm packages (#8156) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.4 (#8140) by @renovate[bot]
- fix clippy replacement typo (#8136) by @IWANABETHATGUY
- disallow `HashMap::new` and `HashSet::new` by clippy (#8135) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.21.7 (#8126) by @renovate[bot]
- deps: update oxc resolver to v11.17.0 (#8121) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.3 (#8109) by @renovate[bot]

### ❤️ New Contributors

* @coolreader18 made their first contribution in [#8110](#8110)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants