refactor(rolldown_plugin_vite_import_glob): remove v1 implementation#8095
Conversation
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
b17c04d to
1d39a91
Compare
1d39a91 to
8a6ea85
Compare
There was a problem hiding this comment.
Pull request overview
Removes the legacy/v1 rolldown_plugin_vite_import_glob implementation and associated “v2” fixture suite, consolidating the plugin on a single Transform-based implementation and updating fixtures/snapshots accordingly.
Changes:
- Dropped the old v1/v2 split in the Rust plugin (removed
utils_2, removedisV2config, always usestransform+MagicString). - Removed
import-glob-v2/**fixture coverage and updatedimport-glob/**fixtures/snapshots to match new output. - Updated bindings/types to reflect the simplified plugin config (
sourcemap,restoreQueryExtension,root).
Reviewed changes
Copilot reviewed 79 out of 81 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/vite/virtual-modules/index.ts.snap | Snapshot update for new import-glob codegen output. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/vite/transform/index.ts.snap | Snapshot update for new import-glob codegen output. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/vite/restore-query-extension/index.ts.snap | Snapshot update for new import-glob codegen output with restored query extension behavior. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/vite/restore-query-extension/_config.ts | Adjusts fixture config formatting/usage for the updated plugin config shape. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/star-star-dot-syntax/_config.ts | Simplifies fixture to use default plugin config (no explicit root). |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/query/_config.ts | Simplifies fixture to use default plugin config (no empty object). |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/query-object/_config.ts | Simplifies fixture to use default plugin config (no empty object). |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/parent/_config.ts | Simplifies fixture to use default plugin config (no explicit root). |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/exhaustive/_config.ts | Simplifies fixture to use default plugin config (no explicit root). |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/basic/_config.ts | Simplifies fixture to use default plugin config (no explicit root). |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/absolute-glob-expr/_config.ts | Simplifies fixture to use default plugin config (no explicit root). |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/virtual-modules/index.ts.snap | Removes obsolete import-glob-v2 fixture snapshot. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/virtual-modules/index.ts | Removes obsolete import-glob-v2 fixture source. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/virtual-modules/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/transform/index.ts.snap | Removes obsolete import-glob-v2 fixture snapshot. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/transform/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/restore-query-extension/index.ts.snap | Removes obsolete import-glob-v2 fixture snapshot. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/restore-query-extension/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/b/index.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/b/b.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/b/a.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/a/sibling.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/a/node_modules/framework/pages/hello.page.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/a/modules/index.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/a/modules/b.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/a/modules/a.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/a/index.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/vite/fixtures/a/.gitignore | Removes obsolete import-glob-v2 fixture gitignore. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/star-star-dot-syntax/main.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/star-star-dot-syntax/dir/a.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/star-star-dot-syntax/assert.mjs | Removes obsolete import-glob-v2 fixture assertion. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/star-star-dot-syntax/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/restore-query-extension/main.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/restore-query-extension/dir/index.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/restore-query-extension/dir/b.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/restore-query-extension/assert.mjs | Removes obsolete import-glob-v2 fixture assertion. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/restore-query-extension/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query/main.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query/dir/index.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query/dir/b.js.snap | Removes obsolete import-glob-v2 fixture snapshot. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query/dir/b.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query/assert.mjs | Removes obsolete import-glob-v2 fixture assertion. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query-object/main.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query-object/dir/index.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query-object/dir/b.js.snap | Removes obsolete import-glob-v2 fixture snapshot. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query-object/dir/b.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query-object/assert.mjs | Removes obsolete import-glob-v2 fixture assertion. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/query-object/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/parent/src/main.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/parent/dir/b.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/parent/dir/a.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/parent/assert.mjs | Removes obsolete import-glob-v2 fixture assertion. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/parent/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/exhaustive/node_modules/a.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/exhaustive/main.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/exhaustive/assert.mjs | Removes obsolete import-glob-v2 fixture assertion. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/exhaustive/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/exhaustive/.gitignore | Removes obsolete import-glob-v2 fixture gitignore. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/exhaustive/.dot/b.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/eager/main.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/eager/dir/index.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/eager/assert.mjs | Removes obsolete import-glob-v2 fixture assertion. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/eager/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/basic/main.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/basic/dir/b.ts | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/basic/dir/a.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/basic/assert.mjs | Removes obsolete import-glob-v2 fixture assertion. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/basic/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/absolute-glob-expr/src/main.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/absolute-glob-expr/src/dir/a.js | Removes obsolete import-glob-v2 fixture file. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/absolute-glob-expr/assert.mjs | Removes obsolete import-glob-v2 fixture assertion. |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob-v2/absolute-glob-expr/_config.ts | Removes obsolete import-glob-v2 fixture config. |
| packages/rolldown/tests/fixtures/builtin-plugin/dynamic-import-vars/vite/_config.ts | Disables the fixture via skip: true. |
| packages/rolldown/tests/fixtures/builtin-plugin/dynamic-import-vars/filter/_config.ts | Disables the fixture via skip: true. |
| packages/rolldown/tests/fixtures/builtin-plugin/dynamic-import-vars/basic/_config.ts | Disables the fixture via skip: true. |
| packages/rolldown/src/binding.d.cts | Updates generated TS bindings for the new import-glob plugin config shape. |
| crates/rolldown_plugin_vite_import_glob/src/utils_2.rs | Removes the legacy/v1 implementation file. |
| crates/rolldown_plugin_vite_import_glob/src/utils.rs | Refactors glob transform to use Visit + MagicString and string replacements. |
| crates/rolldown_plugin_vite_import_glob/src/lib.rs | Simplifies plugin API/config and consolidates to transform hook only. |
| crates/rolldown_binding/src/options/plugin/config/binding_vite_import_glob_plugin_config.rs | Updates N-API binding config to match the simplified Rust plugin config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/rolldown/tests/fixtures/builtin-plugin/dynamic-import-vars/vite/_config.ts
Show resolved
Hide resolved
packages/rolldown/tests/fixtures/builtin-plugin/dynamic-import-vars/filter/_config.ts
Show resolved
Hide resolved
packages/rolldown/tests/fixtures/builtin-plugin/dynamic-import-vars/basic/_config.ts
Show resolved
Hide resolved
Benchmarks Rust
|
Merge activity
|
8a6ea85 to
1d5fcb8
Compare
## [1.0.0-rc.2] - 2026-01-28
⚡ Lazy Barrel Optimization
- Skips compilation of unused re-export modules in side-effect-free barrel modules
- Particularly beneficial for projects importing from large component libraries
For large component libraries like Ant Design, when you import just one component:
```js
import { Button } from 'antd';
Button;
```
| Metric | Without lazy barrel | With lazy barrel |
| -------------------- | --------------------- | ---------------- |
| Modules compiled | 2986 | 250 |
| Build time | ~210ms | ~50ms |
By enabling lazy barrel, Rolldown reduces the number of compiled modules by 90% and speeds up the build by 2-4x.
Enable it in your config:
```js
export default {
experimental: {
lazyBarrel: true,
},
};
```
For more details, see the https://rolldown.rs/in-depth/lazy-barrel-optimization
### 💥 BREAKING CHANGES
- expose `\0rolldown/runtime` in transform hook (#8068) by @hyf0
- rename `rolldown:runtime` to `\0rolldown/runtime.js` (#8067) by @hyf0
### 🚀 Features
- remove inlined constants in smart mode (#8085) by @sapphi-red
- allow more options for `this.emitFile` with `type: 'prebuilt-chunk'` (#8062) by @sapphi-red
- warn when both code and postBanner contain shebang (#8039) by @Copilot
### 🐛 Bug Fixes
- update the links to Rolldown docs in the error messages (#8103) by @sapphi-red
- handle tsconfig.json load errors (#8105) by @sapphi-red
- include inlined constants in namespace object (#8099) by @sapphi-red
- vite test ci (#8084) by @IWANABETHATGUY
- renamer: nested binding shadowing external module namespace in UMD/IIFE formats (#8083) by @Dunqing
- deduplicate ESM chunk imports by canonical symbol (#8059) by @IWANABETHATGUY
- refine side-effect detection for BigInt and RegExp (#8060) by @IWANABETHATGUY
- rust: use string literal span for `new URL` error diagnostic (#8043) by @valadaptive
- rust: use ModuleType::Asset for `new URL` imports (#8035) by @valadaptive
- CJS-ESM interop - property assignment on CJS module exports (#8006) by @IWANABETHATGUY
- eliminate the facade chunk if the dynamic entry module has been merged into common chunk (#8046) by @IWANABETHATGUY
- Inlining dynamic imports broken with multiple entry points (#8037) by @IWANABETHATGUY
- devtools: revert `Chunk#id` to `Chunk#chunk_id` (#8040) by @hyf0
- invert `__exportAll` parameter logic to reduce default output size (#8036) by @Copilot
- `</script` tag search should be case insensitive (#8033) by @IWANABETHATGUY
- use directory name as-is for the variable name even if the name contained `.` (#8029) by @Copilot
- dev/lazy: remove unnecessary rewrite from top level `this` to `undefined` (#8020) by @hyf0
- dev/lazy: should keep lazy entries imports for patch file (#8019) by @hyf0
- `output.generatedCode.preset: 'es2015'` was not set by default (#8026) by @sapphi-red
- node: align option validator to types (#8023) by @sapphi-red
- node: allow `output.strictExecutionOrder` by the option validator (#8022) by @sapphi-red
- types: return `this` from on / off methods of `RolldownWatcher` (#8015) by @sapphi-red
### 🚜 Refactor
- rolldown_plugin_vite_dynamic_import_vars: remove v1 implementation (#8096) by @shulaoda
- rolldown_plugin_vite_import_glob: remove v1 implementation (#8095) by @shulaoda
- lazy-barrel: restructure lazy barrel implementation (#8070) by @shulaoda
- remove `use_built_ins` and `use_spread` from internal JSX options (#8079) by @sapphi-red
- remove `experimental.transformHiresSourcemap` (#8055) by @Copilot
- rust: use `is_data_url` more consistently (#8042) by @valadaptive
- use `FxIndexMap` to store EntryPoint (#8032) by @IWANABETHATGUY
- node: add type checks that ensures validator schema is up to date with types (#8024) by @sapphi-red
### 📚 Documentation
- link to vite plugin registry (#8086) by @sapphi-red
- lazy-barrel: improve documentation and enable in sidebar (#8072) by @shulaoda
- add more examples and details (#8054) by @sapphi-red
- in-depth: add dead code elimination page (#8007) by @sapphi-red
- update status from beta to release candidate (#8012) by @shulaoda
### ⚡ Performance
- run inline-const pass for modules that are affected by inlining (#8064) by @sapphi-red
### 🧪 Testing
- lazy-barrel: use package.json sideEffects instead of plugin hook (#8077) by @shulaoda
- lazy-barrel: enable tests and add treeshake-behavior cases (#8071) by @shulaoda
### ⚙️ Miscellaneous Tasks
- deps: update crate-ci/typos action to v1.42.3 (#8087) by @renovate[bot]
- deps: update rollup submodule for tests to v4.56.0 (#8073) by @sapphi-red
- deps: update oxc to v0.111.0 (#8063) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.6 (#8076) by @renovate[bot]
- deps: update test262 submodule for tests (#8074) by @sapphi-red
- deps: update crate-ci/typos action to v1.42.2 (#8069) by @renovate[bot]
- deps: update oxc apps (#8066) by @renovate[bot]
- remove `{@include ./foo.md}` from d.ts files (#8056) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.11.2 (#8057) by @renovate[bot]
- deps: update github-actions (#8050) by @renovate[bot]
- deps: update npm packages (#8051) by @renovate[bot]
- deps: update rust crates (#8049) by @renovate[bot]
- debug: add IdxExt debug trait for human-readable index debugging (#8045) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.21.5 (#8034) by @renovate[bot]
- deps: update oxc resolver to v11.16.4 (#8031) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.4 (#8030) by @renovate[bot]
- deps: update dependency rust to v1.93.0 (#8018) by @renovate[bot]
- archive 2025 beta changelog (#8014) by @shulaoda
- update release workflow version pattern from beta to rc (#8013) by @shulaoda
### ❤️ New Contributors
* @valadaptive made their first contribution in [#8043](#8043)
Co-authored-by: shulaoda <[email protected]>

No description provided.