Skip to content

Comments

feat: allow more options for this.emitFile with type: 'prebuilt-chunk'#8062

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-26-feat_allow_name_option_for_this.emitfile_with_type_prebuilt-chunk_
Jan 26, 2026
Merged

feat: allow more options for this.emitFile with type: 'prebuilt-chunk'#8062
graphite-app[bot] merged 1 commit intomainfrom
01-26-feat_allow_name_option_for_this.emitfile_with_type_prebuilt-chunk_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 26, 2026

Allow more options for this.emitFile with type: 'prebuilt-chunk'.

This is needed for vitejs/vite#21498

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red changed the title feat: allow more option for this.emitFile with type: 'prebuilt-chunk' feat: allow more options for this.emitFile with type: 'prebuilt-chunk' Jan 26, 2026
@netlify
Copy link

netlify bot commented Jan 26, 2026

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit b2f7642
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/697777afd3686a000705e1d5
😎 Deploy Preview https://deploy-preview-8062--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sapphi-red sapphi-red requested a review from shulaoda January 26, 2026 14:20
@sapphi-red sapphi-red marked this pull request as ready for review January 26, 2026 14:20
Copilot AI review requested due to automatic review settings January 26, 2026 14:20
Copy link
Member Author

sapphi-red commented Jan 26, 2026

Merge activity

  • Jan 26, 2:20 PM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 26, 2:42 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Jan 26, 2:52 PM UTC: Merged by the Graphite merge queue.

@netlify
Copy link

netlify bot commented Jan 26, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e8b30ea
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69777d6379a9e100084d4f90

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the emitFile API to support additional metadata options for prebuilt chunks, aligning them more closely with regular chunks. This enhancement is required for Vite PR #21498.

Changes:

  • Added optional name, facadeModuleId, isEntry, and isDynamicEntry fields to EmittedPrebuiltChunk
  • Updated TypeScript interfaces, binding definitions, and Rust implementations across all layers
  • Added comprehensive test coverage for both default behavior and custom options

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/rolldown/src/plugin/plugin-context.ts Added new optional fields to EmittedPrebuiltChunk interface with documentation, and passed them through in emitFile implementation
packages/rolldown/src/binding.d.cts Updated TypeScript binding definition for BindingEmittedPrebuiltChunk with new optional fields
crates/rolldown_binding/src/options/plugin/types/binding_emitted_prebuilt_chunk.rs Added new fields to Rust binding struct and conversion logic with proper defaults
crates/rolldown_common/src/file_emitter.rs Added new fields to EmittedPrebuiltChunk struct and updated usage in bundle generation
packages/rolldown/tests/fixtures/plugin/context/emit-prebuilt-chunk/_config.ts Expanded tests to verify default values and custom options for prebuilt chunks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(33d77f2)
  • pr: 01-26-feat_allow_name_option_for_this.emitfile_with_type_prebuilt-chunk_(291e6d5)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     69.7±2.73ms        ? ?/sec    1.02     71.4±3.44ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     76.3±2.76ms        ? ?/sec    1.01     77.3±3.26ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    102.0±3.85ms        ? ?/sec    1.01    103.4±2.84ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    113.2±1.87ms        ? ?/sec    1.01    114.7±2.84ms        ? ?/sec
bundle/bundle@threejs                                        1.00     34.7±0.87ms        ? ?/sec    1.06     36.9±2.22ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.0±0.95ms        ? ?/sec    1.05     41.8±1.33ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    364.5±3.50ms        ? ?/sec    1.02    370.3±6.27ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    427.5±6.48ms        ? ?/sec    1.00    428.8±7.81ms        ? ?/sec
scan/scan@rome_ts                                            1.00     81.6±2.37ms        ? ?/sec    1.00     81.8±2.33ms        ? ?/sec
scan/scan@threejs                                            1.00     28.3±0.50ms        ? ?/sec    1.01     28.6±1.74ms        ? ?/sec
scan/scan@threejs10x                                         1.00    287.1±5.25ms        ? ?/sec    1.00    288.2±5.02ms        ? ?/sec

…unk'` (#8062)

Allow more options for `this.emitFile` with `type: 'prebuilt-chunk'`.

This is needed for vitejs/vite#21498
@graphite-app graphite-app bot force-pushed the 01-26-feat_allow_name_option_for_this.emitfile_with_type_prebuilt-chunk_ branch from 291e6d5 to e8b30ea Compare January 26, 2026 14:42
@graphite-app graphite-app bot merged commit e8b30ea into main Jan 26, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 01-26-feat_allow_name_option_for_this.emitfile_with_type_prebuilt-chunk_ branch January 26, 2026 14:52
This was referenced Jan 28, 2026
shulaoda added a commit that referenced this pull request Jan 28, 2026
## [1.0.0-rc.2] - 2026-01-28

⚡ Lazy Barrel Optimization

- Skips compilation of unused re-export modules in side-effect-free barrel modules
- Particularly beneficial for projects importing from large component libraries

For large component libraries like Ant Design, when you import just one component:

```js
import { Button } from 'antd';
Button;
```

| Metric                    | Without lazy barrel | With lazy barrel |
| -------------------- | --------------------- | ---------------- |
| Modules compiled | 2986                       | 250              |
| Build time               | ~210ms                  | ~50ms            |

By enabling lazy barrel, Rolldown reduces the number of compiled modules by 90% and speeds up the build by 2-4x. 

Enable it in your config:

```js
export default {
  experimental: {
    lazyBarrel: true,
  },
};
```

For more details, see the https://rolldown.rs/in-depth/lazy-barrel-optimization

### 💥 BREAKING CHANGES

- expose `\0rolldown/runtime` in transform hook (#8068) by @hyf0
- rename `rolldown:runtime` to `\0rolldown/runtime.js` (#8067) by @hyf0

### 🚀 Features

- remove inlined constants in smart mode (#8085) by @sapphi-red
- allow more options for `this.emitFile` with `type: 'prebuilt-chunk'` (#8062) by @sapphi-red
- warn when both code and postBanner contain shebang (#8039) by @Copilot

### 🐛 Bug Fixes

- update the links to Rolldown docs in the error messages (#8103) by @sapphi-red
- handle tsconfig.json load errors (#8105) by @sapphi-red
- include inlined constants in namespace object (#8099) by @sapphi-red
- vite test ci (#8084) by @IWANABETHATGUY
- renamer: nested binding shadowing external module namespace in UMD/IIFE formats (#8083) by @Dunqing
- deduplicate ESM chunk imports by canonical symbol (#8059) by @IWANABETHATGUY
- refine side-effect detection for BigInt and RegExp (#8060) by @IWANABETHATGUY
- rust: use string literal span for `new URL` error diagnostic (#8043) by @valadaptive
- rust: use ModuleType::Asset for `new URL` imports (#8035) by @valadaptive
- CJS-ESM interop - property assignment on CJS module exports (#8006) by @IWANABETHATGUY
- eliminate the facade chunk if the dynamic entry module has been merged into common chunk (#8046) by @IWANABETHATGUY
- Inlining dynamic imports broken with multiple entry points (#8037) by @IWANABETHATGUY
- devtools: revert `Chunk#id` to `Chunk#chunk_id` (#8040) by @hyf0
- invert `__exportAll` parameter logic to reduce default output size (#8036) by @Copilot
- `</script` tag search should be case insensitive (#8033) by @IWANABETHATGUY
- use directory name as-is for the variable name even if the name contained `.` (#8029) by @Copilot
- dev/lazy: remove unnecessary rewrite from top level `this` to `undefined` (#8020) by @hyf0
- dev/lazy: should keep lazy entries imports for patch file (#8019) by @hyf0
- `output.generatedCode.preset: 'es2015'` was not set by default (#8026) by @sapphi-red
- node: align option validator to types (#8023) by @sapphi-red
- node: allow `output.strictExecutionOrder` by the option validator (#8022) by @sapphi-red
- types: return `this` from on / off methods of `RolldownWatcher` (#8015) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_vite_dynamic_import_vars: remove v1 implementation (#8096) by @shulaoda
- rolldown_plugin_vite_import_glob: remove v1 implementation (#8095) by @shulaoda
- lazy-barrel: restructure lazy barrel implementation (#8070) by @shulaoda
- remove `use_built_ins` and `use_spread` from internal JSX options (#8079) by @sapphi-red
- remove `experimental.transformHiresSourcemap` (#8055) by @Copilot
- rust: use `is_data_url` more consistently (#8042) by @valadaptive
- use `FxIndexMap` to store EntryPoint (#8032) by @IWANABETHATGUY
- node: add type checks that ensures validator schema is up to date with types (#8024) by @sapphi-red

### 📚 Documentation

- link to vite plugin registry (#8086) by @sapphi-red
- lazy-barrel: improve documentation and enable in sidebar (#8072) by @shulaoda
- add more examples and details (#8054) by @sapphi-red
- in-depth: add dead code elimination page (#8007) by @sapphi-red
- update status from beta to release candidate (#8012) by @shulaoda

### ⚡ Performance

- run inline-const pass for modules that are affected by inlining (#8064) by @sapphi-red

### 🧪 Testing

- lazy-barrel: use package.json sideEffects instead of plugin hook (#8077) by @shulaoda
- lazy-barrel: enable tests and add treeshake-behavior cases (#8071) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.42.3 (#8087) by @renovate[bot]
- deps: update rollup submodule for tests to v4.56.0 (#8073) by @sapphi-red
- deps: update oxc to v0.111.0 (#8063) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.6 (#8076) by @renovate[bot]
- deps: update test262 submodule for tests (#8074) by @sapphi-red
- deps: update crate-ci/typos action to v1.42.2 (#8069) by @renovate[bot]
- deps: update oxc apps (#8066) by @renovate[bot]
- remove `{@include ./foo.md}` from d.ts files (#8056) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.11.2 (#8057) by @renovate[bot]
- deps: update github-actions (#8050) by @renovate[bot]
- deps: update npm packages (#8051) by @renovate[bot]
- deps: update rust crates (#8049) by @renovate[bot]
- debug: add IdxExt debug trait for human-readable index debugging (#8045) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.21.5 (#8034) by @renovate[bot]
- deps: update oxc resolver to v11.16.4 (#8031) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.4 (#8030) by @renovate[bot]
- deps: update dependency rust to v1.93.0 (#8018) by @renovate[bot]
- archive 2025 beta changelog (#8014) by @shulaoda
- update release workflow version pattern from beta to rc (#8013) by @shulaoda

### ❤️ New Contributors

* @valadaptive made their first contribution in [#8043](#8043)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants