Skip to content

Comments

fix: deduplicate ESM chunk imports by canonical symbol#8059

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-26-fix_8053
Jan 27, 2026
Merged

fix: deduplicate ESM chunk imports by canonical symbol#8059
graphite-app[bot] merged 1 commit intomainfrom
01-26-fix_8053

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jan 26, 2026

closed #8053

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jan 26, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 62d642b
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69786ac59ce05a00087fe570

@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-26-fix_8053 branch 5 times, most recently from b743186 to 0ef5b05 Compare January 27, 2026 06:00
@IWANABETHATGUY IWANABETHATGUY changed the title fix: 8053 fix: deduplicate ESM chunk imports by canonical symbol Jan 27, 2026
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 27, 2026 06:01
@IWANABETHATGUY IWANABETHATGUY requested review from Copilot, hyf0 and shulaoda and removed request for Copilot January 27, 2026 06:01
@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.22     73.3±2.40ms        ? ?/sec    1.00     60.0±1.82ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.29     84.2±2.70ms        ? ?/sec    1.00     65.1±1.16ms        ? ?/sec
bundle/bundle@rome_ts                                        1.09    102.3±2.52ms        ? ?/sec    1.00     94.2±1.94ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.09    115.7±2.33ms        ? ?/sec    1.00    106.4±1.75ms        ? ?/sec
bundle/bundle@threejs                                        1.06     37.5±2.19ms        ? ?/sec    1.00     35.5±0.69ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     41.7±0.73ms        ? ?/sec    1.00     40.0±0.94ms        ? ?/sec
bundle/bundle@threejs10x                                     1.13    380.3±9.87ms        ? ?/sec    1.00    335.3±2.38ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.15   458.0±12.21ms        ? ?/sec    1.00    397.9±2.54ms        ? ?/sec
scan/scan@rome_ts                                            1.08     78.1±1.39ms        ? ?/sec    1.00     72.2±1.01ms        ? ?/sec
scan/scan@threejs                                            1.07     27.0±0.48ms        ? ?/sec    1.00     25.2±0.31ms        ? ?/sec
scan/scan@threejs10x                                         1.07    277.5±3.17ms        ? ?/sec    1.00    259.0±3.09ms        ? ?/sec

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes invalid ESM output where a chunk import statement could declare the same local binding name multiple times by deduplicating imports using the canonical symbol reference (closes #8053).

Changes:

  • Deduplicate ESM cross-chunk import specifiers by canonical_ref to prevent duplicate local-name imports.
  • Add a regression test case for issue #8053 (incl. ESM + CJS variant snapshots).
  • Update the filename-hash integration snapshot to include the new test case outputs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/rolldown/src/ecmascript/format/esm.rs Skips emitting multiple import specifiers that resolve to the same canonical symbol to avoid invalid ESM imports.
crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap Adds expected hashed filenames for the new issue #8053 integration fixture.
crates/rolldown/tests/rolldown/issues/8053/_config.json New fixture config covering default (ESM) + CJS variant.
crates/rolldown/tests/rolldown/issues/8053/main.js New entry module reproducing the cross-chunk duplicate-local import scenario.
crates/rolldown/tests/rolldown/issues/8053/lazy-a.js New dynamically imported module that triggers the problematic cross-chunk imports.
crates/rolldown/tests/rolldown/issues/8053/utils.js Re-exports from a CJS module to reproduce canonical-symbol collisions.
crates/rolldown/tests/rolldown/issues/8053/lodash.cjs Minimal CJS module used by the reproduction.
crates/rolldown/tests/rolldown/issues/8053/artifacts.snap Snapshot asserting corrected output (no duplicate local-name import in ESM).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 27, 2026

Merge activity

@graphite-app graphite-app bot merged commit 62d642b into main Jan 27, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 01-26-fix_8053 branch January 27, 2026 07:45
This was referenced Jan 28, 2026
shulaoda added a commit that referenced this pull request Jan 28, 2026
## [1.0.0-rc.2] - 2026-01-28

⚡ Lazy Barrel Optimization

- Skips compilation of unused re-export modules in side-effect-free barrel modules
- Particularly beneficial for projects importing from large component libraries

For large component libraries like Ant Design, when you import just one component:

```js
import { Button } from 'antd';
Button;
```

| Metric                    | Without lazy barrel | With lazy barrel |
| -------------------- | --------------------- | ---------------- |
| Modules compiled | 2986                       | 250              |
| Build time               | ~210ms                  | ~50ms            |

By enabling lazy barrel, Rolldown reduces the number of compiled modules by 90% and speeds up the build by 2-4x. 

Enable it in your config:

```js
export default {
  experimental: {
    lazyBarrel: true,
  },
};
```

For more details, see the https://rolldown.rs/in-depth/lazy-barrel-optimization

### 💥 BREAKING CHANGES

- expose `\0rolldown/runtime` in transform hook (#8068) by @hyf0
- rename `rolldown:runtime` to `\0rolldown/runtime.js` (#8067) by @hyf0

### 🚀 Features

- remove inlined constants in smart mode (#8085) by @sapphi-red
- allow more options for `this.emitFile` with `type: 'prebuilt-chunk'` (#8062) by @sapphi-red
- warn when both code and postBanner contain shebang (#8039) by @Copilot

### 🐛 Bug Fixes

- update the links to Rolldown docs in the error messages (#8103) by @sapphi-red
- handle tsconfig.json load errors (#8105) by @sapphi-red
- include inlined constants in namespace object (#8099) by @sapphi-red
- vite test ci (#8084) by @IWANABETHATGUY
- renamer: nested binding shadowing external module namespace in UMD/IIFE formats (#8083) by @Dunqing
- deduplicate ESM chunk imports by canonical symbol (#8059) by @IWANABETHATGUY
- refine side-effect detection for BigInt and RegExp (#8060) by @IWANABETHATGUY
- rust: use string literal span for `new URL` error diagnostic (#8043) by @valadaptive
- rust: use ModuleType::Asset for `new URL` imports (#8035) by @valadaptive
- CJS-ESM interop - property assignment on CJS module exports (#8006) by @IWANABETHATGUY
- eliminate the facade chunk if the dynamic entry module has been merged into common chunk (#8046) by @IWANABETHATGUY
- Inlining dynamic imports broken with multiple entry points (#8037) by @IWANABETHATGUY
- devtools: revert `Chunk#id` to `Chunk#chunk_id` (#8040) by @hyf0
- invert `__exportAll` parameter logic to reduce default output size (#8036) by @Copilot
- `</script` tag search should be case insensitive (#8033) by @IWANABETHATGUY
- use directory name as-is for the variable name even if the name contained `.` (#8029) by @Copilot
- dev/lazy: remove unnecessary rewrite from top level `this` to `undefined` (#8020) by @hyf0
- dev/lazy: should keep lazy entries imports for patch file (#8019) by @hyf0
- `output.generatedCode.preset: 'es2015'` was not set by default (#8026) by @sapphi-red
- node: align option validator to types (#8023) by @sapphi-red
- node: allow `output.strictExecutionOrder` by the option validator (#8022) by @sapphi-red
- types: return `this` from on / off methods of `RolldownWatcher` (#8015) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_vite_dynamic_import_vars: remove v1 implementation (#8096) by @shulaoda
- rolldown_plugin_vite_import_glob: remove v1 implementation (#8095) by @shulaoda
- lazy-barrel: restructure lazy barrel implementation (#8070) by @shulaoda
- remove `use_built_ins` and `use_spread` from internal JSX options (#8079) by @sapphi-red
- remove `experimental.transformHiresSourcemap` (#8055) by @Copilot
- rust: use `is_data_url` more consistently (#8042) by @valadaptive
- use `FxIndexMap` to store EntryPoint (#8032) by @IWANABETHATGUY
- node: add type checks that ensures validator schema is up to date with types (#8024) by @sapphi-red

### 📚 Documentation

- link to vite plugin registry (#8086) by @sapphi-red
- lazy-barrel: improve documentation and enable in sidebar (#8072) by @shulaoda
- add more examples and details (#8054) by @sapphi-red
- in-depth: add dead code elimination page (#8007) by @sapphi-red
- update status from beta to release candidate (#8012) by @shulaoda

### ⚡ Performance

- run inline-const pass for modules that are affected by inlining (#8064) by @sapphi-red

### 🧪 Testing

- lazy-barrel: use package.json sideEffects instead of plugin hook (#8077) by @shulaoda
- lazy-barrel: enable tests and add treeshake-behavior cases (#8071) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.42.3 (#8087) by @renovate[bot]
- deps: update rollup submodule for tests to v4.56.0 (#8073) by @sapphi-red
- deps: update oxc to v0.111.0 (#8063) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.6 (#8076) by @renovate[bot]
- deps: update test262 submodule for tests (#8074) by @sapphi-red
- deps: update crate-ci/typos action to v1.42.2 (#8069) by @renovate[bot]
- deps: update oxc apps (#8066) by @renovate[bot]
- remove `{@include ./foo.md}` from d.ts files (#8056) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.11.2 (#8057) by @renovate[bot]
- deps: update github-actions (#8050) by @renovate[bot]
- deps: update npm packages (#8051) by @renovate[bot]
- deps: update rust crates (#8049) by @renovate[bot]
- debug: add IdxExt debug trait for human-readable index debugging (#8045) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.21.5 (#8034) by @renovate[bot]
- deps: update oxc resolver to v11.16.4 (#8031) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.4 (#8030) by @renovate[bot]
- deps: update dependency rust to v1.93.0 (#8018) by @renovate[bot]
- archive 2025 beta changelog (#8014) by @shulaoda
- update release workflow version pattern from beta to rc (#8013) by @shulaoda

### ❤️ New Contributors

* @valadaptive made their first contribution in [#8043](#8043)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: duplicate local name import in output

2 participants