Skip to content

Comments

fix: keep user-defined entry modules in their own chunks#8047

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-21-fix_5726
Jan 29, 2026
Merged

fix: keep user-defined entry modules in their own chunks#8047
graphite-app[bot] merged 1 commit intomainfrom
01-21-fix_5726

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jan 25, 2026

closed #5726

Copy link
Member Author

IWANABETHATGUY commented Jan 25, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-21-fix_5726 branch 3 times, most recently from 56714e1 to 8f7427e Compare January 25, 2026 18:11
@graphite-app graphite-app bot changed the base branch from 01-25-fix_eliminate_the_facade_chunk_if_the_dynamic_entry_module_has_been_merged_into_common_chunk to graphite-base/8047 January 26, 2026 06:51
@graphite-app graphite-app bot force-pushed the graphite-base/8047 branch from e0f7413 to 8407bf3 Compare January 26, 2026 07:02
@graphite-app graphite-app bot changed the base branch from graphite-base/8047 to main January 26, 2026 07:02
@netlify
Copy link

netlify bot commented Jan 26, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 77d001e
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/697b16ef14e99700082104d6

@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-21-fix_5726 branch 4 times, most recently from ad15fde to c446dfe Compare January 28, 2026 17:01
@IWANABETHATGUY IWANABETHATGUY added the test: vite-tests Trigger Vite tests workflow on this PR label Jan 28, 2026
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-21-fix_5726 branch 2 times, most recently from 8f782c7 to 784fa25 Compare January 29, 2026 01:54
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 29, 2026 01:54
Copilot AI review requested due to automatic review settings January 29, 2026 01:54
@IWANABETHATGUY IWANABETHATGUY changed the title fix: 5726 fix: keep user-defined entry modules in their own chunks Jan 29, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #5726 by optimizing how user-defined entry modules are handled during code splitting, preventing unnecessary common chunks and improving output structure.

Changes:

  • Modified entry module chunk assignment logic to keep user-defined, non-wrapped entry modules in their own entry chunks
  • Enhanced cross-chunk import detection to handle cases where the bit-based check misses dependencies (e.g., entry-to-entry imports)
  • Updated test snapshots to reflect the new, more optimized chunking behavior

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/rolldown/src/stages/generate_stage/code_splitting.rs Added logic to keep user-defined entry modules in their entry chunks when not wrapped, avoiding unnecessary common chunks
crates/rolldown/src/stages/generate_stage/compute_cross_chunk_links.rs Added module-level import checking to preserve cross-chunk dependencies missed by bit-based checks
crates/rolldown/tests/rolldown/issues/5726/* New test case demonstrating the fix with multiple entry points
packages/rolldown/tests/fixtures/issues/4904-bailout/_config.ts Updated test expectation to reflect reduced chunk count (3 instead of 4)
crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap Updated hash snapshots for affected test cases
crates/rolldown/tests/esbuild/splitting/splitting_circular_reference_issue251/artifacts.snap Updated snapshot for circular reference handling
crates/rolldown/tests/esbuild/default/export_forms_with_minify_identifiers_and_no_bundle/* Updated snapshots for export forms test with new chunk structure
packages/rolldown/tests/fixtures/output/sanitize-filename/function/_config.ts Updated hash in test expectation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2026

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.09     73.0±2.38ms        ? ?/sec    1.00     66.9±2.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.05     78.4±1.73ms        ? ?/sec    1.00     74.5±2.70ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    101.8±2.12ms        ? ?/sec    1.00     99.6±2.22ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    112.7±1.52ms        ? ?/sec    1.00    111.5±2.20ms        ? ?/sec
bundle/bundle@threejs                                        1.00     36.3±0.63ms        ? ?/sec    1.00     36.5±2.23ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     41.0±1.45ms        ? ?/sec    1.00     40.2±0.86ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    364.6±3.81ms        ? ?/sec    1.00    361.8±6.22ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    419.4±7.03ms        ? ?/sec    1.00    416.9±5.41ms        ? ?/sec
scan/scan@rome_ts                                            1.02     81.3±2.14ms        ? ?/sec    1.00     79.9±1.64ms        ? ?/sec
scan/scan@threejs                                            1.00     28.1±0.52ms        ? ?/sec    1.00     28.0±1.58ms        ? ?/sec
scan/scan@threejs10x                                         1.03    290.4±5.58ms        ? ?/sec    1.00    281.7±4.20ms        ? ?/sec

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 29, 2026

Merge activity

@graphite-app graphite-app bot merged commit 77d001e into main Jan 29, 2026
35 checks passed
@graphite-app graphite-app bot deleted the 01-21-fix_5726 branch January 29, 2026 08:25
This was referenced Feb 4, 2026
shulaoda added a commit that referenced this pull request Feb 4, 2026
## [1.0.0-rc.3] - 2026-02-04

⚡ Remove Unnecessary Default Export Assignment

- Eliminates redundant variable assignments when exporting default values
- Reduces output bundle size and improves code clarity
```js
// index.js
var x = 42;
export default x;

// Before
var x = 42;
var entry_default = x;
export { entry_default as default };

// After
var x = 42;
export { x as default };
```

🐛 Avoid Unnecessary Facade Chunks

- Keep user-defined entry modules in their own chunks
- Reduces HTTP round trips and improves startup performance

```js
// main.js (entry module)
import { a } from './lib.js'
console.log(a)

// lib.js
export * from './counter.js'

// counter.js (entry module)
export const a = 100

// Before
dist/
├── main.js           → import { a } from './counter-chunk.js'; console.log(a)
├── counter.js        → export { a } from './counter-chunk.js' // ❌ facade chunk
└── counter-chunk.js  → export const a = 100

// After
dist/
├── main.js    → import { a } from './counter.js'; console.log(a)
└── counter.js → export const a = 100
```

### 🚀 Features

- expose `RUNTIME_MODULE_ID` constant for plugin authors (#8199) by @shulaoda
- warn unsupported combination of `preserveValueImports` and `importsNotUsedAsValues` in tsconfig.json (#8169) by @sapphi-red
- sophisticated watch tracking for load dependencies (#8092) by @sapphi-red
- add `inputMap` option to `minify` / `minifySync` functions (#8138) by @sapphi-red
- consolidate same tsconfig errors (#8119) by @sapphi-red
- include tsconfig file path in error messages (#8107) by @Copilot
- lazy-barrel: support incremental build mode (#8114) by @shulaoda

### 🐛 Bug Fixes

- rust: preserve dependencies added by `this.addWatchFile` (#8198) by @hyf0
- spawn `RuntimeModuleTask` after `build_start` to avoid race condition (#8182) by @shulaoda
- rust/dev: only close after the ongoing task finished (#8147) by @hyf0
- ensure `\0rolldown/runtime.js` will go through transform hook and add test (#8093) by @hyf0
- `[name]` in `assetFileNames` does not include the directory part (#8098) by @IWANABETHATGUY
- handle external module properties in namespace imports (#8124) by @IWANABETHATGUY
- keep user-defined entry modules in their own chunks (#8047) by @IWANABETHATGUY
- avoid `Unknown resolve error` error message (#8111) by @sapphi-red

### 💼 Other

- remove warnings  for building rolldown with `not(feature = "experimental")` (#8110) by @coolreader18

### 🚜 Refactor

- move `VERSION` to `constants` directory (#8200) by @shulaoda
- simplify import symbol check using `SymbolFlags` (#8193) by @shulaoda
- extract tsconfig option and transform options merging logic (#8168) by @sapphi-red
- filter empty module_groups before sorting (#8149) by @ShroXd
- lazy-barrel: use single `remove` instead of `contains_key` + `remove` (#8123) by @shulaoda
- lazy-barrel: avoid redundant call and inline `get_barrel_normal_module` (#8122) by @shulaoda
- use logger instead of console.log for warnings (#8117) by @IWANABETHATGUY
- module-loader: remove intermediate ModuleTaskOwnerRef type (#8113) by @shulaoda
- rename ReExportExternalModule to ReExportDynamicExports (#8104) by @IWANABETHATGUY

### 📚 Documentation

- add dynamic OG image generation (#8192) by @sapphi-red
- add dynamic OG image generation (#8191) by @sapphi-red
- add dynamic OG image generation (#8179) by @Copilot
- apis: add links to option descriptions in JSDoc comments (#8167) by @sapphi-red
- apis: clarify parameters of `resolveDynamicImport` hook (#8137) by @sapphi-red
- lazy-barrel: clarify default export behavior (#8128) by @shulaoda

### ⚡ Performance

- remove unnecessary assignment for default export (#8127) by @shulaoda

### 🧪 Testing

- dev: `this.addWatchFile` dependency should be preserved after reload (#8165) by @sapphi-red
- mark flaky `transform_runtime_module` test as ignored (#8178) by @Copilot
- rolldown_sourcemap: add test for coarse segments (#8166) by @sapphi-red
- dev: correctly assert file change (#8164) by @sapphi-red
- rust: `transform_runtime_module` test shouldn't panic inside (#8151) by @hyf0
- rust: fix flakiness of rust tests (#8150) by @hyf0
- mark `output.dynamicImportInCjs` tests as passed (#8125) by @shulaoda
- lazy-barrel: add test cases for default export (#8129) by @shulaoda
- rolldown_plugin_vite_manifest: use relative path for outPath (#8101) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.43.1 (#8188) by @renovate[bot]
- deps: update rust crate ts-rs to v12 (#8160) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.0 (#8175) by @renovate[bot]
- deps: update rust crates (#8157) by @renovate[bot]
- deps: update oxc to v0.112.0 (#8171) by @renovate[bot]
- deps: update rollup submodule for tests to v4.57.1 (#8176) by @sapphi-red
- deps: update test262 submodule for tests (#8177) by @sapphi-red
- deps: update dependency oxlint to v1.43.0 (#8173) by @renovate[bot]
- deps: update dependency oxfmt to ^0.28.0 (#8170) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.8 (#8163) by @renovate[bot]
- deps: update dependency vue-router to v5 (#8159) by @renovate[bot]
- deps: update github-actions (#8158) by @renovate[bot]
- deps: update npm packages (#8156) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.4 (#8140) by @renovate[bot]
- fix clippy replacement typo (#8136) by @IWANABETHATGUY
- disallow `HashMap::new` and `HashSet::new` by clippy (#8135) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.21.7 (#8126) by @renovate[bot]
- deps: update oxc resolver to v11.17.0 (#8121) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.3 (#8109) by @renovate[bot]

### ❤️ New Contributors

* @coolreader18 made their first contribution in [#8110](#8110)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: vite-tests Trigger Vite tests workflow on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Rolldown creates unnecessary facade chunks

2 participants