Skip to content

Comments

chore(debug): add IdxExt debug trait for human-readable index debugging#8045

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-25-chore_debug_add_idxext_debug_trait_for_human-readable_index_debugging
Jan 25, 2026
Merged

chore(debug): add IdxExt debug trait for human-readable index debugging#8045
graphite-app[bot] merged 1 commit intomainfrom
01-25-chore_debug_add_idxext_debug_trait_for_human-readable_index_debugging

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 25, 2026 08:39
Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI review requested due to automatic review settings January 25, 2026 08:39
@netlify
Copy link

netlify bot commented Jan 25, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b85b7f8
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6975d6a4cf7f430008680899

@IWANABETHATGUY IWANABETHATGUY requested review from hyf0 and shulaoda and removed request for Copilot January 25, 2026 08:41
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-25-chore_debug_add_idxext_debug_trait_for_human-readable_index_debugging branch from f97f971 to ebe8c47 Compare January 25, 2026 08:41
Copilot AI review requested due to automatic review settings January 25, 2026 08:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new debug trait IdxExt for generating human-readable debug output from index types like ModuleIdx and ChunkIdx. The trait is conditionally exported only when debug_assertions is enabled, making it suitable for debugging purposes without affecting production builds.

Changes:

  • Introduced IdxExt trait with debug method for context-aware debugging of index types
  • Implemented trait for ModuleIdx, ChunkIdx, and collection types (Vec, FxHashSet, FxHashMap)
  • Added conditional export behind #[cfg(debug_assertions)] flag

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
crates/rolldown_common/src/types/idx_ext.rs New file defining the IdxExt trait and implementations for index types and collections
crates/rolldown_common/src/types/mod.rs Added module declaration for idx_ext
crates/rolldown_common/src/lib.rs Conditionally exported IdxExt trait for debug builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@netlify
Copy link

netlify bot commented Jan 25, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit f97f971
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6975d6e3b1f77e0008757f51

@netlify
Copy link

netlify bot commented Jan 25, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6f552c8
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6975ddeef34eaf0008e010cd

@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-25-chore_debug_add_idxext_debug_trait_for_human-readable_index_debugging branch from ebe8c47 to fd566a3 Compare January 25, 2026 08:49
Copilot AI review requested due to automatic review settings January 25, 2026 08:54
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-25-chore_debug_add_idxext_debug_trait_for_human-readable_index_debugging branch from fd566a3 to 2116efe Compare January 25, 2026 08:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2026

Benchmarks Rust

  • target: main(64a55c3)
  • pr: 01-25-chore_debug_add_idxext_debug_trait_for_human-readable_index_debugging(6f552c8)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     70.4±2.09ms        ? ?/sec    1.00     69.3±1.81ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     75.9±1.90ms        ? ?/sec    1.00     76.2±1.89ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    101.3±1.88ms        ? ?/sec    1.00    100.9±1.62ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    112.3±1.78ms        ? ?/sec    1.00    111.9±1.73ms        ? ?/sec
bundle/bundle@threejs                                        1.00     37.0±2.49ms        ? ?/sec    1.01     37.2±2.61ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.9±0.71ms        ? ?/sec    1.01     41.1±0.63ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    368.2±3.78ms        ? ?/sec    1.00    369.7±5.11ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    424.3±3.60ms        ? ?/sec    1.00    425.6±4.75ms        ? ?/sec
scan/scan@rome_ts                                            1.01     81.9±2.67ms        ? ?/sec    1.00     81.5±2.28ms        ? ?/sec
scan/scan@threejs                                            1.00     28.1±0.83ms        ? ?/sec    1.01     28.4±1.42ms        ? ?/sec
scan/scan@threejs10x                                         1.00    285.4±3.93ms        ? ?/sec    1.01    287.3±4.10ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 25, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-25-chore_debug_add_idxext_debug_trait_for_human-readable_index_debugging branch from 2116efe to 6f552c8 Compare January 25, 2026 09:10
@graphite-app graphite-app bot merged commit 6f552c8 into main Jan 25, 2026
35 checks passed
@graphite-app graphite-app bot deleted the 01-25-chore_debug_add_idxext_debug_trait_for_human-readable_index_debugging branch January 25, 2026 09:20
@github-actions github-actions bot mentioned this pull request Jan 28, 2026
@github-actions github-actions bot mentioned this pull request Jan 28, 2026
shulaoda added a commit that referenced this pull request Jan 28, 2026
## [1.0.0-rc.2] - 2026-01-28

⚡ Lazy Barrel Optimization

- Skips compilation of unused re-export modules in side-effect-free barrel modules
- Particularly beneficial for projects importing from large component libraries

For large component libraries like Ant Design, when you import just one component:

```js
import { Button } from 'antd';
Button;
```

| Metric                    | Without lazy barrel | With lazy barrel |
| -------------------- | --------------------- | ---------------- |
| Modules compiled | 2986                       | 250              |
| Build time               | ~210ms                  | ~50ms            |

By enabling lazy barrel, Rolldown reduces the number of compiled modules by 90% and speeds up the build by 2-4x. 

Enable it in your config:

```js
export default {
  experimental: {
    lazyBarrel: true,
  },
};
```

For more details, see the https://rolldown.rs/in-depth/lazy-barrel-optimization

### 💥 BREAKING CHANGES

- expose `\0rolldown/runtime` in transform hook (#8068) by @hyf0
- rename `rolldown:runtime` to `\0rolldown/runtime.js` (#8067) by @hyf0

### 🚀 Features

- remove inlined constants in smart mode (#8085) by @sapphi-red
- allow more options for `this.emitFile` with `type: 'prebuilt-chunk'` (#8062) by @sapphi-red
- warn when both code and postBanner contain shebang (#8039) by @Copilot

### 🐛 Bug Fixes

- update the links to Rolldown docs in the error messages (#8103) by @sapphi-red
- handle tsconfig.json load errors (#8105) by @sapphi-red
- include inlined constants in namespace object (#8099) by @sapphi-red
- vite test ci (#8084) by @IWANABETHATGUY
- renamer: nested binding shadowing external module namespace in UMD/IIFE formats (#8083) by @Dunqing
- deduplicate ESM chunk imports by canonical symbol (#8059) by @IWANABETHATGUY
- refine side-effect detection for BigInt and RegExp (#8060) by @IWANABETHATGUY
- rust: use string literal span for `new URL` error diagnostic (#8043) by @valadaptive
- rust: use ModuleType::Asset for `new URL` imports (#8035) by @valadaptive
- CJS-ESM interop - property assignment on CJS module exports (#8006) by @IWANABETHATGUY
- eliminate the facade chunk if the dynamic entry module has been merged into common chunk (#8046) by @IWANABETHATGUY
- Inlining dynamic imports broken with multiple entry points (#8037) by @IWANABETHATGUY
- devtools: revert `Chunk#id` to `Chunk#chunk_id` (#8040) by @hyf0
- invert `__exportAll` parameter logic to reduce default output size (#8036) by @Copilot
- `</script` tag search should be case insensitive (#8033) by @IWANABETHATGUY
- use directory name as-is for the variable name even if the name contained `.` (#8029) by @Copilot
- dev/lazy: remove unnecessary rewrite from top level `this` to `undefined` (#8020) by @hyf0
- dev/lazy: should keep lazy entries imports for patch file (#8019) by @hyf0
- `output.generatedCode.preset: 'es2015'` was not set by default (#8026) by @sapphi-red
- node: align option validator to types (#8023) by @sapphi-red
- node: allow `output.strictExecutionOrder` by the option validator (#8022) by @sapphi-red
- types: return `this` from on / off methods of `RolldownWatcher` (#8015) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_vite_dynamic_import_vars: remove v1 implementation (#8096) by @shulaoda
- rolldown_plugin_vite_import_glob: remove v1 implementation (#8095) by @shulaoda
- lazy-barrel: restructure lazy barrel implementation (#8070) by @shulaoda
- remove `use_built_ins` and `use_spread` from internal JSX options (#8079) by @sapphi-red
- remove `experimental.transformHiresSourcemap` (#8055) by @Copilot
- rust: use `is_data_url` more consistently (#8042) by @valadaptive
- use `FxIndexMap` to store EntryPoint (#8032) by @IWANABETHATGUY
- node: add type checks that ensures validator schema is up to date with types (#8024) by @sapphi-red

### 📚 Documentation

- link to vite plugin registry (#8086) by @sapphi-red
- lazy-barrel: improve documentation and enable in sidebar (#8072) by @shulaoda
- add more examples and details (#8054) by @sapphi-red
- in-depth: add dead code elimination page (#8007) by @sapphi-red
- update status from beta to release candidate (#8012) by @shulaoda

### ⚡ Performance

- run inline-const pass for modules that are affected by inlining (#8064) by @sapphi-red

### 🧪 Testing

- lazy-barrel: use package.json sideEffects instead of plugin hook (#8077) by @shulaoda
- lazy-barrel: enable tests and add treeshake-behavior cases (#8071) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.42.3 (#8087) by @renovate[bot]
- deps: update rollup submodule for tests to v4.56.0 (#8073) by @sapphi-red
- deps: update oxc to v0.111.0 (#8063) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.6 (#8076) by @renovate[bot]
- deps: update test262 submodule for tests (#8074) by @sapphi-red
- deps: update crate-ci/typos action to v1.42.2 (#8069) by @renovate[bot]
- deps: update oxc apps (#8066) by @renovate[bot]
- remove `{@include ./foo.md}` from d.ts files (#8056) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.11.2 (#8057) by @renovate[bot]
- deps: update github-actions (#8050) by @renovate[bot]
- deps: update npm packages (#8051) by @renovate[bot]
- deps: update rust crates (#8049) by @renovate[bot]
- debug: add IdxExt debug trait for human-readable index debugging (#8045) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.21.5 (#8034) by @renovate[bot]
- deps: update oxc resolver to v11.16.4 (#8031) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.4 (#8030) by @renovate[bot]
- deps: update dependency rust to v1.93.0 (#8018) by @renovate[bot]
- archive 2025 beta changelog (#8014) by @shulaoda
- update release workflow version pattern from beta to rc (#8013) by @shulaoda

### ❤️ New Contributors

* @valadaptive made their first contribution in [#8043](#8043)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants