Skip to content

Comments

refactor: use FxIndexMap to store EntryPoint#8032

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-23-refactor_use_fxindexmap_to_store_entrypoint_
Jan 24, 2026
Merged

refactor: use FxIndexMap to store EntryPoint#8032
graphite-app[bot] merged 1 commit intomainfrom
01-23-refactor_use_fxindexmap_to_store_entrypoint_

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jan 23, 2026

This modification make get the dynamic importer of dynamic entry module more easy(Used in chunk optimizer).
Also use FxIndexMap to store EntryPoint could speed up lookup performance in some place

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 9b7971a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/697472c765b5010008f0b410

@IWANABETHATGUY IWANABETHATGUY changed the title refactor: use FxIndexMap to store EntryPoint" refactor: support multiple entry points per module Jan 23, 2026
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-23-refactor_use_fxindexmap_to_store_entrypoint_ branch 3 times, most recently from 5a56a46 to 14ace31 Compare January 23, 2026 14:54
@IWANABETHATGUY IWANABETHATGUY changed the title refactor: support multiple entry points per module refactor: use FxIndexMap to store EntryPoint Jan 23, 2026
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 23, 2026 14:55
Copilot AI review requested due to automatic review settings January 23, 2026 14:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the entry point storage from Vec<EntryPoint> to FxIndexMap<ModuleIdx, Vec<EntryPoint>> to support scenarios where multiple entry points can reference the same module (e.g., when this.emitFile() is called multiple times for the same module).

Changes:

  • Changed the entries field type from Vec<EntryPoint> to FxIndexMap<ModuleIdx, Vec<EntryPoint>> in LinkStage and LinkStageOutput
  • Updated all code that iterates over entries to use .keys(), .values().flatten(), or .flat_map() patterns
  • Modified entry initialization to group entry points by module index
  • Optimized determine_module_exports_kind by using contains_key instead of building a FxHashSet

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
crates/rolldown/src/stages/link_stage/mod.rs Changed entries type and added initialization logic to group entry points by module index
crates/rolldown/src/stages/link_stage/tree_shaking/include_statements.rs Updated entry partition logic and reconstruction to work with the new map structure
crates/rolldown/src/stages/link_stage/sort_modules.rs Changed iteration from .iter() to .keys() since only module indices are needed
crates/rolldown/src/stages/link_stage/determine_module_exports_kind.rs Optimized to use contains_key instead of building a separate HashSet
crates/rolldown/src/stages/link_stage/cross_module_optimization.rs Updated to iterate with .values().flatten() to process all entry points
crates/rolldown/src/stages/link_stage/create_exports_for_ecma_modules.rs Changed to use .get() and .first() pattern, only processing first entry point per module
crates/rolldown/src/stages/generate_stage/code_splitting.rs Updated entry counting, iteration patterns, and chunk creation to handle the new structure
crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs Updated filtering logic to check if any entry in a module is user-defined
crates/rolldown/src/stages/generate_stage/chunk_ext.rs Updated debug output to work with the new map structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Benchmarks Rust

  • target: main(56075b5)
  • pr: 01-23-refactor_use_fxindexmap_to_store_entrypoint_(9b7971a)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     69.6±1.90ms        ? ?/sec    1.04     72.7±2.18ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     76.2±2.13ms        ? ?/sec    1.02     77.6±1.65ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    102.7±2.87ms        ? ?/sec    1.01    103.4±3.18ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    114.4±1.76ms        ? ?/sec    1.02    116.2±2.85ms        ? ?/sec
bundle/bundle@threejs                                        1.00     36.8±2.64ms        ? ?/sec    1.01     37.0±1.98ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     41.2±0.76ms        ? ?/sec    1.02     41.9±0.94ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    377.4±6.19ms        ? ?/sec    1.00    376.3±6.53ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.03    445.4±6.77ms        ? ?/sec    1.00    432.6±5.86ms        ? ?/sec
scan/scan@rome_ts                                            1.05     85.9±1.82ms        ? ?/sec    1.00     81.8±2.22ms        ? ?/sec
scan/scan@threejs                                            1.04     29.8±1.70ms        ? ?/sec    1.00     28.6±1.57ms        ? ?/sec
scan/scan@threejs10x                                         1.01    294.5±4.32ms        ? ?/sec    1.00    290.4±6.42ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-23-refactor_use_fxindexmap_to_store_entrypoint_ branch from 14ace31 to 0370543 Compare January 23, 2026 17:21
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 24, 2026

Merge activity

This modification make get the dynamic importer of dynamic entry module more easy(Used in chunk optimizer).
Also use `FxIndexMap` to store `EntryPoint` could speed up lookup performance in some place
@graphite-app graphite-app bot force-pushed the 01-23-refactor_use_fxindexmap_to_store_entrypoint_ branch from 0370543 to 9b7971a Compare January 24, 2026 07:20
@graphite-app graphite-app bot merged commit 9b7971a into main Jan 24, 2026
35 checks passed
@graphite-app graphite-app bot deleted the 01-23-refactor_use_fxindexmap_to_store_entrypoint_ branch January 24, 2026 07:31
This was referenced Jan 28, 2026
shulaoda added a commit that referenced this pull request Jan 28, 2026
## [1.0.0-rc.2] - 2026-01-28

⚡ Lazy Barrel Optimization

- Skips compilation of unused re-export modules in side-effect-free barrel modules
- Particularly beneficial for projects importing from large component libraries

For large component libraries like Ant Design, when you import just one component:

```js
import { Button } from 'antd';
Button;
```

| Metric                    | Without lazy barrel | With lazy barrel |
| -------------------- | --------------------- | ---------------- |
| Modules compiled | 2986                       | 250              |
| Build time               | ~210ms                  | ~50ms            |

By enabling lazy barrel, Rolldown reduces the number of compiled modules by 90% and speeds up the build by 2-4x. 

Enable it in your config:

```js
export default {
  experimental: {
    lazyBarrel: true,
  },
};
```

For more details, see the https://rolldown.rs/in-depth/lazy-barrel-optimization

### 💥 BREAKING CHANGES

- expose `\0rolldown/runtime` in transform hook (#8068) by @hyf0
- rename `rolldown:runtime` to `\0rolldown/runtime.js` (#8067) by @hyf0

### 🚀 Features

- remove inlined constants in smart mode (#8085) by @sapphi-red
- allow more options for `this.emitFile` with `type: 'prebuilt-chunk'` (#8062) by @sapphi-red
- warn when both code and postBanner contain shebang (#8039) by @Copilot

### 🐛 Bug Fixes

- update the links to Rolldown docs in the error messages (#8103) by @sapphi-red
- handle tsconfig.json load errors (#8105) by @sapphi-red
- include inlined constants in namespace object (#8099) by @sapphi-red
- vite test ci (#8084) by @IWANABETHATGUY
- renamer: nested binding shadowing external module namespace in UMD/IIFE formats (#8083) by @Dunqing
- deduplicate ESM chunk imports by canonical symbol (#8059) by @IWANABETHATGUY
- refine side-effect detection for BigInt and RegExp (#8060) by @IWANABETHATGUY
- rust: use string literal span for `new URL` error diagnostic (#8043) by @valadaptive
- rust: use ModuleType::Asset for `new URL` imports (#8035) by @valadaptive
- CJS-ESM interop - property assignment on CJS module exports (#8006) by @IWANABETHATGUY
- eliminate the facade chunk if the dynamic entry module has been merged into common chunk (#8046) by @IWANABETHATGUY
- Inlining dynamic imports broken with multiple entry points (#8037) by @IWANABETHATGUY
- devtools: revert `Chunk#id` to `Chunk#chunk_id` (#8040) by @hyf0
- invert `__exportAll` parameter logic to reduce default output size (#8036) by @Copilot
- `</script` tag search should be case insensitive (#8033) by @IWANABETHATGUY
- use directory name as-is for the variable name even if the name contained `.` (#8029) by @Copilot
- dev/lazy: remove unnecessary rewrite from top level `this` to `undefined` (#8020) by @hyf0
- dev/lazy: should keep lazy entries imports for patch file (#8019) by @hyf0
- `output.generatedCode.preset: 'es2015'` was not set by default (#8026) by @sapphi-red
- node: align option validator to types (#8023) by @sapphi-red
- node: allow `output.strictExecutionOrder` by the option validator (#8022) by @sapphi-red
- types: return `this` from on / off methods of `RolldownWatcher` (#8015) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_vite_dynamic_import_vars: remove v1 implementation (#8096) by @shulaoda
- rolldown_plugin_vite_import_glob: remove v1 implementation (#8095) by @shulaoda
- lazy-barrel: restructure lazy barrel implementation (#8070) by @shulaoda
- remove `use_built_ins` and `use_spread` from internal JSX options (#8079) by @sapphi-red
- remove `experimental.transformHiresSourcemap` (#8055) by @Copilot
- rust: use `is_data_url` more consistently (#8042) by @valadaptive
- use `FxIndexMap` to store EntryPoint (#8032) by @IWANABETHATGUY
- node: add type checks that ensures validator schema is up to date with types (#8024) by @sapphi-red

### 📚 Documentation

- link to vite plugin registry (#8086) by @sapphi-red
- lazy-barrel: improve documentation and enable in sidebar (#8072) by @shulaoda
- add more examples and details (#8054) by @sapphi-red
- in-depth: add dead code elimination page (#8007) by @sapphi-red
- update status from beta to release candidate (#8012) by @shulaoda

### ⚡ Performance

- run inline-const pass for modules that are affected by inlining (#8064) by @sapphi-red

### 🧪 Testing

- lazy-barrel: use package.json sideEffects instead of plugin hook (#8077) by @shulaoda
- lazy-barrel: enable tests and add treeshake-behavior cases (#8071) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.42.3 (#8087) by @renovate[bot]
- deps: update rollup submodule for tests to v4.56.0 (#8073) by @sapphi-red
- deps: update oxc to v0.111.0 (#8063) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.6 (#8076) by @renovate[bot]
- deps: update test262 submodule for tests (#8074) by @sapphi-red
- deps: update crate-ci/typos action to v1.42.2 (#8069) by @renovate[bot]
- deps: update oxc apps (#8066) by @renovate[bot]
- remove `{@include ./foo.md}` from d.ts files (#8056) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.11.2 (#8057) by @renovate[bot]
- deps: update github-actions (#8050) by @renovate[bot]
- deps: update npm packages (#8051) by @renovate[bot]
- deps: update rust crates (#8049) by @renovate[bot]
- debug: add IdxExt debug trait for human-readable index debugging (#8045) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.21.5 (#8034) by @renovate[bot]
- deps: update oxc resolver to v11.16.4 (#8031) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.4 (#8030) by @renovate[bot]
- deps: update dependency rust to v1.93.0 (#8018) by @renovate[bot]
- archive 2025 beta changelog (#8014) by @shulaoda
- update release workflow version pattern from beta to rc (#8013) by @shulaoda

### ❤️ New Contributors

* @valadaptive made their first contribution in [#8043](#8043)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants