Skip to content

Comments

fix: output.generatedCode.preset: 'es2015' was not set by default#8026

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-23-fix_output.generatedcode.preset_es2015_was_not_set_by_default
Jan 23, 2026
Merged

fix: output.generatedCode.preset: 'es2015' was not set by default#8026
graphite-app[bot] merged 1 commit intomainfrom
01-23-fix_output.generatedcode.preset_es2015_was_not_set_by_default

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 23, 2026

output.generatedCode should have 'es2015' set by default, but it wasn't.

fixes #8017

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 097316f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69733251eca52f00088f5128

@sapphi-red sapphi-red force-pushed the 01-23-fix_output.generatedcode.preset_es2015_was_not_set_by_default branch 2 times, most recently from 362283d to 35f7966 Compare January 23, 2026 07:50
@sapphi-red sapphi-red marked this pull request as ready for review January 23, 2026 08:28
Copilot AI review requested due to automatic review settings January 23, 2026 08:28
Copy link
Member Author

sapphi-red commented Jan 23, 2026

Merge activity

  • Jan 23, 8:28 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 23, 8:32 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Jan 23, 8:43 AM UTC: Merged by the Graphite merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug where output.generatedCode.preset: 'es2015' was not set by default, which caused Vue async components to fail rendering (issue #8017).

Changes:

  • Removed the preset field from GeneratedCodeOptions struct and made es2015 (symbols: true) the default
  • Updated binding normalization to maintain backward compatibility with preset option
  • Updated JSON schema to remove preset field
  • Updated all test snapshots to reflect Symbol.toStringTag now being included in generated code by default

Reviewed changes

Copilot reviewed 277 out of 278 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/rolldown_common/src/inner_bundler_options/types/generated_code_options.rs Removed preset field, made es2015() the default implementation
crates/rolldown_binding/src/utils/normalize_binding_options.rs Simplified normalization logic while maintaining backward compatibility
crates/rolldown_testing/_config.schema.json Removed preset field from schema
packages/rollup-tests/test/function/index.js Explicitly set es5 preset for Rollup compatibility tests
packages/rollup-tests/test/form/index.js Explicitly set es5 preset for Rollup compatibility tests
Test snapshots (150+ files) Updated to reflect Symbol.toStringTag now being included by default
Files not reviewed (1)
  • crates/rolldown/tests/rolldown/function/advanced_chunks/split_node_modules/artifacts.snap: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…8026)

`output.generatedCode` should have `'es2015'` set by default, but it wasn't.

fixes #8017
@graphite-app graphite-app bot force-pushed the 01-23-fix_output.generatedcode.preset_es2015_was_not_set_by_default branch from 35f7966 to 097316f Compare January 23, 2026 08:33
@graphite-app graphite-app bot merged commit 097316f into main Jan 23, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 01-23-fix_output.generatedcode.preset_es2015_was_not_set_by_default branch January 23, 2026 08:43
sapphi-red added a commit that referenced this pull request Jan 24, 2026
…ze (#8036)

## Summary

This PR implements the optimization requested in #8026 to reduce output
code size by inverting the logic of the `__exportAll` function's second
parameter.

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: sapphi-red <[email protected]>
This was referenced Jan 28, 2026
shulaoda added a commit that referenced this pull request Jan 28, 2026
## [1.0.0-rc.2] - 2026-01-28

⚡ Lazy Barrel Optimization

- Skips compilation of unused re-export modules in side-effect-free barrel modules
- Particularly beneficial for projects importing from large component libraries

For large component libraries like Ant Design, when you import just one component:

```js
import { Button } from 'antd';
Button;
```

| Metric                    | Without lazy barrel | With lazy barrel |
| -------------------- | --------------------- | ---------------- |
| Modules compiled | 2986                       | 250              |
| Build time               | ~210ms                  | ~50ms            |

By enabling lazy barrel, Rolldown reduces the number of compiled modules by 90% and speeds up the build by 2-4x. 

Enable it in your config:

```js
export default {
  experimental: {
    lazyBarrel: true,
  },
};
```

For more details, see the https://rolldown.rs/in-depth/lazy-barrel-optimization

### 💥 BREAKING CHANGES

- expose `\0rolldown/runtime` in transform hook (#8068) by @hyf0
- rename `rolldown:runtime` to `\0rolldown/runtime.js` (#8067) by @hyf0

### 🚀 Features

- remove inlined constants in smart mode (#8085) by @sapphi-red
- allow more options for `this.emitFile` with `type: 'prebuilt-chunk'` (#8062) by @sapphi-red
- warn when both code and postBanner contain shebang (#8039) by @Copilot

### 🐛 Bug Fixes

- update the links to Rolldown docs in the error messages (#8103) by @sapphi-red
- handle tsconfig.json load errors (#8105) by @sapphi-red
- include inlined constants in namespace object (#8099) by @sapphi-red
- vite test ci (#8084) by @IWANABETHATGUY
- renamer: nested binding shadowing external module namespace in UMD/IIFE formats (#8083) by @Dunqing
- deduplicate ESM chunk imports by canonical symbol (#8059) by @IWANABETHATGUY
- refine side-effect detection for BigInt and RegExp (#8060) by @IWANABETHATGUY
- rust: use string literal span for `new URL` error diagnostic (#8043) by @valadaptive
- rust: use ModuleType::Asset for `new URL` imports (#8035) by @valadaptive
- CJS-ESM interop - property assignment on CJS module exports (#8006) by @IWANABETHATGUY
- eliminate the facade chunk if the dynamic entry module has been merged into common chunk (#8046) by @IWANABETHATGUY
- Inlining dynamic imports broken with multiple entry points (#8037) by @IWANABETHATGUY
- devtools: revert `Chunk#id` to `Chunk#chunk_id` (#8040) by @hyf0
- invert `__exportAll` parameter logic to reduce default output size (#8036) by @Copilot
- `</script` tag search should be case insensitive (#8033) by @IWANABETHATGUY
- use directory name as-is for the variable name even if the name contained `.` (#8029) by @Copilot
- dev/lazy: remove unnecessary rewrite from top level `this` to `undefined` (#8020) by @hyf0
- dev/lazy: should keep lazy entries imports for patch file (#8019) by @hyf0
- `output.generatedCode.preset: 'es2015'` was not set by default (#8026) by @sapphi-red
- node: align option validator to types (#8023) by @sapphi-red
- node: allow `output.strictExecutionOrder` by the option validator (#8022) by @sapphi-red
- types: return `this` from on / off methods of `RolldownWatcher` (#8015) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_vite_dynamic_import_vars: remove v1 implementation (#8096) by @shulaoda
- rolldown_plugin_vite_import_glob: remove v1 implementation (#8095) by @shulaoda
- lazy-barrel: restructure lazy barrel implementation (#8070) by @shulaoda
- remove `use_built_ins` and `use_spread` from internal JSX options (#8079) by @sapphi-red
- remove `experimental.transformHiresSourcemap` (#8055) by @Copilot
- rust: use `is_data_url` more consistently (#8042) by @valadaptive
- use `FxIndexMap` to store EntryPoint (#8032) by @IWANABETHATGUY
- node: add type checks that ensures validator schema is up to date with types (#8024) by @sapphi-red

### 📚 Documentation

- link to vite plugin registry (#8086) by @sapphi-red
- lazy-barrel: improve documentation and enable in sidebar (#8072) by @shulaoda
- add more examples and details (#8054) by @sapphi-red
- in-depth: add dead code elimination page (#8007) by @sapphi-red
- update status from beta to release candidate (#8012) by @shulaoda

### ⚡ Performance

- run inline-const pass for modules that are affected by inlining (#8064) by @sapphi-red

### 🧪 Testing

- lazy-barrel: use package.json sideEffects instead of plugin hook (#8077) by @shulaoda
- lazy-barrel: enable tests and add treeshake-behavior cases (#8071) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.42.3 (#8087) by @renovate[bot]
- deps: update rollup submodule for tests to v4.56.0 (#8073) by @sapphi-red
- deps: update oxc to v0.111.0 (#8063) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.6 (#8076) by @renovate[bot]
- deps: update test262 submodule for tests (#8074) by @sapphi-red
- deps: update crate-ci/typos action to v1.42.2 (#8069) by @renovate[bot]
- deps: update oxc apps (#8066) by @renovate[bot]
- remove `{@include ./foo.md}` from d.ts files (#8056) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.11.2 (#8057) by @renovate[bot]
- deps: update github-actions (#8050) by @renovate[bot]
- deps: update npm packages (#8051) by @renovate[bot]
- deps: update rust crates (#8049) by @renovate[bot]
- debug: add IdxExt debug trait for human-readable index debugging (#8045) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to v0.21.5 (#8034) by @renovate[bot]
- deps: update oxc resolver to v11.16.4 (#8031) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.4 (#8030) by @renovate[bot]
- deps: update dependency rust to v1.93.0 (#8018) by @renovate[bot]
- archive 2025 beta changelog (#8014) by @shulaoda
- update release workflow version pattern from beta to rc (#8013) by @shulaoda

### ❤️ New Contributors

* @valadaptive made their first contribution in [#8043](#8043)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Vue async component not rendered with code splitting

2 participants