chore: enable `tagged_template_transform ` uncondionally by IWANABETHATGUY · Pull Request #7975 · rolldown/rolldown

IWANABETHATGUY · 2026-01-20T18:09:09Z

related discussion:

IWANABETHATGUY · 2026-01-20T18:09:25Z

chore: enable tagged_template_transform uncondionally #7975 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-20T18:10:24Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`e173aeb`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69706677c4cdd9000845cb5f

Copilot

Pull request overview

This PR enables the tagged_template_transform feature unconditionally in the oxc transformer to ensure proper escaping of </script> sequences in template literals, preventing potential HTML injection issues when JavaScript is embedded in HTML script tags.

Changes:

Enabled tagged_template_transform by changing the value from false to true in the oxc transformer plugin options
Added comprehensive test case for issue #6829 to verify proper escaping behavior
Updated hash snapshot to include the new test case

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`crates/rolldown_common/src/inner_bundler_options/types/transform_option/plugin_options.rs`	Enabled `tagged_template_transform` unconditionally by changing the hardcoded value from `false` to `true`
`crates/rolldown/tests/rolldown/issues/6829/main.js`	Added test input with both tagged and regular template literals containing `</script>`
`crates/rolldown/tests/rolldown/issues/6829/_test.mjs`	Added test assertions to verify that `</script>` is properly escaped to `<\/script>` in the output
`crates/rolldown/tests/rolldown/issues/6829/_config.json`	Added test configuration for the new test case
`crates/rolldown/tests/rolldown/issues/6829/artifacts.snap`	Added snapshot showing expected escaped output
`crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap`	Updated hash snapshot to include the new test case entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/tests/rolldown/issues/6829/_test.mjs

crates/rolldown/tests/rolldown/issues/6829/main.js

github-actions · 2026-01-20T18:45:24Z

Benchmarks Rust

target: main(9e35ade)
pr: 01-21-fix_6829(e173aeb)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     71.2±2.27ms        ? ?/sec    1.00     70.6±2.13ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     77.6±2.45ms        ? ?/sec    1.00     76.8±2.23ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    103.2±2.45ms        ? ?/sec    1.00    103.7±2.34ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    113.9±3.09ms        ? ?/sec    1.01    115.0±2.38ms        ? ?/sec
bundle/bundle@threejs                                        1.02     37.0±2.20ms        ? ?/sec    1.00     36.2±0.83ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     41.7±1.35ms        ? ?/sec    1.00     41.2±0.93ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    373.1±4.37ms        ? ?/sec    1.00    374.6±5.62ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    433.0±6.16ms        ? ?/sec    1.00    432.3±5.32ms        ? ?/sec
scan/scan@rome_ts                                            1.00     83.5±1.91ms        ? ?/sec    1.00     83.7±2.03ms        ? ?/sec
scan/scan@threejs                                            1.01     28.8±1.77ms        ? ?/sec    1.00     28.6±0.59ms        ? ?/sec
scan/scan@threejs10x                                         1.00    292.5±4.59ms        ? ?/sec    1.01    295.1±5.63ms        ? ?/sec

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graphite-app · 2026-01-21T05:38:39Z

Merge activity

Jan 21, 5:38 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 21, 5:53 AM UTC: Merged by the Graphite merge queue.

related discussion: - #7098 (comment) - #6829 (comment) closed #6829

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

sapphi-red · 2026-01-21T06:50:05Z

crates/rolldown/tests/rolldown/issues/6829/_test.mjs

+const content = nodeFs.readFileSync(nodePath.join(import.meta.dirname, "dist/main.js"), "utf-8");
+
+// Template literals containing </script> should be emitted with it escaped as <\/script> to avoid breaking HTML script tags
+nodeAssert(content.includes("String.raw`<\\/script>`"));


This test case is not correct. This assertion should be like

nodeAssert(content.includes("String.raw(_foo || (_foo = babelHelpers.tagedTemplateLiteral(["<\/script>"])))"));

https://github.com/oxc-project/oxc/pull/15664/files#diff-6901e0dc661cb317b502e57fa4fa194f42efc1c68c9e1b2c79bc3a410013ce4dR32

@IWANABETHATGUY

## [1.0.0-rc.1] - 2026-01-22 ### 🚀 Features - debug_info: add facade chunk elimination reason (#7980) by @IWANABETHATGUY - support lazy barrel optimization (#7933) by @shulaoda - add `experimental.lazyBarrel` option (#7908) by @shulaoda - skip unused external modules from IIFE parameter list (#7978) by @sapphi-red - add custom panic hook for better crash reporting (#7752) by @shulaoda - treeshake: add `invalidImportSideEffects` option (#7958) by @shulaoda - merge allow-extension emitted chunks (#7940) by @IWANABETHATGUY - nativeMagicString generateMap (#7944) by @IWANABETHATGUY - Include meta.magicString in RenderChunkMeta (#7943) by @IWANABETHATGUY - debug_info: add debug info for eliminated facade chunks (#7946) by @IWANABETHATGUY - stablize `strictExecutionOrder` and move to `output.strictExecutionOrder` from `experimental.strictExecutionOrder` (#7901) by @sapphi-red - add documentation link to require() error message (#7898) by @Copilot - add `codeSplitting: boolean` and deprecate `inlineDynamicImports` (#7870) by @hyf0 - dev: change lazy module URL to `/@vite/lazy` from `/lazy` (#7884) by @sapphi-red ### 🐛 Bug Fixes - transform JS files containing `</script>` to escape template literals (#7987) by @IWANABETHATGUY - apply avoid-breaking-exported-api = false to clippy.toml and fix clippy errors (#7982) by @Boshen - pass `kind` from `this.resolve` (#7981) by @sapphi-red - rolldown_plugin_vite_resolve: ignore yarn resolution errors and fallback to other resolvers (#7968) by @sapphi-red - renamer: prevent renaming symbols when there no conflicts (#7936) by @Dunqing - correct minifyInterExports when emitted chunk got merged (#7941) by @IWANABETHATGUY - deduplicate entry points when module is both emitted and dynamically imported (#7885) by @IWANABETHATGUY - dev: add `@vite-ignore` to lazy compilation proxy module import (#7883) by @sapphi-red ### 🚜 Refactor - rust: enable clippy nursery lint group (#8002) by @Boshen - rust: fix inconsistent_struct_constructor clippy lint (#7999) by @Boshen - rust: fix needless_pass_by_ref_mut clippy lint (#7994) by @Boshen - rust: fix unnecessary_wraps clippy lint (#7993) by @Boshen - rust: fix enum_variant_names clippy lint (#7992) by @Boshen - fix single_match clippy lint (#7997) by @Boshen - rust: fix redundant_clone clippy lint (#7996) by @Boshen - rust: rename CJS to Cjs to follow upper_case_acronyms lint (#7991) by @Boshen - rust: remove unnecessary Box wrapper around Vec in MemberExprRef (#7990) by @Boshen - import_record: make resolved_module optional (#7907) by @shulaoda - remove unnecessary `.parse` (#7966) by @sapphi-red - remove unused `ImportRecordMeta::IsPlainImport` (#7948) by @shulaoda - proper set chunk meta (#7939) by @IWANABETHATGUY - module_loader: remove `try_spawn_with_cache` (#7920) by @shulaoda - link_stage: simplify `ImportStatus::NoMatch` to unit variant (#7909) by @shulaoda - improve global scope symbol reservation in chunk deconfliction (#7906) by @IWANABETHATGUY - simplify ast unwrapping in generate stage (#7900) by @IWANABETHATGUY - generate_stage: optimize cross-chunk imports computation (#7889) by @shulaoda - link_stage: move runtime require logic into match branch (#7892) by @shulaoda - link_stage: simplify runtime require reference conditions (#7891) by @shulaoda - link_stage: inline and simplify external dynamic import check (#7890) by @shulaoda - generate_stage: simplify external module import collection logic (#7887) by @shulaoda - avoid redundant module lookup in TLA computation (#7886) by @shulaoda - dev: `devEngine.compileEntry` does not return null (#7882) by @sapphi-red - dev: fix type errors for test HMR runtime (#7881) by @sapphi-red - dev: move `clientId` property to `DevRuntime` base class (#7880) by @sapphi-red - dev: generate client id in browser (#7878) by @hyf0 ### 📚 Documentation - apis: organize hook filters documentation and add composable filters section (#8003) by @sapphi-red - update `vitepress-plugin-group-icons` (#7947) by @yuyinws - add in-depth documentation for lazy barrel optimization (#7969) by @shulaoda - bump theme & update activeMatch for reference (#7963) by @mdong1909 - mark `build()` API as experimental (#7954) by @sapphi-red - enhance search functionality with improved scoring and filtering logic (#7935) by @hyf0 - add minor comments to multiple types (#7930) by @sapphi-red - refactor advanedChunks related content to adapt manual code splitting concept (#7925) by @hyf0 - apis: add content to Bundler API page (#7926) by @sapphi-red - apis: restructure plugin API related docs (#7924) by @sapphi-red - add plugin API docs (#7923) by @sapphi-red - apis: add docs to important APIs (#7913) by @sapphi-red - move the important APIs to the top of the sidebar (#7912) by @sapphi-red - apis: add more content to CLI documentation (#7911) by @sapphi-red - apis: generate CLI docs from --help output (#7910) by @sapphi-red - add fathom analytics (#7896) by @mdong1909 ### ⚡ Performance - use u32 for string indices in string_wizard and rolldown to reduce memory usage (#7989) by @IWANABETHATGUY - rust: remove all usages of `with_scope_tree_child_ids(true)` for `SemanticBuilder` (#7995) by @Dunqing - renamer: skip unnecessary nested scope symbol processing (#7899) by @Dunqing - module_loader: use ArcStr for importer_id to avoid string copy (#7922) by @shulaoda - module_loader: defer `ModuleTaskOwner` construction until needed (#7921) by @shulaoda - renamer: optimize symbol renaming by eliminating `rename_non_root_symbol` pass (#7867) by @Dunqing ### 🧪 Testing - add lazy barrel optimization test cases (#7967) by @shulaoda ### ⚙️ Miscellaneous Tasks - remove lazy barrel option (#8010) by @shulaoda - mark watch API as experimental (#8004) by @sapphi-red - deps: update dependency lodash-es to v4.17.23 [security] (#8001) by @renovate[bot] - git ignore zed local config (#7988) by @IWANABETHATGUY - setup publint for published packages (#7972) by @Copilot - enable `tagged_template_transform ` uncondionally (#7975) by @IWANABETHATGUY - deps: update oxc to v0.110.0 (#7964) by @renovate[bot] - deps: update oxc apps (#7962) by @renovate[bot] - ai: add upgrade-oxc Claude skill (#7957) by @Boshen - deps: update rollup submodule for tests to v4.55.2 (#7959) by @sapphi-red - deps: update test262 submodule for tests (#7960) by @sapphi-red - deps: update crate-ci/typos action to v1.42.1 (#7961) by @renovate[bot] - deps: update rust crates (#7951) by @renovate[bot] - deps: update npm packages (#7953) by @renovate[bot] - deps: update github-actions (#7952) by @renovate[bot] - deps: update npm packages (#7950) by @renovate[bot] - format magic-string test before write to disk (#7945) by @IWANABETHATGUY - deps: update dependency rolldown-plugin-dts to ^0.21.0 (#7915) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.11.1 (#7914) by @renovate[bot] - deps: update dependency diff to v8.0.3 [security] (#7904) by @renovate[bot] - remove outdated TODO comment in `collect_depended_symbols` (#7888) by @shulaoda - deps: update oxc resolver to v11.16.3 (#7876) by @renovate[bot]

github-actions bot assigned IWANABETHATGUY Jan 20, 2026

IWANABETHATGUY force-pushed the 01-21-fix_6829 branch from 1319201 to 2b01e03 Compare January 20, 2026 18:27

IWANABETHATGUY changed the title ~~fix: 6829~~ chore: enable Jan 20, 2026

IWANABETHATGUY changed the title ~~chore: enable~~ chore: enable tagged_template_transform uncondionally Jan 20, 2026

IWANABETHATGUY marked this pull request as ready for review January 20, 2026 18:29

Copilot AI review requested due to automatic review settings January 20, 2026 18:29

Copilot started reviewing on behalf of IWANABETHATGUY January 20, 2026 18:30 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

crates/rolldown/tests/rolldown/issues/6829/_test.mjs Outdated Show resolved Hide resolved

crates/rolldown/tests/rolldown/issues/6829/main.js Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings January 21, 2026 04:09

Copilot started reviewing on behalf of IWANABETHATGUY January 21, 2026 04:10 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

IWANABETHATGUY requested review from hyf0 and shulaoda January 21, 2026 04:34

shulaoda approved these changes Jan 21, 2026

View reviewed changes

chore: enable tagged_template_transform uncondionally (#7975)

e173aeb

related discussion: - #7098 (comment) - #6829 (comment) closed #6829

Copilot AI review requested due to automatic review settings January 21, 2026 05:39

graphite-app bot force-pushed the 01-21-fix_6829 branch from dea501b to e173aeb Compare January 21, 2026 05:39

Copilot AI reviewed Jan 21, 2026

View reviewed changes

graphite-app bot merged commit e173aeb into main Jan 21, 2026
35 checks passed

graphite-app bot deleted the 01-21-fix_6829 branch January 21, 2026 05:53

sapphi-red reviewed Jan 21, 2026

View reviewed changes

github-actions bot mentioned this pull request Jan 22, 2026

release: v1.0.0-rc.1 #8011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

chore: enable `tagged_template_transform` uncondionally#7975

chore: enable `tagged_template_transform` uncondionally#7975
graphite-app[bot] merged 1 commit intomainfrom
01-21-fix_6829

IWANABETHATGUY commented Jan 20, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Jan 20, 2026

Uh oh!

netlify bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

sapphi-red Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

IWANABETHATGUY commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Jan 20, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sapphi-red Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

IWANABETHATGUY commented Jan 20, 2026 •

edited

Loading

netlify bot commented Jan 20, 2026 •

edited

Loading

github-actions bot commented Jan 20, 2026 •

edited

Loading

graphite-app bot commented Jan 21, 2026 •

edited

Loading