feat(debug_info): add debug info for eliminated facade chunks by IWANABETHATGUY · Pull Request #7946 · rolldown/rolldown

IWANABETHATGUY · 2026-01-18T10:04:42Z

No description provided.

IWANABETHATGUY · 2026-01-18T10:05:07Z

feat(debug_info): add debug info for eliminated facade chunks #7946 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-18T10:05:39Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`ecac0af`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/696cbed45e06a3000834b5ac

hyf0

👍

Copilot

Pull request overview

This PR enhances the debug information system for chunks by refactoring the create_reasons field to a more structured debug_info field using an enum-based approach, and adds specific debug information for eliminated facade chunks during chunk optimization.

Changes:

Introduced ChunkDebugInfo enum to replace string-based debug reasons with structured variants
Renamed Chunk.create_reasons to Chunk.debug_info to better reflect its purpose
Added automatic tracking of eliminated facade chunks with their names and entry module IDs

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`crates/rolldown_common/src/chunk/types/chunk_debug_info.rs`	New enum definition for structured debug information with Display implementation
`crates/rolldown_common/src/chunk/types/mod.rs`	Added module declaration for chunk_debug_info
`crates/rolldown_common/src/lib.rs`	Added ChunkDebugInfo to public exports
`crates/rolldown_common/src/chunk/mod.rs`	Updated Chunk struct field from create_reasons to debug_info
`crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs`	Added logic to track eliminated facade chunks in debug info
`crates/rolldown/src/stages/generate_stage/chunk_ext.rs`	Updated to use ChunkDebugInfo::CreateReason variant
`crates/rolldown/src/ecmascript/ecma_generator.rs`	Updated debug info output formatting to use Display trait
`crates/rolldown/tests/rolldown/function/experimental/attach_debug_info/eliminated_facade_chunk/*`	Comprehensive integration test for the new feature
`crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap`	Updated hash snapshot for new test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_common/src/chunk/types/chunk_debug_info.rs

github-actions · 2026-01-18T10:31:11Z

Benchmarks Rust

target: main(9ed472f)
pr: 01-18-feat_eliminated_facade_entry(ecac0af)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     65.7±1.06ms        ? ?/sec    1.01     66.6±1.99ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     72.1±1.03ms        ? ?/sec    1.01     72.6±1.83ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    101.3±2.78ms        ? ?/sec    1.00     98.9±1.48ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    111.4±3.32ms        ? ?/sec    1.00    110.1±1.92ms        ? ?/sec
bundle/bundle@threejs                                        1.04     35.8±2.19ms        ? ?/sec    1.00     34.5±0.51ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     39.5±0.84ms        ? ?/sec    1.00     39.5±0.47ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    359.7±3.95ms        ? ?/sec    1.00    360.7±5.13ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    418.6±4.06ms        ? ?/sec    1.00    416.8±2.91ms        ? ?/sec
scan/scan@rome_ts                                            1.00     80.4±1.80ms        ? ?/sec    1.00     80.8±1.62ms        ? ?/sec
scan/scan@threejs                                            1.00     27.3±0.38ms        ? ?/sec    1.06     28.9±1.77ms        ? ?/sec
scan/scan@threejs10x                                         1.00    283.3±3.76ms        ? ?/sec    1.02    288.3±3.89ms        ? ?/sec

graphite-app · 2026-01-18T11:06:37Z

Merge activity

Jan 18, 11:06 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 18, 11:17 AM UTC: Merged by the Graphite merge queue.

@IWANABETHATGUY

## [1.0.0-rc.1] - 2026-01-22 ### 🚀 Features - debug_info: add facade chunk elimination reason (#7980) by @IWANABETHATGUY - support lazy barrel optimization (#7933) by @shulaoda - add `experimental.lazyBarrel` option (#7908) by @shulaoda - skip unused external modules from IIFE parameter list (#7978) by @sapphi-red - add custom panic hook for better crash reporting (#7752) by @shulaoda - treeshake: add `invalidImportSideEffects` option (#7958) by @shulaoda - merge allow-extension emitted chunks (#7940) by @IWANABETHATGUY - nativeMagicString generateMap (#7944) by @IWANABETHATGUY - Include meta.magicString in RenderChunkMeta (#7943) by @IWANABETHATGUY - debug_info: add debug info for eliminated facade chunks (#7946) by @IWANABETHATGUY - stablize `strictExecutionOrder` and move to `output.strictExecutionOrder` from `experimental.strictExecutionOrder` (#7901) by @sapphi-red - add documentation link to require() error message (#7898) by @Copilot - add `codeSplitting: boolean` and deprecate `inlineDynamicImports` (#7870) by @hyf0 - dev: change lazy module URL to `/@vite/lazy` from `/lazy` (#7884) by @sapphi-red ### 🐛 Bug Fixes - transform JS files containing `</script>` to escape template literals (#7987) by @IWANABETHATGUY - apply avoid-breaking-exported-api = false to clippy.toml and fix clippy errors (#7982) by @Boshen - pass `kind` from `this.resolve` (#7981) by @sapphi-red - rolldown_plugin_vite_resolve: ignore yarn resolution errors and fallback to other resolvers (#7968) by @sapphi-red - renamer: prevent renaming symbols when there no conflicts (#7936) by @Dunqing - correct minifyInterExports when emitted chunk got merged (#7941) by @IWANABETHATGUY - deduplicate entry points when module is both emitted and dynamically imported (#7885) by @IWANABETHATGUY - dev: add `@vite-ignore` to lazy compilation proxy module import (#7883) by @sapphi-red ### 🚜 Refactor - rust: enable clippy nursery lint group (#8002) by @Boshen - rust: fix inconsistent_struct_constructor clippy lint (#7999) by @Boshen - rust: fix needless_pass_by_ref_mut clippy lint (#7994) by @Boshen - rust: fix unnecessary_wraps clippy lint (#7993) by @Boshen - rust: fix enum_variant_names clippy lint (#7992) by @Boshen - fix single_match clippy lint (#7997) by @Boshen - rust: fix redundant_clone clippy lint (#7996) by @Boshen - rust: rename CJS to Cjs to follow upper_case_acronyms lint (#7991) by @Boshen - rust: remove unnecessary Box wrapper around Vec in MemberExprRef (#7990) by @Boshen - import_record: make resolved_module optional (#7907) by @shulaoda - remove unnecessary `.parse` (#7966) by @sapphi-red - remove unused `ImportRecordMeta::IsPlainImport` (#7948) by @shulaoda - proper set chunk meta (#7939) by @IWANABETHATGUY - module_loader: remove `try_spawn_with_cache` (#7920) by @shulaoda - link_stage: simplify `ImportStatus::NoMatch` to unit variant (#7909) by @shulaoda - improve global scope symbol reservation in chunk deconfliction (#7906) by @IWANABETHATGUY - simplify ast unwrapping in generate stage (#7900) by @IWANABETHATGUY - generate_stage: optimize cross-chunk imports computation (#7889) by @shulaoda - link_stage: move runtime require logic into match branch (#7892) by @shulaoda - link_stage: simplify runtime require reference conditions (#7891) by @shulaoda - link_stage: inline and simplify external dynamic import check (#7890) by @shulaoda - generate_stage: simplify external module import collection logic (#7887) by @shulaoda - avoid redundant module lookup in TLA computation (#7886) by @shulaoda - dev: `devEngine.compileEntry` does not return null (#7882) by @sapphi-red - dev: fix type errors for test HMR runtime (#7881) by @sapphi-red - dev: move `clientId` property to `DevRuntime` base class (#7880) by @sapphi-red - dev: generate client id in browser (#7878) by @hyf0 ### 📚 Documentation - apis: organize hook filters documentation and add composable filters section (#8003) by @sapphi-red - update `vitepress-plugin-group-icons` (#7947) by @yuyinws - add in-depth documentation for lazy barrel optimization (#7969) by @shulaoda - bump theme & update activeMatch for reference (#7963) by @mdong1909 - mark `build()` API as experimental (#7954) by @sapphi-red - enhance search functionality with improved scoring and filtering logic (#7935) by @hyf0 - add minor comments to multiple types (#7930) by @sapphi-red - refactor advanedChunks related content to adapt manual code splitting concept (#7925) by @hyf0 - apis: add content to Bundler API page (#7926) by @sapphi-red - apis: restructure plugin API related docs (#7924) by @sapphi-red - add plugin API docs (#7923) by @sapphi-red - apis: add docs to important APIs (#7913) by @sapphi-red - move the important APIs to the top of the sidebar (#7912) by @sapphi-red - apis: add more content to CLI documentation (#7911) by @sapphi-red - apis: generate CLI docs from --help output (#7910) by @sapphi-red - add fathom analytics (#7896) by @mdong1909 ### ⚡ Performance - use u32 for string indices in string_wizard and rolldown to reduce memory usage (#7989) by @IWANABETHATGUY - rust: remove all usages of `with_scope_tree_child_ids(true)` for `SemanticBuilder` (#7995) by @Dunqing - renamer: skip unnecessary nested scope symbol processing (#7899) by @Dunqing - module_loader: use ArcStr for importer_id to avoid string copy (#7922) by @shulaoda - module_loader: defer `ModuleTaskOwner` construction until needed (#7921) by @shulaoda - renamer: optimize symbol renaming by eliminating `rename_non_root_symbol` pass (#7867) by @Dunqing ### 🧪 Testing - add lazy barrel optimization test cases (#7967) by @shulaoda ### ⚙️ Miscellaneous Tasks - remove lazy barrel option (#8010) by @shulaoda - mark watch API as experimental (#8004) by @sapphi-red - deps: update dependency lodash-es to v4.17.23 [security] (#8001) by @renovate[bot] - git ignore zed local config (#7988) by @IWANABETHATGUY - setup publint for published packages (#7972) by @Copilot - enable `tagged_template_transform ` uncondionally (#7975) by @IWANABETHATGUY - deps: update oxc to v0.110.0 (#7964) by @renovate[bot] - deps: update oxc apps (#7962) by @renovate[bot] - ai: add upgrade-oxc Claude skill (#7957) by @Boshen - deps: update rollup submodule for tests to v4.55.2 (#7959) by @sapphi-red - deps: update test262 submodule for tests (#7960) by @sapphi-red - deps: update crate-ci/typos action to v1.42.1 (#7961) by @renovate[bot] - deps: update rust crates (#7951) by @renovate[bot] - deps: update npm packages (#7953) by @renovate[bot] - deps: update github-actions (#7952) by @renovate[bot] - deps: update npm packages (#7950) by @renovate[bot] - format magic-string test before write to disk (#7945) by @IWANABETHATGUY - deps: update dependency rolldown-plugin-dts to ^0.21.0 (#7915) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.11.1 (#7914) by @renovate[bot] - deps: update dependency diff to v8.0.3 [security] (#7904) by @renovate[bot] - remove outdated TODO comment in `collect_depended_symbols` (#7888) by @shulaoda - deps: update oxc resolver to v11.16.3 (#7876) by @renovate[bot]

github-actions bot assigned IWANABETHATGUY Jan 18, 2026

IWANABETHATGUY changed the title ~~feat: eliminated facade entry~~ feat(debug_info): Addeliminated facade entry Jan 18, 2026

IWANABETHATGUY changed the title ~~feat(debug_info): Addeliminated facade entry~~ feat(debug_info): add debug info for eliminated facade chunks Jan 18, 2026

IWANABETHATGUY force-pushed the 01-18-feat_eliminated_facade_entry branch from 586f0a1 to 1620ead Compare January 18, 2026 10:11

hyf0 approved these changes Jan 18, 2026

View reviewed changes

IWANABETHATGUY marked this pull request as ready for review January 18, 2026 10:15

Copilot AI review requested due to automatic review settings January 18, 2026 10:15

Copilot started reviewing on behalf of IWANABETHATGUY January 18, 2026 10:16 View session

Copilot AI reviewed Jan 18, 2026

View reviewed changes

crates/rolldown_common/src/chunk/types/chunk_debug_info.rs Show resolved Hide resolved

feat(debug_info): add debug info for eliminated facade chunks (#7946)

ecac0af

graphite-app bot force-pushed the 01-18-feat_eliminated_facade_entry branch from 1620ead to ecac0af Compare January 18, 2026 11:06

graphite-app bot merged commit ecac0af into main Jan 18, 2026
35 checks passed

graphite-app bot deleted the 01-18-feat_eliminated_facade_entry branch January 18, 2026 11:17

This was referenced Jan 21, 2026

release: v1.0.0-beta.61 #7976

Closed

release: v1.0.0-rc.1 #8011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat(debug_info): add debug info for eliminated facade chunks#7946

feat(debug_info): add debug info for eliminated facade chunks#7946
graphite-app[bot] merged 1 commit intomainfrom
01-18-feat_eliminated_facade_entry

IWANABETHATGUY commented Jan 18, 2026

Uh oh!

IWANABETHATGUY commented Jan 18, 2026

Uh oh!

netlify bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

hyf0 left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Jan 18, 2026

Uh oh!

IWANABETHATGUY commented Jan 18, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

hyf0 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jan 18, 2026 •

edited

Loading

github-actions bot commented Jan 18, 2026 •

edited

Loading

graphite-app bot commented Jan 18, 2026 •

edited

Loading