Skip to content

Comments

fix: correct minifyInterExports when emitted chunk got merged#7941

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged
Jan 19, 2026
Merged

fix: correct minifyInterExports when emitted chunk got merged#7941
graphite-app[bot] merged 1 commit intomainfrom
01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author

IWANABETHATGUY commented Jan 17, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged branch from 6a81bbe to f0c2eb9 Compare January 18, 2026 11:02
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged branch from f0c2eb9 to fb6c257 Compare January 18, 2026 11:02
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 18, 2026 11:03
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2026

Benchmarks Rust

  • target: main(44373ef)
  • pr: 01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged(4b58006)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     67.5±1.42ms        ? ?/sec    1.00     65.8±1.53ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     74.1±1.31ms        ? ?/sec    1.00     72.9±2.85ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01     98.4±2.38ms        ? ?/sec    1.00     97.0±1.40ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    110.8±1.19ms        ? ?/sec    1.00    109.7±1.53ms        ? ?/sec
bundle/bundle@threejs                                        1.04     36.5±2.16ms        ? ?/sec    1.00     35.0±0.61ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     41.0±0.55ms        ? ?/sec    1.00     40.4±0.66ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    358.5±3.57ms        ? ?/sec    1.00    359.0±5.96ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    422.3±3.66ms        ? ?/sec    1.00    422.0±7.16ms        ? ?/sec
scan/scan@rome_ts                                            1.01     76.1±2.85ms        ? ?/sec    1.00     75.7±1.51ms        ? ?/sec
scan/scan@threejs                                            1.00     26.8±1.71ms        ? ?/sec    1.00     26.8±1.75ms        ? ?/sec
scan/scan@threejs10x                                         1.00    266.5±3.40ms        ? ?/sec    1.01    270.1±5.70ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from 01-16-feat_5726 to graphite-base/7941 January 18, 2026 11:36
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged branch from fb6c257 to a90eca2 Compare January 18, 2026 17:24
@IWANABETHATGUY IWANABETHATGUY changed the base branch from graphite-base/7941 to 01-16-feat_5726 January 18, 2026 17:24
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged branch from a90eca2 to 2727080 Compare January 18, 2026 18:15
@graphite-app graphite-app bot changed the base branch from 01-16-feat_5726 to graphite-base/7941 January 18, 2026 18:48
@graphite-app graphite-app bot force-pushed the 01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged branch from 2727080 to 0e1a98e Compare January 18, 2026 19:01
@graphite-app graphite-app bot force-pushed the graphite-base/7941 branch from a53c388 to c2c0edc Compare January 18, 2026 19:01
@graphite-app graphite-app bot changed the base branch from graphite-base/7941 to main January 18, 2026 19:01
@graphite-app graphite-app bot force-pushed the 01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged branch from 0e1a98e to 78d34cb Compare January 18, 2026 19:02
@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4b58006
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/696d9a58d46f890008048ec7

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 19, 2026

Merge activity

Copilot AI review requested due to automatic review settings January 19, 2026 02:43
@graphite-app graphite-app bot force-pushed the 01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged branch from 78d34cb to 4b58006 Compare January 19, 2026 02:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 4b58006 into main Jan 19, 2026
35 checks passed
@graphite-app graphite-app bot deleted the 01-17-fix_correct_minifyinterexports_when_emitted_chunk_got_merged branch January 19, 2026 02:55
This was referenced Jan 21, 2026
shulaoda pushed a commit that referenced this pull request Jan 22, 2026
## [1.0.0-rc.1] - 2026-01-22

### 🚀 Features

- debug_info: add facade chunk elimination reason (#7980) by @IWANABETHATGUY
- support lazy barrel optimization (#7933) by @shulaoda
- add `experimental.lazyBarrel` option (#7908) by @shulaoda
- skip unused external modules from IIFE parameter list (#7978) by @sapphi-red
- add custom panic hook for better crash reporting (#7752) by @shulaoda
- treeshake: add `invalidImportSideEffects` option (#7958) by @shulaoda
- merge allow-extension emitted chunks (#7940) by @IWANABETHATGUY
- nativeMagicString generateMap (#7944) by @IWANABETHATGUY
- Include meta.magicString in RenderChunkMeta (#7943) by @IWANABETHATGUY
- debug_info: add debug info for eliminated facade chunks (#7946) by @IWANABETHATGUY
- stablize `strictExecutionOrder` and move to `output.strictExecutionOrder` from `experimental.strictExecutionOrder` (#7901) by @sapphi-red
- add documentation link to require() error message (#7898) by @Copilot
- add `codeSplitting: boolean` and deprecate `inlineDynamicImports` (#7870) by @hyf0
- dev: change lazy module URL to `/@vite/lazy` from `/lazy` (#7884) by @sapphi-red

### 🐛 Bug Fixes

- transform JS files containing `</script>` to escape template literals (#7987) by @IWANABETHATGUY
- apply avoid-breaking-exported-api = false to clippy.toml and fix clippy errors (#7982) by @Boshen
- pass `kind` from `this.resolve` (#7981) by @sapphi-red
- rolldown_plugin_vite_resolve: ignore yarn resolution errors and fallback to other resolvers (#7968) by @sapphi-red
- renamer: prevent renaming symbols when there no conflicts (#7936) by @Dunqing
- correct minifyInterExports when emitted chunk got merged (#7941) by @IWANABETHATGUY
- deduplicate entry points when module is both emitted and dynamically imported (#7885) by @IWANABETHATGUY
- dev: add `@vite-ignore` to lazy compilation proxy module import (#7883) by @sapphi-red

### 🚜 Refactor

- rust: enable clippy nursery lint group (#8002) by @Boshen
- rust: fix inconsistent_struct_constructor clippy lint (#7999) by @Boshen
- rust: fix needless_pass_by_ref_mut clippy lint (#7994) by @Boshen
- rust: fix unnecessary_wraps clippy lint (#7993) by @Boshen
- rust: fix enum_variant_names clippy lint (#7992) by @Boshen
- fix single_match clippy lint (#7997) by @Boshen
- rust: fix redundant_clone clippy lint (#7996) by @Boshen
- rust: rename CJS to Cjs to follow upper_case_acronyms lint (#7991) by @Boshen
- rust: remove unnecessary Box wrapper around Vec in MemberExprRef (#7990) by @Boshen
- import_record: make resolved_module optional (#7907) by @shulaoda
- remove unnecessary `.parse` (#7966) by @sapphi-red
- remove unused `ImportRecordMeta::IsPlainImport` (#7948) by @shulaoda
- proper set chunk meta (#7939) by @IWANABETHATGUY
- module_loader: remove `try_spawn_with_cache` (#7920) by @shulaoda
- link_stage: simplify `ImportStatus::NoMatch` to unit variant (#7909) by @shulaoda
- improve global scope symbol reservation in chunk deconfliction (#7906) by @IWANABETHATGUY
- simplify ast unwrapping in generate stage (#7900) by @IWANABETHATGUY
- generate_stage: optimize cross-chunk imports computation (#7889) by @shulaoda
- link_stage: move runtime require logic into match branch (#7892) by @shulaoda
- link_stage: simplify runtime require reference conditions (#7891) by @shulaoda
- link_stage: inline and simplify external dynamic import check (#7890) by @shulaoda
- generate_stage: simplify external module import collection logic (#7887) by @shulaoda
- avoid redundant module lookup in TLA computation (#7886) by @shulaoda
- dev: `devEngine.compileEntry` does not return null (#7882) by @sapphi-red
- dev: fix type errors for test HMR runtime (#7881) by @sapphi-red
- dev: move `clientId` property to `DevRuntime` base class (#7880) by @sapphi-red
- dev: generate client id in browser (#7878) by @hyf0

### 📚 Documentation

- apis: organize hook filters documentation and add composable filters section (#8003) by @sapphi-red
- update `vitepress-plugin-group-icons` (#7947) by @yuyinws
- add in-depth documentation for lazy barrel optimization (#7969) by @shulaoda
- bump theme & update activeMatch for reference (#7963) by @mdong1909
- mark `build()` API as experimental (#7954) by @sapphi-red
- enhance search functionality with improved scoring and filtering logic (#7935) by @hyf0
- add minor comments to multiple types (#7930) by @sapphi-red
- refactor advanedChunks related content to adapt manual code splitting concept (#7925) by @hyf0
- apis: add content to Bundler API page (#7926) by @sapphi-red
- apis: restructure plugin API related docs (#7924) by @sapphi-red
- add plugin API docs (#7923) by @sapphi-red
- apis: add docs to important APIs (#7913) by @sapphi-red
- move the important APIs to the top of the sidebar (#7912) by @sapphi-red
- apis: add more content to CLI documentation (#7911) by @sapphi-red
- apis: generate CLI docs from --help output (#7910) by @sapphi-red
- add fathom analytics (#7896) by @mdong1909

### ⚡ Performance

- use u32 for string indices in string_wizard and rolldown to reduce memory usage (#7989) by @IWANABETHATGUY
- rust: remove all usages of `with_scope_tree_child_ids(true)` for `SemanticBuilder` (#7995) by @Dunqing
- renamer: skip unnecessary nested scope symbol processing (#7899) by @Dunqing
- module_loader: use ArcStr for importer_id to avoid string copy (#7922) by @shulaoda
- module_loader: defer `ModuleTaskOwner` construction until needed (#7921) by @shulaoda
- renamer: optimize symbol renaming by eliminating `rename_non_root_symbol` pass (#7867) by @Dunqing

### 🧪 Testing

- add lazy barrel optimization test cases (#7967) by @shulaoda

### ⚙️ Miscellaneous Tasks

- remove lazy barrel option (#8010) by @shulaoda
- mark watch API as experimental (#8004) by @sapphi-red
- deps: update dependency lodash-es to v4.17.23 [security] (#8001) by @renovate[bot]
- git ignore zed local config (#7988) by @IWANABETHATGUY
- setup publint for published packages (#7972) by @Copilot
- enable `tagged_template_transform ` uncondionally (#7975) by @IWANABETHATGUY
- deps: update oxc to v0.110.0 (#7964) by @renovate[bot]
- deps: update oxc apps (#7962) by @renovate[bot]
- ai: add upgrade-oxc Claude skill (#7957) by @Boshen
- deps: update rollup submodule for tests to v4.55.2 (#7959) by @sapphi-red
- deps: update test262 submodule for tests (#7960) by @sapphi-red
- deps: update crate-ci/typos action to v1.42.1 (#7961) by @renovate[bot]
- deps: update rust crates (#7951) by @renovate[bot]
- deps: update npm packages (#7953) by @renovate[bot]
- deps: update github-actions (#7952) by @renovate[bot]
- deps: update npm packages (#7950) by @renovate[bot]
- format magic-string test before write to disk (#7945) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to ^0.21.0 (#7915) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.1 (#7914) by @renovate[bot]
- deps: update dependency diff to v8.0.3 [security] (#7904) by @renovate[bot]
- remove outdated TODO comment in `collect_depended_symbols` (#7888) by @shulaoda
- deps: update oxc resolver to v11.16.3 (#7876) by @renovate[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants