Skip to content

Comments

feat: stablize strictExecutionOrder and move to output.strictExecutionOrder from experimental.strictExecutionOrder#7901

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-15-feat_stablize_strictexecutionorder_and_move_to_output.strictexecutionorder_from_experimental.strictexecutionorder_
Jan 15, 2026
Merged

feat: stablize strictExecutionOrder and move to output.strictExecutionOrder from experimental.strictExecutionOrder#7901
graphite-app[bot] merged 1 commit intomainfrom
01-15-feat_stablize_strictexecutionorder_and_move_to_output.strictexecutionorder_from_experimental.strictexecutionorder_

Conversation

@sapphi-red
Copy link
Member

No description provided.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red force-pushed the 01-15-feat_stablize_strictexecutionorder_and_move_to_output.strictexecutionorder_from_experimental.strictexecutionorder_ branch from cf89d2d to 3e5e285 Compare January 15, 2026 06:46
@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit cf89d2d
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69688cfb1a66e6000811391e
😎 Deploy Preview https://deploy-preview-7901--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sapphi-red sapphi-red linked an issue Jan 15, 2026 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit d7ddb69
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6968ab3c5bd11500089b6829
😎 Deploy Preview https://deploy-preview-7901--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sapphi-red sapphi-red marked this pull request as ready for review January 15, 2026 06:51
Copilot AI review requested due to automatic review settings January 15, 2026 06:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request stabilizes the strictExecutionOrder option by moving it from the experimental namespace (experimental.strictExecutionOrder) to become a first-class output option (output.strictExecutionOrder). This change reflects the feature's maturity and makes it more discoverable for users.

Changes:

  • Moved strictExecutionOrder from InputOptions.experimental to OutputOptions (top-level)
  • Added deprecation warning when the old experimental.strictExecutionOrder path is used
  • Updated all test configurations to use the new option location
  • Updated Rust bindings, TypeScript types, and internal option handling to reflect the new structure

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/rolldown/src/options/output-options.ts Added strictExecutionOrder field to OutputOptions interface with documentation
packages/rolldown/src/options/input-options.ts Removed strictExecutionOrder from experimental options
packages/rolldown/src/utils/bindingify-output-options.ts Added destructuring and passing of strictExecutionOrder in output options
packages/rolldown/src/utils/bindingify-input-options.ts Removed strictExecutionOrder from experimental options binding
packages/rolldown/src/utils/create-bundler-option.ts Added deprecation warning for old experimental.strictExecutionOrder usage
packages/rolldown/src/binding.d.cts Moved strictExecutionOrder from BindingExperimentalOptions to BindingOutputOptions
crates/rolldown_binding/src/options/binding_output_options/mod.rs Added strictExecutionOrder field to BindingOutputOptions
crates/rolldown_binding/src/options/binding_input_options/binding_experimental_options.rs Removed strictExecutionOrder from BindingExperimentalOptions
crates/rolldown_binding/src/utils/normalize_binding_options.rs Added strictExecutionOrder mapping from output options
crates/rolldown_common/src/inner_bundler_options/mod.rs Added strictExecutionOrder as top-level field in BundlerOptions
crates/rolldown_common/src/inner_bundler_options/types/normalized_bundler_options.rs Added strictExecutionOrder field and is_strict_execution_order_enabled() helper method
crates/rolldown_common/src/inner_bundler_options/types/experimental_options.rs Removed strictExecutionOrder field and is_strict_execution_order_enabled() method
crates/rolldown/src/utils/prepare_build_context.rs Updated to initialize strict_execution_order from top-level option
crates/rolldown/src/stages/link_stage/wrapping.rs Updated to call is_strict_execution_order_enabled() on options directly
crates/rolldown/src/stages/generate_stage/*.rs Updated to call is_strict_execution_order_enabled() on options directly
crates/rolldown_testing_config/src/config_variant.rs Updated ConfigVariant to set strict_execution_order on BundlerOptions directly
crates/rolldown_testing/_config.schema.json Moved strictExecutionOrder from ExperimentalOptions to OutputOptions in schema
packages/rolldown/tests/fixtures/misc/issues/3331/_config.ts Updated test config to use output.strictExecutionOrder
crates/rolldown/tests/rolldown/**/_config.json Updated 30+ test configs to use new option location
Comments suppressed due to low confidence (1)

packages/rolldown/src/options/output-options.ts:547

  • The documentation comment still references the old experimental.strictExecutionOrder path. This should be updated to output.strictExecutionOrder to match the new API structure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(6a1946b)
  • pr: 01-15-feat_stablize_strictexecutionorder_and_move_to_output.strictexecutionorder_from_experimental.strictexecutionorder_(3e5e285)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.12     76.4±2.29ms        ? ?/sec    1.00     68.3±3.51ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.14     82.8±2.15ms        ? ?/sec    1.00     72.9±1.64ms        ? ?/sec
bundle/bundle@rome_ts                                        1.05    106.8±3.22ms        ? ?/sec    1.00    101.4±2.31ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.05    118.6±2.24ms        ? ?/sec    1.00    112.6±1.68ms        ? ?/sec
bundle/bundle@threejs                                        1.10     38.8±2.17ms        ? ?/sec    1.00     35.3±0.82ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.08     42.8±0.72ms        ? ?/sec    1.00     39.8±0.78ms        ? ?/sec
bundle/bundle@threejs10x                                     1.04    382.8±3.96ms        ? ?/sec    1.00    366.7±3.87ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.04    440.4±5.28ms        ? ?/sec    1.00    422.9±3.15ms        ? ?/sec
scan/scan@rome_ts                                            1.08     85.3±2.36ms        ? ?/sec    1.00     79.4±1.44ms        ? ?/sec
scan/scan@threejs                                            1.05     29.2±0.55ms        ? ?/sec    1.00     27.8±1.78ms        ? ?/sec
scan/scan@threejs10x                                         1.06    297.2±4.87ms        ? ?/sec    1.00    279.1±3.52ms        ? ?/sec

Copy link
Member Author

sapphi-red commented Jan 15, 2026

Merge activity

  • Jan 15, 7:21 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 15, 8:53 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Jan 15, 9:03 AM UTC: Merged by the Graphite merge queue.

@IWANABETHATGUY
Copy link
Member

LGTM cc @hyf0

…tionOrder` from `experimental.strictExecutionOrder` (#7901)
@graphite-app graphite-app bot force-pushed the 01-15-feat_stablize_strictexecutionorder_and_move_to_output.strictexecutionorder_from_experimental.strictexecutionorder_ branch from 3e5e285 to d7ddb69 Compare January 15, 2026 08:54
@graphite-app graphite-app bot merged commit d7ddb69 into main Jan 15, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 01-15-feat_stablize_strictexecutionorder_and_move_to_output.strictexecutionorder_from_experimental.strictexecutionorder_ branch January 15, 2026 09:03
This was referenced Jan 21, 2026
shulaoda pushed a commit that referenced this pull request Jan 22, 2026
## [1.0.0-rc.1] - 2026-01-22

### 🚀 Features

- debug_info: add facade chunk elimination reason (#7980) by @IWANABETHATGUY
- support lazy barrel optimization (#7933) by @shulaoda
- add `experimental.lazyBarrel` option (#7908) by @shulaoda
- skip unused external modules from IIFE parameter list (#7978) by @sapphi-red
- add custom panic hook for better crash reporting (#7752) by @shulaoda
- treeshake: add `invalidImportSideEffects` option (#7958) by @shulaoda
- merge allow-extension emitted chunks (#7940) by @IWANABETHATGUY
- nativeMagicString generateMap (#7944) by @IWANABETHATGUY
- Include meta.magicString in RenderChunkMeta (#7943) by @IWANABETHATGUY
- debug_info: add debug info for eliminated facade chunks (#7946) by @IWANABETHATGUY
- stablize `strictExecutionOrder` and move to `output.strictExecutionOrder` from `experimental.strictExecutionOrder` (#7901) by @sapphi-red
- add documentation link to require() error message (#7898) by @Copilot
- add `codeSplitting: boolean` and deprecate `inlineDynamicImports` (#7870) by @hyf0
- dev: change lazy module URL to `/@vite/lazy` from `/lazy` (#7884) by @sapphi-red

### 🐛 Bug Fixes

- transform JS files containing `</script>` to escape template literals (#7987) by @IWANABETHATGUY
- apply avoid-breaking-exported-api = false to clippy.toml and fix clippy errors (#7982) by @Boshen
- pass `kind` from `this.resolve` (#7981) by @sapphi-red
- rolldown_plugin_vite_resolve: ignore yarn resolution errors and fallback to other resolvers (#7968) by @sapphi-red
- renamer: prevent renaming symbols when there no conflicts (#7936) by @Dunqing
- correct minifyInterExports when emitted chunk got merged (#7941) by @IWANABETHATGUY
- deduplicate entry points when module is both emitted and dynamically imported (#7885) by @IWANABETHATGUY
- dev: add `@vite-ignore` to lazy compilation proxy module import (#7883) by @sapphi-red

### 🚜 Refactor

- rust: enable clippy nursery lint group (#8002) by @Boshen
- rust: fix inconsistent_struct_constructor clippy lint (#7999) by @Boshen
- rust: fix needless_pass_by_ref_mut clippy lint (#7994) by @Boshen
- rust: fix unnecessary_wraps clippy lint (#7993) by @Boshen
- rust: fix enum_variant_names clippy lint (#7992) by @Boshen
- fix single_match clippy lint (#7997) by @Boshen
- rust: fix redundant_clone clippy lint (#7996) by @Boshen
- rust: rename CJS to Cjs to follow upper_case_acronyms lint (#7991) by @Boshen
- rust: remove unnecessary Box wrapper around Vec in MemberExprRef (#7990) by @Boshen
- import_record: make resolved_module optional (#7907) by @shulaoda
- remove unnecessary `.parse` (#7966) by @sapphi-red
- remove unused `ImportRecordMeta::IsPlainImport` (#7948) by @shulaoda
- proper set chunk meta (#7939) by @IWANABETHATGUY
- module_loader: remove `try_spawn_with_cache` (#7920) by @shulaoda
- link_stage: simplify `ImportStatus::NoMatch` to unit variant (#7909) by @shulaoda
- improve global scope symbol reservation in chunk deconfliction (#7906) by @IWANABETHATGUY
- simplify ast unwrapping in generate stage (#7900) by @IWANABETHATGUY
- generate_stage: optimize cross-chunk imports computation (#7889) by @shulaoda
- link_stage: move runtime require logic into match branch (#7892) by @shulaoda
- link_stage: simplify runtime require reference conditions (#7891) by @shulaoda
- link_stage: inline and simplify external dynamic import check (#7890) by @shulaoda
- generate_stage: simplify external module import collection logic (#7887) by @shulaoda
- avoid redundant module lookup in TLA computation (#7886) by @shulaoda
- dev: `devEngine.compileEntry` does not return null (#7882) by @sapphi-red
- dev: fix type errors for test HMR runtime (#7881) by @sapphi-red
- dev: move `clientId` property to `DevRuntime` base class (#7880) by @sapphi-red
- dev: generate client id in browser (#7878) by @hyf0

### 📚 Documentation

- apis: organize hook filters documentation and add composable filters section (#8003) by @sapphi-red
- update `vitepress-plugin-group-icons` (#7947) by @yuyinws
- add in-depth documentation for lazy barrel optimization (#7969) by @shulaoda
- bump theme & update activeMatch for reference (#7963) by @mdong1909
- mark `build()` API as experimental (#7954) by @sapphi-red
- enhance search functionality with improved scoring and filtering logic (#7935) by @hyf0
- add minor comments to multiple types (#7930) by @sapphi-red
- refactor advanedChunks related content to adapt manual code splitting concept (#7925) by @hyf0
- apis: add content to Bundler API page (#7926) by @sapphi-red
- apis: restructure plugin API related docs (#7924) by @sapphi-red
- add plugin API docs (#7923) by @sapphi-red
- apis: add docs to important APIs (#7913) by @sapphi-red
- move the important APIs to the top of the sidebar (#7912) by @sapphi-red
- apis: add more content to CLI documentation (#7911) by @sapphi-red
- apis: generate CLI docs from --help output (#7910) by @sapphi-red
- add fathom analytics (#7896) by @mdong1909

### ⚡ Performance

- use u32 for string indices in string_wizard and rolldown to reduce memory usage (#7989) by @IWANABETHATGUY
- rust: remove all usages of `with_scope_tree_child_ids(true)` for `SemanticBuilder` (#7995) by @Dunqing
- renamer: skip unnecessary nested scope symbol processing (#7899) by @Dunqing
- module_loader: use ArcStr for importer_id to avoid string copy (#7922) by @shulaoda
- module_loader: defer `ModuleTaskOwner` construction until needed (#7921) by @shulaoda
- renamer: optimize symbol renaming by eliminating `rename_non_root_symbol` pass (#7867) by @Dunqing

### 🧪 Testing

- add lazy barrel optimization test cases (#7967) by @shulaoda

### ⚙️ Miscellaneous Tasks

- remove lazy barrel option (#8010) by @shulaoda
- mark watch API as experimental (#8004) by @sapphi-red
- deps: update dependency lodash-es to v4.17.23 [security] (#8001) by @renovate[bot]
- git ignore zed local config (#7988) by @IWANABETHATGUY
- setup publint for published packages (#7972) by @Copilot
- enable `tagged_template_transform ` uncondionally (#7975) by @IWANABETHATGUY
- deps: update oxc to v0.110.0 (#7964) by @renovate[bot]
- deps: update oxc apps (#7962) by @renovate[bot]
- ai: add upgrade-oxc Claude skill (#7957) by @Boshen
- deps: update rollup submodule for tests to v4.55.2 (#7959) by @sapphi-red
- deps: update test262 submodule for tests (#7960) by @sapphi-red
- deps: update crate-ci/typos action to v1.42.1 (#7961) by @renovate[bot]
- deps: update rust crates (#7951) by @renovate[bot]
- deps: update npm packages (#7953) by @renovate[bot]
- deps: update github-actions (#7952) by @renovate[bot]
- deps: update npm packages (#7950) by @renovate[bot]
- format magic-string test before write to disk (#7945) by @IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to ^0.21.0 (#7915) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.1 (#7914) by @renovate[bot]
- deps: update dependency diff to v8.0.3 [security] (#7904) by @renovate[bot]
- remove outdated TODO comment in `collect_depended_symbols` (#7888) by @shulaoda
- deps: update oxc resolver to v11.16.3 (#7876) by @renovate[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize experimental.strictExecutionOrder

3 participants