refactor: simplify ast unwrapping in generate stage by IWANABETHATGUY · Pull Request #7900 · rolldown/rolldown

IWANABETHATGUY · 2026-01-15T06:10:09Z

No description provided.

IWANABETHATGUY · 2026-01-15T06:10:25Z

refactor: simplify ast unwrapping in generate stage #7900 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-15T06:11:34Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`098289c`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69689f0947935d00099db501

Copilot

Pull request overview

This pull request refactors an early return pattern in the finalize_modules code to use Rust's ? operator syntax instead of explicit let-else pattern matching.

Changes:

Simplified early return logic using ? operator on Option::as_mut() instead of explicit pattern matching

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-01-15T06:26:01Z

Benchmarks Rust

target: main(e26a334)
pr: 01-15-refactor_use_syntax_simplify_early_return(098289c)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.3±1.92ms        ? ?/sec    1.09     73.2±2.09ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     73.2±1.09ms        ? ?/sec    1.09     79.4±2.09ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    100.8±2.45ms        ? ?/sec    1.01    101.9±2.08ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    111.8±1.80ms        ? ?/sec    1.03    115.2±2.45ms        ? ?/sec
bundle/bundle@threejs                                        1.00     36.1±1.94ms        ? ?/sec    1.00     36.0±0.50ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     39.8±0.46ms        ? ?/sec    1.03     40.9±0.53ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    364.9±3.99ms        ? ?/sec    1.02    373.7±6.82ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    426.4±4.27ms        ? ?/sec    1.01    430.1±3.69ms        ? ?/sec
scan/scan@rome_ts                                            1.00     81.8±1.56ms        ? ?/sec    1.00     81.9±1.85ms        ? ?/sec
scan/scan@threejs                                            1.00     28.4±1.77ms        ? ?/sec    1.00     28.4±0.89ms        ? ?/sec
scan/scan@threejs10x                                         1.00    284.9±4.03ms        ? ?/sec    1.02    290.2±3.88ms        ? ?/sec

graphite-app · 2026-01-15T06:34:18Z

Merge activity

Jan 15, 6:34 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 15, 7:05 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
Jan 15, 8:24 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 15, 8:24 AM UTC: Merged by the Graphite merge queue.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IWANABETHATGUY

## [1.0.0-rc.1] - 2026-01-22 ### 🚀 Features - debug_info: add facade chunk elimination reason (#7980) by @IWANABETHATGUY - support lazy barrel optimization (#7933) by @shulaoda - add `experimental.lazyBarrel` option (#7908) by @shulaoda - skip unused external modules from IIFE parameter list (#7978) by @sapphi-red - add custom panic hook for better crash reporting (#7752) by @shulaoda - treeshake: add `invalidImportSideEffects` option (#7958) by @shulaoda - merge allow-extension emitted chunks (#7940) by @IWANABETHATGUY - nativeMagicString generateMap (#7944) by @IWANABETHATGUY - Include meta.magicString in RenderChunkMeta (#7943) by @IWANABETHATGUY - debug_info: add debug info for eliminated facade chunks (#7946) by @IWANABETHATGUY - stablize `strictExecutionOrder` and move to `output.strictExecutionOrder` from `experimental.strictExecutionOrder` (#7901) by @sapphi-red - add documentation link to require() error message (#7898) by @Copilot - add `codeSplitting: boolean` and deprecate `inlineDynamicImports` (#7870) by @hyf0 - dev: change lazy module URL to `/@vite/lazy` from `/lazy` (#7884) by @sapphi-red ### 🐛 Bug Fixes - transform JS files containing `</script>` to escape template literals (#7987) by @IWANABETHATGUY - apply avoid-breaking-exported-api = false to clippy.toml and fix clippy errors (#7982) by @Boshen - pass `kind` from `this.resolve` (#7981) by @sapphi-red - rolldown_plugin_vite_resolve: ignore yarn resolution errors and fallback to other resolvers (#7968) by @sapphi-red - renamer: prevent renaming symbols when there no conflicts (#7936) by @Dunqing - correct minifyInterExports when emitted chunk got merged (#7941) by @IWANABETHATGUY - deduplicate entry points when module is both emitted and dynamically imported (#7885) by @IWANABETHATGUY - dev: add `@vite-ignore` to lazy compilation proxy module import (#7883) by @sapphi-red ### 🚜 Refactor - rust: enable clippy nursery lint group (#8002) by @Boshen - rust: fix inconsistent_struct_constructor clippy lint (#7999) by @Boshen - rust: fix needless_pass_by_ref_mut clippy lint (#7994) by @Boshen - rust: fix unnecessary_wraps clippy lint (#7993) by @Boshen - rust: fix enum_variant_names clippy lint (#7992) by @Boshen - fix single_match clippy lint (#7997) by @Boshen - rust: fix redundant_clone clippy lint (#7996) by @Boshen - rust: rename CJS to Cjs to follow upper_case_acronyms lint (#7991) by @Boshen - rust: remove unnecessary Box wrapper around Vec in MemberExprRef (#7990) by @Boshen - import_record: make resolved_module optional (#7907) by @shulaoda - remove unnecessary `.parse` (#7966) by @sapphi-red - remove unused `ImportRecordMeta::IsPlainImport` (#7948) by @shulaoda - proper set chunk meta (#7939) by @IWANABETHATGUY - module_loader: remove `try_spawn_with_cache` (#7920) by @shulaoda - link_stage: simplify `ImportStatus::NoMatch` to unit variant (#7909) by @shulaoda - improve global scope symbol reservation in chunk deconfliction (#7906) by @IWANABETHATGUY - simplify ast unwrapping in generate stage (#7900) by @IWANABETHATGUY - generate_stage: optimize cross-chunk imports computation (#7889) by @shulaoda - link_stage: move runtime require logic into match branch (#7892) by @shulaoda - link_stage: simplify runtime require reference conditions (#7891) by @shulaoda - link_stage: inline and simplify external dynamic import check (#7890) by @shulaoda - generate_stage: simplify external module import collection logic (#7887) by @shulaoda - avoid redundant module lookup in TLA computation (#7886) by @shulaoda - dev: `devEngine.compileEntry` does not return null (#7882) by @sapphi-red - dev: fix type errors for test HMR runtime (#7881) by @sapphi-red - dev: move `clientId` property to `DevRuntime` base class (#7880) by @sapphi-red - dev: generate client id in browser (#7878) by @hyf0 ### 📚 Documentation - apis: organize hook filters documentation and add composable filters section (#8003) by @sapphi-red - update `vitepress-plugin-group-icons` (#7947) by @yuyinws - add in-depth documentation for lazy barrel optimization (#7969) by @shulaoda - bump theme & update activeMatch for reference (#7963) by @mdong1909 - mark `build()` API as experimental (#7954) by @sapphi-red - enhance search functionality with improved scoring and filtering logic (#7935) by @hyf0 - add minor comments to multiple types (#7930) by @sapphi-red - refactor advanedChunks related content to adapt manual code splitting concept (#7925) by @hyf0 - apis: add content to Bundler API page (#7926) by @sapphi-red - apis: restructure plugin API related docs (#7924) by @sapphi-red - add plugin API docs (#7923) by @sapphi-red - apis: add docs to important APIs (#7913) by @sapphi-red - move the important APIs to the top of the sidebar (#7912) by @sapphi-red - apis: add more content to CLI documentation (#7911) by @sapphi-red - apis: generate CLI docs from --help output (#7910) by @sapphi-red - add fathom analytics (#7896) by @mdong1909 ### ⚡ Performance - use u32 for string indices in string_wizard and rolldown to reduce memory usage (#7989) by @IWANABETHATGUY - rust: remove all usages of `with_scope_tree_child_ids(true)` for `SemanticBuilder` (#7995) by @Dunqing - renamer: skip unnecessary nested scope symbol processing (#7899) by @Dunqing - module_loader: use ArcStr for importer_id to avoid string copy (#7922) by @shulaoda - module_loader: defer `ModuleTaskOwner` construction until needed (#7921) by @shulaoda - renamer: optimize symbol renaming by eliminating `rename_non_root_symbol` pass (#7867) by @Dunqing ### 🧪 Testing - add lazy barrel optimization test cases (#7967) by @shulaoda ### ⚙️ Miscellaneous Tasks - remove lazy barrel option (#8010) by @shulaoda - mark watch API as experimental (#8004) by @sapphi-red - deps: update dependency lodash-es to v4.17.23 [security] (#8001) by @renovate[bot] - git ignore zed local config (#7988) by @IWANABETHATGUY - setup publint for published packages (#7972) by @Copilot - enable `tagged_template_transform ` uncondionally (#7975) by @IWANABETHATGUY - deps: update oxc to v0.110.0 (#7964) by @renovate[bot] - deps: update oxc apps (#7962) by @renovate[bot] - ai: add upgrade-oxc Claude skill (#7957) by @Boshen - deps: update rollup submodule for tests to v4.55.2 (#7959) by @sapphi-red - deps: update test262 submodule for tests (#7960) by @sapphi-red - deps: update crate-ci/typos action to v1.42.1 (#7961) by @renovate[bot] - deps: update rust crates (#7951) by @renovate[bot] - deps: update npm packages (#7953) by @renovate[bot] - deps: update github-actions (#7952) by @renovate[bot] - deps: update npm packages (#7950) by @renovate[bot] - format magic-string test before write to disk (#7945) by @IWANABETHATGUY - deps: update dependency rolldown-plugin-dts to ^0.21.0 (#7915) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.11.1 (#7914) by @renovate[bot] - deps: update dependency diff to v8.0.3 [security] (#7904) by @renovate[bot] - remove outdated TODO comment in `collect_depended_symbols` (#7888) by @shulaoda - deps: update oxc resolver to v11.16.3 (#7876) by @renovate[bot]

github-actions bot assigned IWANABETHATGUY Jan 15, 2026

IWANABETHATGUY marked this pull request as ready for review January 15, 2026 06:10

Copilot AI review requested due to automatic review settings January 15, 2026 06:10

Copilot started reviewing on behalf of IWANABETHATGUY January 15, 2026 06:11 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

IWANABETHATGUY requested review from hyf0 and shulaoda January 15, 2026 06:26

IWANABETHATGUY changed the title ~~refactor: use ? syntax simplify early return~~ refactor: simplify ast unwrapping in generate stage Jan 15, 2026

shulaoda approved these changes Jan 15, 2026

View reviewed changes

graphite-app bot pushed a commit that referenced this pull request Jan 15, 2026

refactor: simplify ast unwrapping in generate stage (#7900)

29eea80

graphite-app bot force-pushed the 01-15-refactor_use_syntax_simplify_early_return branch from 2b77082 to 29eea80 Compare January 15, 2026 06:34

graphite-app bot pushed a commit that referenced this pull request Jan 15, 2026

refactor: simplify ast unwrapping in generate stage (#7900)

3ac3615

Copilot AI review requested due to automatic review settings January 15, 2026 06:40

graphite-app bot force-pushed the 01-15-refactor_use_syntax_simplify_early_return branch from 29eea80 to 3ac3615 Compare January 15, 2026 06:40

Copilot AI reviewed Jan 15, 2026

View reviewed changes

graphite-app bot pushed a commit that referenced this pull request Jan 15, 2026

refactor: simplify ast unwrapping in generate stage (#7900)

b63586f

graphite-app bot force-pushed the 01-15-refactor_use_syntax_simplify_early_return branch from 3ac3615 to b63586f Compare January 15, 2026 06:48

refactor: simplify ast unwrapping in generate stage (#7900)

098289c

Copilot AI review requested due to automatic review settings January 15, 2026 08:02

IWANABETHATGUY force-pushed the 01-15-refactor_use_syntax_simplify_early_return branch from b63586f to 098289c Compare January 15, 2026 08:02

Copilot started reviewing on behalf of IWANABETHATGUY January 15, 2026 08:02 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

graphite-app bot merged commit 098289c into main Jan 15, 2026
63 of 64 checks passed

graphite-app bot deleted the 01-15-refactor_use_syntax_simplify_early_return branch January 15, 2026 08:24

This was referenced Jan 21, 2026

release: v1.0.0-beta.61 #7976

Closed

release: v1.0.0-rc.1 #8011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: simplify ast unwrapping in generate stage#7900

refactor: simplify ast unwrapping in generate stage#7900
graphite-app[bot] merged 1 commit intomainfrom
01-15-refactor_use_syntax_simplify_early_return

IWANABETHATGUY commented Jan 15, 2026

Uh oh!

IWANABETHATGUY commented Jan 15, 2026

Uh oh!

netlify bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Jan 15, 2026

Uh oh!

IWANABETHATGUY commented Jan 15, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jan 15, 2026 •

edited

Loading

github-actions bot commented Jan 15, 2026 •

edited

Loading

graphite-app bot commented Jan 15, 2026 •

edited

Loading