Addresses feedback on PR #7890 to keep the is_external_dynamic_import function while incorporating the new optimized logic.

Changes Made

• Restored the is_external_dynamic_import helper function that was previously removed
• Refactored the function signature to use the new optimized logic:
  • Removed the ModuleTable parameter (no longer needed)
  • Takes rec, rec_resolved_module, importer_is_user_defined_entry, and importer_idx as parameters
  • Uses importer.is_user_defined_entry directly instead of fetching from the module table
• Updated the call site to use the refactored function instead of inlined logic
• Added necessary imports (ModuleIdx and ResolvedImportRecord)

Benefits

• Maintains better code organization with a clearly-named function
• Improves readability by encapsulating the logic
• Preserves the performance optimization from the original refactoring
• No runtime overhead - Rust's optimizer will inline this automatically

Testing

• ✅ Code compiles successfully with just build-rolldown
• ✅ No clippy warnings introduced
• ✅ Function semantics remain identical to the inlined version

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.