Skip to content

Comments

refactor: generalize ParseError to OxcError with dynamic EventKind#7868

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-13-refactor_generalize_parseerror_to_oxcerror_with_dynamic_eventkind
Jan 14, 2026
Merged

refactor: generalize ParseError to OxcError with dynamic EventKind#7868
graphite-app[bot] merged 1 commit intomainfrom
01-13-refactor_generalize_parseerror_to_oxcerror_with_dynamic_eventkind

Conversation

@shulaoda
Copy link
Member

No description provided.

Copy link
Member Author

shulaoda commented Jan 13, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda force-pushed the 01-13-refactor_generalize_parseerror_to_oxcerror_with_dynamic_eventkind branch 3 times, most recently from 7a682dd to fa00362 Compare January 14, 2026 06:11
@shulaoda shulaoda force-pushed the 01-12-feat_emit_transformer_warnings_instead_of_ignoring_them branch from eb21a3b to 1788076 Compare January 14, 2026 06:11
@shulaoda shulaoda force-pushed the 01-13-refactor_generalize_parseerror_to_oxcerror_with_dynamic_eventkind branch from fa00362 to 86ae261 Compare January 14, 2026 06:23
@shulaoda shulaoda marked this pull request as ready for review January 14, 2026 06:31
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: 01-12-feat_emit_transformer_warnings_instead_of_ignoring_them(1788076)
  • pr: 01-13-refactor_generalize_parseerror_to_oxcerror_with_dynamic_eventkind(86ae261)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     72.2±2.41ms        ? ?/sec    1.02     73.4±2.48ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     78.5±1.62ms        ? ?/sec    1.03     80.6±2.13ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    105.5±2.63ms        ? ?/sec    1.00    105.1±1.84ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    116.8±1.73ms        ? ?/sec    1.00    117.1±2.37ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.1±2.17ms        ? ?/sec    1.01     39.6±2.12ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.4±0.57ms        ? ?/sec    1.00     43.4±0.52ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    388.9±7.68ms        ? ?/sec    1.00    388.3±4.15ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    450.1±4.31ms        ? ?/sec    1.00    449.0±4.49ms        ? ?/sec
scan/scan@rome_ts                                            1.00     82.4±1.25ms        ? ?/sec    1.02     84.1±1.78ms        ? ?/sec
scan/scan@threejs                                            1.01     28.3±0.44ms        ? ?/sec    1.00     28.1±0.36ms        ? ?/sec
scan/scan@threejs10x                                         1.00    289.2±4.99ms        ? ?/sec    1.00    289.4±4.21ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from 01-12-feat_emit_transformer_warnings_instead_of_ignoring_them to graphite-base/7868 January 14, 2026 07:20
@graphite-app graphite-app bot force-pushed the graphite-base/7868 branch from 1788076 to dfe05e7 Compare January 14, 2026 07:31
@graphite-app graphite-app bot force-pushed the 01-13-refactor_generalize_parseerror_to_oxcerror_with_dynamic_eventkind branch from 86ae261 to 92e24df Compare January 14, 2026 07:31
@graphite-app graphite-app bot changed the base branch from graphite-base/7868 to main January 14, 2026 07:31
@graphite-app graphite-app bot force-pushed the 01-13-refactor_generalize_parseerror_to_oxcerror_with_dynamic_eventkind branch from 92e24df to 8d02177 Compare January 14, 2026 07:32
@netlify
Copy link

netlify bot commented Jan 14, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8ce2459
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/696749ecf1431100080c38f1

Copy link
Member Author

shulaoda commented Jan 14, 2026

Merge activity

  • Jan 14, 7:41 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 14, 7:46 AM UTC: shulaoda added this pull request to the Graphite merge queue.
  • Jan 14, 7:57 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 01-13-refactor_generalize_parseerror_to_oxcerror_with_dynamic_eventkind branch from 8d02177 to 8ce2459 Compare January 14, 2026 07:46
@graphite-app graphite-app bot merged commit 8ce2459 into main Jan 14, 2026
34 checks passed
@graphite-app graphite-app bot deleted the 01-13-refactor_generalize_parseerror_to_oxcerror_with_dynamic_eventkind branch January 14, 2026 07:57
shulaoda added a commit that referenced this pull request Jan 14, 2026
## [1.0.0-beta.60] - 2026-01-14

### 💥 BREAKING CHANGES

- tsconfig: enable auto-discovery by default (#7817) by @shulaoda

### 🚀 Features

- distinguish transformer diagnostics from parse errors (#7872) by @shulaoda
- emit transformer warnings instead of ignoring them (#7850) by @shulaoda
- node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0
- nativeMagicString reset (#7828) by @IWANABETHATGUY
- nativeMagicString lastChar (#7819) by @IWANABETHATGUY
- dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0
- nativeMagicString snip (#7818) by @IWANABETHATGUY
- nativeMagicString construct with options (#7814) by @IWANABETHATGUY
- nativeMagicString clone (#7813) by @IWANABETHATGUY
- nativeMagicString `insert` (#7812) by @IWANABETHATGUY
- nativeMagicString `slice` (#7807) by @IWANABETHATGUY
- nativeMagicString trim methods (#7800) by @IWANABETHATGUY
- make closeBundle hook receive the last error (#7278) by @Copilot

### 🐛 Bug Fixes

- when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY
- inline __name calls for default exports  (#7862) by @IWANABETHATGUY
- improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY
- use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY
- transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda
- dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0
- set ExportsKind to Esm when json is none object literal  (#7808) by @IWANABETHATGUY
- nativeMagicString move api (#7796) by @IWANABETHATGUY
- remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY
- use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot

### 🚜 Refactor

- generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda
- rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0
- string_wizard error hanlding (#7830) by @IWANABETHATGUY
- remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red
- node/test: run fixture tests in concurrent (#7790) by @hyf0
- move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda
- cli: validate config after resolving and improve error message (#7798) by @shulaoda

### 📚 Documentation

- rebrand (#7670) by @yyx990803
- fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot
- remove options pages and redirect to reference pages (#7834) by @sapphi-red
- options: inline types to option property pages (#7831) by @sapphi-red
- options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red
- options: use `@linkcode` where possible (#7824) by @sapphi-red
- options: port content from options page to reference page (#7822) by @sapphi-red
- options: add descriptions for output options (#7821) by @sapphi-red
- options: add description for input options (#7802) by @sapphi-red
- options: add description for `checks.*` (#7801) by @sapphi-red
- apis: add hook graph (#7671) by @sapphi-red

### 🧪 Testing

- add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY
- enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY
- init magic-string test (#7794) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- vite-tests: configure git user for rebase operation (#7875) by @shulaoda
- rolldown_binding: remove v3 native plugins (#7837) by @shulaoda
- rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn
- README.md: adjust position and size of rolldown logo (#7861) by @hyf0
- deps: update test262 submodule for tests (#7857) by @sapphi-red
- deps: update oxc to v0.108.0 (#7845) by @renovate[bot]
- deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot]
- deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot]
- deps: update npm packages (#7841) by @renovate[bot]
- deps: update rust crates (#7839) by @renovate[bot]
- deps: update github-actions (#7840) by @renovate[bot]
- use workspace edition for all crates (#7829) by @IWANABETHATGUY
- deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot]
- deps: update napi to v3.8.2 (#7810) by @renovate[bot]
- remove outdated snapshot files (#7806) by @shulaoda
- deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants