refactor(rust): rename `advanced_chunks` to `manual_code_splitting` by hyf0 · Pull Request #7856 · rolldown/rolldown

hyf0 · 2026-01-12T20:03:56Z

Part of #7330

hyf0 · 2026-01-12T20:04:14Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

hyf0 · 2026-01-12T20:05:04Z

Merge activity

Jan 12, 8:05 PM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 13, 4:32 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Jan 13, 4:43 AM UTC: Merged by the Graphite merge queue.

github-actions · 2026-01-12T20:21:52Z

Benchmarks Rust

target: 01-13-feat_node_add_output.codesplitting_option_and_deprecate_output.advancedchunks_(13b85c6)
pr: 01-13-refactor_rust_rename_advancedchunks_to_manual_code_splitting_(265645f)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     68.5±2.85ms        ? ?/sec    1.00     66.9±1.98ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     74.1±1.64ms        ? ?/sec    1.00     72.6±2.13ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    102.6±2.06ms        ? ?/sec    1.00    100.9±1.71ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    114.9±2.07ms        ? ?/sec    1.00    114.0±1.36ms        ? ?/sec
bundle/bundle@threejs                                        1.03     39.0±2.20ms        ? ?/sec    1.00     37.7±1.93ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     43.6±0.74ms        ? ?/sec    1.00     42.8±0.60ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    379.3±4.31ms        ? ?/sec    1.00    377.1±3.34ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    450.4±3.87ms        ? ?/sec    1.00    445.0±3.43ms        ? ?/sec
scan/scan@rome_ts                                            1.00     75.8±1.45ms        ? ?/sec    1.00     75.5±1.67ms        ? ?/sec
scan/scan@threejs                                            1.01     26.6±1.65ms        ? ?/sec    1.00     26.4±1.74ms        ? ?/sec
scan/scan@threejs10x                                         1.01    271.7±4.26ms        ? ?/sec    1.00    269.8±3.29ms        ? ?/sec

sapphi-red

(the CI needs to be fixed)

Copilot

Pull request overview

This PR renames advancedChunks to manualCodeSplitting throughout the codebase as part of issue #7330, which aimed to find a better name for the advanced chunking feature. The rename is comprehensive, touching TypeScript bindings, Rust implementation, test configurations, and snapshots.

Changes:

Renamed TypeScript types and options from BindingAdvancedChunksOptions to BindingManualCodeSplittingOptions
Renamed Rust structs, fields, and modules from advanced_chunks/AdvancedChunksOptions to manual_code_splitting/ManualCodeSplittingOptions
Updated all test configuration files to use manualCodeSplitting instead of advancedChunks
Updated enum variants from AdvancedChunks to ManualCodeSplitting in chunk reason types
Renamed module file from advanced_chunks.rs to manual_code_splitting.rs

Reviewed changes

Copilot reviewed 57 out of 58 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
packages/rolldown/src/utils/bindingify-output-options.ts	Updated option mapping and type references from advancedChunks to manualCodeSplitting
packages/rolldown/src/binding.d.cts	Renamed interface from BindingAdvancedChunksOptions to BindingManualCodeSplittingOptions
crates/rolldown_testing/_config.schema.json	Updated JSON schema reference from AdvancedChunksOptions to ManualCodeSplittingOptions
crates/rolldown_error/src/build_diagnostic/events/invalid_option.rs	Updated error variant names and messages (with inconsistencies noted)
crates/rolldown_common/src/lib.rs	Updated public exports to use manual_code_splitting_options module
crates/rolldown_common/src/inner_bundler_options/types/normalized_bundler_options.rs	Renamed field from advanced_chunks to manual_code_splitting
crates/rolldown_common/src/inner_bundler_options/types/mod.rs	Renamed module from advanced_chunks_options to manual_code_splitting_options
crates/rolldown_common/src/inner_bundler_options/types/manual_code_splitting_options.rs	Renamed struct from AdvancedChunksOptions to ManualCodeSplittingOptions
crates/rolldown_common/src/inner_bundler_options/mod.rs	Updated import to use ManualCodeSplittingOptions
crates/rolldown_common/src/chunk/types/chunk_reason_type.rs	Renamed enum variant from AdvancedChunks to ManualCodeSplitting
crates/rolldown_binding/src/utils/normalize_binding_options.rs	Updated option mapping to use ManualCodeSplittingOptions
crates/rolldown_binding/src/options/binding_output_options/mod.rs	Updated module import and field name
crates/rolldown_binding/src/options/binding_output_options/binding_manual_code_splitting_options.rs	Renamed struct from BindingAdvancedChunksOptions to BindingManualCodeSplittingOptions
crates/rolldown/src/utils/prepare_build_context.rs	Updated all references from advanced_chunks to manual_code_splitting
crates/rolldown/src/stages/generate_stage/mod.rs	Renamed module from advanced_chunks to manual_code_splitting
crates/rolldown/src/stages/generate_stage/manual_code_splitting.rs	Renamed function from apply_advanced_chunks to apply_manual_code_splitting
crates/rolldown/src/stages/generate_stage/code_splitting.rs	Updated function call to use new name
crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs	Updated enum variant reference in match pattern
crates/rolldown/src/stages/generate_stage/chunk_ext.rs	Renamed enum variant and updated debug formatting
Test config files (30+ files)	Updated all test configurations from advancedChunks to manualCodeSplitting
Test snapshot files	Updated expected outputs with new terminology and adjusted content hashes

Files not reviewed (1)

crates/rolldown/tests/rolldown/function/advanced_chunks/split_node_modules/_config.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_error/src/build_diagnostic/events/invalid_option.rs

crates/rolldown/tests/rolldown/issues/3650/artifacts.snap

...id_option/include_dependencies_recursively_conflict_preserve_entry_signatures/artifacts.snap

...ts/rolldown/errors/invalid_option/inline_dynamic_imports_with_advanced_chunks/artifacts.snap

crates/rolldown/src/utils/prepare_build_context.rs

crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs

crates/rolldown_error/src/build_diagnostic/events/invalid_option.rs

...id_option/include_dependencies_recursively_implicit_preserve_entry_signatures/artifacts.snap

…7856) Part of #7330

@shulaoda

## [1.0.0-beta.60] - 2026-01-14 ### 💥 BREAKING CHANGES - tsconfig: enable auto-discovery by default (#7817) by @shulaoda ### 🚀 Features - distinguish transformer diagnostics from parse errors (#7872) by @shulaoda - emit transformer warnings instead of ignoring them (#7850) by @shulaoda - node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0 - nativeMagicString reset (#7828) by @IWANABETHATGUY - nativeMagicString lastChar (#7819) by @IWANABETHATGUY - dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0 - nativeMagicString snip (#7818) by @IWANABETHATGUY - nativeMagicString construct with options (#7814) by @IWANABETHATGUY - nativeMagicString clone (#7813) by @IWANABETHATGUY - nativeMagicString `insert` (#7812) by @IWANABETHATGUY - nativeMagicString `slice` (#7807) by @IWANABETHATGUY - nativeMagicString trim methods (#7800) by @IWANABETHATGUY - make closeBundle hook receive the last error (#7278) by @Copilot ### 🐛 Bug Fixes - when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY - inline __name calls for default exports (#7862) by @IWANABETHATGUY - improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY - use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY - transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda - dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0 - set ExportsKind to Esm when json is none object literal (#7808) by @IWANABETHATGUY - nativeMagicString move api (#7796) by @IWANABETHATGUY - remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY - use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot ### 🚜 Refactor - generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda - rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0 - string_wizard error hanlding (#7830) by @IWANABETHATGUY - remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red - node/test: run fixture tests in concurrent (#7790) by @hyf0 - move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda - cli: validate config after resolving and improve error message (#7798) by @shulaoda ### 📚 Documentation - rebrand (#7670) by @yyx990803 - fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot - remove options pages and redirect to reference pages (#7834) by @sapphi-red - options: inline types to option property pages (#7831) by @sapphi-red - options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red - options: use `@linkcode` where possible (#7824) by @sapphi-red - options: port content from options page to reference page (#7822) by @sapphi-red - options: add descriptions for output options (#7821) by @sapphi-red - options: add description for input options (#7802) by @sapphi-red - options: add description for `checks.*` (#7801) by @sapphi-red - apis: add hook graph (#7671) by @sapphi-red ### 🧪 Testing - add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY - enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY - init magic-string test (#7794) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - vite-tests: configure git user for rebase operation (#7875) by @shulaoda - rolldown_binding: remove v3 native plugins (#7837) by @shulaoda - rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn - README.md: adjust position and size of rolldown logo (#7861) by @hyf0 - deps: update test262 submodule for tests (#7857) by @sapphi-red - deps: update oxc to v0.108.0 (#7845) by @renovate[bot] - deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot] - deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot] - deps: update npm packages (#7841) by @renovate[bot] - deps: update rust crates (#7839) by @renovate[bot] - deps: update github-actions (#7840) by @renovate[bot] - use workspace edition for all crates (#7829) by @IWANABETHATGUY - deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot] - deps: update napi to v3.8.2 (#7810) by @renovate[bot] - remove outdated snapshot files (#7806) by @shulaoda - deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned hyf0 Jan 12, 2026

hyf0 marked this pull request as ready for review January 12, 2026 20:04

Copilot AI review requested due to automatic review settings January 12, 2026 20:04

hyf0 mentioned this pull request Jan 12, 2026

feat(node): add output.codeSplitting option and deprecate output.advancedChunks #7855

Merged

hyf0 changed the title ~~refactor(rust): rename advancedChunks to manual_code_splitting~~ refactor(rust): rename advanced_chunks to manual_code_splitting Jan 12, 2026

Copilot started reviewing on behalf of hyf0 January 12, 2026 20:04 View session

hyf0 added the graphite: merge-when-ready label Jan 12, 2026 — with Graphite App

hyf0 requested review from sapphi-red and shulaoda and removed request for Copilot January 12, 2026 20:05

sapphi-red approved these changes Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 03:53

hyf0 force-pushed the 01-13-feat_node_add_output.codesplitting_option_and_deprecate_output.advancedchunks_ branch from 13b85c6 to 0a5227a Compare January 13, 2026 03:53

hyf0 force-pushed the 01-13-refactor_rust_rename_advancedchunks_to_manual_code_splitting_ branch from 265645f to 7027b9c Compare January 13, 2026 03:53

Copilot started reviewing on behalf of hyf0 January 13, 2026 03:53 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

refactor(rust): rename advanced_chunks to manual_code_splitting (#…

c37bd72

…7856) Part of #7330

graphite-app bot force-pushed the 01-13-feat_node_add_output.codesplitting_option_and_deprecate_output.advancedchunks_ branch from 0a5227a to 23a80da Compare January 13, 2026 04:32

graphite-app bot force-pushed the 01-13-refactor_rust_rename_advancedchunks_to_manual_code_splitting_ branch from 7027b9c to c37bd72 Compare January 13, 2026 04:33

Base automatically changed from 01-13-feat_node_add_output.codesplitting_option_and_deprecate_output.advancedchunks_ to main January 13, 2026 04:41

graphite-app bot removed the graphite: merge-when-ready label Jan 13, 2026

graphite-app bot merged commit c37bd72 into main Jan 13, 2026
31 checks passed

graphite-app bot deleted the 01-13-refactor_rust_rename_advancedchunks_to_manual_code_splitting_ branch January 13, 2026 04:43

This was referenced Jan 14, 2026

release: v1.0.0-beta.60 #7869

Closed

release: v1.0.0-beta.60 #7877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor(rust): rename `advanced_chunks` to `manual_code_splitting`#7856

refactor(rust): rename `advanced_chunks` to `manual_code_splitting`#7856
graphite-app[bot] merged 1 commit intomainfrom
01-13-refactor_rust_rename_advancedchunks_to_manual_code_splitting_

hyf0 commented Jan 12, 2026 •

edited

Loading

Uh oh!

hyf0 commented Jan 12, 2026 •

edited

Loading

Uh oh!

hyf0 commented Jan 12, 2026 •

edited by graphite-app bot

Loading

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

sapphi-red left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

hyf0 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyf0 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

hyf0 commented Jan 12, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

github-actions bot commented Jan 12, 2026

Benchmarks Rust

Uh oh!

sapphi-red left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hyf0 commented Jan 12, 2026 •

edited

Loading

hyf0 commented Jan 12, 2026 •

edited

Loading

hyf0 commented Jan 12, 2026 •

edited by graphite-app bot

Loading