fix: use correct index when inserting keepNames statements during export default transformation by IWANABETHATGUY · Pull Request #7853 · rolldown/rolldown

IWANABETHATGUY · 2026-01-12T16:13:44Z

IWANABETHATGUY · 2026-01-12T16:14:05Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-12T16:15:21Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`74c0c54`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69652a8b7e980b000878b12c

crates/rolldown/src/module_finalizers/mod.rs

Copilot

Pull request overview

This PR fixes a bug where keepNames statements were inserted at incorrect positions during export default transformation. The issue occurred when using self.cur_stmt_index (which tracks position during AST visitation) instead of program.body.len() (which tracks the current build state) in the remove_unused_top_level_stmt function.

Changes:

Fixed index calculation for inserting __name() helper calls after export default transformations involving anonymous expressions
Added test case to verify the fix works correctly with arrow function exports

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/rolldown/src/module_finalizers/mod.rs	Fixed `insert_position` calculation to use `program.body.len() + 1` instead of `self.cur_stmt_index + 1` for correct insertion of keepNames statements
crates/rolldown/tests/rolldown/topics/keep_names/issue_7852/main.js	Added test case with arrow function assigned to const and exported as default to validate the fix
crates/rolldown/tests/rolldown/topics/keep_names/issue_7852/_config.json	Configuration file enabling `keepNames` for the test
crates/rolldown/tests/rolldown/topics/keep_names/issue_7852/artifacts.snap	Expected snapshot output showing correct code generation
crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap	Updated snapshot to include new test case hash

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/tests/rolldown/topics/keep_names/issue_7852/artifacts.snap

github-actions · 2026-01-12T16:52:30Z

Benchmarks Rust

target: main(edc8809)
pr: 01-13-fix_7852(74c0c54)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     72.8±2.25ms        ? ?/sec    1.05     76.5±1.97ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     78.2±1.83ms        ? ?/sec    1.06     82.8±1.64ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    105.5±2.35ms        ? ?/sec    1.03    108.9±1.90ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    117.2±2.08ms        ? ?/sec    1.03    120.8±2.35ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.2±2.33ms        ? ?/sec    1.04     40.9±2.10ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.7±1.49ms        ? ?/sec    1.03     44.9±0.65ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    386.0±4.25ms        ? ?/sec    1.04    399.8±5.59ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    448.9±4.69ms        ? ?/sec    1.03    461.5±6.05ms        ? ?/sec
scan/scan@rome_ts                                            1.01     84.6±1.78ms        ? ?/sec    1.00     84.1±2.02ms        ? ?/sec
scan/scan@threejs                                            1.00     29.2±0.57ms        ? ?/sec    1.00     29.2±1.69ms        ? ?/sec
scan/scan@threejs10x                                         1.01    295.6±4.55ms        ? ?/sec    1.00    293.8±5.62ms        ? ?/sec

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/tests/rolldown/topics/keep_names/issue_7852/artifacts.snap

graphite-app · 2026-01-12T17:07:52Z

Merge activity

Jan 12, 5:07 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 12, 5:18 PM UTC: Merged by the Graphite merge queue.

…ort default transformation (#7853) closed #7852

@shulaoda

## [1.0.0-beta.60] - 2026-01-14 ### 💥 BREAKING CHANGES - tsconfig: enable auto-discovery by default (#7817) by @shulaoda ### 🚀 Features - distinguish transformer diagnostics from parse errors (#7872) by @shulaoda - emit transformer warnings instead of ignoring them (#7850) by @shulaoda - node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0 - nativeMagicString reset (#7828) by @IWANABETHATGUY - nativeMagicString lastChar (#7819) by @IWANABETHATGUY - dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0 - nativeMagicString snip (#7818) by @IWANABETHATGUY - nativeMagicString construct with options (#7814) by @IWANABETHATGUY - nativeMagicString clone (#7813) by @IWANABETHATGUY - nativeMagicString `insert` (#7812) by @IWANABETHATGUY - nativeMagicString `slice` (#7807) by @IWANABETHATGUY - nativeMagicString trim methods (#7800) by @IWANABETHATGUY - make closeBundle hook receive the last error (#7278) by @Copilot ### 🐛 Bug Fixes - when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY - inline __name calls for default exports (#7862) by @IWANABETHATGUY - improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY - use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY - transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda - dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0 - set ExportsKind to Esm when json is none object literal (#7808) by @IWANABETHATGUY - nativeMagicString move api (#7796) by @IWANABETHATGUY - remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY - use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot ### 🚜 Refactor - generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda - rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0 - string_wizard error hanlding (#7830) by @IWANABETHATGUY - remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red - node/test: run fixture tests in concurrent (#7790) by @hyf0 - move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda - cli: validate config after resolving and improve error message (#7798) by @shulaoda ### 📚 Documentation - rebrand (#7670) by @yyx990803 - fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot - remove options pages and redirect to reference pages (#7834) by @sapphi-red - options: inline types to option property pages (#7831) by @sapphi-red - options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red - options: use `@linkcode` where possible (#7824) by @sapphi-red - options: port content from options page to reference page (#7822) by @sapphi-red - options: add descriptions for output options (#7821) by @sapphi-red - options: add description for input options (#7802) by @sapphi-red - options: add description for `checks.*` (#7801) by @sapphi-red - apis: add hook graph (#7671) by @sapphi-red ### 🧪 Testing - add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY - enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY - init magic-string test (#7794) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - vite-tests: configure git user for rebase operation (#7875) by @shulaoda - rolldown_binding: remove v3 native plugins (#7837) by @shulaoda - rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn - README.md: adjust position and size of rolldown logo (#7861) by @hyf0 - deps: update test262 submodule for tests (#7857) by @sapphi-red - deps: update oxc to v0.108.0 (#7845) by @renovate[bot] - deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot] - deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot] - deps: update npm packages (#7841) by @renovate[bot] - deps: update rust crates (#7839) by @renovate[bot] - deps: update github-actions (#7840) by @renovate[bot] - use workspace edition for all crates (#7829) by @IWANABETHATGUY - deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot] - deps: update napi to v3.8.2 (#7810) by @renovate[bot] - remove outdated snapshot files (#7806) by @shulaoda - deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Jan 12, 2026

IWANABETHATGUY commented Jan 12, 2026

View reviewed changes

crates/rolldown/src/module_finalizers/mod.rs Show resolved Hide resolved

IWANABETHATGUY force-pushed the 01-13-fix_7852 branch from 3340ae8 to 9209a5e Compare January 12, 2026 16:30

IWANABETHATGUY changed the title ~~fix: 7852~~ fix: correct insert position for keepNames statements Jan 12, 2026

IWANABETHATGUY changed the title ~~fix: correct insert position for keepNames statements~~ fix: use correct index when inserting keepNames statements during export default transformation Jan 12, 2026

IWANABETHATGUY force-pushed the 01-13-fix_7852 branch from 9209a5e to 1f8ab97 Compare January 12, 2026 16:36

IWANABETHATGUY marked this pull request as ready for review January 12, 2026 16:37

Copilot AI review requested due to automatic review settings January 12, 2026 16:37

Copilot started reviewing on behalf of IWANABETHATGUY January 12, 2026 16:37 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

hyf0 reviewed Jan 12, 2026

View reviewed changes

crates/rolldown/tests/rolldown/topics/keep_names/issue_7852/artifacts.snap Outdated Show resolved Hide resolved

IWANABETHATGUY force-pushed the 01-13-fix_7852 branch from 1f8ab97 to 35d3588 Compare January 12, 2026 16:54

Copilot AI review requested due to automatic review settings January 12, 2026 16:55

IWANABETHATGUY force-pushed the 01-13-fix_7852 branch from 35d3588 to a2dd5a1 Compare January 12, 2026 16:55

Copilot started reviewing on behalf of IWANABETHATGUY January 12, 2026 16:56 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

hyf0 reviewed Jan 12, 2026

View reviewed changes

crates/rolldown/tests/rolldown/topics/keep_names/issue_7852/artifacts.snap Show resolved Hide resolved

hyf0 approved these changes Jan 12, 2026

View reviewed changes

IWANABETHATGUY mentioned this pull request Jan 12, 2026

Better keepNames transformation for export default arrow expr #7854

Closed

fix: use correct index when inserting keepNames statements during exp…

74c0c54

…ort default transformation (#7853) closed #7852

graphite-app bot force-pushed the 01-13-fix_7852 branch from a2dd5a1 to 74c0c54 Compare January 12, 2026 17:08

graphite-app bot merged commit 74c0c54 into main Jan 12, 2026
35 checks passed

graphite-app bot deleted the 01-13-fix_7852 branch January 12, 2026 17:18

sapphi-red mentioned this pull request Jan 13, 2026

Incorrect emit order: __name runtime helper called before variable is defined #7852

Closed

This was referenced Jan 14, 2026

release: v1.0.0-beta.60 #7869

Closed

release: v1.0.0-beta.60 #7877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: use correct index when inserting keepNames statements during export default transformation#7853

fix: use correct index when inserting keepNames statements during export default transformation#7853
graphite-app[bot] merged 1 commit intomainfrom
01-13-fix_7852

IWANABETHATGUY commented Jan 12, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Jan 12, 2026

Uh oh!

netlify bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Jan 12, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

graphite-app bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Jan 12, 2026 •

edited

Loading

netlify bot commented Jan 12, 2026 •

edited

Loading

github-actions bot commented Jan 12, 2026 •

edited

Loading

graphite-app bot commented Jan 12, 2026 •

edited

Loading