chore(rolldown_binding): remove v3 native plugins by shulaoda · Pull Request #7837 · rolldown/rolldown

shulaoda · 2026-01-10T13:51:53Z

shulaoda · 2026-01-10T13:52:21Z

chore(rolldown_binding): remove v3 native plugins #7837 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-10T13:53:35Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`bb37a1f`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69674f32b856bf0008d5ef42
😎 Deploy Preview	https://deploy-preview-7837--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

socket-security · 2026-01-14T07:41:33Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

Copilot

Pull request overview

This pull request removes v3 native plugins from the rolldown binding layer, as these plugins are not planned to be enabled at this time (per issue #7825 and related upstream discussion). The removal is comprehensive, covering TypeScript exports, Rust plugin implementations, binding configurations, and associated test fixtures.

Changes:

Removed six v3 native plugin implementations and their TypeScript wrappers
Cleaned up binding layer references to removed plugins
Deleted test fixtures for removed plugins
Changed transformToRollupOutputChunk from exported to internal function

Reviewed changes

Copilot reviewed 30 out of 32 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`packages/rolldown/src/experimental-index.ts`	Removed exports for viteAssetPlugin, viteAssetImportMetaUrlPlugin, viteCSSPlugin, viteCSSPostPlugin, viteHtmlPlugin, and viteHtmlInlineProxyPlugin
`packages/rolldown/src/builtin-plugin/*.ts`	Deleted plugin wrapper files for asset, css, css-post, and html plugins
`packages/rolldown/src/builtin-plugin/utils.ts`	Removed bindingifyCSSPostPlugin and bindingifyViteHtmlPlugin functions and related imports
`packages/rolldown/src/builtin-plugin/constructors.ts`	Removed factory functions for viteHtmlInlineProxyPlugin and viteAssetImportMetaUrlPlugin
`packages/rolldown/src/utils/bindingify-input-options.ts`	Removed switch cases for removed plugins
`packages/rolldown/src/utils/transform-to-rollup-output.ts`	Changed transformToRollupOutputChunk visibility from export to internal function
`packages/rolldown/src/binding.d.cts`	Removed TypeScript type definitions for removed plugin configs and BindingUrlResolver
`packages/rolldown/src/binding.cjs`	Removed BindingUrlResolver export
`packages/rolldown/src/rolldown-binding.wasi.cjs`	Removed BindingUrlResolver export
`packages/rolldown/src/rolldown-binding.wasi-browser.js`	Removed BindingUrlResolver export
`crates/rolldown_binding/Cargo.toml`	Removed dependencies on deleted plugin crates
`Cargo.toml`	Removed workspace member references to deleted plugin crates
`Cargo.lock`	Updated lockfile to reflect removed dependencies
`crates/rolldown_binding/src/options/plugin/config/mod.rs`	Removed imports and re-exports for deleted plugin configs
`crates/rolldown_binding/src/options/plugin/config/binding_vite_*.rs`	Deleted configuration files for removed plugins
`crates/rolldown_binding/src/options/plugin/types/binding_builtin_plugin_name.rs`	Removed enum variants for deleted plugins
`crates/rolldown_binding/src/options/plugin/binding_builtin_plugin.rs`	Removed plugin initialization cases and unused imports
`packages/rolldown/tests/fixtures/builtin-plugin/wasm-helper-v2/*`	Deleted v2 test fixture directory
`packages/rolldown/tests/fixtures/builtin-plugin/asset-import-meta-url/dynamic-url/*`	Deleted dynamic-url test fixture directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-01-14T08:27:43Z

Benchmarks Rust

target: main(3bcb41b)
pr: 01-10-chore_rolldown_binding_remove_v3_native_plugins(bb37a1f)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     71.0±1.60ms        ? ?/sec    1.00     71.2±1.88ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     77.5±1.69ms        ? ?/sec    1.00     76.6±1.70ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    103.9±3.06ms        ? ?/sec    1.00    104.1±1.66ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    115.2±1.59ms        ? ?/sec    1.00    115.5±1.94ms        ? ?/sec
bundle/bundle@threejs                                        1.00     37.3±2.10ms        ? ?/sec    1.00     37.3±0.74ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.1±0.56ms        ? ?/sec    1.01     42.6±0.70ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    381.0±3.72ms        ? ?/sec    1.00    382.2±3.86ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    442.9±3.29ms        ? ?/sec    1.00    443.0±4.82ms        ? ?/sec
scan/scan@rome_ts                                            1.00     80.5±1.63ms        ? ?/sec    1.02     82.5±1.77ms        ? ?/sec
scan/scan@threejs                                            1.00     27.7±0.45ms        ? ?/sec    1.00     27.7±0.41ms        ? ?/sec
scan/scan@threejs10x                                         1.01    290.1±4.55ms        ? ?/sec    1.00    288.6±4.05ms        ? ?/sec

@shulaoda

## [1.0.0-beta.60] - 2026-01-14 ### 💥 BREAKING CHANGES - tsconfig: enable auto-discovery by default (#7817) by @shulaoda ### 🚀 Features - distinguish transformer diagnostics from parse errors (#7872) by @shulaoda - emit transformer warnings instead of ignoring them (#7850) by @shulaoda - node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0 - nativeMagicString reset (#7828) by @IWANABETHATGUY - nativeMagicString lastChar (#7819) by @IWANABETHATGUY - dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0 - nativeMagicString snip (#7818) by @IWANABETHATGUY - nativeMagicString construct with options (#7814) by @IWANABETHATGUY - nativeMagicString clone (#7813) by @IWANABETHATGUY - nativeMagicString `insert` (#7812) by @IWANABETHATGUY - nativeMagicString `slice` (#7807) by @IWANABETHATGUY - nativeMagicString trim methods (#7800) by @IWANABETHATGUY - make closeBundle hook receive the last error (#7278) by @Copilot ### 🐛 Bug Fixes - when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY - inline __name calls for default exports (#7862) by @IWANABETHATGUY - improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY - use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY - transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda - dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0 - set ExportsKind to Esm when json is none object literal (#7808) by @IWANABETHATGUY - nativeMagicString move api (#7796) by @IWANABETHATGUY - remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY - use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot ### 🚜 Refactor - generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda - rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0 - string_wizard error hanlding (#7830) by @IWANABETHATGUY - remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red - node/test: run fixture tests in concurrent (#7790) by @hyf0 - move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda - cli: validate config after resolving and improve error message (#7798) by @shulaoda ### 📚 Documentation - rebrand (#7670) by @yyx990803 - fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot - remove options pages and redirect to reference pages (#7834) by @sapphi-red - options: inline types to option property pages (#7831) by @sapphi-red - options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red - options: use `@linkcode` where possible (#7824) by @sapphi-red - options: port content from options page to reference page (#7822) by @sapphi-red - options: add descriptions for output options (#7821) by @sapphi-red - options: add description for input options (#7802) by @sapphi-red - options: add description for `checks.*` (#7801) by @sapphi-red - apis: add hook graph (#7671) by @sapphi-red ### 🧪 Testing - add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY - enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY - init magic-string test (#7794) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - vite-tests: configure git user for rebase operation (#7875) by @shulaoda - rolldown_binding: remove v3 native plugins (#7837) by @shulaoda - rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn - README.md: adjust position and size of rolldown logo (#7861) by @hyf0 - deps: update test262 submodule for tests (#7857) by @sapphi-red - deps: update oxc to v0.108.0 (#7845) by @renovate[bot] - deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot] - deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot] - deps: update npm packages (#7841) by @renovate[bot] - deps: update rust crates (#7839) by @renovate[bot] - deps: update github-actions (#7840) by @renovate[bot] - use workspace edition for all crates (#7829) by @IWANABETHATGUY - deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot] - deps: update napi to v3.8.2 (#7810) by @renovate[bot] - remove outdated snapshot files (#7806) by @shulaoda - deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned shulaoda Jan 10, 2026

shulaoda force-pushed the 01-10-chore_rolldown_binding_remove_v3_native_plugins branch from d193d0b to 372a9ce Compare January 14, 2026 07:41

shulaoda force-pushed the 01-10-chore_rolldown_binding_remove_v3_native_plugins branch 2 times, most recently from 426b82e to c869168 Compare January 14, 2026 08:04

chore(rolldown_binding): remove v3 native plugins

bb37a1f

shulaoda force-pushed the 01-10-chore_rolldown_binding_remove_v3_native_plugins branch from c869168 to bb37a1f Compare January 14, 2026 08:09

shulaoda requested review from IWANABETHATGUY, hyf0 and sapphi-red January 14, 2026 08:14

shulaoda marked this pull request as ready for review January 14, 2026 08:14

Copilot AI review requested due to automatic review settings January 14, 2026 08:14

Copilot started reviewing on behalf of shulaoda January 14, 2026 08:15 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

sapphi-red approved these changes Jan 14, 2026

View reviewed changes

shulaoda merged commit 15907bc into main Jan 14, 2026
44 checks passed

shulaoda deleted the 01-10-chore_rolldown_binding_remove_v3_native_plugins branch January 14, 2026 08:33

github-actions bot mentioned this pull request Jan 14, 2026

release: v1.0.0-beta.60 #7877

Merged

github-actions bot mentioned this pull request Jan 14, 2026

release: v0.0.0-beta.2 leegeunhyeok/rolldown#5

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

chore(rolldown_binding): remove v3 native plugins#7837

chore(rolldown_binding): remove v3 native plugins#7837
shulaoda merged 1 commit intomainfrom
01-10-chore_rolldown_binding_remove_v3_native_plugins

shulaoda commented Jan 10, 2026 •

edited

Loading

Uh oh!

shulaoda commented Jan 10, 2026

Uh oh!

netlify bot commented Jan 10, 2026 •

edited

Loading

Uh oh!

socket-security bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

shulaoda commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Jan 10, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

socket-security bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Jan 14, 2026

Benchmarks Rust

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shulaoda commented Jan 10, 2026 •

edited

Loading

netlify bot commented Jan 10, 2026 •

edited

Loading

socket-security bot commented Jan 14, 2026 •

edited

Loading