Skip to content

Comments

docs(options): port checks.pluginTimings content from options page to reference page#7832

Merged
sapphi-red merged 1 commit intomainfrom
01-10-docs_options_port_checks.plugintimings_content_from_options_page_to_reference_page
Jan 10, 2026
Merged

docs(options): port checks.pluginTimings content from options page to reference page#7832
sapphi-red merged 1 commit intomainfrom
01-10-docs_options_port_checks.plugintimings_content_from_options_page_to_reference_page

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 10, 2026

Follow up to #7822

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review January 10, 2026 07:02
Copilot AI review requested due to automatic review settings January 10, 2026 07:02
@netlify
Copy link

netlify bot commented Jan 10, 2026

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 603c159
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6961f91a62b3fd0008dcd378
😎 Deploy Preview https://deploy-preview-7832--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for the checks.pluginTimings option by creating a dedicated markdown file and referencing it using include directives. This is a follow-up to PR #7822 that properly organizes the documentation content.

Changes:

  • Created a new markdown documentation file explaining how plugin timing warnings work
  • Added {@include} directive to the Rust enum source that generates the TypeScript interface
  • The TypeScript interface now includes the documentation reference (via code generation)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/rolldown/src/options/docs/checks-plugin-timings.md New documentation file with detailed explanation of plugin timing detection
packages/rolldown/src/options/generated/checks-options.ts Updated auto-generated TypeScript interface with include directive for the new documentation
crates/rolldown_error/src/types/event_kind.rs Added include directive to Rust enum variant (source for code generation)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sapphi-red sapphi-red merged commit fe35235 into main Jan 10, 2026
44 checks passed
@sapphi-red sapphi-red deleted the 01-10-docs_options_port_checks.plugintimings_content_from_options_page_to_reference_page branch January 10, 2026 07:11
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(d1f3551)
  • pr: 01-10-docs_options_port_checks.plugintimings_content_from_options_page_to_reference_page(603c159)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     66.3±1.18ms        ? ?/sec    1.07     70.7±2.28ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     73.1±1.19ms        ? ?/sec    1.01     73.9±1.13ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    103.3±3.27ms        ? ?/sec    1.01    104.7±2.89ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    114.3±1.49ms        ? ?/sec    1.01    115.8±1.51ms        ? ?/sec
bundle/bundle@threejs                                        1.01     38.0±1.93ms        ? ?/sec    1.00     37.4±0.50ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.1±0.50ms        ? ?/sec    1.01     42.7±0.58ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    381.8±3.14ms        ? ?/sec    1.00    380.7±4.31ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    442.2±4.00ms        ? ?/sec    1.00    441.1±4.22ms        ? ?/sec
scan/scan@rome_ts                                            1.00     81.7±1.49ms        ? ?/sec    1.00     82.1±1.71ms        ? ?/sec
scan/scan@threejs                                            1.01     28.6±1.72ms        ? ?/sec    1.00     28.2±0.31ms        ? ?/sec
scan/scan@threejs10x                                         1.00    289.5±4.98ms        ? ?/sec    1.01    293.1±6.64ms        ? ?/sec

This was referenced Jan 14, 2026
shulaoda added a commit that referenced this pull request Jan 14, 2026
## [1.0.0-beta.60] - 2026-01-14

### 💥 BREAKING CHANGES

- tsconfig: enable auto-discovery by default (#7817) by @shulaoda

### 🚀 Features

- distinguish transformer diagnostics from parse errors (#7872) by @shulaoda
- emit transformer warnings instead of ignoring them (#7850) by @shulaoda
- node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0
- nativeMagicString reset (#7828) by @IWANABETHATGUY
- nativeMagicString lastChar (#7819) by @IWANABETHATGUY
- dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0
- nativeMagicString snip (#7818) by @IWANABETHATGUY
- nativeMagicString construct with options (#7814) by @IWANABETHATGUY
- nativeMagicString clone (#7813) by @IWANABETHATGUY
- nativeMagicString `insert` (#7812) by @IWANABETHATGUY
- nativeMagicString `slice` (#7807) by @IWANABETHATGUY
- nativeMagicString trim methods (#7800) by @IWANABETHATGUY
- make closeBundle hook receive the last error (#7278) by @Copilot

### 🐛 Bug Fixes

- when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY
- inline __name calls for default exports  (#7862) by @IWANABETHATGUY
- improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY
- use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY
- transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda
- dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0
- set ExportsKind to Esm when json is none object literal  (#7808) by @IWANABETHATGUY
- nativeMagicString move api (#7796) by @IWANABETHATGUY
- remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY
- use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot

### 🚜 Refactor

- generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda
- rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0
- string_wizard error hanlding (#7830) by @IWANABETHATGUY
- remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red
- node/test: run fixture tests in concurrent (#7790) by @hyf0
- move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda
- cli: validate config after resolving and improve error message (#7798) by @shulaoda

### 📚 Documentation

- rebrand (#7670) by @yyx990803
- fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot
- remove options pages and redirect to reference pages (#7834) by @sapphi-red
- options: inline types to option property pages (#7831) by @sapphi-red
- options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red
- options: use `@linkcode` where possible (#7824) by @sapphi-red
- options: port content from options page to reference page (#7822) by @sapphi-red
- options: add descriptions for output options (#7821) by @sapphi-red
- options: add description for input options (#7802) by @sapphi-red
- options: add description for `checks.*` (#7801) by @sapphi-red
- apis: add hook graph (#7671) by @sapphi-red

### 🧪 Testing

- add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY
- enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY
- init magic-string test (#7794) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- vite-tests: configure git user for rebase operation (#7875) by @shulaoda
- rolldown_binding: remove v3 native plugins (#7837) by @shulaoda
- rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn
- README.md: adjust position and size of rolldown logo (#7861) by @hyf0
- deps: update test262 submodule for tests (#7857) by @sapphi-red
- deps: update oxc to v0.108.0 (#7845) by @renovate[bot]
- deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot]
- deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot]
- deps: update npm packages (#7841) by @renovate[bot]
- deps: update rust crates (#7839) by @renovate[bot]
- deps: update github-actions (#7840) by @renovate[bot]
- use workspace edition for all crates (#7829) by @IWANABETHATGUY
- deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot]
- deps: update napi to v3.8.2 (#7810) by @renovate[bot]
- remove outdated snapshot files (#7806) by @shulaoda
- deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant