chore: use workspace edition for all crates by IWANABETHATGUY · Pull Request #7829 · rolldown/rolldown

IWANABETHATGUY · 2026-01-09T18:08:20Z

I found this when I try to use let chain in string_wizard .

IWANABETHATGUY · 2026-01-09T18:08:37Z

refactor: string_wizard error hanlding #7830
feat: nativeMagicString reset #7828
chore: use workspace edition for all crates #7829 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-09T18:09:15Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`896f82f`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6961ff0381ce770008718c32

Copilot

Pull request overview

This pull request standardizes the use of the workspace-level Rust edition (2024) across multiple crates and leverages the new let-chain syntax for cleaner, more idiomatic code.

Updates Cargo.toml files to use edition.workspace = true instead of hardcoded edition = "2021"
Refactors nested if let statements to use let-chain syntax (a Rust 2024 feature)
Simplifies code by removing unnecessary intermediate variables

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/string_wizard/Cargo.toml	Updates to use workspace edition
crates/string_wizard/src/magic_string/mod.rs	Refactors four instances of nested `if let` to use let-chains
crates/string_wizard/src/magic_string/indent.rs	Removes unnecessary intermediate variable in `guessed_indentor`
crates/rolldown_plugin_vite_resolve/Cargo.toml	Updates to use workspace edition
crates/rolldown_plugin_vite_resolve/src/vite_resolve_plugin.rs	Refactors five instances of nested `if let` to use let-chains
crates/rolldown_plugin_vite_resolve/src/resolver.rs	Refactors two instances of nested `if let` to use let-chains
crates/rolldown_plugin_data_uri/Cargo.toml	Updates to use workspace edition
crates/rolldown_plugin_chunk_import_map/Cargo.toml	Updates to use workspace edition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-01-09T18:31:37Z

Benchmarks Rust

target: main(d1f3551)
pr: 01-10-chore_change_edition_of_string_wizard_to_2024(4ab4e7d)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     74.6±2.50ms        ? ?/sec    1.00     72.1±3.86ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     79.6±3.16ms        ? ?/sec    1.00     78.4±2.40ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    106.4±1.83ms        ? ?/sec    1.00    106.1±1.87ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    119.8±1.98ms        ? ?/sec    1.00    118.6±1.63ms        ? ?/sec
bundle/bundle@threejs                                        1.00     37.8±0.78ms        ? ?/sec    1.03     39.1±0.82ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.4±1.02ms        ? ?/sec    1.01     43.7±0.92ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    393.1±5.14ms        ? ?/sec    1.00    394.0±5.54ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02   464.5±10.06ms        ? ?/sec    1.00    456.3±4.94ms        ? ?/sec
scan/scan@rome_ts                                            1.00     83.8±2.32ms        ? ?/sec    1.01     84.5±2.01ms        ? ?/sec
scan/scan@threejs                                            1.00     28.8±0.50ms        ? ?/sec    1.02     29.4±1.61ms        ? ?/sec
scan/scan@threejs10x                                         1.01    294.8±4.83ms        ? ?/sec    1.00    291.9±4.77ms        ? ?/sec

graphite-app · 2026-01-10T07:25:35Z

Merge activity

Jan 10, 7:25 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 10, 7:34 AM UTC: Merged by the Graphite merge queue.

I found this when I try to use `let chain` in `string_wizard` .

@shulaoda

## [1.0.0-beta.60] - 2026-01-14 ### 💥 BREAKING CHANGES - tsconfig: enable auto-discovery by default (#7817) by @shulaoda ### 🚀 Features - distinguish transformer diagnostics from parse errors (#7872) by @shulaoda - emit transformer warnings instead of ignoring them (#7850) by @shulaoda - node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0 - nativeMagicString reset (#7828) by @IWANABETHATGUY - nativeMagicString lastChar (#7819) by @IWANABETHATGUY - dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0 - nativeMagicString snip (#7818) by @IWANABETHATGUY - nativeMagicString construct with options (#7814) by @IWANABETHATGUY - nativeMagicString clone (#7813) by @IWANABETHATGUY - nativeMagicString `insert` (#7812) by @IWANABETHATGUY - nativeMagicString `slice` (#7807) by @IWANABETHATGUY - nativeMagicString trim methods (#7800) by @IWANABETHATGUY - make closeBundle hook receive the last error (#7278) by @Copilot ### 🐛 Bug Fixes - when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY - inline __name calls for default exports (#7862) by @IWANABETHATGUY - improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY - use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY - transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda - dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0 - set ExportsKind to Esm when json is none object literal (#7808) by @IWANABETHATGUY - nativeMagicString move api (#7796) by @IWANABETHATGUY - remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY - use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot ### 🚜 Refactor - generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda - rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0 - string_wizard error hanlding (#7830) by @IWANABETHATGUY - remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red - node/test: run fixture tests in concurrent (#7790) by @hyf0 - move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda - cli: validate config after resolving and improve error message (#7798) by @shulaoda ### 📚 Documentation - rebrand (#7670) by @yyx990803 - fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot - remove options pages and redirect to reference pages (#7834) by @sapphi-red - options: inline types to option property pages (#7831) by @sapphi-red - options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red - options: use `@linkcode` where possible (#7824) by @sapphi-red - options: port content from options page to reference page (#7822) by @sapphi-red - options: add descriptions for output options (#7821) by @sapphi-red - options: add description for input options (#7802) by @sapphi-red - options: add description for `checks.*` (#7801) by @sapphi-red - apis: add hook graph (#7671) by @sapphi-red ### 🧪 Testing - add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY - enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY - init magic-string test (#7794) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - vite-tests: configure git user for rebase operation (#7875) by @shulaoda - rolldown_binding: remove v3 native plugins (#7837) by @shulaoda - rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn - README.md: adjust position and size of rolldown logo (#7861) by @hyf0 - deps: update test262 submodule for tests (#7857) by @sapphi-red - deps: update oxc to v0.108.0 (#7845) by @renovate[bot] - deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot] - deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot] - deps: update npm packages (#7841) by @renovate[bot] - deps: update rust crates (#7839) by @renovate[bot] - deps: update github-actions (#7840) by @renovate[bot] - use workspace edition for all crates (#7829) by @IWANABETHATGUY - deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot] - deps: update napi to v3.8.2 (#7810) by @renovate[bot] - remove outdated snapshot files (#7806) by @shulaoda - deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Jan 9, 2026

IWANABETHATGUY changed the title ~~chore: change edition of string_wizard to 2024~~ refactor: optimize MagicString and use workspace edition Jan 9, 2026

IWANABETHATGUY changed the title ~~refactor: optimize MagicString and use workspace edition~~ chore: use workspace edition for all crates Jan 9, 2026

IWANABETHATGUY force-pushed the 01-10-chore_change_edition_of_string_wizard_to_2024 branch from c5daa16 to 4ab4e7d Compare January 9, 2026 18:14

IWANABETHATGUY marked this pull request as ready for review January 9, 2026 18:15

Copilot AI review requested due to automatic review settings January 9, 2026 18:15

Copilot started reviewing on behalf of IWANABETHATGUY January 9, 2026 18:16 View session

IWANABETHATGUY mentioned this pull request Jan 9, 2026

feat: nativeMagicString reset #7828

Merged

Copilot AI reviewed Jan 9, 2026

View reviewed changes

IWANABETHATGUY mentioned this pull request Jan 9, 2026

refactor: string_wizard error hanlding #7830

Merged

hyf0 approved these changes Jan 10, 2026

View reviewed changes

hyf0 added the graphite: merge-when-ready label Jan 10, 2026

chore: use workspace edition for all crates (#7829)

896f82f

I found this when I try to use `let chain` in `string_wizard` .

graphite-app bot force-pushed the 01-10-chore_change_edition_of_string_wizard_to_2024 branch from 4ab4e7d to 896f82f Compare January 10, 2026 07:25

graphite-app bot merged commit 896f82f into main Jan 10, 2026
34 checks passed

graphite-app bot deleted the 01-10-chore_change_edition_of_string_wizard_to_2024 branch January 10, 2026 07:34

graphite-app bot removed the graphite: merge-when-ready label Jan 10, 2026

This was referenced Jan 14, 2026

release: v1.0.0-beta.60 #7869

Closed

release: v1.0.0-beta.60 #7877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

chore: use workspace edition for all crates#7829

chore: use workspace edition for all crates#7829
graphite-app[bot] merged 1 commit intomainfrom
01-10-chore_change_edition_of_string_wizard_to_2024

IWANABETHATGUY commented Jan 9, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Jan 9, 2026 •

edited

Loading

Uh oh!

netlify bot commented Jan 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

graphite-app bot commented Jan 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Jan 9, 2026

Benchmarks Rust

Uh oh!

graphite-app bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Jan 9, 2026 •

edited

Loading

IWANABETHATGUY commented Jan 9, 2026 •

edited

Loading

netlify bot commented Jan 9, 2026 •

edited

Loading

graphite-app bot commented Jan 10, 2026 •

edited

Loading