Skip to content

Comments

refactor: remove experimental.disableLiveBindings option#7820

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-09-refactor_remove_experimental.disablelivebindings_option
Jan 9, 2026
Merged

refactor: remove experimental.disableLiveBindings option#7820
graphite-app[bot] merged 1 commit intomainfrom
01-09-refactor_remove_experimental.disablelivebindings_option

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 9, 2026

This PR removes experimental.disableLiveBindings option.

This option was introduced in #2282 to reduce the code size in some cases. Now that Rolldown uses exports.foo = instead of Object.defineProperty(exports, 'foo', { get() { ... } }) if the value is known not to be changed, there are few cases this option is effective.

Copy link
Member Author

sapphi-red commented Jan 9, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red requested a review from hyf0 January 9, 2026 11:00
@sapphi-red sapphi-red marked this pull request as ready for review January 9, 2026 11:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Benchmarks Rust

  • target: 01-08-docs_options_add_description_for_input_options(348dcf0)
  • pr: 01-09-refactor_remove_experimental.disablelivebindings_option(dadcab1)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     62.0±1.46ms        ? ?/sec    1.00     61.0±1.26ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     68.3±1.62ms        ? ?/sec    1.00     67.2±1.51ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    104.0±1.71ms        ? ?/sec    1.00    103.6±1.52ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    116.1±3.38ms        ? ?/sec    1.00    115.5±1.56ms        ? ?/sec
bundle/bundle@threejs                                        1.01     37.7±2.36ms        ? ?/sec    1.00     37.2±2.10ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     41.3±0.54ms        ? ?/sec    1.01     41.6±0.66ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    378.6±2.86ms        ? ?/sec    1.00    380.0±6.53ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    439.3±3.84ms        ? ?/sec    1.00    440.6±3.05ms        ? ?/sec
scan/scan@rome_ts                                            1.00     83.0±3.89ms        ? ?/sec    1.02     84.5±1.89ms        ? ?/sec
scan/scan@threejs                                            1.00     27.9±1.66ms        ? ?/sec    1.01     28.2±1.75ms        ? ?/sec
scan/scan@threejs10x                                         1.00    284.5±3.82ms        ? ?/sec    1.02    289.1±3.59ms        ? ?/sec

Copy link
Member

hyf0 commented Jan 9, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-08-docs_options_add_description_for_input_options branch from 348dcf0 to c261f1e Compare January 9, 2026 11:36
graphite-app bot pushed a commit that referenced this pull request Jan 9, 2026
This PR removes `experimental.disableLiveBindings` option.

This option was introduced in #2282 to reduce the code size in some cases. Now that Rolldown uses `exports.foo =` instead of `Object.defineProperty(exports, 'foo', { get() { ... } })` if the value is known not to be changed, there are few cases this option is effective.
@graphite-app graphite-app bot force-pushed the 01-09-refactor_remove_experimental.disablelivebindings_option branch from dadcab1 to 9ebc3bf Compare January 9, 2026 11:37
This PR removes `experimental.disableLiveBindings` option.

This option was introduced in #2282 to reduce the code size in some cases. Now that Rolldown uses `exports.foo =` instead of `Object.defineProperty(exports, 'foo', { get() { ... } })` if the value is known not to be changed, there are few cases this option is effective.
@graphite-app graphite-app bot force-pushed the 01-08-docs_options_add_description_for_input_options branch from c261f1e to b2e0e08 Compare January 9, 2026 11:39
@graphite-app graphite-app bot force-pushed the 01-09-refactor_remove_experimental.disablelivebindings_option branch from 9ebc3bf to 2f6eb6d Compare January 9, 2026 11:40
Base automatically changed from 01-08-docs_options_add_description_for_input_options to main January 9, 2026 11:54
@graphite-app graphite-app bot merged commit 2f6eb6d into main Jan 9, 2026
31 checks passed
@graphite-app graphite-app bot deleted the 01-09-refactor_remove_experimental.disablelivebindings_option branch January 9, 2026 11:54
This was referenced Jan 14, 2026
shulaoda added a commit that referenced this pull request Jan 14, 2026
## [1.0.0-beta.60] - 2026-01-14

### 💥 BREAKING CHANGES

- tsconfig: enable auto-discovery by default (#7817) by @shulaoda

### 🚀 Features

- distinguish transformer diagnostics from parse errors (#7872) by @shulaoda
- emit transformer warnings instead of ignoring them (#7850) by @shulaoda
- node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0
- nativeMagicString reset (#7828) by @IWANABETHATGUY
- nativeMagicString lastChar (#7819) by @IWANABETHATGUY
- dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0
- nativeMagicString snip (#7818) by @IWANABETHATGUY
- nativeMagicString construct with options (#7814) by @IWANABETHATGUY
- nativeMagicString clone (#7813) by @IWANABETHATGUY
- nativeMagicString `insert` (#7812) by @IWANABETHATGUY
- nativeMagicString `slice` (#7807) by @IWANABETHATGUY
- nativeMagicString trim methods (#7800) by @IWANABETHATGUY
- make closeBundle hook receive the last error (#7278) by @Copilot

### 🐛 Bug Fixes

- when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY
- inline __name calls for default exports  (#7862) by @IWANABETHATGUY
- improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY
- use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY
- transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda
- dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0
- set ExportsKind to Esm when json is none object literal  (#7808) by @IWANABETHATGUY
- nativeMagicString move api (#7796) by @IWANABETHATGUY
- remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY
- use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot

### 🚜 Refactor

- generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda
- rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0
- string_wizard error hanlding (#7830) by @IWANABETHATGUY
- remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red
- node/test: run fixture tests in concurrent (#7790) by @hyf0
- move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda
- cli: validate config after resolving and improve error message (#7798) by @shulaoda

### 📚 Documentation

- rebrand (#7670) by @yyx990803
- fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot
- remove options pages and redirect to reference pages (#7834) by @sapphi-red
- options: inline types to option property pages (#7831) by @sapphi-red
- options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red
- options: use `@linkcode` where possible (#7824) by @sapphi-red
- options: port content from options page to reference page (#7822) by @sapphi-red
- options: add descriptions for output options (#7821) by @sapphi-red
- options: add description for input options (#7802) by @sapphi-red
- options: add description for `checks.*` (#7801) by @sapphi-red
- apis: add hook graph (#7671) by @sapphi-red

### 🧪 Testing

- add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY
- enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY
- init magic-string test (#7794) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- vite-tests: configure git user for rebase operation (#7875) by @shulaoda
- rolldown_binding: remove v3 native plugins (#7837) by @shulaoda
- rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn
- README.md: adjust position and size of rolldown logo (#7861) by @hyf0
- deps: update test262 submodule for tests (#7857) by @sapphi-red
- deps: update oxc to v0.108.0 (#7845) by @renovate[bot]
- deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot]
- deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot]
- deps: update npm packages (#7841) by @renovate[bot]
- deps: update rust crates (#7839) by @renovate[bot]
- deps: update github-actions (#7840) by @renovate[bot]
- use workspace edition for all crates (#7829) by @IWANABETHATGUY
- deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot]
- deps: update napi to v3.8.2 (#7810) by @renovate[bot]
- remove outdated snapshot files (#7806) by @shulaoda
- deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants