feat: nativeMagicString `insert` by IWANABETHATGUY · Pull Request #7812 · rolldown/rolldown

IWANABETHATGUY · 2026-01-09T07:16:46Z

No description provided.

IWANABETHATGUY · 2026-01-09T07:17:06Z

feat: nativeMagicString lastChar #7819
feat: nativeMagicString snip #7818
feat: nativeMagicString construct with options #7814
feat: nativeMagicString clone #7813
feat: nativeMagicString insert #7812 👈 (View in Graphite)
feat: nativeMagicString slice #7807
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-01-09T07:33:13Z

Benchmarks Rust

target: main(b20fec4)
pr: 01-09-feat_nativemagicstring_insert(78ae564)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     66.5±2.22ms        ? ?/sec    1.01     67.1±1.83ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     73.5±2.02ms        ? ?/sec    1.00     72.4±1.52ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    108.1±1.87ms        ? ?/sec    1.00    108.0±2.13ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    119.6±1.76ms        ? ?/sec    1.01    120.5±2.95ms        ? ?/sec
bundle/bundle@threejs                                        1.03     39.6±2.46ms        ? ?/sec    1.00     38.5±0.92ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.9±0.66ms        ? ?/sec    1.00     44.0±0.95ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02    397.7±5.96ms        ? ?/sec    1.00    390.3±3.60ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    458.0±3.61ms        ? ?/sec    1.00    451.2±5.09ms        ? ?/sec
scan/scan@rome_ts                                            1.02     85.1±1.88ms        ? ?/sec    1.00     83.4±1.63ms        ? ?/sec
scan/scan@threejs                                            1.01     28.4±0.40ms        ? ?/sec    1.00     28.0±0.37ms        ? ?/sec
scan/scan@threejs10x                                         1.00    291.6±5.04ms        ? ?/sec    1.00    290.5±4.28ms        ? ?/sec

graphite-app · 2026-01-09T08:30:39Z

Merge activity

Jan 9, 8:30 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
Jan 9, 9:07 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 9, 9:16 AM UTC: Merged by the Graphite merge queue.

netlify · 2026-01-09T08:31:36Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`78ae564`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6960c53f909ce90008bb488c

Copilot

Pull request overview

This PR implements the deprecated insert method for BindingMagicString to match the behavior of the original magic-string library. The method throws an error directing users to use prependRight or appendLeft instead.

Key changes:

Adds insert method that throws a deprecation error in Rust and TypeScript bindings
Enables the insert test case that verifies the deprecation error is thrown
Updates documentation to reflect that insert and slice are now supported

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
`crates/rolldown_binding/src/types/binding_magic_string.rs`	Implements the `insert` method that throws a deprecation error
`packages/rolldown/src/binding.d.cts`	Adds TypeScript type definition for the `insert` method
`packages/rolldown/tests/magic-string/MagicString.test.ts`	Enables the `insert` test and adds redundant skip to a clone test
`packages/rolldown/tests/magic-string/download-tests.mjs`	Updates documentation comments to reflect supported methods and clarifies skip reasons

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/rolldown/tests/magic-string/MagicString.test.ts

@shulaoda

## [1.0.0-beta.60] - 2026-01-14 ### 💥 BREAKING CHANGES - tsconfig: enable auto-discovery by default (#7817) by @shulaoda ### 🚀 Features - distinguish transformer diagnostics from parse errors (#7872) by @shulaoda - emit transformer warnings instead of ignoring them (#7850) by @shulaoda - node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0 - nativeMagicString reset (#7828) by @IWANABETHATGUY - nativeMagicString lastChar (#7819) by @IWANABETHATGUY - dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0 - nativeMagicString snip (#7818) by @IWANABETHATGUY - nativeMagicString construct with options (#7814) by @IWANABETHATGUY - nativeMagicString clone (#7813) by @IWANABETHATGUY - nativeMagicString `insert` (#7812) by @IWANABETHATGUY - nativeMagicString `slice` (#7807) by @IWANABETHATGUY - nativeMagicString trim methods (#7800) by @IWANABETHATGUY - make closeBundle hook receive the last error (#7278) by @Copilot ### 🐛 Bug Fixes - when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY - inline __name calls for default exports (#7862) by @IWANABETHATGUY - improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY - use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY - transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda - dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0 - set ExportsKind to Esm when json is none object literal (#7808) by @IWANABETHATGUY - nativeMagicString move api (#7796) by @IWANABETHATGUY - remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY - use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot ### 🚜 Refactor - generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda - rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0 - string_wizard error hanlding (#7830) by @IWANABETHATGUY - remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red - node/test: run fixture tests in concurrent (#7790) by @hyf0 - move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda - cli: validate config after resolving and improve error message (#7798) by @shulaoda ### 📚 Documentation - rebrand (#7670) by @yyx990803 - fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot - remove options pages and redirect to reference pages (#7834) by @sapphi-red - options: inline types to option property pages (#7831) by @sapphi-red - options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red - options: use `@linkcode` where possible (#7824) by @sapphi-red - options: port content from options page to reference page (#7822) by @sapphi-red - options: add descriptions for output options (#7821) by @sapphi-red - options: add description for input options (#7802) by @sapphi-red - options: add description for `checks.*` (#7801) by @sapphi-red - apis: add hook graph (#7671) by @sapphi-red ### 🧪 Testing - add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY - enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY - init magic-string test (#7794) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - vite-tests: configure git user for rebase operation (#7875) by @shulaoda - rolldown_binding: remove v3 native plugins (#7837) by @shulaoda - rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn - README.md: adjust position and size of rolldown logo (#7861) by @hyf0 - deps: update test262 submodule for tests (#7857) by @sapphi-red - deps: update oxc to v0.108.0 (#7845) by @renovate[bot] - deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot] - deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot] - deps: update npm packages (#7841) by @renovate[bot] - deps: update rust crates (#7839) by @renovate[bot] - deps: update github-actions (#7840) by @renovate[bot] - use workspace edition for all crates (#7829) by @IWANABETHATGUY - deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot] - deps: update napi to v3.8.2 (#7810) by @renovate[bot] - remove outdated snapshot files (#7806) by @shulaoda - deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Jan 9, 2026

IWANABETHATGUY mentioned this pull request Jan 9, 2026

feat: nativeMagicString slice #7807

Merged

IWANABETHATGUY force-pushed the 01-09-feat_nativemagicstring_insert branch from 3d61476 to cdcf811 Compare January 9, 2026 07:19

IWANABETHATGUY marked this pull request as ready for review January 9, 2026 07:20

IWANABETHATGUY requested review from hyf0 and shulaoda January 9, 2026 07:27

IWANABETHATGUY changed the title ~~feat: nativeMagicString insert~~ feat: nativeMagicString insert Jan 9, 2026

IWANABETHATGUY mentioned this pull request Jan 9, 2026

feat: nativeMagicString clone #7813

Merged

IWANABETHATGUY force-pushed the 01-09-feat_nativemagicstring_insert branch from cdcf811 to aab3788 Compare January 9, 2026 07:39

IWANABETHATGUY force-pushed the 01-08-feat_nativemagicstring_slice branch from 25f65a4 to 0e806b2 Compare January 9, 2026 07:39

IWANABETHATGUY force-pushed the 01-09-feat_nativemagicstring_insert branch from aab3788 to 34a0408 Compare January 9, 2026 07:49

IWANABETHATGUY force-pushed the 01-08-feat_nativemagicstring_slice branch from 0e806b2 to 80e474e Compare January 9, 2026 07:49

IWANABETHATGUY force-pushed the 01-09-feat_nativemagicstring_insert branch from 2611116 to 92e1d20 Compare January 9, 2026 08:11

IWANABETHATGUY mentioned this pull request Jan 9, 2026

feat: nativeMagicString construct with options #7814

Merged

IWANABETHATGUY force-pushed the 01-09-feat_nativemagicstring_insert branch from 92e1d20 to 800f98a Compare January 9, 2026 08:28

shulaoda approved these changes Jan 9, 2026

View reviewed changes

Base automatically changed from 01-08-feat_nativemagicstring_slice to main January 9, 2026 08:29

IWANABETHATGUY force-pushed the 01-09-feat_nativemagicstring_insert branch from 800f98a to b1f3383 Compare January 9, 2026 08:30

IWANABETHATGUY force-pushed the 01-09-feat_nativemagicstring_insert branch 2 times, most recently from 5ea7f41 to 1a60bae Compare January 9, 2026 08:51

Copilot AI review requested due to automatic review settings January 9, 2026 08:51

Copilot started reviewing on behalf of IWANABETHATGUY January 9, 2026 08:51 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

packages/rolldown/tests/magic-string/MagicString.test.ts Show resolved Hide resolved

feat: nativeMagicString insert (#7812)

78ae564

graphite-app bot force-pushed the 01-09-feat_nativemagicstring_insert branch from 1a60bae to 78ae564 Compare January 9, 2026 09:07

graphite-app bot merged commit 78ae564 into main Jan 9, 2026
35 checks passed

graphite-app bot deleted the 01-09-feat_nativemagicstring_insert branch January 9, 2026 09:16

This was referenced Jan 9, 2026

feat: nativeMagicString snip #7818

Merged

feat: nativeMagicString lastChar #7819

Merged

This was referenced Jan 14, 2026

release: v1.0.0-beta.60 #7869

Closed

release: v1.0.0-beta.60 #7877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: nativeMagicString `insert`#7812

feat: nativeMagicString `insert`#7812
graphite-app[bot] merged 1 commit intomainfrom
01-09-feat_nativemagicstring_insert

IWANABETHATGUY commented Jan 9, 2026

Uh oh!

IWANABETHATGUY commented Jan 9, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 9, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 9, 2026 •

edited

Loading

Uh oh!

netlify bot commented Jan 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Jan 9, 2026

Uh oh!

IWANABETHATGUY commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

netlify bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Jan 9, 2026 •

edited

Loading

github-actions bot commented Jan 9, 2026 •

edited

Loading

graphite-app bot commented Jan 9, 2026 •

edited

Loading

netlify bot commented Jan 9, 2026 •

edited

Loading