test: init magic-string test by IWANABETHATGUY · Pull Request #7794 · rolldown/rolldown

IWANABETHATGUY · 2026-01-08T07:22:15Z

automatically sync magic-string test case

IWANABETHATGUY · 2026-01-08T07:22:33Z

feat: nativeMagicString trim methods #7800
test: enable MagicString test after api return type alignment #7797
fix: nativeMagicString move api #7796
test: init magic-string test #7794 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-08T07:24:04Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`bb38a45`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/695f6bac76e7ba00088079f5

Copilot

Pull request overview

This PR initializes automated testing for the BindingMagicString API by setting up infrastructure to download and adapt test cases from the upstream magic-string library.

Key changes:

Adds a download script that fetches tests from magic-string's repository
Automatically transforms tests to work with rolldown's BindingMagicString API
Skips unsupported features and methods that differ in behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`packages/rolldown/tests/magic-string/download-tests.mjs`	Script to download and adapt magic-string tests, with comprehensive documentation of supported/unsupported features
`packages/rolldown/tests/magic-string/MagicString.test.ts`	Auto-generated test file with 1985 lines of tests, most skipped due to API differences
`.oxlintrc.json`	Adds ignore pattern for generated test files (contains a bug in the glob pattern)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.oxlintrc.json

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.typos.toml

.oxlintrc.json

packages/rolldown/tests/magic-string/download-tests.mjs

graphite-app · 2026-01-08T08:32:07Z

Merge activity

Jan 8, 8:32 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 8, 8:42 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test-macos / Node Test').
Jan 8, 8:49 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 8, 8:50 AM UTC: Merged by the Graphite merge queue.

1. automatically sync magic-string test case

@shulaoda

## [1.0.0-beta.60] - 2026-01-14 ### 💥 BREAKING CHANGES - tsconfig: enable auto-discovery by default (#7817) by @shulaoda ### 🚀 Features - distinguish transformer diagnostics from parse errors (#7872) by @shulaoda - emit transformer warnings instead of ignoring them (#7850) by @shulaoda - node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0 - nativeMagicString reset (#7828) by @IWANABETHATGUY - nativeMagicString lastChar (#7819) by @IWANABETHATGUY - dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0 - nativeMagicString snip (#7818) by @IWANABETHATGUY - nativeMagicString construct with options (#7814) by @IWANABETHATGUY - nativeMagicString clone (#7813) by @IWANABETHATGUY - nativeMagicString `insert` (#7812) by @IWANABETHATGUY - nativeMagicString `slice` (#7807) by @IWANABETHATGUY - nativeMagicString trim methods (#7800) by @IWANABETHATGUY - make closeBundle hook receive the last error (#7278) by @Copilot ### 🐛 Bug Fixes - when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY - inline __name calls for default exports (#7862) by @IWANABETHATGUY - improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY - use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY - transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda - dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0 - set ExportsKind to Esm when json is none object literal (#7808) by @IWANABETHATGUY - nativeMagicString move api (#7796) by @IWANABETHATGUY - remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY - use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot ### 🚜 Refactor - generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda - rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0 - string_wizard error hanlding (#7830) by @IWANABETHATGUY - remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red - node/test: run fixture tests in concurrent (#7790) by @hyf0 - move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda - cli: validate config after resolving and improve error message (#7798) by @shulaoda ### 📚 Documentation - rebrand (#7670) by @yyx990803 - fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot - remove options pages and redirect to reference pages (#7834) by @sapphi-red - options: inline types to option property pages (#7831) by @sapphi-red - options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red - options: use `@linkcode` where possible (#7824) by @sapphi-red - options: port content from options page to reference page (#7822) by @sapphi-red - options: add descriptions for output options (#7821) by @sapphi-red - options: add description for input options (#7802) by @sapphi-red - options: add description for `checks.*` (#7801) by @sapphi-red - apis: add hook graph (#7671) by @sapphi-red ### 🧪 Testing - add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY - enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY - init magic-string test (#7794) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - vite-tests: configure git user for rebase operation (#7875) by @shulaoda - rolldown_binding: remove v3 native plugins (#7837) by @shulaoda - rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn - README.md: adjust position and size of rolldown logo (#7861) by @hyf0 - deps: update test262 submodule for tests (#7857) by @sapphi-red - deps: update oxc to v0.108.0 (#7845) by @renovate[bot] - deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot] - deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot] - deps: update npm packages (#7841) by @renovate[bot] - deps: update rust crates (#7839) by @renovate[bot] - deps: update github-actions (#7840) by @renovate[bot] - use workspace edition for all crates (#7829) by @IWANABETHATGUY - deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot] - deps: update napi to v3.8.2 (#7810) by @renovate[bot] - remove outdated snapshot files (#7806) by @shulaoda - deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Jan 8, 2026

IWANABETHATGUY changed the title ~~test: init magic-string test~~ chore: exclude magic-string tests from oxlint Jan 8, 2026

IWANABETHATGUY force-pushed the 01-08-test_init_magic-string_test branch from e76ec7e to 9edc778 Compare January 8, 2026 07:27

IWANABETHATGUY changed the title ~~chore: exclude magic-string tests from oxlint~~ test: init magic-string test Jan 8, 2026

IWANABETHATGUY force-pushed the 01-08-test_init_magic-string_test branch from 9edc778 to b822263 Compare January 8, 2026 07:46

IWANABETHATGUY marked this pull request as ready for review January 8, 2026 08:00

Copilot AI review requested due to automatic review settings January 8, 2026 08:00

Copilot started reviewing on behalf of IWANABETHATGUY January 8, 2026 08:00 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

.oxlintrc.json Outdated Show resolved Hide resolved

IWANABETHATGUY force-pushed the 01-08-test_init_magic-string_test branch from b822263 to 7f01265 Compare January 8, 2026 08:03

Copilot AI review requested due to automatic review settings January 8, 2026 08:07

IWANABETHATGUY force-pushed the 01-08-test_init_magic-string_test branch 2 times, most recently from 6c315c1 to 910e260 Compare January 8, 2026 08:07

Copilot started reviewing on behalf of IWANABETHATGUY January 8, 2026 08:07 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

.typos.toml Show resolved Hide resolved

.oxlintrc.json Show resolved Hide resolved

packages/rolldown/tests/magic-string/download-tests.mjs Show resolved Hide resolved

IWANABETHATGUY mentioned this pull request Jan 8, 2026

fix: nativeMagicString move api #7796

Merged

IWANABETHATGUY requested review from hyf0 and shulaoda January 8, 2026 08:30

shulaoda approved these changes Jan 8, 2026

View reviewed changes

test: init magic-string test (#7794)

bb38a45

1. automatically sync magic-string test case

graphite-app bot force-pushed the 01-08-test_init_magic-string_test branch from 910e260 to bb38a45 Compare January 8, 2026 08:32

IWANABETHATGUY mentioned this pull request Jan 8, 2026

test: enable MagicString test after api return type alignment #7797

Merged

graphite-app bot merged commit bb38a45 into main Jan 8, 2026
55 of 56 checks passed

graphite-app bot deleted the 01-08-test_init_magic-string_test branch January 8, 2026 08:50

IWANABETHATGUY mentioned this pull request Jan 8, 2026

feat: nativeMagicString trim methods #7800

Merged

This was referenced Jan 14, 2026

release: v1.0.0-beta.60 #7869

Closed

release: v1.0.0-beta.60 #7877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

test: init magic-string test#7794

test: init magic-string test#7794
graphite-app[bot] merged 1 commit intomainfrom
01-08-test_init_magic-string_test

IWANABETHATGUY commented Jan 8, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Jan 8, 2026 •

edited

Loading

Uh oh!

netlify bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IWANABETHATGUY commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Jan 8, 2026 •

edited

Loading

IWANABETHATGUY commented Jan 8, 2026 •

edited

Loading

netlify bot commented Jan 8, 2026 •

edited

Loading

graphite-app bot commented Jan 8, 2026 •

edited

Loading