Skip to content

Comments

ci(vite-tests): allow running on PRs with test: vite-tests label#7770

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-06-ci_vite-tests_allow_running_on_prs_with_test_vite-tests_label
Jan 6, 2026
Merged

ci(vite-tests): allow running on PRs with test: vite-tests label#7770
graphite-app[bot] merged 1 commit intomainfrom
01-06-ci_vite-tests_allow_running_on_prs_with_test_vite-tests_label

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jan 6, 2026

No description provided.

Copy link
Member Author

shulaoda commented Jan 6, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title ci(vite-tests): allow running on PRs with test: vite-tests label ci(vite-tests): allow running on PRs with test: vite-tests label Jan 6, 2026
@shulaoda shulaoda changed the base branch from 01-06-refactor_module_loader_remove_unnecessary_collect_before_extend to graphite-base/7770 January 6, 2026 09:32
@shulaoda shulaoda force-pushed the 01-06-ci_vite-tests_allow_running_on_prs_with_test_vite-tests_label branch from 198c2e4 to f403b87 Compare January 6, 2026 09:32
@shulaoda shulaoda changed the base branch from graphite-base/7770 to main January 6, 2026 09:32
@shulaoda shulaoda marked this pull request as ready for review January 6, 2026 09:32
Copilot AI review requested due to automatic review settings January 6, 2026 09:32
@shulaoda shulaoda added the test: vite-tests Trigger Vite tests workflow on this PR label Jan 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the Vite tests workflow to run on pull requests when they have the test: vite-tests label applied, in addition to the existing triggers for push events and manual workflow dispatch.

Key changes:

  • Added pull_request trigger for labeled and synchronize events
  • Implemented conditional job execution to skip the workflow for PRs without the required label

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 6, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-06-ci_vite-tests_allow_running_on_prs_with_test_vite-tests_label branch from f403b87 to bd15ecd Compare January 6, 2026 09:58
@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit bd15ecd
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/695cdcaebb947e000806ba04

@graphite-app graphite-app bot merged commit bd15ecd into main Jan 6, 2026
34 of 35 checks passed
@graphite-app graphite-app bot deleted the 01-06-ci_vite-tests_allow_running_on_prs_with_test_vite-tests_label branch January 6, 2026 10:07
This was referenced Jan 7, 2026
shulaoda added a commit that referenced this pull request Jan 7, 2026
## [1.0.0-beta.59] - 2026-01-07

⚡ Inline Dynamic Imports for Statically Imported Modules

- When a module is already statically imported, dynamic imports to that same module are now inlined instead of creating a separate chunk

### 🚀 Features

- plugin_timings: add 3s threshold and doc link to warning message (#7741) by @shulaoda
- improve treeshaking logic to handle empty parameter list in dynamic import .then() callbacks (#7781) by @Copilot
- dev/lazy: don't include already executed modules (#7745) by @hyf0
- dev/lazy: support dynamic `import(..)` (#7726) by @hyf0
- inline dynamic imports that imports statically imported modules (#7742) by @IWANABETHATGUY
- option: add experimental option to control chunk optimization (#7738) by @IWANABETHATGUY

### 🐛 Bug Fixes

- inline dynamic entry to user defined entry with esm wrap kind (#7783) by @IWANABETHATGUY
- use canonical namespace reference for property access (#7777) by @IWANABETHATGUY
- dynamic entry merged into common chunk with cjs and esm wrap kind (#7771) by @IWANABETHATGUY
- tla: should not await non-tla-related modules (#7768) by @hyf0
- dynamic entry captured by common chunk with CJS format (#7757) by @IWANABETHATGUY
- module_loader: mark emitted chunks as user-defined entry when already loaded (#7765) by @shulaoda
- normalize preserveModulesRoot path (#7737) by @IWANABETHATGUY
- linker: resolve race condition in side effects computation for export-star (#7728) by @camc314

### 🚜 Refactor

- plugin_timings: filter out plugins with duration < 1s from timing warnings (#7785) by @shulaoda
- module_loader: remove unnecessary collect before extend (#7769) by @shulaoda
- rename _id suffixes to _idx for oxc_index types (#7767) by @IWANABETHATGUY
- remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg` (#7762) by @shulaoda
- module_loader: pass `user_defined_entries` by reference (#7756) by @shulaoda
- dev/lazy: get proxy entry's `ResolvedId` correctly (#7746) by @hyf0
- simplify try_rewrite_import_expression control flow (#7753) by @IWANABETHATGUY
- module_loader: remove unnecessary dynamic import handling for runtime module (#7754) by @shulaoda
- inline __toDynamicImportESM  (#7747) by @IWANABETHATGUY
- use From impl for ModuleLoaderOutput conversion (#7732) by @shulaoda
- remove duplicate fields from `ModuleLoader` (#7731) by @shulaoda
- tweak `resolve_user_defined_entries` (#7727) by @shulaoda

### 📚 Documentation

- add rolldown-string reference to native MagicString compatibility section (#7778) by @Copilot
- improve comments for export star side effects handling (#7730) by @IWANABETHATGUY

### 🧪 Testing

- use assertion instead of console.log for some testcase (#7744) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- tweak some `output.dynamicImportInCjs` related rollup test results (#7776) by @sapphi-red
- mark esbuild/dce/dce_of_symbol_ctor_call as passed (#7775) by @sapphi-red
- deps: update oxc apps (#7772) by @renovate[bot]
- vite-tests: allow running on PRs with `test: vite-tests` label (#7770) by @shulaoda
- deps: update oxc apps (#7760) by @renovate[bot]
- deps: update rollup submodule for tests to v4.55.1 (#7763) by @sapphi-red
- deps: update test262 submodule for tests (#7764) by @sapphi-red
- deps: update oxc to v0.107.0 (#7758) by @camc314
- deps: update taiki-e/install-action action to v2.65.13 (#7751) by @renovate[bot]
- deps: update rust crates (#7750) by @renovate[bot]
- deps: update npm packages (#7749) by @renovate[bot]
- deps: update github-actions (#7748) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.10.1 (#7729) by @renovate[bot]
- deps: update crate-ci/typos action to v1.41.0 (#7725) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: vite-tests Trigger Vite tests workflow on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants