fix(module_loader): mark emitted chunks as user-defined entry when already loaded by shulaoda · Pull Request #7765 · rolldown/rolldown

shulaoda · 2026-01-06T03:55:20Z

Related to #5012

When emitFile is called for a module that was already loaded as a dependency, the module's is_user_defined_entry flag was not being set correctly.

shulaoda · 2026-01-06T03:55:38Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-06T03:56:31Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`f76c274`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/695c971a46c1ad00087d523d

crates/rolldown/src/module_loader/module_loader.rs

Copilot

Pull request overview

This PR fixes a bug where modules emitted via emitFile API were not properly marked as user-defined entries when they had already been loaded as dependencies. The fix ensures consistent handling of the is_user_defined_entry flag across different module loading scenarios.

Key Changes:

Added logic to mark already-loaded modules as user-defined entries when emitted via plugin API
Refactored module index usage for better code clarity and consistency
Enhanced test coverage for the edge case scenario

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`crates/rolldown/src/module_loader/module_loader.rs`	Core fix: marks modules as user-defined entries when already in `Seen` state, refactors to use `module_idx` consistently
`crates/rolldown/tests/rolldown/issues/5011/src/entry.js`	Test update: adds import for the new test case module
`crates/rolldown/tests/rolldown/issues/5011/src/before-preload-dynamic.js`	New test file: demonstrates scenario where module is loaded before being emitted
`crates/rolldown/tests/rolldown/issues/5011/mod.rs`	Test plugin: adds emit_chunk call when transforming `dynamic-foo.js`, simplifies API usage
`crates/rolldown/tests/rolldown/issues/5011/artifacts.snap`	Expected output: includes new entry chunk for `before-preload-dynamic.js`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/src/module_loader/module_loader.rs

github-actions · 2026-01-06T04:13:27Z

Benchmarks Rust

target: main(0cae717)
pr: 01-06-fix_module_loader_mark_emitted_chunks_as_user-defined_entry_when_already_loaded(f76c274)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     63.8±1.94ms        ? ?/sec    1.00     62.8±1.98ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     69.7±1.80ms        ? ?/sec    1.00     69.3±1.40ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    105.2±2.04ms        ? ?/sec    1.00    104.4±1.84ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    115.8±2.46ms        ? ?/sec    1.01    116.5±1.70ms        ? ?/sec
bundle/bundle@threejs                                        1.06     40.0±2.44ms        ? ?/sec    1.00     37.6±0.79ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     43.1±0.85ms        ? ?/sec    1.00     42.8±0.56ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    383.4±7.81ms        ? ?/sec    1.00    378.0±3.74ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    439.8±4.27ms        ? ?/sec    1.00    439.1±5.14ms        ? ?/sec
scan/scan@rome_ts                                            1.00     82.1±1.67ms        ? ?/sec    1.01     83.2±1.82ms        ? ?/sec
scan/scan@threejs                                            1.00     28.1±1.61ms        ? ?/sec    1.00     28.3±1.58ms        ? ?/sec
scan/scan@threejs10x                                         1.01    288.0±4.38ms        ? ?/sec    1.00    284.3±5.45ms        ? ?/sec

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/src/module_loader/module_loader.rs

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ready loaded

@shulaoda

## [1.0.0-beta.59] - 2026-01-07 ⚡ Inline Dynamic Imports for Statically Imported Modules - When a module is already statically imported, dynamic imports to that same module are now inlined instead of creating a separate chunk ### 🚀 Features - plugin_timings: add 3s threshold and doc link to warning message (#7741) by @shulaoda - improve treeshaking logic to handle empty parameter list in dynamic import .then() callbacks (#7781) by @Copilot - dev/lazy: don't include already executed modules (#7745) by @hyf0 - dev/lazy: support dynamic `import(..)` (#7726) by @hyf0 - inline dynamic imports that imports statically imported modules (#7742) by @IWANABETHATGUY - option: add experimental option to control chunk optimization (#7738) by @IWANABETHATGUY ### 🐛 Bug Fixes - inline dynamic entry to user defined entry with esm wrap kind (#7783) by @IWANABETHATGUY - use canonical namespace reference for property access (#7777) by @IWANABETHATGUY - dynamic entry merged into common chunk with cjs and esm wrap kind (#7771) by @IWANABETHATGUY - tla: should not await non-tla-related modules (#7768) by @hyf0 - dynamic entry captured by common chunk with CJS format (#7757) by @IWANABETHATGUY - module_loader: mark emitted chunks as user-defined entry when already loaded (#7765) by @shulaoda - normalize preserveModulesRoot path (#7737) by @IWANABETHATGUY - linker: resolve race condition in side effects computation for export-star (#7728) by @camc314 ### 🚜 Refactor - plugin_timings: filter out plugins with duration < 1s from timing warnings (#7785) by @shulaoda - module_loader: remove unnecessary collect before extend (#7769) by @shulaoda - rename _id suffixes to _idx for oxc_index types (#7767) by @IWANABETHATGUY - remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg` (#7762) by @shulaoda - module_loader: pass `user_defined_entries` by reference (#7756) by @shulaoda - dev/lazy: get proxy entry's `ResolvedId` correctly (#7746) by @hyf0 - simplify try_rewrite_import_expression control flow (#7753) by @IWANABETHATGUY - module_loader: remove unnecessary dynamic import handling for runtime module (#7754) by @shulaoda - inline __toDynamicImportESM (#7747) by @IWANABETHATGUY - use From impl for ModuleLoaderOutput conversion (#7732) by @shulaoda - remove duplicate fields from `ModuleLoader` (#7731) by @shulaoda - tweak `resolve_user_defined_entries` (#7727) by @shulaoda ### 📚 Documentation - add rolldown-string reference to native MagicString compatibility section (#7778) by @Copilot - improve comments for export star side effects handling (#7730) by @IWANABETHATGUY ### 🧪 Testing - use assertion instead of console.log for some testcase (#7744) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - tweak some `output.dynamicImportInCjs` related rollup test results (#7776) by @sapphi-red - mark esbuild/dce/dce_of_symbol_ctor_call as passed (#7775) by @sapphi-red - deps: update oxc apps (#7772) by @renovate[bot] - vite-tests: allow running on PRs with `test: vite-tests` label (#7770) by @shulaoda - deps: update oxc apps (#7760) by @renovate[bot] - deps: update rollup submodule for tests to v4.55.1 (#7763) by @sapphi-red - deps: update test262 submodule for tests (#7764) by @sapphi-red - deps: update oxc to v0.107.0 (#7758) by @camc314 - deps: update taiki-e/install-action action to v2.65.13 (#7751) by @renovate[bot] - deps: update rust crates (#7750) by @renovate[bot] - deps: update npm packages (#7749) by @renovate[bot] - deps: update github-actions (#7748) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.1 (#7729) by @renovate[bot] - deps: update crate-ci/typos action to v1.41.0 (#7725) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned shulaoda Jan 6, 2026

shulaoda requested a review from IWANABETHATGUY January 6, 2026 03:57

shulaoda marked this pull request as ready for review January 6, 2026 03:57

Copilot AI review requested due to automatic review settings January 6, 2026 03:57

Copilot started reviewing on behalf of shulaoda January 6, 2026 03:57 View session

shulaoda commented Jan 6, 2026

View reviewed changes

crates/rolldown/src/module_loader/module_loader.rs Show resolved Hide resolved

Copilot AI reviewed Jan 6, 2026

View reviewed changes

IWANABETHATGUY reviewed Jan 6, 2026

View reviewed changes

crates/rolldown/src/module_loader/module_loader.rs Outdated Show resolved Hide resolved

shulaoda force-pushed the 01-06-fix_module_loader_mark_emitted_chunks_as_user-defined_entry_when_already_loaded branch from 51db4dc to 9ff8331 Compare January 6, 2026 04:34

shulaoda requested a review from IWANABETHATGUY January 6, 2026 04:34

shulaoda force-pushed the 01-06-fix_module_loader_mark_emitted_chunks_as_user-defined_entry_when_already_loaded branch from 9ff8331 to 8b1c845 Compare January 6, 2026 04:35

Copilot AI review requested due to automatic review settings January 6, 2026 04:35

Copilot started reviewing on behalf of shulaoda January 6, 2026 04:36 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

crates/rolldown/src/module_loader/module_loader.rs Outdated Show resolved Hide resolved

IWANABETHATGUY reviewed Jan 6, 2026

View reviewed changes

crates/rolldown/src/module_loader/module_loader.rs Show resolved Hide resolved

shulaoda force-pushed the 01-06-fix_module_loader_mark_emitted_chunks_as_user-defined_entry_when_already_loaded branch from 8b1c845 to 181087a Compare January 6, 2026 04:56

shulaoda requested a review from Copilot January 6, 2026 04:56

Copilot started reviewing on behalf of shulaoda January 6, 2026 04:57 View session

shulaoda requested a review from IWANABETHATGUY January 6, 2026 04:57

Copilot AI reviewed Jan 6, 2026

View reviewed changes

fix(module_loader): mark emitted chunks as user-defined entry when al…

f76c274

…ready loaded

shulaoda force-pushed the 01-06-fix_module_loader_mark_emitted_chunks_as_user-defined_entry_when_already_loaded branch from 181087a to f76c274 Compare January 6, 2026 05:01

IWANABETHATGUY approved these changes Jan 6, 2026

View reviewed changes

shulaoda merged commit 100a21a into main Jan 6, 2026
33 of 34 checks passed

shulaoda deleted the 01-06-fix_module_loader_mark_emitted_chunks_as_user-defined_entry_when_already_loaded branch January 6, 2026 05:24

This was referenced Jan 7, 2026

release: v1.0.0-beta.59 #7774

Closed

release: v1.0.0-beta.59 #7786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix(module_loader): mark emitted chunks as user-defined entry when already loaded#7765

fix(module_loader): mark emitted chunks as user-defined entry when already loaded#7765
shulaoda merged 1 commit intomainfrom
01-06-fix_module_loader_mark_emitted_chunks_as_user-defined_entry_when_already_loaded

shulaoda commented Jan 6, 2026 •

edited

Loading

Uh oh!

shulaoda commented Jan 6, 2026

Uh oh!

netlify bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

shulaoda commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Jan 6, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shulaoda commented Jan 6, 2026 •

edited

Loading

netlify bot commented Jan 6, 2026 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading