refactor: remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg` by shulaoda · Pull Request #7762 · rolldown/rolldown

shulaoda · 2026-01-06T00:29:13Z

This field is already accessible via chunk.preserve_entry_signatures, so storing it separately is redundant.

shulaoda · 2026-01-06T00:29:32Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-01-06T00:46:35Z

Benchmarks Rust

target: main(fcf2e8f)
pr: 01-06-refactor_remove_duplicate_preserve_entry_signatures_from_addentrymodulemsg(4b63c62)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     57.4±1.88ms        ? ?/sec    1.02     58.8±1.30ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     63.8±1.60ms        ? ?/sec    1.01     64.2±1.76ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00     97.8±1.94ms        ? ?/sec    1.01     98.9±1.13ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    110.3±2.30ms        ? ?/sec    1.01    111.7±1.44ms        ? ?/sec
bundle/bundle@threejs                                        1.00     35.3±0.65ms        ? ?/sec    1.00     35.5±0.52ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.6±0.43ms        ? ?/sec    1.01     41.0±0.55ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    364.9±2.33ms        ? ?/sec    1.00    365.4±3.19ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    433.8±3.19ms        ? ?/sec    1.00    430.7±2.93ms        ? ?/sec
scan/scan@rome_ts                                            1.00     76.1±1.29ms        ? ?/sec    1.00     76.2±1.22ms        ? ?/sec
scan/scan@threejs                                            1.00     26.0±0.30ms        ? ?/sec    1.00     25.9±0.33ms        ? ?/sec
scan/scan@threejs10x                                         1.00    265.3±2.61ms        ? ?/sec    1.01    267.2±3.14ms        ? ?/sec

netlify · 2026-01-06T03:53:45Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`4b63c62`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/695c8ca555abca0008bdb6c7

graphite-app · 2026-01-06T04:16:17Z

Merge activity

Jan 6, 4:16 AM UTC: shulaoda added this pull request to the Graphite merge queue.
Jan 6, 4:17 AM UTC: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason.

…ModuleMsg` (#7762) This field is already accessible via `chunk.preserve_entry_signatures`, so storing it separately is redundant.

@shulaoda

## [1.0.0-beta.59] - 2026-01-07 ⚡ Inline Dynamic Imports for Statically Imported Modules - When a module is already statically imported, dynamic imports to that same module are now inlined instead of creating a separate chunk ### 🚀 Features - plugin_timings: add 3s threshold and doc link to warning message (#7741) by @shulaoda - improve treeshaking logic to handle empty parameter list in dynamic import .then() callbacks (#7781) by @Copilot - dev/lazy: don't include already executed modules (#7745) by @hyf0 - dev/lazy: support dynamic `import(..)` (#7726) by @hyf0 - inline dynamic imports that imports statically imported modules (#7742) by @IWANABETHATGUY - option: add experimental option to control chunk optimization (#7738) by @IWANABETHATGUY ### 🐛 Bug Fixes - inline dynamic entry to user defined entry with esm wrap kind (#7783) by @IWANABETHATGUY - use canonical namespace reference for property access (#7777) by @IWANABETHATGUY - dynamic entry merged into common chunk with cjs and esm wrap kind (#7771) by @IWANABETHATGUY - tla: should not await non-tla-related modules (#7768) by @hyf0 - dynamic entry captured by common chunk with CJS format (#7757) by @IWANABETHATGUY - module_loader: mark emitted chunks as user-defined entry when already loaded (#7765) by @shulaoda - normalize preserveModulesRoot path (#7737) by @IWANABETHATGUY - linker: resolve race condition in side effects computation for export-star (#7728) by @camc314 ### 🚜 Refactor - plugin_timings: filter out plugins with duration < 1s from timing warnings (#7785) by @shulaoda - module_loader: remove unnecessary collect before extend (#7769) by @shulaoda - rename _id suffixes to _idx for oxc_index types (#7767) by @IWANABETHATGUY - remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg` (#7762) by @shulaoda - module_loader: pass `user_defined_entries` by reference (#7756) by @shulaoda - dev/lazy: get proxy entry's `ResolvedId` correctly (#7746) by @hyf0 - simplify try_rewrite_import_expression control flow (#7753) by @IWANABETHATGUY - module_loader: remove unnecessary dynamic import handling for runtime module (#7754) by @shulaoda - inline __toDynamicImportESM (#7747) by @IWANABETHATGUY - use From impl for ModuleLoaderOutput conversion (#7732) by @shulaoda - remove duplicate fields from `ModuleLoader` (#7731) by @shulaoda - tweak `resolve_user_defined_entries` (#7727) by @shulaoda ### 📚 Documentation - add rolldown-string reference to native MagicString compatibility section (#7778) by @Copilot - improve comments for export star side effects handling (#7730) by @IWANABETHATGUY ### 🧪 Testing - use assertion instead of console.log for some testcase (#7744) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - tweak some `output.dynamicImportInCjs` related rollup test results (#7776) by @sapphi-red - mark esbuild/dce/dce_of_symbol_ctor_call as passed (#7775) by @sapphi-red - deps: update oxc apps (#7772) by @renovate[bot] - vite-tests: allow running on PRs with `test: vite-tests` label (#7770) by @shulaoda - deps: update oxc apps (#7760) by @renovate[bot] - deps: update rollup submodule for tests to v4.55.1 (#7763) by @sapphi-red - deps: update test262 submodule for tests (#7764) by @sapphi-red - deps: update oxc to v0.107.0 (#7758) by @camc314 - deps: update taiki-e/install-action action to v2.65.13 (#7751) by @renovate[bot] - deps: update rust crates (#7750) by @renovate[bot] - deps: update npm packages (#7749) by @renovate[bot] - deps: update github-actions (#7748) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.1 (#7729) by @renovate[bot] - deps: update crate-ci/typos action to v1.41.0 (#7725) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned shulaoda Jan 6, 2026

shulaoda changed the title ~~refactor: remove duplicate preserve_entry_signatures from AddEntryModuleMsg~~ refactor: remove duplicate preserve_entry_signatures from AddEntryModuleMsg Jan 6, 2026

shulaoda mentioned this pull request Jan 6, 2026

refactor(module_loader): pass user_defined_entries by reference #7756

Merged

shulaoda requested a review from IWANABETHATGUY January 6, 2026 00:30

shulaoda marked this pull request as ready for review January 6, 2026 00:30

shulaoda requested review from hyf0 and removed request for IWANABETHATGUY January 6, 2026 00:30

shulaoda force-pushed the 01-06-refactor_remove_duplicate_preserve_entry_signatures_from_addentrymodulemsg branch from 3459c6b to 86e213a Compare January 6, 2026 00:31

shulaoda force-pushed the 01-05-refactor_module_loader_pass_user_defined_entries_by_reference branch from 74b55e8 to 4cb9d65 Compare January 6, 2026 00:31

graphite-app bot changed the base branch from 01-05-refactor_module_loader_pass_user_defined_entries_by_reference to graphite-base/7762 January 6, 2026 03:39

graphite-app bot force-pushed the 01-06-refactor_remove_duplicate_preserve_entry_signatures_from_addentrymodulemsg branch from 86e213a to 99d2370 Compare January 6, 2026 03:52

graphite-app bot changed the base branch from graphite-base/7762 to main January 6, 2026 03:52

graphite-app bot force-pushed the 01-06-refactor_remove_duplicate_preserve_entry_signatures_from_addentrymodulemsg branch from 99d2370 to 12601fe Compare January 6, 2026 03:52

shulaoda requested review from IWANABETHATGUY and removed request for hyf0 January 6, 2026 04:02

IWANABETHATGUY approved these changes Jan 6, 2026

View reviewed changes

refactor: remove duplicate preserve_entry_signatures from `AddEntry…

4b63c62

…ModuleMsg` (#7762) This field is already accessible via `chunk.preserve_entry_signatures`, so storing it separately is redundant.

graphite-app bot force-pushed the 01-06-refactor_remove_duplicate_preserve_entry_signatures_from_addentrymodulemsg branch from 12601fe to 4b63c62 Compare January 6, 2026 04:16

shulaoda merged commit 0cae717 into main Jan 6, 2026
11 of 12 checks passed

shulaoda deleted the 01-06-refactor_remove_duplicate_preserve_entry_signatures_from_addentrymodulemsg branch January 6, 2026 04:16

This was referenced Jan 7, 2026

release: v1.0.0-beta.59 #7774

Closed

release: v1.0.0-beta.59 #7786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg`#7762

refactor: remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg`#7762
shulaoda merged 1 commit intomainfrom
01-06-refactor_remove_duplicate_preserve_entry_signatures_from_addentrymodulemsg

shulaoda commented Jan 6, 2026 •

edited

Loading

Uh oh!

shulaoda commented Jan 6, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

netlify bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

shulaoda commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

netlify bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

graphite-app bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shulaoda commented Jan 6, 2026 •

edited

Loading

shulaoda commented Jan 6, 2026 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading

netlify bot commented Jan 6, 2026 •

edited

Loading

graphite-app bot commented Jan 6, 2026 •

edited

Loading