fix: dynamic entry captured by common chunk with CJS format by IWANABETHATGUY · Pull Request #7757 · rolldown/rolldown

IWANABETHATGUY · 2026-01-05T11:59:04Z

Move the dynamic import module in CJS format transformation logic to try_rewrite_import_expression because the logic is more closely aligned with the function name. Before it is in

rolldown/crates/rolldown/src/module_finalizers/mod.rs

Lines 1015 to 1019 in bc3a9ad

    
           fn try_rewrite_inline_dynamic_import_expr( 
        
             &self, 
        
             import_expr: &mut oxc::allocator::Box<'ast, ImportExpression<'ast>>, 
        
           ) -> Option<Expression<'ast>> { 
        
             let rec_id = self.ctx.module.imports.get(&import_expr.span)?;

Add logic for dynamic entry merge in the common chunk for cjs format.

IWANABETHATGUY · 2026-01-05T11:59:30Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-05T12:45:54Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`f0586c8`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/695cb60292915900086ab234

graphite-app · 2026-01-06T07:12:30Z

Merge activity

Jan 6, 7:12 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Jan 6, 7:23 AM UTC: Merged by the Graphite merge queue.

1. Move the dynamic import module in CJS format transformation logic to `try_rewrite_import_expression` because the logic is more closely aligned with the function name. Before it is in https://github.com/rolldown/rolldown/blob/bc3a9adb27966f8633b9482351c2a6fbc3c9992e/crates/rolldown/src/module_finalizers/mod.rs#L1015-L1019 2. Add logic for dynamic entry merge in the common chunk for cjs format.

github-actions · 2026-01-06T07:28:23Z

Benchmarks Rust

target: main(bc01984)
pr: 01-05-fix_dynamic_entry_captured_by_common_chunk(f0586c8)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.05     65.4±1.60ms        ? ?/sec    1.00     62.6±1.19ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.05     72.0±1.20ms        ? ?/sec    1.00     68.4±1.09ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    105.0±4.16ms        ? ?/sec    1.00    102.9±1.45ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    116.2±1.73ms        ? ?/sec    1.00    114.6±1.54ms        ? ?/sec
bundle/bundle@threejs                                        1.01     37.6±2.20ms        ? ?/sec    1.00     37.1±2.24ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     42.2±0.57ms        ? ?/sec    1.00     41.4±0.47ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02    379.2±3.55ms        ? ?/sec    1.00    371.4±5.74ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    440.4±4.97ms        ? ?/sec    1.00    432.6±3.44ms        ? ?/sec
scan/scan@rome_ts                                            1.00     82.9±1.67ms        ? ?/sec    1.00     82.7±1.44ms        ? ?/sec
scan/scan@threejs                                            1.02     28.1±1.50ms        ? ?/sec    1.00     27.4±0.35ms        ? ?/sec
scan/scan@threejs10x                                         1.00    281.5±3.70ms        ? ?/sec    1.02    286.2±4.22ms        ? ?/sec

@shulaoda

## [1.0.0-beta.59] - 2026-01-07 ⚡ Inline Dynamic Imports for Statically Imported Modules - When a module is already statically imported, dynamic imports to that same module are now inlined instead of creating a separate chunk ### 🚀 Features - plugin_timings: add 3s threshold and doc link to warning message (#7741) by @shulaoda - improve treeshaking logic to handle empty parameter list in dynamic import .then() callbacks (#7781) by @Copilot - dev/lazy: don't include already executed modules (#7745) by @hyf0 - dev/lazy: support dynamic `import(..)` (#7726) by @hyf0 - inline dynamic imports that imports statically imported modules (#7742) by @IWANABETHATGUY - option: add experimental option to control chunk optimization (#7738) by @IWANABETHATGUY ### 🐛 Bug Fixes - inline dynamic entry to user defined entry with esm wrap kind (#7783) by @IWANABETHATGUY - use canonical namespace reference for property access (#7777) by @IWANABETHATGUY - dynamic entry merged into common chunk with cjs and esm wrap kind (#7771) by @IWANABETHATGUY - tla: should not await non-tla-related modules (#7768) by @hyf0 - dynamic entry captured by common chunk with CJS format (#7757) by @IWANABETHATGUY - module_loader: mark emitted chunks as user-defined entry when already loaded (#7765) by @shulaoda - normalize preserveModulesRoot path (#7737) by @IWANABETHATGUY - linker: resolve race condition in side effects computation for export-star (#7728) by @camc314 ### 🚜 Refactor - plugin_timings: filter out plugins with duration < 1s from timing warnings (#7785) by @shulaoda - module_loader: remove unnecessary collect before extend (#7769) by @shulaoda - rename _id suffixes to _idx for oxc_index types (#7767) by @IWANABETHATGUY - remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg` (#7762) by @shulaoda - module_loader: pass `user_defined_entries` by reference (#7756) by @shulaoda - dev/lazy: get proxy entry's `ResolvedId` correctly (#7746) by @hyf0 - simplify try_rewrite_import_expression control flow (#7753) by @IWANABETHATGUY - module_loader: remove unnecessary dynamic import handling for runtime module (#7754) by @shulaoda - inline __toDynamicImportESM (#7747) by @IWANABETHATGUY - use From impl for ModuleLoaderOutput conversion (#7732) by @shulaoda - remove duplicate fields from `ModuleLoader` (#7731) by @shulaoda - tweak `resolve_user_defined_entries` (#7727) by @shulaoda ### 📚 Documentation - add rolldown-string reference to native MagicString compatibility section (#7778) by @Copilot - improve comments for export star side effects handling (#7730) by @IWANABETHATGUY ### 🧪 Testing - use assertion instead of console.log for some testcase (#7744) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - tweak some `output.dynamicImportInCjs` related rollup test results (#7776) by @sapphi-red - mark esbuild/dce/dce_of_symbol_ctor_call as passed (#7775) by @sapphi-red - deps: update oxc apps (#7772) by @renovate[bot] - vite-tests: allow running on PRs with `test: vite-tests` label (#7770) by @shulaoda - deps: update oxc apps (#7760) by @renovate[bot] - deps: update rollup submodule for tests to v4.55.1 (#7763) by @sapphi-red - deps: update test262 submodule for tests (#7764) by @sapphi-red - deps: update oxc to v0.107.0 (#7758) by @camc314 - deps: update taiki-e/install-action action to v2.65.13 (#7751) by @renovate[bot] - deps: update rust crates (#7750) by @renovate[bot] - deps: update npm packages (#7749) by @renovate[bot] - deps: update github-actions (#7748) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.1 (#7729) by @renovate[bot] - deps: update crate-ci/typos action to v1.41.0 (#7725) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Jan 5, 2026

This was referenced Jan 5, 2026

feat: inline dynamic imports that imports statically imported modules #7742

Merged

test: use assertion instead of console.log for some testcase #7744

Merged

refactor: simplify try_rewrite_import_expression control flow #7753

Merged

IWANABETHATGUY changed the title ~~fix~~ fix: dynamic entry captured by common chunk with CJS format Jan 5, 2026

IWANABETHATGUY marked this pull request as ready for review January 5, 2026 11:59

IWANABETHATGUY marked this pull request as draft January 5, 2026 11:59

IWANABETHATGUY force-pushed the 01-05-fix_dynamic_entry_captured_by_common_chunk branch 2 times, most recently from c67f5a7 to 02d7eb2 Compare January 5, 2026 12:07

graphite-app bot changed the base branch from 01-05-refactor_simplify_try_rewrite_import_expression_control_flow to graphite-base/7757 January 5, 2026 12:22

graphite-app bot force-pushed the graphite-base/7757 branch from b609f15 to 77768f5 Compare January 5, 2026 12:44

graphite-app bot force-pushed the 01-05-fix_dynamic_entry_captured_by_common_chunk branch from 02d7eb2 to 15f8e2d Compare January 5, 2026 12:44

graphite-app bot changed the base branch from graphite-base/7757 to main January 5, 2026 12:44

graphite-app bot force-pushed the 01-05-fix_dynamic_entry_captured_by_common_chunk branch from 15f8e2d to 1a371a0 Compare January 5, 2026 12:45

IWANABETHATGUY force-pushed the 01-05-fix_dynamic_entry_captured_by_common_chunk branch 4 times, most recently from 74c62da to c9163e1 Compare January 6, 2026 06:44

IWANABETHATGUY marked this pull request as ready for review January 6, 2026 06:58

Copilot AI review requested due to automatic review settings January 6, 2026 06:58

Copilot started reviewing on behalf of IWANABETHATGUY January 6, 2026 06:59 View session

IWANABETHATGUY requested review from hyf0 and shulaoda and removed request for Copilot January 6, 2026 06:59

shulaoda approved these changes Jan 6, 2026

View reviewed changes

graphite-app bot force-pushed the 01-05-fix_dynamic_entry_captured_by_common_chunk branch from c9163e1 to f0586c8 Compare January 6, 2026 07:13

graphite-app bot merged commit f0586c8 into main Jan 6, 2026
34 checks passed

graphite-app bot deleted the 01-05-fix_dynamic_entry_captured_by_common_chunk branch January 6, 2026 07:23

This was referenced Jan 7, 2026

release: v1.0.0-beta.59 #7774

Closed

release: v1.0.0-beta.59 #7786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: dynamic entry captured by common chunk with CJS format#7757

fix: dynamic entry captured by common chunk with CJS format#7757
graphite-app[bot] merged 1 commit intomainfrom
01-05-fix_dynamic_entry_captured_by_common_chunk

IWANABETHATGUY commented Jan 5, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Jan 5, 2026 •

edited

Loading

Uh oh!

netlify bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	fn try_rewrite_inline_dynamic_import_expr(
	&self,
	import_expr: &mut oxc::allocator::Box<'ast, ImportExpression<'ast>>,
	) -> Option<Expression<'ast>> {
	let rec_id = self.ctx.module.imports.get(&import_expr.span)?;

Comments

Conversation

IWANABETHATGUY commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

graphite-app bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026

Benchmarks Rust

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Jan 5, 2026 •

edited

Loading

IWANABETHATGUY commented Jan 5, 2026 •

edited

Loading

netlify bot commented Jan 5, 2026 •

edited

Loading

graphite-app bot commented Jan 6, 2026 •

edited

Loading