refactor(module_loader): pass `user_defined_entries` by reference by shulaoda · Pull Request #7756 · rolldown/rolldown

shulaoda · 2026-01-05T11:41:32Z

Change parameter type from Arc<...> to &Arc<...> to avoid unnecessary cloning
Use explicit Module::External(Box::new(...)) instead of .into()
Use .iter().cloned() instead of manual .clone() in loops
Remove redundant type annotations
Fix grammar in comments

shulaoda · 2026-01-05T11:41:51Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-01-05T12:08:52Z

Benchmarks Rust

target: main(da592c7)
pr: 01-05-refactor_module_loader_pass_user_defined_entries_by_reference(fcf2e8f)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     58.2±1.24ms        ? ?/sec    1.04     60.5±1.58ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     64.2±1.20ms        ? ?/sec    1.02     65.6±1.21ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00     99.5±2.02ms        ? ?/sec    1.02    102.0±2.29ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    112.7±2.27ms        ? ?/sec    1.01    113.4±1.84ms        ? ?/sec
bundle/bundle@threejs                                        1.00     35.9±0.66ms        ? ?/sec    1.02     36.7±0.62ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     41.0±0.61ms        ? ?/sec    1.01     41.6±1.04ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    368.4±4.77ms        ? ?/sec    1.01    370.8±5.04ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    436.5±6.10ms        ? ?/sec    1.01    442.8±4.99ms        ? ?/sec
scan/scan@rome_ts                                            1.00     77.5±1.45ms        ? ?/sec    1.03     79.5±3.13ms        ? ?/sec
scan/scan@threejs                                            1.00     26.6±1.71ms        ? ?/sec    1.02     27.1±1.66ms        ? ?/sec
scan/scan@threejs10x                                         1.00    271.7±3.57ms        ? ?/sec    1.06   288.1±14.22ms        ? ?/sec

crates/rolldown/src/module_loader/module_loader.rs

netlify · 2026-01-06T00:15:09Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`fcf2e8f`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/695c840efa3f710008f1a5d3

Copilot

Pull request overview

This PR refactors the user_defined_entries parameter handling in ModuleLoader to use references instead of cloning Arc, improving performance by avoiding unnecessary reference count increments. The changes also include minor code quality improvements such as better variable naming and grammar fixes.

Optimized try_spawn_new_task to accept &Arc<Vec<...>> instead of Arc<Vec<...>>, eliminating redundant Arc::clone calls at call sites
Simplified iteration patterns using .iter().cloned() instead of manual cloning
Improved code readability with better variable names and clearer comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graphite-app · 2026-01-06T03:39:17Z

Merge activity

Jan 6, 3:39 AM UTC: shulaoda added this pull request to the Graphite merge queue.
Jan 6, 3:51 AM UTC: Merged by the Graphite merge queue.

) - Change parameter type from `Arc<...>` to `&Arc<...>` to avoid unnecessary cloning - Use explicit `Module::External(Box::new(...))` instead of `.into()` - Use `.iter().cloned()` instead of manual `.clone()` in loops - Remove redundant type annotations - Fix grammar in comments

@shulaoda

## [1.0.0-beta.59] - 2026-01-07 ⚡ Inline Dynamic Imports for Statically Imported Modules - When a module is already statically imported, dynamic imports to that same module are now inlined instead of creating a separate chunk ### 🚀 Features - plugin_timings: add 3s threshold and doc link to warning message (#7741) by @shulaoda - improve treeshaking logic to handle empty parameter list in dynamic import .then() callbacks (#7781) by @Copilot - dev/lazy: don't include already executed modules (#7745) by @hyf0 - dev/lazy: support dynamic `import(..)` (#7726) by @hyf0 - inline dynamic imports that imports statically imported modules (#7742) by @IWANABETHATGUY - option: add experimental option to control chunk optimization (#7738) by @IWANABETHATGUY ### 🐛 Bug Fixes - inline dynamic entry to user defined entry with esm wrap kind (#7783) by @IWANABETHATGUY - use canonical namespace reference for property access (#7777) by @IWANABETHATGUY - dynamic entry merged into common chunk with cjs and esm wrap kind (#7771) by @IWANABETHATGUY - tla: should not await non-tla-related modules (#7768) by @hyf0 - dynamic entry captured by common chunk with CJS format (#7757) by @IWANABETHATGUY - module_loader: mark emitted chunks as user-defined entry when already loaded (#7765) by @shulaoda - normalize preserveModulesRoot path (#7737) by @IWANABETHATGUY - linker: resolve race condition in side effects computation for export-star (#7728) by @camc314 ### 🚜 Refactor - plugin_timings: filter out plugins with duration < 1s from timing warnings (#7785) by @shulaoda - module_loader: remove unnecessary collect before extend (#7769) by @shulaoda - rename _id suffixes to _idx for oxc_index types (#7767) by @IWANABETHATGUY - remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg` (#7762) by @shulaoda - module_loader: pass `user_defined_entries` by reference (#7756) by @shulaoda - dev/lazy: get proxy entry's `ResolvedId` correctly (#7746) by @hyf0 - simplify try_rewrite_import_expression control flow (#7753) by @IWANABETHATGUY - module_loader: remove unnecessary dynamic import handling for runtime module (#7754) by @shulaoda - inline __toDynamicImportESM (#7747) by @IWANABETHATGUY - use From impl for ModuleLoaderOutput conversion (#7732) by @shulaoda - remove duplicate fields from `ModuleLoader` (#7731) by @shulaoda - tweak `resolve_user_defined_entries` (#7727) by @shulaoda ### 📚 Documentation - add rolldown-string reference to native MagicString compatibility section (#7778) by @Copilot - improve comments for export star side effects handling (#7730) by @IWANABETHATGUY ### 🧪 Testing - use assertion instead of console.log for some testcase (#7744) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - tweak some `output.dynamicImportInCjs` related rollup test results (#7776) by @sapphi-red - mark esbuild/dce/dce_of_symbol_ctor_call as passed (#7775) by @sapphi-red - deps: update oxc apps (#7772) by @renovate[bot] - vite-tests: allow running on PRs with `test: vite-tests` label (#7770) by @shulaoda - deps: update oxc apps (#7760) by @renovate[bot] - deps: update rollup submodule for tests to v4.55.1 (#7763) by @sapphi-red - deps: update test262 submodule for tests (#7764) by @sapphi-red - deps: update oxc to v0.107.0 (#7758) by @camc314 - deps: update taiki-e/install-action action to v2.65.13 (#7751) by @renovate[bot] - deps: update rust crates (#7750) by @renovate[bot] - deps: update npm packages (#7749) by @renovate[bot] - deps: update github-actions (#7748) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.1 (#7729) by @renovate[bot] - deps: update crate-ci/typos action to v1.41.0 (#7725) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned shulaoda Jan 5, 2026

shulaoda changed the title ~~refactor(module_loader): pass user_defined_entries by reference~~ refactor(module_loader): pass user_defined_entries by reference Jan 5, 2026

shulaoda mentioned this pull request Jan 5, 2026

refactor(module_loader): remove unnecessary dynamic import handling for runtime module #7754

Merged

shulaoda mentioned this pull request Jan 5, 2026

refactor(module_loader): use HybridIndexVec::update for value assignment #7755

Closed

shulaoda requested review from IWANABETHATGUY and hyf0 January 5, 2026 11:42

shulaoda marked this pull request as ready for review January 5, 2026 11:42

shulaoda force-pushed the 01-05-refactor_module_loader_pass_user_defined_entries_by_reference branch 2 times, most recently from 1704fc3 to 3ddc51c Compare January 5, 2026 11:53

shulaoda force-pushed the 01-05-refactor_use_hybridindexvec_update_for_value_assignment branch from 3b7ff66 to e82b8de Compare January 5, 2026 11:53

IWANABETHATGUY reviewed Jan 5, 2026

View reviewed changes

crates/rolldown/src/module_loader/module_loader.rs Outdated Show resolved Hide resolved

graphite-app bot force-pushed the 01-05-refactor_use_hybridindexvec_update_for_value_assignment branch 2 times, most recently from 4bf3df2 to ad3e134 Compare January 5, 2026 12:23

graphite-app bot force-pushed the 01-05-refactor_module_loader_pass_user_defined_entries_by_reference branch from 3ddc51c to 19c1c65 Compare January 5, 2026 12:23

shulaoda changed the base branch from 01-05-refactor_use_hybridindexvec_update_for_value_assignment to graphite-base/7756 January 6, 2026 00:10

shulaoda force-pushed the 01-05-refactor_module_loader_pass_user_defined_entries_by_reference branch from 19c1c65 to 5944d0b Compare January 6, 2026 00:10

shulaoda force-pushed the graphite-base/7756 branch from ad3e134 to da592c7 Compare January 6, 2026 00:10

shulaoda changed the base branch from graphite-base/7756 to main January 6, 2026 00:10

Copilot AI review requested due to automatic review settings January 6, 2026 00:13

shulaoda force-pushed the 01-05-refactor_module_loader_pass_user_defined_entries_by_reference branch from 5944d0b to 74b55e8 Compare January 6, 2026 00:13

Copilot started reviewing on behalf of shulaoda January 6, 2026 00:13 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

shulaoda mentioned this pull request Jan 6, 2026

refactor: remove duplicate preserve_entry_signatures from AddEntryModuleMsg #7762

Merged

shulaoda requested a review from IWANABETHATGUY January 6, 2026 00:31

shulaoda force-pushed the 01-05-refactor_module_loader_pass_user_defined_entries_by_reference branch from 74b55e8 to 4cb9d65 Compare January 6, 2026 00:31

IWANABETHATGUY approved these changes Jan 6, 2026

View reviewed changes

graphite-app bot force-pushed the 01-05-refactor_module_loader_pass_user_defined_entries_by_reference branch from 4cb9d65 to fcf2e8f Compare January 6, 2026 03:39

graphite-app bot merged commit fcf2e8f into main Jan 6, 2026
34 checks passed

graphite-app bot deleted the 01-05-refactor_module_loader_pass_user_defined_entries_by_reference branch January 6, 2026 03:51

This was referenced Jan 7, 2026

release: v1.0.0-beta.59 #7774

Closed

release: v1.0.0-beta.59 #7786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor(module_loader): pass `user_defined_entries` by reference#7756

refactor(module_loader): pass `user_defined_entries` by reference#7756
graphite-app[bot] merged 1 commit intomainfrom
01-05-refactor_module_loader_pass_user_defined_entries_by_reference

shulaoda commented Jan 5, 2026 •

edited

Loading

Uh oh!

shulaoda commented Jan 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

netlify bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

shulaoda commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

netlify bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shulaoda commented Jan 5, 2026 •

edited

Loading

shulaoda commented Jan 5, 2026 •

edited

Loading

github-actions bot commented Jan 5, 2026 •

edited

Loading

netlify bot commented Jan 6, 2026 •

edited

Loading

graphite-app bot commented Jan 6, 2026 •

edited

Loading