refactor(module_loader): remove unnecessary dynamic import handling for runtime module by shulaoda · Pull Request #7754 · rolldown/rolldown

shulaoda · 2026-01-05T10:50:34Z

The runtime module is internal bundler code that doesn't have dynamic imports, so the dynamic import entry tracking logic is unnecessary for RuntimeNormalModuleDone.

shulaoda · 2026-01-05T10:50:49Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-01-05T10:52:43Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`fac5b13`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/695ba9fbabcf1500088eb042

Copilot

Pull request overview

This PR removes unnecessary dynamic import entry tracking logic from the RuntimeNormalModuleDone handler. Since the runtime module is internal bundler code that doesn't contain dynamic imports, the logic for tracking dynamic imports and adding them as entry points is not needed.

Key Changes:

Removed dynamic import entry tracking code that populates dynamic_import_entry_ids map
Changed from into_iter_enumerated() to into_iter() since rec_idx is no longer needed
Minor code organization improvements (whitespace and variable assignment order)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-01-05T11:06:54Z

Benchmarks Rust

target: main(6c69f39)
pr: 01-05-refactor_remove_unnecessary_dynamic_import_handling_for_runtime_module(fac5b13)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.11     67.9±1.50ms        ? ?/sec    1.00     61.2±1.16ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.09     74.0±2.91ms        ? ?/sec    1.00     67.7±1.22ms        ? ?/sec
bundle/bundle@rome_ts                                        1.05    110.7±1.45ms        ? ?/sec    1.00    105.4±2.18ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.04    122.3±2.16ms        ? ?/sec    1.00    117.5±1.52ms        ? ?/sec
bundle/bundle@threejs                                        1.10     40.9±2.18ms        ? ?/sec    1.00     37.0±0.76ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.05     45.0±0.65ms        ? ?/sec    1.00     42.8±1.27ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02    390.8±5.18ms        ? ?/sec    1.00    384.5±4.36ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    460.9±6.26ms        ? ?/sec    1.00    451.2±5.72ms        ? ?/sec
scan/scan@rome_ts                                            1.06     88.0±1.67ms        ? ?/sec    1.00     83.3±1.33ms        ? ?/sec
scan/scan@threejs                                            1.04     29.3±0.40ms        ? ?/sec    1.00     28.2±0.43ms        ? ?/sec
scan/scan@threejs10x                                         1.05    303.9±4.48ms        ? ?/sec    1.00    289.3±4.72ms        ? ?/sec

graphite-app · 2026-01-05T12:08:54Z

Merge activity

Jan 5, 12:08 PM UTC: shulaoda added this pull request to the Graphite merge queue.
Jan 5, 12:21 PM UTC: Merged by the Graphite merge queue.

…or runtime module (#7754) The runtime module is internal bundler code that doesn't have dynamic imports, so the dynamic import entry tracking logic is unnecessary for `RuntimeNormalModuleDone`.

@shulaoda

## [1.0.0-beta.59] - 2026-01-07 ⚡ Inline Dynamic Imports for Statically Imported Modules - When a module is already statically imported, dynamic imports to that same module are now inlined instead of creating a separate chunk ### 🚀 Features - plugin_timings: add 3s threshold and doc link to warning message (#7741) by @shulaoda - improve treeshaking logic to handle empty parameter list in dynamic import .then() callbacks (#7781) by @Copilot - dev/lazy: don't include already executed modules (#7745) by @hyf0 - dev/lazy: support dynamic `import(..)` (#7726) by @hyf0 - inline dynamic imports that imports statically imported modules (#7742) by @IWANABETHATGUY - option: add experimental option to control chunk optimization (#7738) by @IWANABETHATGUY ### 🐛 Bug Fixes - inline dynamic entry to user defined entry with esm wrap kind (#7783) by @IWANABETHATGUY - use canonical namespace reference for property access (#7777) by @IWANABETHATGUY - dynamic entry merged into common chunk with cjs and esm wrap kind (#7771) by @IWANABETHATGUY - tla: should not await non-tla-related modules (#7768) by @hyf0 - dynamic entry captured by common chunk with CJS format (#7757) by @IWANABETHATGUY - module_loader: mark emitted chunks as user-defined entry when already loaded (#7765) by @shulaoda - normalize preserveModulesRoot path (#7737) by @IWANABETHATGUY - linker: resolve race condition in side effects computation for export-star (#7728) by @camc314 ### 🚜 Refactor - plugin_timings: filter out plugins with duration < 1s from timing warnings (#7785) by @shulaoda - module_loader: remove unnecessary collect before extend (#7769) by @shulaoda - rename _id suffixes to _idx for oxc_index types (#7767) by @IWANABETHATGUY - remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg` (#7762) by @shulaoda - module_loader: pass `user_defined_entries` by reference (#7756) by @shulaoda - dev/lazy: get proxy entry's `ResolvedId` correctly (#7746) by @hyf0 - simplify try_rewrite_import_expression control flow (#7753) by @IWANABETHATGUY - module_loader: remove unnecessary dynamic import handling for runtime module (#7754) by @shulaoda - inline __toDynamicImportESM (#7747) by @IWANABETHATGUY - use From impl for ModuleLoaderOutput conversion (#7732) by @shulaoda - remove duplicate fields from `ModuleLoader` (#7731) by @shulaoda - tweak `resolve_user_defined_entries` (#7727) by @shulaoda ### 📚 Documentation - add rolldown-string reference to native MagicString compatibility section (#7778) by @Copilot - improve comments for export star side effects handling (#7730) by @IWANABETHATGUY ### 🧪 Testing - use assertion instead of console.log for some testcase (#7744) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - tweak some `output.dynamicImportInCjs` related rollup test results (#7776) by @sapphi-red - mark esbuild/dce/dce_of_symbol_ctor_call as passed (#7775) by @sapphi-red - deps: update oxc apps (#7772) by @renovate[bot] - vite-tests: allow running on PRs with `test: vite-tests` label (#7770) by @shulaoda - deps: update oxc apps (#7760) by @renovate[bot] - deps: update rollup submodule for tests to v4.55.1 (#7763) by @sapphi-red - deps: update test262 submodule for tests (#7764) by @sapphi-red - deps: update oxc to v0.107.0 (#7758) by @camc314 - deps: update taiki-e/install-action action to v2.65.13 (#7751) by @renovate[bot] - deps: update rust crates (#7750) by @renovate[bot] - deps: update npm packages (#7749) by @renovate[bot] - deps: update github-actions (#7748) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.1 (#7729) by @renovate[bot] - deps: update crate-ci/typos action to v1.41.0 (#7725) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned shulaoda Jan 5, 2026

shulaoda requested review from IWANABETHATGUY and hyf0 January 5, 2026 10:50

shulaoda marked this pull request as ready for review January 5, 2026 10:50

Copilot AI review requested due to automatic review settings January 5, 2026 10:51

Copilot started reviewing on behalf of shulaoda January 5, 2026 10:51 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

hyf0 assigned IWANABETHATGUY and unassigned shulaoda Jan 5, 2026

This was referenced Jan 5, 2026

refactor(module_loader): use HybridIndexVec::update for value assignment #7755

Closed

refactor(module_loader): pass user_defined_entries by reference #7756

Merged

shulaoda changed the title ~~refactor: remove unnecessary dynamic import handling for runtime module~~ refactor(module_loader): remove unnecessary dynamic import handling for runtime module Jan 5, 2026

IWANABETHATGUY approved these changes Jan 5, 2026

View reviewed changes

refactor(module_loader): remove unnecessary dynamic import handling f…

fac5b13

…or runtime module (#7754) The runtime module is internal bundler code that doesn't have dynamic imports, so the dynamic import entry tracking logic is unnecessary for `RuntimeNormalModuleDone`.

graphite-app bot force-pushed the 01-05-refactor_remove_unnecessary_dynamic_import_handling_for_runtime_module branch from 3116949 to fac5b13 Compare January 5, 2026 12:09

graphite-app bot merged commit fac5b13 into main Jan 5, 2026
34 checks passed

graphite-app bot deleted the 01-05-refactor_remove_unnecessary_dynamic_import_handling_for_runtime_module branch January 5, 2026 12:21

This was referenced Jan 7, 2026

release: v1.0.0-beta.59 #7774

Closed

release: v1.0.0-beta.59 #7786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor(module_loader): remove unnecessary dynamic import handling for runtime module#7754

refactor(module_loader): remove unnecessary dynamic import handling for runtime module#7754
graphite-app[bot] merged 1 commit intomainfrom
01-05-refactor_remove_unnecessary_dynamic_import_handling_for_runtime_module

shulaoda commented Jan 5, 2026 •

edited

Loading

Uh oh!

shulaoda commented Jan 5, 2026 •

edited

Loading

Uh oh!

netlify bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

shulaoda commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shulaoda commented Jan 5, 2026 •

edited

Loading

shulaoda commented Jan 5, 2026 •

edited

Loading

netlify bot commented Jan 5, 2026 •

edited

Loading

github-actions bot commented Jan 5, 2026 •

edited

Loading

graphite-app bot commented Jan 5, 2026 •

edited

Loading