feat(dev/lazy): don't include already executed modules by hyf0 · Pull Request #7745 · rolldown/rolldown

hyf0 · 2026-01-04T15:42:43Z

No description provided.

hyf0 · 2026-01-04T15:42:58Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-01-04T16:00:03Z

Benchmarks Rust

target: main(e8e1c20)
pr: 01-04-feat_dev_lazy_don_t_include_already_executed_modules(950b728)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     70.6±3.55ms        ? ?/sec    1.11     78.3±3.12ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     86.0±3.13ms        ? ?/sec    1.01     86.8±5.37ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    106.5±2.33ms        ? ?/sec    1.12    119.3±2.95ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    120.5±4.45ms        ? ?/sec    1.09    131.3±2.47ms        ? ?/sec
bundle/bundle@threejs                                        1.00     38.9±2.36ms        ? ?/sec    1.12     43.5±2.34ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.2±1.06ms        ? ?/sec    1.11     48.1±0.85ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    438.8±4.42ms        ? ?/sec    1.00    433.3±6.79ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    503.9±5.77ms        ? ?/sec    1.00    497.1±5.94ms        ? ?/sec
scan/scan@rome_ts                                            1.00     93.9±3.44ms        ? ?/sec    1.02     95.7±2.28ms        ? ?/sec
scan/scan@threejs                                            1.00     31.4±1.66ms        ? ?/sec    1.00     31.5±1.92ms        ? ?/sec
scan/scan@threejs10x                                         1.00    317.5±4.68ms        ? ?/sec    1.00    318.8±5.63ms        ? ?/sec

graphite-app · 2026-01-05T12:45:33Z

Merge activity

Jan 5, 12:45 PM UTC: graphite-app added this pull request to the Graphite merge queue.
Jan 5, 12:46 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7726.
Jan 5, 12:46 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #7726.
Jan 5, 3:30 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Jan 5, 3:41 PM UTC: Merged by the Graphite merge queue.

Copilot

Pull request overview

This PR enhances the lazy compilation feature by implementing module deduplication to prevent duplicate execution when multiple lazy entries share common dependencies. The implementation tracks executed modules on the client side and filters them out during server-side patch generation.

Key changes:

Documentation updated to explain the new deduplication mechanism and document the race condition edge case
Server-side filtering logic added to exclude already-executed modules from lazy compilation patches
AST transformation updated to conditionally generate init function calls based on module presence in the current patch

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
examples/lazy/lazy-compilation.md	Updated documentation to explain the new deduplication mechanism, race condition edge case, and potential future enhancement with runtime guards
crates/rolldown/src/hmr/hmr_stage.rs	Added filtering logic to exclude executed modules from patches while preserving the entry module, and activated the previously unused `executed_modules` parameter
crates/rolldown/src/hmr/hmr_ast_finalizer.rs	Refactored require() rewriting to conditionally call init functions only for modules in the current patch, falling back to just loading exports for already-executed modules

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

examples/lazy/lazy-compilation.md

crates/rolldown/src/hmr/hmr_stage.rs

crates/rolldown/src/hmr/hmr_ast_finalizer.rs

netlify · 2026-01-05T13:22:47Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`c4012f3`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/695bd921b892be0008bcd56c

@shulaoda

## [1.0.0-beta.59] - 2026-01-07 ⚡ Inline Dynamic Imports for Statically Imported Modules - When a module is already statically imported, dynamic imports to that same module are now inlined instead of creating a separate chunk ### 🚀 Features - plugin_timings: add 3s threshold and doc link to warning message (#7741) by @shulaoda - improve treeshaking logic to handle empty parameter list in dynamic import .then() callbacks (#7781) by @Copilot - dev/lazy: don't include already executed modules (#7745) by @hyf0 - dev/lazy: support dynamic `import(..)` (#7726) by @hyf0 - inline dynamic imports that imports statically imported modules (#7742) by @IWANABETHATGUY - option: add experimental option to control chunk optimization (#7738) by @IWANABETHATGUY ### 🐛 Bug Fixes - inline dynamic entry to user defined entry with esm wrap kind (#7783) by @IWANABETHATGUY - use canonical namespace reference for property access (#7777) by @IWANABETHATGUY - dynamic entry merged into common chunk with cjs and esm wrap kind (#7771) by @IWANABETHATGUY - tla: should not await non-tla-related modules (#7768) by @hyf0 - dynamic entry captured by common chunk with CJS format (#7757) by @IWANABETHATGUY - module_loader: mark emitted chunks as user-defined entry when already loaded (#7765) by @shulaoda - normalize preserveModulesRoot path (#7737) by @IWANABETHATGUY - linker: resolve race condition in side effects computation for export-star (#7728) by @camc314 ### 🚜 Refactor - plugin_timings: filter out plugins with duration < 1s from timing warnings (#7785) by @shulaoda - module_loader: remove unnecessary collect before extend (#7769) by @shulaoda - rename _id suffixes to _idx for oxc_index types (#7767) by @IWANABETHATGUY - remove duplicate `preserve_entry_signatures` from `AddEntryModuleMsg` (#7762) by @shulaoda - module_loader: pass `user_defined_entries` by reference (#7756) by @shulaoda - dev/lazy: get proxy entry's `ResolvedId` correctly (#7746) by @hyf0 - simplify try_rewrite_import_expression control flow (#7753) by @IWANABETHATGUY - module_loader: remove unnecessary dynamic import handling for runtime module (#7754) by @shulaoda - inline __toDynamicImportESM (#7747) by @IWANABETHATGUY - use From impl for ModuleLoaderOutput conversion (#7732) by @shulaoda - remove duplicate fields from `ModuleLoader` (#7731) by @shulaoda - tweak `resolve_user_defined_entries` (#7727) by @shulaoda ### 📚 Documentation - add rolldown-string reference to native MagicString compatibility section (#7778) by @Copilot - improve comments for export star side effects handling (#7730) by @IWANABETHATGUY ### 🧪 Testing - use assertion instead of console.log for some testcase (#7744) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - tweak some `output.dynamicImportInCjs` related rollup test results (#7776) by @sapphi-red - mark esbuild/dce/dce_of_symbol_ctor_call as passed (#7775) by @sapphi-red - deps: update oxc apps (#7772) by @renovate[bot] - vite-tests: allow running on PRs with `test: vite-tests` label (#7770) by @shulaoda - deps: update oxc apps (#7760) by @renovate[bot] - deps: update rollup submodule for tests to v4.55.1 (#7763) by @sapphi-red - deps: update test262 submodule for tests (#7764) by @sapphi-red - deps: update oxc to v0.107.0 (#7758) by @camc314 - deps: update taiki-e/install-action action to v2.65.13 (#7751) by @renovate[bot] - deps: update rust crates (#7750) by @renovate[bot] - deps: update npm packages (#7749) by @renovate[bot] - deps: update github-actions (#7748) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.1 (#7729) by @renovate[bot] - deps: update crate-ci/typos action to v1.41.0 (#7725) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>

hyf0 mentioned this pull request Jan 4, 2026

feat(dev/lazy): support dynamic import(..) #7726

Merged

github-actions bot assigned hyf0 Jan 4, 2026

hyf0 mentioned this pull request Jan 4, 2026

refactor(dev/lazy): get proxy entry's ResolvedId correctly #7746

Merged

hyf0 marked this pull request as ready for review January 4, 2026 15:44

hyf0 requested review from Copilot and sapphi-red and removed request for Copilot January 4, 2026 15:44

Copilot started reviewing on behalf of hyf0 January 4, 2026 15:44 View session

graphite-app bot added the graphite: merge-when-ready label Jan 5, 2026

graphite-app bot changed the base branch from hyf_lazy_new to graphite-base/7745 January 5, 2026 12:23

shulaoda changed the title ~~feat(dev/lazy): don\'t include already executed modules~~ feat(dev/lazy): don't include already executed modules Jan 5, 2026

shulaoda approved these changes Jan 5, 2026

View reviewed changes

graphite-app bot removed the graphite: merge-when-ready label Jan 5, 2026

hyf0 force-pushed the graphite-base/7745 branch from 5736c0a to 93766ca Compare January 5, 2026 12:49

Copilot AI review requested due to automatic review settings January 5, 2026 12:49

hyf0 force-pushed the 01-04-feat_dev_lazy_don_t_include_already_executed_modules branch from 243ccf0 to c5f0486 Compare January 5, 2026 12:49

Copilot started reviewing on behalf of hyf0 January 5, 2026 12:49 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

examples/lazy/lazy-compilation.md Show resolved Hide resolved

examples/lazy/lazy-compilation.md Show resolved Hide resolved

crates/rolldown/src/hmr/hmr_stage.rs Show resolved Hide resolved

crates/rolldown/src/hmr/hmr_ast_finalizer.rs Show resolved Hide resolved

graphite-app bot force-pushed the graphite-base/7745 branch from 93766ca to e8e1c20 Compare January 5, 2026 13:20

graphite-app bot force-pushed the 01-04-feat_dev_lazy_don_t_include_already_executed_modules branch from c5f0486 to b84e521 Compare January 5, 2026 13:20

graphite-app bot changed the base branch from graphite-base/7745 to main January 5, 2026 13:21

graphite-app bot force-pushed the 01-04-feat_dev_lazy_don_t_include_already_executed_modules branch from b84e521 to 950b728 Compare January 5, 2026 13:21

graphite-app bot added the graphite: merge-when-ready label Jan 5, 2026

feat(dev/lazy): don't include already executed modules (#7745)

c4012f3

graphite-app bot force-pushed the 01-04-feat_dev_lazy_don_t_include_already_executed_modules branch from 950b728 to c4012f3 Compare January 5, 2026 15:30

graphite-app bot merged commit c4012f3 into main Jan 5, 2026
33 checks passed

graphite-app bot deleted the 01-04-feat_dev_lazy_don_t_include_already_executed_modules branch January 5, 2026 15:41

graphite-app bot removed the graphite: merge-when-ready label Jan 5, 2026

This was referenced Jan 7, 2026

release: v1.0.0-beta.59 #7774

Closed

release: v1.0.0-beta.59 #7786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat(dev/lazy): don't include already executed modules#7745

feat(dev/lazy): don't include already executed modules#7745
graphite-app[bot] merged 1 commit intomainfrom
01-04-feat_dev_lazy_don_t_include_already_executed_modules

hyf0 commented Jan 4, 2026

Uh oh!

hyf0 commented Jan 4, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 4, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

hyf0 commented Jan 4, 2026

Uh oh!

hyf0 commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hyf0 commented Jan 4, 2026 •

edited

Loading

github-actions bot commented Jan 4, 2026 •

edited

Loading

graphite-app bot commented Jan 5, 2026 •

edited

Loading

netlify bot commented Jan 5, 2026 •

edited

Loading